<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166929] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166929">166929</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-04-08 09:19:56 -0700 (Tue, 08 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel rendering: Slow paint path for inlines should snap to device pixels.
https://bugs.webkit.org/show_bug.cgi?id=131259
Reviewed by Simon Fraser.
InlineTextBox::paint needs to round to the same device pixel position as SimpleLineLayout does.
Source/WebCore:
Test: fast/inline/hidpi-slow-path-text-on-subpixel-position.html
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/TextPainter.h: Cleanup. No reason to have them as references here.
LayoutTests:
* fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html: Added.
* fast/inline/hidpi-slow-path-text-on-subpixel-position.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingInlineTextBoxcpp">trunk/Source/WebCore/rendering/InlineTextBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingTextPainterh">trunk/Source/WebCore/rendering/TextPainter.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastinlinehidpislowpathtextonsubpixelpositionexpectedhtml">trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastinlinehidpislowpathtextonsubpixelpositionhtml">trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (166928 => 166929)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-04-08 16:09:29 UTC (rev 166928)
+++ trunk/LayoutTests/ChangeLog 2014-04-08 16:19:56 UTC (rev 166929)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2014-04-08 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><ins>+ Subpixel rendering: Slow paint path for inlines should snap to device pixels.
+ https://bugs.webkit.org/show_bug.cgi?id=131259
+
+ Reviewed by Simon Fraser.
+
+ InlineTextBox::paint needs to round to the same device pixel position as SimpleLineLayout does.
+
+ * fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html: Added.
+ * fast/inline/hidpi-slow-path-text-on-subpixel-position.html: Added.
+
+2014-04-08 Zalan Bujtas <zalan@apple.com>
+
</ins><span class="cx"> Subpixel rendering: Paint the filter effect result image on device pixel position.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=131255
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastinlinehidpislowpathtextonsubpixelpositionexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html (0 => 166929)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html (rev 0)
+++ trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html 2014-04-08 16:19:56 UTC (rev 166929)
</span><span class="lines">@@ -0,0 +1,23 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<style>
+ .outer {
+ display: -webkit-flex;
+ -webkit-align-items: center;
+ box-sizing: border-box;
+ padding-top: 1px;
+ height: 25px;
+ }
+ .inner {
+ font: -webkit-small-control;
+ font-size: 9px;
+}
+</style>
+</head>
+<body>
+ <div class=outer>
+ <div class=inner>This tests that slow paint for inlines draws the text on the same position as fast path.</div>
+ </div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastinlinehidpislowpathtextonsubpixelpositionhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position.html (0 => 166929)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position.html (rev 0)
+++ trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position.html 2014-04-08 16:19:56 UTC (rev 166929)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<style>
+ .outer {
+ display: -webkit-flex;
+ -webkit-align-items: center;
+ box-sizing: border-box;
+ padding-top: 1px;
+ height: 25px;
+ }
+ .inner {
+ font: -webkit-small-control;
+ font-size: 9px;
+ -webkit-transform: translateX(0);
+}
+</style>
+</head>
+<body>
+ <div class=outer>
+ <div class=inner>This tests that slow paint for inlines draws the text on the same position as fast path.</div>
+ </div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (166928 => 166929)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-08 16:09:29 UTC (rev 166928)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 16:19:56 UTC (rev 166929)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-04-08 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Slow paint path for inlines should snap to device pixels.
+ https://bugs.webkit.org/show_bug.cgi?id=131259
+
+ Reviewed by Simon Fraser.
+
+ InlineTextBox::paint needs to round to the same device pixel position as SimpleLineLayout does.
+
+ Test: fast/inline/hidpi-slow-path-text-on-subpixel-position.html
+
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paint):
+ * rendering/TextPainter.h: Cleanup. No reason to have them as references here.
+
</ins><span class="cx"> 2014-04-07 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Keep 'webkitClosedCaptionsVisible' API in sync with captions display preferences
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingInlineTextBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (166928 => 166929)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/InlineTextBox.cpp 2014-04-08 16:09:29 UTC (rev 166928)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp 2014-04-08 16:19:56 UTC (rev 166929)
</span><span class="lines">@@ -517,7 +517,7 @@
</span><span class="cx"> LayoutUnit paintEnd = isHorizontal() ? paintInfo.rect.maxX() : paintInfo.rect.maxY();
</span><span class="cx"> LayoutUnit paintStart = isHorizontal() ? paintInfo.rect.x() : paintInfo.rect.y();
</span><span class="cx">
</span><del>- LayoutPoint adjustedPaintOffset = roundedIntPoint(paintOffset);
</del><ins>+ FloatPoint adjustedPaintOffset = roundedForPainting(paintOffset, renderer().document().deviceScaleFactor());
</ins><span class="cx">
</span><span class="cx"> if (logicalStart >= paintEnd || logicalStart + logicalExtent <= paintStart)
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingTextPainterh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/TextPainter.h (166928 => 166929)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/TextPainter.h 2014-04-08 16:09:29 UTC (rev 166928)
+++ trunk/Source/WebCore/rendering/TextPainter.h 2014-04-08 16:19:56 UTC (rev 166929)
</span><span class="lines">@@ -80,8 +80,8 @@
</span><span class="cx"> const AtomicString& m_emphasisMark;
</span><span class="cx"> RenderCombineText* m_combinedText;
</span><span class="cx"> TextRun& m_textRun;
</span><del>- FloatRect& m_boxRect;
- FloatPoint& m_textOrigin;
</del><ins>+ FloatRect m_boxRect;
+ FloatPoint m_textOrigin;
</ins><span class="cx"> int m_emphasisMarkOffset;
</span><span class="cx"> bool m_textBoxIsHorizontal;
</span><span class="cx"> SavedDrawingStateForMask m_savedDrawingStateForMask;
</span></span></pre>
</div>
</div>
</body>
</html>