<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166990] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166990">166990</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2014-04-08 18:11:52 -0700 (Tue, 08 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Source/WebCore: REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/155998">r155998</a>): Elements render at very low resolution with some 3d transforms
https://bugs.webkit.org/show_bug.cgi?id=131412
<rdar://problem/16525044>
Reviewed by Tim Horton.
In <a href="http://trac.webkit.org/projects/webkit/changeset/155998">r155998</a> we started to compute a root-relative transform in order to choose
a good contentsScale to avoid blurring on scaling.
However, the code failed to update this transform when passing over
GraphicsLayerCAs with no uncommitted changes, which caused us to choose
an incorrect contentsScale sometimes, resulting in blurriness.
Fix by updating the root-relative transform on layers with no uncommitted
changes.
Test: compositing/contents-scale/incremental-change.html
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
LayoutTests: REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/155998">r155998</a>): Elements render at very low resolution with some 3d transforms
https://bugs.webkit.org/show_bug.cgi?id=131412
Reviewed by Tim Horton.
Test that makes an incremental change to a layer property in a tree with
interesting 3d transforms.
* compositing/contents-scale/incremental-change-expected.html: Added.
* compositing/contents-scale/incremental-change.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscaGraphicsLayerCAcpp">trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscompositingcontentsscaleincrementalchangeexpectedhtml">trunk/LayoutTests/compositing/contents-scale/incremental-change-expected.html</a></li>
<li><a href="#trunkLayoutTestscompositingcontentsscaleincrementalchangehtml">trunk/LayoutTests/compositing/contents-scale/incremental-change.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (166989 => 166990)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-04-09 01:11:15 UTC (rev 166989)
+++ trunk/LayoutTests/ChangeLog 2014-04-09 01:11:52 UTC (rev 166990)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-04-08 Simon Fraser <simon.fraser@apple.com>
+
+ REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
+ https://bugs.webkit.org/show_bug.cgi?id=131412
+
+ Reviewed by Tim Horton.
+
+ Test that makes an incremental change to a layer property in a tree with
+ interesting 3d transforms.
+
+ * compositing/contents-scale/incremental-change-expected.html: Added.
+ * compositing/contents-scale/incremental-change.html: Added.
+
</ins><span class="cx"> 2014-04-08 Adenilson Cavalcanti <cavalcantii@gmail.com>
</span><span class="cx">
</span><span class="cx"> [SVG] Fix CSS transform handling when zoomed
</span></span></pre></div>
<a id="trunkLayoutTestscompositingcontentsscaleincrementalchangeexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/contents-scale/incremental-change-expected.html (0 => 166990)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/contents-scale/incremental-change-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/contents-scale/incremental-change-expected.html 2014-04-09 01:11:52 UTC (rev 166990)
</span><span class="lines">@@ -0,0 +1,47 @@
</span><ins>+<!DOCTYPE html>
+
+<html>
+<head>
+ <style>
+ * {
+ box-sizing: border-box;
+ }
+ .container {
+ width: 100px;
+ height: 100px;
+ margin: 200px;
+ -webkit-perspective: 1000px;
+ border: 1px solid black;
+ }
+
+ .middle {
+ -webkit-transform-style: preserve-3d;
+ -webkit-transform: translate3d(0px, 0px, 800px);
+ width: 100px;
+ height: 100px;
+ }
+
+ #leaf {
+ width: 400px;
+ height: 401px;
+ position: absolute;
+ border: 5px solid blue;
+ -webkit-transform-origin: top left;
+ -webkit-transform: matrix3d(
+ 0.2, 0, 0, 0,
+ 0, 0.2, 0, 0,
+ 0, 0, 0.2, 0,
+ 0, 0, 0, 1);
+ background-image: repeating-linear-gradient(white, black 50px, white 50px);
+ }
+ </style>
+</head>
+<body>
+ <div class="container">
+ <div class="middle">
+ <div id="leaf">
+ </div>
+ </div>
+ </div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestscompositingcontentsscaleincrementalchangehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/contents-scale/incremental-change.html (0 => 166990)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/contents-scale/incremental-change.html (rev 0)
+++ trunk/LayoutTests/compositing/contents-scale/incremental-change.html 2014-04-09 01:11:52 UTC (rev 166990)
</span><span class="lines">@@ -0,0 +1,65 @@
</span><ins>+<!DOCTYPE html>
+
+<html>
+<head>
+ <style>
+ * {
+ box-sizing: border-box;
+ }
+ .container {
+ width: 100px;
+ height: 100px;
+ margin: 200px;
+ -webkit-perspective: 1000px;
+ border: 1px solid black;
+ }
+
+ .middle {
+ -webkit-transform-style: preserve-3d;
+ -webkit-transform: translate3d(0px, 0px, 800px);
+ width: 100px;
+ height: 100px;
+ }
+
+ #leaf {
+ width: 400px;
+ height: 400px;
+ position: absolute;
+ border: 5px solid blue;
+ -webkit-transform-origin: top left;
+ -webkit-transform: matrix3d(
+ 0.2, 0, 0, 0,
+ 0, 0.2, 0, 0,
+ 0, 0, 0.2, 0,
+ 0, 0, 0, 1);
+ background-image: repeating-linear-gradient(white, black 50px, white 50px);
+ }
+ </style>
+ <script>
+ if (window.testRunner)
+ testRunner.waitUntilDone();
+
+ function doTest()
+ {
+ window.setTimeout(function() {
+ window.setTimeout(function() {
+ document.getElementById('leaf').style.height = '401px';
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }, 0);
+ }, 0);
+ }
+
+ window.addEventListener('load', doTest, false);
+ </script>
+</head>
+<body>
+
+ <div class="container">
+ <div class="middle">
+ <div id="leaf">
+ </div>
+ </div>
+ </div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (166989 => 166990)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-09 01:11:15 UTC (rev 166989)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 01:11:52 UTC (rev 166990)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2014-04-08 Simon Fraser <simon.fraser@apple.com>
+
+ REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
+ https://bugs.webkit.org/show_bug.cgi?id=131412
+ <rdar://problem/16525044>
+
+ Reviewed by Tim Horton.
+
+ In r155998 we started to compute a root-relative transform in order to choose
+ a good contentsScale to avoid blurring on scaling.
+
+ However, the code failed to update this transform when passing over
+ GraphicsLayerCAs with no uncommitted changes, which caused us to choose
+ an incorrect contentsScale sometimes, resulting in blurriness.
+
+ Fix by updating the root-relative transform on layers with no uncommitted
+ changes.
+
+ Test: compositing/contents-scale/incremental-change.html
+
+ * platform/graphics/ca/GraphicsLayerCA.cpp:
+ (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
+
</ins><span class="cx"> 2014-04-08 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Don't call CGPathAddPath with invalid CGAffineTransform objects
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscaGraphicsLayerCAcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (166989 => 166990)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2014-04-09 01:11:15 UTC (rev 166989)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2014-04-09 01:11:52 UTC (rev 166990)
</span><span class="lines">@@ -1336,6 +1336,8 @@
</span><span class="cx"> // Ensure that we cap layer depth in commitLayerChangesAfterSublayers().
</span><span class="cx"> if (commitState.treeDepth > cMaxLayerTreeDepth)
</span><span class="cx"> m_uncommittedChanges |= ChildrenChanged;
</span><ins>+
+ updateRootRelativeScale(transformFromRoot);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>