<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166926] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166926">166926</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-04-08 07:52:33 -0700 (Tue, 08 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel rendering: Paint the filter effect result image on device pixel position.
https://bugs.webkit.org/show_bug.cgi?id=131255
Reviewed by Simon Fraser.
This patch moves filter effect images from integral to device pixel position. However,
result images are still integral based.
Source/WebCore:
Test: css3/filters/hidpi-filter-is-on-subpixel-position.html
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
LayoutTests:
* css3/filters/hidpi-filter-is-on-subpixel-position-expected.html: Added.
* css3/filters/hidpi-filter-is-on-subpixel-position.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingFilterEffectRenderercpp">trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscss3filtershidpifilterisonsubpixelpositionexpectedhtml">trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position-expected.html</a></li>
<li><a href="#trunkLayoutTestscss3filtershidpifilterisonsubpixelpositionhtml">trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (166925 => 166926)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-04-08 14:50:38 UTC (rev 166925)
+++ trunk/LayoutTests/ChangeLog 2014-04-08 14:52:33 UTC (rev 166926)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2014-04-08 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><ins>+ Subpixel rendering: Paint the filter effect result image on device pixel position.
+ https://bugs.webkit.org/show_bug.cgi?id=131255
+
+ Reviewed by Simon Fraser.
+
+ This patch moves filter effect images from integral to device pixel position. However,
+ result images are still integral based.
+
+ * css3/filters/hidpi-filter-is-on-subpixel-position-expected.html: Added.
+ * css3/filters/hidpi-filter-is-on-subpixel-position.html: Added.
+
+2014-04-08 Zalan Bujtas <zalan@apple.com>
+
</ins><span class="cx"> Subpixel rendering: Make border images device pixel aware.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=131209
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestscss3filtershidpifilterisonsubpixelpositionexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position-expected.html (0 => 166926)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position-expected.html (rev 0)
+++ trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position-expected.html 2014-04-08 14:52:33 UTC (rev 166926)
</span><span class="lines">@@ -0,0 +1,40 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that filter effects don't push content to different position when RenderLayer is present.</title>
+<style>
+ p {
+ position: fixed;
+ display: -webkit-flex;
+ -webkit-align-items: center;
+ }
+
+ div {
+ width: 10px;
+ height: 10px;
+ background: black;
+ border: 2px solid white;
+ -webkit-filter: drop-shadow(black 0 0px 0px);
+ }
+</style>
+</head>
+<body>
+<span id="container"></span>
+<script>
+ var container = document.getElementById("container");
+ w = 15; h = 15;
+ for (i = 0; i < 10; ++i) {
+ for (j = 0; j < 10; ++j) {
+ var e = document.createElement("p");
+ e.style.top = ((w + 1) * i) + "px";
+ e.style.left = ((w + 1) * j) + "px";
+ e.style.height = h + "px";
+ e.appendChild(document.createElement("div"));
+ container.appendChild(e);
+ w+=1;
+ h+=1;
+ }
+ }
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestscss3filtershidpifilterisonsubpixelpositionhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position.html (0 => 166926)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position.html (rev 0)
+++ trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position.html 2014-04-08 14:52:33 UTC (rev 166926)
</span><span class="lines">@@ -0,0 +1,41 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that filter effects don't push content to different position when RenderLayer is present.</title>
+<style>
+ p {
+ position: fixed;
+ display: -webkit-flex;
+ -webkit-align-items: center;
+ }
+
+ div {
+ width: 10px;
+ height: 10px;
+ background: black;
+ border: 2px solid white;
+ -webkit-filter: drop-shadow(black 0 0px 0px);
+ -webkit-transform: translateX(0);
+ }
+</style>
+</head>
+<body>
+<span id="container"></span>
+<script>
+ var container = document.getElementById("container");
+ w = 15; h = 15;
+ for (i = 0; i < 10; ++i) {
+ for (j = 0; j < 10; ++j) {
+ var e = document.createElement("p");
+ e.style.top = ((w + 1) * i) + "px";
+ e.style.left = ((w + 1) * j) + "px";
+ e.style.height = h + "px";
+ e.appendChild(document.createElement("div"));
+ container.appendChild(e);
+ w+=1;
+ h+=1;
+ }
+ }
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (166925 => 166926)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-08 14:50:38 UTC (rev 166925)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 14:52:33 UTC (rev 166926)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2014-04-08 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><ins>+ Subpixel rendering: Paint the filter effect result image on device pixel position.
+ https://bugs.webkit.org/show_bug.cgi?id=131255
+
+ Reviewed by Simon Fraser.
+
+ This patch moves filter effect images from integral to device pixel position. However,
+ result images are still integral based.
+
+ Test: css3/filters/hidpi-filter-is-on-subpixel-position.html
+
+ * rendering/FilterEffectRenderer.cpp:
+ (WebCore::FilterEffectRendererHelper::applyFilterEffect):
+
+2014-04-08 Zalan Bujtas <zalan@apple.com>
+
</ins><span class="cx"> Subpixel rendering: Make border images device pixel aware.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=131209
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingFilterEffectRenderercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp (166925 => 166926)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp 2014-04-08 14:50:38 UTC (rev 166925)
+++ trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp 2014-04-08 14:52:33 UTC (rev 166926)
</span><span class="lines">@@ -434,9 +434,10 @@
</span><span class="cx"> // Get the filtered output and draw it in place.
</span><span class="cx"> LayoutRect destRect = filter->outputRect();
</span><span class="cx"> destRect.move(m_paintOffset.x(), m_paintOffset.y());
</span><del>-
- destinationContext->drawImageBuffer(filter->output(), m_renderLayer->renderer().style().colorSpace(), pixelSnappedIntRect(destRect), CompositeSourceOver);
-
</del><ins>+
+ destinationContext->drawImageBuffer(filter->output(), m_renderLayer->renderer().style().colorSpace(),
+ pixelSnappedForPainting(destRect, m_renderLayer->renderer().document().deviceScaleFactor()), CompositeSourceOver);
+
</ins><span class="cx"> filter->clearIntermediateResults();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>