<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166993] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166993">166993</a></dd>
<dt>Author</dt> <dd>jonlee@apple.com</dd>
<dt>Date</dt> <dd>2014-04-08 19:18:52 -0700 (Tue, 08 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Turn MSE on by default
https://bugs.webkit.org/show_bug.cgi?id=131313
<rdar://problem/16525223>
Reviewed by Jer Noble.
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
* Configurations/FeatureDefines.xcconfig:
* page/Settings.in: Add MEDIA_SOURCE conditional.
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Set default to true.
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
* Shared/WebPreferencesStore.h: Set default to true.
* UIProcess/API/C/WKPreferencesRefPrivate.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreConfigurationsFeatureDefinesxcconfig">trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreConfigurationsFeatureDefinesxcconfig">trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig</a></li>
<li><a href="#trunkSourceWebCorepageSettingsin">trunk/Source/WebCore/page/Settings.in</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacConfigurationsFeatureDefinesxcconfig">trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesmm">trunk/Source/WebKit/mac/WebView/WebPreferences.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2ConfigurationsFeatureDefinesxcconfig">trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPreferencesStoreh">trunk/Source/WebKit2/Shared/WebPreferencesStore.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh">trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (166992 => 166993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-04-09 02:18:52 UTC (rev 166993)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-04-08 Jon Lee <jonlee@apple.com>
+
+ Turn MSE on by default
+ https://bugs.webkit.org/show_bug.cgi?id=131313
+ <rdar://problem/16525223>
+
+ Reviewed by Jer Noble.
+
+ * Configurations/FeatureDefines.xcconfig:
+
</ins><span class="cx"> 2014-04-08 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Prevent deadlocks receiving WIRPermissionDenied message
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreConfigurationsFeatureDefinesxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig (166992 => 166993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig 2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig 2014-04-09 02:18:52 UTC (rev 166993)
</span><span class="lines">@@ -142,7 +142,10 @@
</span><span class="cx"> ENABLE_LINK_PREFETCH = ;
</span><span class="cx"> ENABLE_MATHML = ENABLE_MATHML;
</span><span class="cx"> ENABLE_MEDIA_CONTROLS_SCRIPT = ENABLE_MEDIA_CONTROLS_SCRIPT;
</span><del>-ENABLE_MEDIA_SOURCE = ENABLE_MEDIA_SOURCE;
</del><ins>+
+ENABLE_MEDIA_SOURCE = $(ENABLE_MEDIA_SOURCE_$(PLATFORM_NAME));
+ENABLE_MEDIA_SOURCE_macosx = ENABLE_MEDIA_SOURCE;
+
</ins><span class="cx"> ENABLE_MEDIA_STATISTICS = ;
</span><span class="cx"> ENABLE_METER_ELEMENT = $(ENABLE_METER_ELEMENT_$(PLATFORM_NAME));
</span><span class="cx"> ENABLE_METER_ELEMENT_macosx = ENABLE_METER_ELEMENT;
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (166992 => 166993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 02:18:52 UTC (rev 166993)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-04-08 Jon Lee <jonlee@apple.com>
+
+ Turn MSE on by default
+ https://bugs.webkit.org/show_bug.cgi?id=131313
+ <rdar://problem/16525223>
+
+ Reviewed by Jer Noble.
+
+ * Configurations/FeatureDefines.xcconfig:
+ * page/Settings.in: Add MEDIA_SOURCE conditional.
+
</ins><span class="cx"> 2014-04-08 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove an unused parameter from loadResource.
</span></span></pre></div>
<a id="trunkSourceWebCoreConfigurationsFeatureDefinesxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (166992 => 166993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2014-04-09 02:18:52 UTC (rev 166993)
</span><span class="lines">@@ -142,7 +142,10 @@
</span><span class="cx"> ENABLE_LINK_PREFETCH = ;
</span><span class="cx"> ENABLE_MATHML = ENABLE_MATHML;
</span><span class="cx"> ENABLE_MEDIA_CONTROLS_SCRIPT = ENABLE_MEDIA_CONTROLS_SCRIPT;
</span><del>-ENABLE_MEDIA_SOURCE = ENABLE_MEDIA_SOURCE;
</del><ins>+
+ENABLE_MEDIA_SOURCE = $(ENABLE_MEDIA_SOURCE_$(PLATFORM_NAME));
+ENABLE_MEDIA_SOURCE_macosx = ENABLE_MEDIA_SOURCE;
+
</ins><span class="cx"> ENABLE_MEDIA_STATISTICS = ;
</span><span class="cx"> ENABLE_METER_ELEMENT = $(ENABLE_METER_ELEMENT_$(PLATFORM_NAME));
</span><span class="cx"> ENABLE_METER_ELEMENT_macosx = ENABLE_METER_ELEMENT;
</span></span></pre></div>
<a id="trunkSourceWebCorepageSettingsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.in (166992 => 166993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Settings.in 2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebCore/page/Settings.in 2014-04-09 02:18:52 UTC (rev 166993)
</span><span class="lines">@@ -197,7 +197,7 @@
</span><span class="cx"> simpleLineLayoutEnabled initial=true, setNeedsStyleRecalcInAllFrames=1
</span><span class="cx"> simpleLineLayoutDebugBordersEnabled initial=false, setNeedsStyleRecalcInAllFrames=1
</span><span class="cx">
</span><del>-mediaSourceEnabled initial=false
</del><ins>+mediaSourceEnabled initial=true, conditional=MEDIA_SOURCE
</ins><span class="cx">
</span><span class="cx"> # FIXME: Rename to allowMultiElementImplicitFormSubmission once we upstream the iOS changes to WebView.mm.
</span><span class="cx"> allowMultiElementImplicitSubmission initial=false
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (166992 => 166993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-04-09 02:18:52 UTC (rev 166993)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-04-08 Jon Lee <jonlee@apple.com>
+
+ Turn MSE on by default
+ https://bugs.webkit.org/show_bug.cgi?id=131313
+ <rdar://problem/16525223>
+
+ Reviewed by Jer Noble.
+
+ * Configurations/FeatureDefines.xcconfig:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]): Set default to true.
+
</ins><span class="cx"> 2014-04-08 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Rename Clipboard to DataTransfer
</span></span></pre></div>
<a id="trunkSourceWebKitmacConfigurationsFeatureDefinesxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (166992 => 166993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig 2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig 2014-04-09 02:18:52 UTC (rev 166993)
</span><span class="lines">@@ -142,7 +142,10 @@
</span><span class="cx"> ENABLE_LINK_PREFETCH = ;
</span><span class="cx"> ENABLE_MATHML = ENABLE_MATHML;
</span><span class="cx"> ENABLE_MEDIA_CONTROLS_SCRIPT = ENABLE_MEDIA_CONTROLS_SCRIPT;
</span><del>-ENABLE_MEDIA_SOURCE = ENABLE_MEDIA_SOURCE;
</del><ins>+
+ENABLE_MEDIA_SOURCE = $(ENABLE_MEDIA_SOURCE_$(PLATFORM_NAME));
+ENABLE_MEDIA_SOURCE_macosx = ENABLE_MEDIA_SOURCE;
+
</ins><span class="cx"> ENABLE_MEDIA_STATISTICS = ;
</span><span class="cx"> ENABLE_METER_ELEMENT = $(ENABLE_METER_ELEMENT_$(PLATFORM_NAME));
</span><span class="cx"> ENABLE_METER_ELEMENT_macosx = ENABLE_METER_ELEMENT;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (166992 => 166993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2014-04-09 02:18:52 UTC (rev 166993)
</span><span class="lines">@@ -588,7 +588,7 @@
</span><span class="cx">
</span><span class="cx"> [NSNumber numberWithBool:NO], WebKitVideoPluginProxyEnabledKey,
</span><span class="cx"> #if ENABLE(MEDIA_SOURCE)
</span><del>- [NSNumber numberWithBool:NO], WebKitMediaSourceEnabledPreferenceKey,
</del><ins>+ [NSNumber numberWithBool:YES], WebKitMediaSourceEnabledPreferenceKey,
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(IMAGE_CONTROLS)
</span><span class="cx"> [NSNumber numberWithBool:NO], WebKitImageControlsEnabledPreferenceKey,
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (166992 => 166993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-09 02:18:52 UTC (rev 166993)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-04-08 Jon Lee <jonlee@apple.com>
+
+ Turn MSE on by default
+ https://bugs.webkit.org/show_bug.cgi?id=131313
+ <rdar://problem/16525223>
+
+ Reviewed by Jer Noble.
+
+ * Configurations/FeatureDefines.xcconfig:
+ * Shared/WebPreferencesStore.h: Set default to true.
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+
</ins><span class="cx"> 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Fix the typo in the previous commit.
</span></span></pre></div>
<a id="trunkSourceWebKit2ConfigurationsFeatureDefinesxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig (166992 => 166993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig 2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig 2014-04-09 02:18:52 UTC (rev 166993)
</span><span class="lines">@@ -142,7 +142,10 @@
</span><span class="cx"> ENABLE_LINK_PREFETCH = ;
</span><span class="cx"> ENABLE_MATHML = ENABLE_MATHML;
</span><span class="cx"> ENABLE_MEDIA_CONTROLS_SCRIPT = ENABLE_MEDIA_CONTROLS_SCRIPT;
</span><del>-ENABLE_MEDIA_SOURCE = ENABLE_MEDIA_SOURCE;
</del><ins>+
+ENABLE_MEDIA_SOURCE = $(ENABLE_MEDIA_SOURCE_$(PLATFORM_NAME));
+ENABLE_MEDIA_SOURCE_macosx = ENABLE_MEDIA_SOURCE;
+
</ins><span class="cx"> ENABLE_MEDIA_STATISTICS = ;
</span><span class="cx"> ENABLE_METER_ELEMENT = $(ENABLE_METER_ELEMENT_$(PLATFORM_NAME));
</span><span class="cx"> ENABLE_METER_ELEMENT_macosx = ENABLE_METER_ELEMENT;
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPreferencesStoreh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (166992 => 166993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2014-04-09 02:18:52 UTC (rev 166993)
</span><span class="lines">@@ -214,7 +214,7 @@
</span><span class="cx"> macro(MediaStreamEnabled, mediaStreamEnabled, Bool, bool, false) \
</span><span class="cx"> macro(UseLegacyTextAlignPositionedElementBehavior, useLegacyTextAlignPositionedElementBehavior, Bool, bool, false) \
</span><span class="cx"> macro(SpatialNavigationEnabled, spatialNavigationEnabled, Bool, bool, false) \
</span><del>- macro(MediaSourceEnabled, mediaSourceEnabled, Bool, bool, false) \
</del><ins>+ macro(MediaSourceEnabled, mediaSourceEnabled, Bool, bool, true) \
</ins><span class="cx"> macro(ViewGestureDebuggingEnabled, viewGestureDebuggingEnabled, Bool, bool, false) \
</span><span class="cx"> macro(ShouldConvertPositionStyleOnCopy, shouldConvertPositionStyleOnCopy, Bool, bool, false) \
</span><span class="cx"> macro(Standalone, standalone, Bool, bool, false) \
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (166992 => 166993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2014-04-09 02:18:52 UTC (rev 166993)
</span><span class="lines">@@ -306,7 +306,7 @@
</span><span class="cx"> WK_EXPORT void WKPreferencesSetUseLegacyTextAlignPositionedElementBehavior(WKPreferencesRef preferencesRef, bool enabled);
</span><span class="cx"> WK_EXPORT bool WKPreferencesUseLegacyTextAlignPositionedElementBehavior(WKPreferencesRef preferencesRef);
</span><span class="cx">
</span><del>-// Defaults to false.
</del><ins>+// Defaults to true.
</ins><span class="cx"> WK_EXPORT void WKPreferencesSetMediaSourceEnabled(WKPreferencesRef preferencesRef, bool enabled);
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetMediaSourceEnabled(WKPreferencesRef preferencesRef);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>