<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166833] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166833">166833</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-04-05 06:52:11 -0700 (Sat, 05 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Source/WebCore: bad values from HTMLImageElement x and y attributes (CSSOM-View)
https://bugs.webkit.org/show_bug.cgi?id=130308
Patch by Jeongeun Kim <je_julie.kim@samsung.com> on 2014-04-05
Reviewed by Simon Fraser.
According to CSSOM-View, interface HTMLImageElement,
The x attribute must return the x-coordinate.
If style is not updated when x() is called, it can’t return anything.
Style and layout should be done before getting value for x() and y().
Test: cssom/cssom-view-img-attributes-001.html
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::x):
(WebCore::HTMLImageElement::y):
LayoutTests: bad values from HTMLImageElement x and y attributes (CSSOM-View)
https://bugs.webkit.org/show_bug.cgi?id=130308
Patch by Jeongeun Kim <je_julie.kim@samsung.com> on 2014-04-05
Reviewed by Simon Fraser.
According to CSSOM-View, ‘interface HTMLImageElement’,
The x attribute must return the x-coordinate.
If style is not updated when x() is called, it can’t return anything.
Style and layout should be done before getting value for x() and y().
* cssom/cssom-view-img-attributes-001-expected.txt: Added.
* cssom/cssom-view-img-attributes-001.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLImageElementcpp">trunk/Source/WebCore/html/HTMLImageElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscssomcssomviewimgattributes001expectedtxt">trunk/LayoutTests/cssom/cssom-view-img-attributes-001-expected.txt</a></li>
<li><a href="#trunkLayoutTestscssomcssomviewimgattributes001html">trunk/LayoutTests/cssom/cssom-view-img-attributes-001.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (166832 => 166833)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-04-05 13:34:17 UTC (rev 166832)
+++ trunk/LayoutTests/ChangeLog 2014-04-05 13:52:11 UTC (rev 166833)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-04-05 Jeongeun Kim <je_julie.kim@samsung.com>
+
+ bad values from HTMLImageElement x and y attributes (CSSOM-View)
+ https://bugs.webkit.org/show_bug.cgi?id=130308
+
+ Reviewed by Simon Fraser.
+
+ According to CSSOM-View, ‘interface HTMLImageElement’,
+ The x attribute must return the x-coordinate.
+ If style is not updated when x() is called, it can’t return anything.
+ Style and layout should be done before getting value for x() and y().
+
+ * cssom/cssom-view-img-attributes-001-expected.txt: Added.
+ * cssom/cssom-view-img-attributes-001.html: Added.
+
</ins><span class="cx"> 2014-04-05 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> WebProcess freezes after fast/forms/form-associated-element-crash3.html test
</span></span></pre></div>
<a id="trunkLayoutTestscssomcssomviewimgattributes001expectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/cssom/cssom-view-img-attributes-001-expected.txt (0 => 166833)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/cssom/cssom-view-img-attributes-001-expected.txt (rev 0)
+++ trunk/LayoutTests/cssom/cssom-view-img-attributes-001-expected.txt 2014-04-05 13:52:11 UTC (rev 166833)
</span><span class="lines">@@ -0,0 +1,6 @@
</span><ins>+
+PASS test x with display false
+PASS test y with display false
+PASS test x with display true
+PASS test y with display true
+
</ins></span></pre></div>
<a id="trunkLayoutTestscssomcssomviewimgattributes001html"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/cssom/cssom-view-img-attributes-001.html (0 => 166833)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/cssom/cssom-view-img-attributes-001.html (rev 0)
+++ trunk/LayoutTests/cssom/cssom-view-img-attributes-001.html 2014-04-05 13:52:11 UTC (rev 166833)
</span><span class="lines">@@ -0,0 +1,48 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <title>CSSOM-View: HTMLImageElement x and y attributes</title>
+ <link rel="author" title="Adobe" href="http://html.adobe.com/">
+ <link rel="author" title="Alan Stearns" href="mailto:stearns@adobe.com">
+ <link rel="reviewer" title="" href="">
+ <link rel="help" href="http://dev.w3.org/csswg/cssom-view/#excensions-to-the-htmlimageelement-interface">
+ <meta name="assert" content="HTMLImageElement attributes give x and y position of CSS layout box">
+ <meta name="flags" content="dom">
+ <script src="../resources/testharness.js"></script>
+ <script src="../resources/testharnessreport.js"></script>
+ </head>
+ <body>
+ <div id="log"></div>
+ <script type="text/javascript">
+
+ function testIMGAttributes(attribute_name, display_none) {
+ var element = document.createElement("img");
+ document.body.appendChild(element);
+ element.style.setProperty("position", "absolute");
+ element.style.setProperty("left", "10px");
+ element.style.setProperty("top", "10px");
+ element.style.setProperty("width", "10px");
+ element.style.setProperty("height", "10px");
+ if (display_none) {
+ element.style.setProperty("display", "none");
+ }
+ var attributeValue = element[attribute_name];
+ document.body.removeChild(element);
+ return attributeValue;
+ }
+
+ var imgAttributes = [
+ ["x", false, 10],
+ ["y", false, 10],
+ ["x", true, 0],
+ ["y", true, 0],
+ ];
+
+ imgAttributes.forEach(function(test_data) {
+ test (function() { assert_equals(testIMGAttributes(test_data[0], test_data[1]), test_data[2])},
+ "test " + test_data[0] + " with display " + test_data[1])
+ }
+ );
+ </script>
+ </body>
+</html>
</ins><span class="cx">Property changes on: trunk/LayoutTests/cssom/cssom-view-img-attributes-001.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (166832 => 166833)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-05 13:34:17 UTC (rev 166832)
+++ trunk/Source/WebCore/ChangeLog 2014-04-05 13:52:11 UTC (rev 166833)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-04-05 Jeongeun Kim <je_julie.kim@samsung.com>
+
+ bad values from HTMLImageElement x and y attributes (CSSOM-View)
+ https://bugs.webkit.org/show_bug.cgi?id=130308
+
+ Reviewed by Simon Fraser.
+
+ According to CSSOM-View, interface HTMLImageElement,
+ The x attribute must return the x-coordinate.
+ If style is not updated when x() is called, it can’t return anything.
+ Style and layout should be done before getting value for x() and y().
+
+ Test: cssom/cssom-view-img-attributes-001.html
+
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::x):
+ (WebCore::HTMLImageElement::y):
+
</ins><span class="cx"> 2014-04-05 Zoltan Horvath <zoltan@webkit.org>
</span><span class="cx">
</span><span class="cx"> [CSS Shapes] Remove CSSBoxType member from BasicShape and CSSBasicShape
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLImageElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLImageElement.cpp (166832 => 166833)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLImageElement.cpp 2014-04-05 13:34:17 UTC (rev 166832)
+++ trunk/Source/WebCore/html/HTMLImageElement.cpp 2014-04-05 13:52:11 UTC (rev 166833)
</span><span class="lines">@@ -379,6 +379,7 @@
</span><span class="cx">
</span><span class="cx"> int HTMLImageElement::x() const
</span><span class="cx"> {
</span><ins>+ document().updateLayoutIgnorePendingStylesheets();
</ins><span class="cx"> auto renderer = this->renderer();
</span><span class="cx"> if (!renderer)
</span><span class="cx"> return 0;
</span><span class="lines">@@ -389,6 +390,7 @@
</span><span class="cx">
</span><span class="cx"> int HTMLImageElement::y() const
</span><span class="cx"> {
</span><ins>+ document().updateLayoutIgnorePendingStylesheets();
</ins><span class="cx"> auto renderer = this->renderer();
</span><span class="cx"> if (!renderer)
</span><span class="cx"> return 0;
</span></span></pre>
</div>
</div>
</body>
</html>