<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166723] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166723">166723</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-04-03 09:36:18 -0700 (Thu, 03 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
https://bugs.webkit.org/show_bug.cgi?id=131155
Reviewed by Andreas Kling.
The bug was caused by Chart.attach binding event listeners on plot container on each call.
This resulted in the click event handler toggling the visiblity of the tooltip twice upon
click when attach() has been called even number of times, keeping the tooltip invisible.
Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
is called for the first time.
* public/index.html:
(Chart.attach):
(Chart..bindPlotEventHandlers):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicindexhtml">trunk/Websites/perf.webkit.org/public/index.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (166722 => 166723)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2014-04-03 16:29:32 UTC (rev 166722)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2014-04-03 16:36:18 UTC (rev 166723)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
+ https://bugs.webkit.org/show_bug.cgi?id=131155
+
+ Reviewed by Andreas Kling.
+
+ The bug was caused by Chart.attach binding event listeners on plot container on each call.
+ This resulted in the click event handler toggling the visiblity of the tooltip twice upon
+ click when attach() has been called even number of times, keeping the tooltip invisible.
+
+ Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
+ a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
+ is called for the first time.
+
+ * public/index.html:
+ (Chart.attach):
+ (Chart..bindPlotEventHandlers):
+
+2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> WebKitPerfMonitor: Tooltips can be cut off at the top
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=130960
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicindexhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/index.html (166722 => 166723)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/index.html 2014-04-03 16:29:32 UTC (rev 166722)
+++ trunk/Websites/perf.webkit.org/public/index.html 2014-04-03 16:36:18 UTC (rev 166723)
</span><span class="lines">@@ -739,12 +739,16 @@
</span><span class="cx"> else
</span><span class="cx"> this.attachMainPlot(minTime);
</span><span class="cx">
</span><del>- var self = this;
</del><ins>+ if (bindPlotEventHandlers)
+ bindPlotEventHandlers(this);
+ bindPlotEventHandlers = null;
+ };
</ins><span class="cx">
</span><ins>+ function bindPlotEventHandlers(chart) {
</ins><span class="cx"> // FIXME: Crosshair should stay where it was between charts.
</span><span class="cx"> $(plotContainer).bind("plothover", function (event, pos, item) {
</span><span class="cx"> for (var i = 0; i < charts.length; i++) {
</span><del>- if (charts[i] !== self) {
</del><ins>+ if (charts[i] !== chart) {
</ins><span class="cx"> charts[i].setCrosshair(pos);
</span><span class="cx"> charts[i].hideTooltip();
</span><span class="cx"> }
</span><span class="lines">@@ -782,8 +786,8 @@
</span><span class="cx"> toggleClickTooltip(tooltip.currentItem.dataIndex, tooltip.currentItem.pageX, tooltip.currentItem.pageY);
</span><span class="cx"> });
</span><span class="cx"> }
</span><del>- };
-
</del><ins>+ }
+
</ins><span class="cx"> charts.push(this);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>