<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166701] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166701">166701</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-04-03 00:08:32 -0700 (Thu, 03 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>WebKitPerfMonitor: Tooltips can be cut off at the top
https://bugs.webkit.org/show_bug.cgi?id=130960
Reviewed by Andreas Kling.
* public/common.css:
(#title): Removed the gradients, box shadows, and border from the header.
(#title h1): Reduce the font size.
(#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
* public/index.html:
(.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
(.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
(.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
* public/js/helper-classes.js:
(Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
tooltip extending above y=0.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpubliccommoncss">trunk/Websites/perf.webkit.org/public/common.css</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicindexhtml">trunk/Websites/perf.webkit.org/public/index.html</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicjshelperclassesjs">trunk/Websites/perf.webkit.org/public/js/helper-classes.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (166700 => 166701)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2014-04-03 07:07:02 UTC (rev 166700)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2014-04-03 07:08:32 UTC (rev 166701)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ WebKitPerfMonitor: Tooltips can be cut off at the top
+ https://bugs.webkit.org/show_bug.cgi?id=130960
+
+ Reviewed by Andreas Kling.
+
+ * public/common.css:
+ (#title): Removed the gradients, box shadows, and border from the header.
+ (#title h1): Reduce the font size.
+ (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
+ * public/index.html:
+ (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
+ (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
+ (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
+ * public/js/helper-classes.js:
+ (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
+ tooltip extending above y=0.
+
+2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> WebKitPerfMonitor: Y-axis adjustment is too aggressive
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=130937
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpubliccommoncss"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/common.css (166700 => 166701)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/common.css 2014-04-03 07:07:02 UTC (rev 166700)
+++ trunk/Websites/perf.webkit.org/public/common.css 2014-04-03 07:08:32 UTC (rev 166701)
</span><span class="lines">@@ -11,17 +11,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #title {
</span><del>- background-image: linear-gradient(bottom, rgb(240,240,240) 31%, rgb(255,255,255) 90%);
- background-image: -o-linear-gradient(bottom, rgb(240,240,240) 31%, rgb(255,255,255) 90%);
- background-image: -moz-linear-gradient(bottom, rgb(240,240,240) 31%, rgb(255,255,255) 90%);
- background-image: -webkit-linear-gradient(bottom, rgb(240,240,240) 31%, rgb(255,255,255) 90%);
- background-image: -ms-linear-gradient(bottom, rgb(240,240,240) 31%, rgb(255,255,255) 90%);
- -moz-box-shadow: 1px 1px 3px 1px #ccc;
- -webkit-box-shadow: 1px 1px 3px 1px #ccc;
- box-shadow: 1px 1px 3px 1px #ccc;
- padding: 5px 10px;
- margin: 0 0 10px 0;
- border-radius: 5px;
</del><span class="cx"> position: relative;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -30,7 +19,7 @@
</span><span class="cx"> text-shadow: #bbb 1px 1px 2px;
</span><span class="cx"> margin: 0;
</span><span class="cx"> padding: 0;
</span><del>- font-size: 2em;
</del><ins>+ font-size: 1.5em;
</ins><span class="cx"> }
</span><span class="cx"> #title li, #title ul {
</span><span class="cx"> list-style: none;
</span><span class="lines">@@ -55,7 +44,7 @@
</span><span class="cx"> vertical-align: middle;
</span><span class="cx"> top: 5px;
</span><span class="cx"> right: 20px;
</span><del>- padding-top: 0.6em;
</del><ins>+ line-height: 1.5em;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> a {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicindexhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/index.html (166700 => 166701)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/index.html 2014-04-03 07:07:02 UTC (rev 166700)
+++ trunk/Websites/perf.webkit.org/public/index.html 2014-04-03 07:08:32 UTC (rev 166701)
</span><span class="lines">@@ -251,6 +251,28 @@
</span><span class="cx"> white-space: nowrap;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.tooltip:before {
+ position: absolute;
+ width: 0;
+ height: 0;
+ left: 50%;
+ margin-left: -9px;
+ top: -19px;
+ content: "";
+ display: none;
+ border-style: solid;
+ border-width: 10px;
+ border-color: transparent transparent #333 transparent;
+}
+
+.tooltip.inverted:before {
+ display: block;
+}
+
+.tooltip.inverted:after {
+ display: none;
+}
+
</ins><span class="cx"> .tooltip:after {
</span><span class="cx"> position: absolute;
</span><span class="cx"> width: 0;
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicjshelperclassesjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/js/helper-classes.js (166700 => 166701)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/js/helper-classes.js 2014-04-03 07:07:02 UTC (rev 166700)
+++ trunk/Websites/perf.webkit.org/public/js/helper-classes.js 2014-04-03 07:08:32 UTC (rev 166701)
</span><span class="lines">@@ -377,7 +377,13 @@
</span><span class="cx"> container.innerHTML = content;
</span><span class="cx"> $(container).show();
</span><span class="cx"> // FIXME: Style specific computation like this one shouldn't be in Tooltip class.
</span><del>- $(container).offset({left: x - $(container).outerWidth() / 2, top: y - $(container).outerHeight() - 15});
</del><ins>+ var top = y - $(container).outerHeight() - 15;
+ if (top < 0) {
+ $(container).addClass('inverted');
+ top = y + 15;
+ } else
+ $(container).removeClass('inverted');
+ $(container).offset({left: x - $(container).outerWidth() / 2, top: top});
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> this.hide = function () {
</span></span></pre>
</div>
</div>
</body>
</html>