<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166649] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166649">166649</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2014-04-02 09:31:15 -0700 (Wed, 02 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: Improve ARIA live region reliability by sending notifications when live regions are created/shown and hidden/destroyed
https://bugs.webkit.org/show_bug.cgi?id=124381
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Re-organize some code so that when we detect a new node has been created, we can safely determine its live region status.
If it is a live region, we fire off a live region created notification.
Test: platform/mac/accessibility/live-region-creation-notification.html
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleLiveRegionCreated):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::handleAttributeChanged):
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::childrenChanged):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::defaultLiveRegionStatusForRole):
(WebCore::AccessibilityObject::liveRegionStatusIsEnabled):
(WebCore::AccessibilityObject::supportsARIALiveRegion):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::ariaLiveRegionStatus):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
* accessibility/AccessibilityRenderObject.h:
* accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper postLiveRegionCreatedNotification]):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
* platform/mac/accessibility/live-region-creation-notification.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAXObjectCachecpp">trunk/Source/WebCore/accessibility/AXObjectCache.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAXObjectCacheh">trunk/Source/WebCore/accessibility/AXObjectCache.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjecth">trunk/Source/WebCore/accessibility/AccessibilityObject.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityRenderObjecth">trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosAXObjectCacheIOSmm">trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSh">trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm">trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacAXObjectCacheMacmm">trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityliveregioncreationnotificationhtml">trunk/LayoutTests/platform/mac/accessibility/live-region-creation-notification.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (166648 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-04-02 15:38:40 UTC (rev 166648)
+++ trunk/LayoutTests/ChangeLog 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2014-04-02 Chris Fleizach <cfleizach@apple.com>
+
+ AX: Improve ARIA live region reliability by sending notifications when live regions are created/shown and hidden/destroyed
+ https://bugs.webkit.org/show_bug.cgi?id=124381
+
+ Reviewed by Mario Sanchez Prada.
+
+ * platform/mac/accessibility/live-region-creation-notification.html: Added.
+
</ins><span class="cx"> 2014-04-02 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> Add LayoutTest for crash with bidi isolates
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityliveregioncreationnotificationhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/live-region-creation-notification.html (0 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/live-region-creation-notification.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/live-region-creation-notification.html 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -0,0 +1,113 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../../../resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+<div id="content">
+<div id="first" role="log"></div>
+</div>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+description("This tests that the AXLiveRegionCreated notification gets fired when live regions appear.");
+var notification = 0;
+var element = 0;
+
+function startTest() {
+
+ var HIDE = true;
+
+ // add second live region immediately
+ appendLiveRegion('second');
+
+ // add third live region later
+ window.setTimeout(function() {
+ appendLiveRegion('third');
+ window.setTimeout(function() {
+ appendLiveRegion('fourth', HIDE);
+ window.setTimeout(function() {
+ unhide('fourth');
+ window.setTimeout(function() {
+ appendDiv('fifth');
+ window.setTimeout(updateAll, 1);
+ }, 1);
+ }, 1);
+ }, 1);
+ }, 1);
+}
+
+var $ = function(id) {
+ return document.getElementById(id);
+}
+
+var updateAll = function() {
+ window.setTimeout(function() {
+ updateLiveRegion('first');
+ window.setTimeout(function() {
+ updateLiveRegion('second');
+ window.setTimeout(function() {
+ updateLiveRegion('third');
+ window.setTimeout(function() {
+ updateLiveRegion('fourth');
+ window.setTimeout(function() { endTest(); }, 1);
+ }, 1);
+ }, 1);
+ }, 1);
+ }, 1);
+
+}
+var updateLiveRegion = function(id) {
+ var lr = $(id);
+ lr.innerHTML = id;
+}
+var appendLiveRegion = function(id, optHide) {
+ var lr = document.createElement('div');
+ lr.id = id;
+ lr.setAttribute('role', 'log');
+ if (optHide) {
+ lr.hidden = true;
+ }
+ $("content").appendChild(lr);
+}
+var appendDiv = function(id) {
+ var lr = document.createElement('div');
+ lr.id = id;
+ lr.setAttribute('role', 'group');
+ $("content").appendChild(lr);
+}
+var unhide = function(id){
+ $(id).hidden = false;
+}
+
+function ariaCallback(element, notification) {
+ if (notification == "AXLiveRegionCreated") {
+ debug("PASS Received live region created notification: " + notification + ": " + element.stringAttributeValue('AXDOMIdentifier'));
+ }
+}
+
+function endTest() {
+ document.getElementById("content").style.display = 'none';
+ finishJSTest();
+}
+
+window.jsTestIsAsync = true;
+if (window.accessibilityController) {
+ var addedNotification = accessibilityController.addNotificationListener(ariaCallback);
+
+ // Make sure AX is enabled by accessing root element.
+ accessibilityController.rootElement;
+
+ startTest();
+}
+successfullyParsed = true;
+
+</script>
+
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (166648 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-02 15:38:40 UTC (rev 166648)
+++ trunk/Source/WebCore/ChangeLog 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -1,3 +1,38 @@
</span><ins>+2014-04-02 Chris Fleizach <cfleizach@apple.com>
+
+ AX: Improve ARIA live region reliability by sending notifications when live regions are created/shown and hidden/destroyed
+ https://bugs.webkit.org/show_bug.cgi?id=124381
+
+ Reviewed by Mario Sanchez Prada.
+
+ Re-organize some code so that when we detect a new node has been created, we can safely determine its live region status.
+ If it is a live region, we fire off a live region created notification.
+
+ Test: platform/mac/accessibility/live-region-creation-notification.html
+
+ * accessibility/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::handleLiveRegionCreated):
+ (WebCore::AXObjectCache::childrenChanged):
+ (WebCore::AXObjectCache::handleAttributeChanged):
+ * accessibility/AXObjectCache.h:
+ (WebCore::AXObjectCache::childrenChanged):
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::defaultLiveRegionStatusForRole):
+ (WebCore::AccessibilityObject::liveRegionStatusIsEnabled):
+ (WebCore::AccessibilityObject::supportsARIALiveRegion):
+ * accessibility/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::ariaLiveRegionStatus):
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
+ * accessibility/AccessibilityRenderObject.h:
+ * accessibility/ios/AXObjectCacheIOS.mm:
+ (WebCore::AXObjectCache::postPlatformNotification):
+ * accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
+ * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+ (-[WebAccessibilityObjectWrapper postLiveRegionCreatedNotification]):
+ * accessibility/mac/AXObjectCacheMac.mm:
+ (WebCore::AXObjectCache::postPlatformNotification):
+
</ins><span class="cx"> 2014-04-02 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r165704): [GTK] Inspector resources not correctly generated
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAXObjectCachecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (166648 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2014-04-02 15:38:40 UTC (rev 166648)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -636,8 +636,30 @@
</span><span class="cx"> postNotification(getOrCreate(node), &document(), AXMenuOpened);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void AXObjectCache::childrenChanged(Node* node)
</del><ins>+void AXObjectCache::handleLiveRegionCreated(Node* node)
</ins><span class="cx"> {
</span><ins>+ if (!node || !node->renderer() || !node->isElementNode())
+ return;
+
+ Element* element = toElement(node);
+ String liveRegionStatus = element->fastGetAttribute(aria_liveAttr);
+ if (liveRegionStatus.isEmpty()) {
+ const AtomicString& ariaRole = element->fastGetAttribute(roleAttr);
+ if (!ariaRole.isEmpty())
+ liveRegionStatus = AccessibilityObject::defaultLiveRegionStatusForRole(AccessibilityObject::ariaRoleToWebCoreRole(ariaRole));
+ }
+
+ if (AccessibilityObject::liveRegionStatusIsEnabled(liveRegionStatus))
+ postNotification(getOrCreate(node), &document(), AXLiveRegionCreated);
+}
+
+void AXObjectCache::childrenChanged(Node* node, Node* newChild)
+{
+ if (newChild) {
+ handleMenuOpened(newChild);
+ handleLiveRegionCreated(newChild);
+ }
+
</ins><span class="cx"> childrenChanged(get(node));
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -645,8 +667,11 @@
</span><span class="cx"> {
</span><span class="cx"> if (!renderer)
</span><span class="cx"> return;
</span><del>- if (newChild)
</del><ins>+
+ if (newChild) {
</ins><span class="cx"> handleMenuOpened(newChild->node());
</span><ins>+ handleLiveRegionCreated(newChild->node());
+ }
</ins><span class="cx">
</span><span class="cx"> childrenChanged(get(renderer));
</span><span class="cx"> }
</span><span class="lines">@@ -899,7 +924,7 @@
</span><span class="cx"> else if (attrName == aria_expandedAttr)
</span><span class="cx"> handleAriaExpandedChange(element);
</span><span class="cx"> else if (attrName == aria_hiddenAttr)
</span><del>- childrenChanged(element->parentNode());
</del><ins>+ childrenChanged(element->parentNode(), element);
</ins><span class="cx"> else if (attrName == aria_invalidAttr)
</span><span class="cx"> postNotification(element, AXObjectCache::AXInvalidStatusChanged);
</span><span class="cx"> else
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAXObjectCacheh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (166648 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AXObjectCache.h 2014-04-02 15:38:40 UTC (rev 166648)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -104,7 +104,7 @@
</span><span class="cx">
</span><span class="cx"> void detachWrapper(AccessibilityObject*, AccessibilityDetachmentType);
</span><span class="cx"> void attachWrapper(AccessibilityObject*);
</span><del>- void childrenChanged(Node*);
</del><ins>+ void childrenChanged(Node*, Node* newChild = nullptr);
</ins><span class="cx"> void childrenChanged(RenderObject*, RenderObject* newChild = nullptr);
</span><span class="cx"> void childrenChanged(AccessibilityObject*);
</span><span class="cx"> void checkedStateChanged(Node*);
</span><span class="lines">@@ -169,6 +169,7 @@
</span><span class="cx"> AXSelectedTextChanged,
</span><span class="cx"> AXValueChanged,
</span><span class="cx"> AXScrolledToAnchor,
</span><ins>+ AXLiveRegionCreated,
</ins><span class="cx"> AXLiveRegionChanged,
</span><span class="cx"> AXMenuListItemSelected,
</span><span class="cx"> AXMenuListValueChanged,
</span><span class="lines">@@ -243,6 +244,7 @@
</span><span class="cx"> Vector<std::pair<RefPtr<AccessibilityObject>, AXNotification>> m_notificationsToPost;
</span><span class="cx"> void notificationPostTimerFired(Timer<AXObjectCache>&);
</span><span class="cx"> void handleMenuOpened(Node*);
</span><ins>+ void handleLiveRegionCreated(Node*);
</ins><span class="cx"> void handleMenuItemSelected(Node*);
</span><span class="cx">
</span><span class="cx"> static AccessibilityObject* focusedImageMapUIElement(HTMLAreaElement*);
</span><span class="lines">@@ -288,7 +290,7 @@
</span><span class="cx"> inline void AXObjectCache::attachWrapper(AccessibilityObject*) { }
</span><span class="cx"> inline void AXObjectCache::checkedStateChanged(Node*) { }
</span><span class="cx"> inline void AXObjectCache::childrenChanged(RenderObject*, RenderObject*) { }
</span><del>-inline void AXObjectCache::childrenChanged(Node*) { }
</del><ins>+inline void AXObjectCache::childrenChanged(Node*, Node*) { }
</ins><span class="cx"> inline void AXObjectCache::childrenChanged(AccessibilityObject*) { }
</span><span class="cx"> inline void AXObjectCache::textChanged(RenderObject*) { }
</span><span class="cx"> inline void AXObjectCache::textChanged(Node*) { }
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (166648 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2014-04-02 15:38:40 UTC (rev 166648)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -1489,7 +1489,24 @@
</span><span class="cx"> obj->ariaTreeRows(result);
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>-
</del><ins>+
+const String AccessibilityObject::defaultLiveRegionStatusForRole(AccessibilityRole role)
+{
+ switch (role) {
+ case ApplicationAlertDialogRole:
+ case ApplicationAlertRole:
+ return ASCIILiteral("assertive");
+ case ApplicationLogRole:
+ case ApplicationStatusRole:
+ return ASCIILiteral("polite");
+ case ApplicationTimerRole:
+ case ApplicationMarqueeRole:
+ return ASCIILiteral("off");
+ default:
+ return nullAtom;
+ }
+}
+
</ins><span class="cx"> #if HAVE(ACCESSIBILITY)
</span><span class="cx"> const String& AccessibilityObject::actionVerb() const
</span><span class="cx"> {
</span><span class="lines">@@ -1825,10 +1842,14 @@
</span><span class="cx"> || hasAttribute(aria_relevantAttr);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+bool AccessibilityObject::liveRegionStatusIsEnabled(const AtomicString& liveRegionStatus)
+{
+ return equalIgnoringCase(liveRegionStatus, "polite") || equalIgnoringCase(liveRegionStatus, "assertive");
+}
+
</ins><span class="cx"> bool AccessibilityObject::supportsARIALiveRegion() const
</span><span class="cx"> {
</span><del>- const AtomicString& liveRegion = ariaLiveRegionStatus();
- return equalIgnoringCase(liveRegion, "polite") || equalIgnoringCase(liveRegion, "assertive");
</del><ins>+ return liveRegionStatusIsEnabled(ariaLiveRegionStatus());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> AccessibilityObject* AccessibilityObject::elementAccessibilityHitTest(const IntPoint& point) const
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (166648 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.h 2014-04-02 15:38:40 UTC (rev 166648)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -837,10 +837,12 @@
</span><span class="cx"> // ARIA live-region features.
</span><span class="cx"> bool supportsARIALiveRegion() const;
</span><span class="cx"> bool isInsideARIALiveRegion() const;
</span><del>- virtual const AtomicString& ariaLiveRegionStatus() const { return nullAtom; }
</del><ins>+ virtual const String ariaLiveRegionStatus() const { return String(); }
</ins><span class="cx"> virtual const AtomicString& ariaLiveRegionRelevant() const { return nullAtom; }
</span><span class="cx"> virtual bool ariaLiveRegionAtomic() const { return false; }
</span><span class="cx"> virtual bool ariaLiveRegionBusy() const { return false; }
</span><ins>+ static const String defaultLiveRegionStatusForRole(AccessibilityRole);
+ static bool liveRegionStatusIsEnabled(const AtomicString&);
</ins><span class="cx">
</span><span class="cx"> bool supportsARIAAttributes() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (166648 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-04-02 15:38:40 UTC (rev 166648)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -3049,29 +3049,12 @@
</span><span class="cx"> return AccessibilityNodeObject::canHaveChildren();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-const AtomicString& AccessibilityRenderObject::ariaLiveRegionStatus() const
</del><ins>+const String AccessibilityRenderObject::ariaLiveRegionStatus() const
</ins><span class="cx"> {
</span><del>- static NeverDestroyed<const AtomicString> liveRegionStatusAssertive("assertive", AtomicString::ConstructFromLiteral);
- static NeverDestroyed<const AtomicString> liveRegionStatusPolite("polite", AtomicString::ConstructFromLiteral);
- static NeverDestroyed<const AtomicString> liveRegionStatusOff("off", AtomicString::ConstructFromLiteral);
-
</del><span class="cx"> const AtomicString& liveRegionStatus = getAttribute(aria_liveAttr);
</span><span class="cx"> // These roles have implicit live region status.
</span><del>- if (liveRegionStatus.isEmpty()) {
- switch (roleValue()) {
- case ApplicationAlertDialogRole:
- case ApplicationAlertRole:
- return liveRegionStatusAssertive;
- case ApplicationLogRole:
- case ApplicationStatusRole:
- return liveRegionStatusPolite;
- case ApplicationTimerRole:
- case ApplicationMarqueeRole:
- return liveRegionStatusOff;
- default:
- break;
- }
- }
</del><ins>+ if (liveRegionStatus.isEmpty())
+ return defaultLiveRegionStatusForRole(roleValue());
</ins><span class="cx">
</span><span class="cx"> return liveRegionStatus;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityRenderObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h (166648 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h 2014-04-02 15:38:40 UTC (rev 166648)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -278,7 +278,7 @@
</span><span class="cx">
</span><span class="cx"> virtual ESpeak speakProperty() const override;
</span><span class="cx">
</span><del>- virtual const AtomicString& ariaLiveRegionStatus() const override;
</del><ins>+ virtual const String ariaLiveRegionStatus() const override;
</ins><span class="cx"> virtual const AtomicString& ariaLiveRegionRelevant() const override;
</span><span class="cx"> virtual bool ariaLiveRegionAtomic() const override;
</span><span class="cx"> virtual bool ariaLiveRegionBusy() const override;
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosAXObjectCacheIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm (166648 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm 2014-04-02 15:38:40 UTC (rev 166648)
+++ trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -70,6 +70,9 @@
</span><span class="cx"> case AXLiveRegionChanged:
</span><span class="cx"> [obj->wrapper() postLiveRegionChangeNotification];
</span><span class="cx"> break;
</span><ins>+ case AXLiveRegionCreated:
+ [obj->wrapper() postLiveRegionCreatedNotification];
+ break;
</ins><span class="cx"> case AXChildrenChanged:
</span><span class="cx"> [obj->wrapper() postChildrenChangedNotification];
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h (166648 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h 2014-04-02 15:38:40 UTC (rev 166648)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -60,6 +60,7 @@
</span><span class="cx"> - (void)postLoadCompleteNotification;
</span><span class="cx"> - (void)postChildrenChangedNotification;
</span><span class="cx"> - (void)postInvalidStatusChangedNotification;
</span><ins>+- (void)postLiveRegionCreatedNotification;
</ins><span class="cx">
</span><span class="cx"> @end
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (166648 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-04-02 15:38:40 UTC (rev 166648)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -1367,6 +1367,11 @@
</span><span class="cx"> // The UIKit accessibility wrapper will override and post appropriate notification.
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (void)postLiveRegionCreatedNotification
+{
+ // The UIKit accessibility wrapper will override and post appropriate notification.
+}
+
</ins><span class="cx"> - (void)postLoadCompleteNotification
</span><span class="cx"> {
</span><span class="cx"> // The UIKit accessibility wrapper will override and post appropriate notification.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacAXObjectCacheMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm (166648 => 166649)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm 2014-04-02 15:38:40 UTC (rev 166648)
+++ trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm 2014-04-02 16:31:15 UTC (rev 166649)
</span><span class="lines">@@ -39,6 +39,10 @@
</span><span class="cx"> #define NSAccessibilityLiveRegionChangedNotification @"AXLiveRegionChanged"
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+#ifndef NSAccessibilityLiveRegionCreatedNotification
+#define NSAccessibilityLiveRegionCreatedNotification @"AXLiveRegionCreated"
+#endif
+
</ins><span class="cx"> // The simple Cocoa calls in this file don't throw exceptions.
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -103,6 +107,9 @@
</span><span class="cx"> case AXValueChanged:
</span><span class="cx"> macNotification = NSAccessibilityValueChangedNotification;
</span><span class="cx"> break;
</span><ins>+ case AXLiveRegionCreated:
+ macNotification = NSAccessibilityLiveRegionCreatedNotification;
+ break;
</ins><span class="cx"> case AXLiveRegionChanged:
</span><span class="cx"> macNotification = NSAccessibilityLiveRegionChangedNotification;
</span><span class="cx"> break;
</span></span></pre>
</div>
</div>
</body>
</html>