<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166568] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166568">166568</a></dd>
<dt>Author</dt> <dd>mrobinson@webkit.org</dd>
<dt>Date</dt> <dd>2014-04-01 00:28:14 -0700 (Tue, 01 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Readonly attributes installed as readwrite in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=130978
Reviewed by Carlos Garcia Campos.
Unify how we decide if an attribute is readable or writeable and improve the code.
This results in some attributes now being marked as read-only which didn't have
corresponding case statements in the set_property switch statements and also correctly
installs set_property support for some more POD types.
* bindings/scripts/CodeGeneratorGObject.pm:
(IsPropertyReadable): Added this helper to simplify deciding if an attribute is readable.
(IsPropertyWriteable): Added this helper to simplify deciding if an attribute is writeable. Also
update the list of types to reflect the full list of types we can generate setters for.
(GenerateProperty): Use the IsPropertyWriteable helper instead of checking whether the attribute is read-only.
Also fix generation of the blurb by using $mutableString instead of $mutableStringconst which isn't used.
(GenerateProperties): Use grep and the new helpers to simplify the code.
(GetReadableProperties): Deleted.
(GetWriteableProperties): Deleted.
* bindings/scripts/test/GObject: Update results</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestInterfacecpp">trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestSerializedScriptValueInterfacecpp">trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestTypedefscpp">trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (166567 => 166568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-01 06:34:18 UTC (rev 166567)
+++ trunk/Source/WebCore/ChangeLog 2014-04-01 07:28:14 UTC (rev 166568)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2014-04-01 Martin Robinson <mrobinson@igalia.com>
+
+ [GTK] Readonly attributes installed as readwrite in GObject DOM bindings
+ https://bugs.webkit.org/show_bug.cgi?id=130978
+
+ Reviewed by Carlos Garcia Campos.
+
+ Unify how we decide if an attribute is readable or writeable and improve the code.
+ This results in some attributes now being marked as read-only which didn't have
+ corresponding case statements in the set_property switch statements and also correctly
+ installs set_property support for some more POD types.
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (IsPropertyReadable): Added this helper to simplify deciding if an attribute is readable.
+ (IsPropertyWriteable): Added this helper to simplify deciding if an attribute is writeable. Also
+ update the list of types to reflect the full list of types we can generate setters for.
+ (GenerateProperty): Use the IsPropertyWriteable helper instead of checking whether the attribute is read-only.
+ Also fix generation of the blurb by using $mutableString instead of $mutableStringconst which isn't used.
+ (GenerateProperties): Use grep and the new helpers to simplify the code.
+ (GetReadableProperties): Deleted.
+ (GetWriteableProperties): Deleted.
+ * bindings/scripts/test/GObject: Update results
+
</ins><span class="cx"> 2014-03-31 Ryuan Choi <ryuan.choi@samsung.com>
</span><span class="cx">
</span><span class="cx"> [EFL][WK2] Extract the control of page background out of color_set
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (166567 => 166568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-04-01 06:34:18 UTC (rev 166567)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-04-01 07:28:14 UTC (rev 166568)
</span><span class="lines">@@ -412,41 +412,45 @@
</span><span class="cx"> return 1;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-sub GetReadableProperties {
- my $properties = shift;
</del><ins>+sub IsPropertyReadable {
+ my $property = shift;
+ return !SkipAttribute($property);
+}
</ins><span class="cx">
</span><del>- my @result = ();
</del><ins>+sub IsPropertyWriteable {
+ my $property = shift;
</ins><span class="cx">
</span><del>- foreach my $property (@{$properties}) {
- if (!SkipAttribute($property)) {
- push(@result, $property);
- }
</del><ins>+ if (!IsPropertyReadable($property)) {
+ return 0;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- return @result;
-}
</del><ins>+ if ($property->isReadOnly) {
+ return 0;
+ }
</ins><span class="cx">
</span><del>-sub GetWriteableProperties {
- my $properties = shift;
- my @result = ();
</del><ins>+ my $gtype = GetGValueTypeName($property->signature->type);
+ my $hasGtypeSignature = $gtype eq "boolean" || $gtype eq "float" || $gtype eq "double" ||
+ $gtype eq "int64" || $gtype eq "uint64" ||
+ $gtype eq "long" || $gtype eq "ulong" ||
+ $gtype eq "int" || $gtype eq "uint" ||
+ $gtype eq "short" || $gtype eq "ushort" ||
+ $gtype eq "int8" || $gtype eq "uint8" ||
+ $gtype eq "char" || $gtype eq "uchar" ||
+ $gtype eq "string";
+ if (!$hasGtypeSignature) {
+ return 0;
+ }
</ins><span class="cx">
</span><del>- foreach my $property (@{$properties}) {
- my $gtype = GetGValueTypeName($property->signature->type);
- my $hasGtypeSignature = ($gtype eq "boolean" || $gtype eq "float" || $gtype eq "double" ||
- $gtype eq "uint64" || $gtype eq "ulong" || $gtype eq "long" ||
- $gtype eq "uint" || $gtype eq "ushort" || $gtype eq "int8" ||
- $gtype eq "uint8" || $gtype eq "uchar" || $gtype eq "char" ||
- $gtype eq "string");
- # FIXME: We are not generating setters for 'Replaceable'
- # attributes now, but we should somehow.
- my $replaceable = $property->signature->extendedAttributes->{"Replaceable"};
- my $custom = $property->signature->extendedAttributes->{"CustomSetter"};
- if (!$property->isReadOnly && $hasGtypeSignature && !$replaceable && !$custom) {
- push(@result, $property);
- }
</del><ins>+ # FIXME: We are not generating setters for 'Replaceable' attributes now, but we should somehow.
+ if ($property->signature->extendedAttributes->{"Replaceable"}) {
+ return 0;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- return @result;
</del><ins>+ if ($property->signature->extendedAttributes->{"CustomSetter"}) {
+ return 0;
+ }
+
+ return 1;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sub GenerateConditionalWarning
</span><span class="lines">@@ -508,15 +512,15 @@
</span><span class="cx">
</span><span class="cx"> my $gtype = GetGValueTypeName($propType);
</span><span class="cx"> my $gparamflag = "WEBKIT_PARAM_READABLE";
</span><del>- my $writeable = !$attribute->isReadOnly;
</del><ins>+ my $writeable = IsPropertyWriteable($attribute);
</ins><span class="cx">
</span><span class="cx"> my $mutableString = "read-only";
</span><span class="cx"> my $hasCustomSetter = $attribute->signature->extendedAttributes->{"CustomSetter"};
</span><span class="cx"> if ($writeable && $hasCustomSetter) {
</span><del>- $mutableStringconst = "read-only (due to custom functions needed in webkitdom)";
</del><ins>+ $mutableString = "read-only (due to custom functions needed in webkitdom)";
</ins><span class="cx"> } elsif ($writeable) {
</span><span class="cx"> $gparamflag = "WEBKIT_PARAM_READWRITE";
</span><del>- $mutableStringconst = "read-write";
</del><ins>+ $mutableString = "read-write";
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> my $convertFunction = "";
</span><span class="lines">@@ -637,8 +641,8 @@
</span><span class="cx">
</span><span class="cx"> # Properties
</span><span class="cx"> my $implContent = "";
</span><del>- my @readableProperties = GetReadableProperties($interface->attributes);
- my @writeableProperties = GetWriteableProperties(\@readableProperties);
</del><ins>+ my @readableProperties = grep { IsPropertyReadable($_) } @{$interface->attributes};
+ my @writeableProperties = grep { IsPropertyWriteable($_) } @{$interface->attributes};
</ins><span class="cx"> my $numProperties = scalar @readableProperties;
</span><span class="cx">
</span><span class="cx"> # Properties
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestInterfacecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp (166567 => 166568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp 2014-04-01 06:34:18 UTC (rev 166567)
+++ trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp 2014-04-01 07:28:14 UTC (rev 166568)
</span><span class="lines">@@ -279,7 +279,7 @@
</span><span class="cx"> g_param_spec_string(
</span><span class="cx"> "implements-str2",
</span><span class="cx"> "TestInterface:implements-str2",
</span><del>- "read-only gchar* TestInterface:implements-str2",
</del><ins>+ "read-write gchar* TestInterface:implements-str2",
</ins><span class="cx"> "",
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -291,7 +291,7 @@
</span><span class="cx"> "TestInterface:implements-node",
</span><span class="cx"> "read-only WebKitDOMNode* TestInterface:implements-node",
</span><span class="cx"> WEBKIT_TYPE_DOM_NODE,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -309,7 +309,7 @@
</span><span class="cx"> g_param_spec_string(
</span><span class="cx"> "supplemental-str2",
</span><span class="cx"> "TestInterface:supplemental-str2",
</span><del>- "read-only gchar* TestInterface:supplemental-str2",
</del><ins>+ "read-write gchar* TestInterface:supplemental-str2",
</ins><span class="cx"> "",
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -321,7 +321,7 @@
</span><span class="cx"> "TestInterface:supplemental-node",
</span><span class="cx"> "read-only WebKitDOMNode* TestInterface:supplemental-node",
</span><span class="cx"> WEBKIT_TYPE_DOM_NODE,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestObjcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp (166567 => 166568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp 2014-04-01 06:34:18 UTC (rev 166567)
+++ trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp 2014-04-01 07:28:14 UTC (rev 166568)
</span><span class="lines">@@ -159,6 +159,10 @@
</span><span class="cx"> coreSelf->setOctetAttr((g_value_get_uint8(value)));
</span><span class="cx"> break;
</span><span class="cx"> }
</span><ins>+ case PROP_SHORT_ATTR: {
+ coreSelf->setShortAttr((g_value_get_int(value)));
+ break;
+ }
</ins><span class="cx"> case PROP_UNSIGNED_SHORT_ATTR: {
</span><span class="cx"> coreSelf->setUnsignedShortAttr((g_value_get_uint(value)));
</span><span class="cx"> break;
</span><span class="lines">@@ -167,6 +171,10 @@
</span><span class="cx"> coreSelf->setLongAttr((g_value_get_long(value)));
</span><span class="cx"> break;
</span><span class="cx"> }
</span><ins>+ case PROP_LONG_LONG_ATTR: {
+ coreSelf->setLongLongAttr((g_value_get_int64(value)));
+ break;
+ }
</ins><span class="cx"> case PROP_UNSIGNED_LONG_LONG_ATTR: {
</span><span class="cx"> coreSelf->setUnsignedLongLongAttr((g_value_get_uint64(value)));
</span><span class="cx"> break;
</span><span class="lines">@@ -626,7 +634,7 @@
</span><span class="cx"> g_param_spec_int8(
</span><span class="cx"> "byte-attr",
</span><span class="cx"> "TestObj:byte-attr",
</span><del>- "read-only gint8 TestObj:byte-attr",
</del><ins>+ "read-write gint8 TestObj:byte-attr",
</ins><span class="cx"> G_MININT8, G_MAXINT8, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -636,7 +644,7 @@
</span><span class="cx"> g_param_spec_uint8(
</span><span class="cx"> "octet-attr",
</span><span class="cx"> "TestObj:octet-attr",
</span><del>- "read-only guint8 TestObj:octet-attr",
</del><ins>+ "read-write guint8 TestObj:octet-attr",
</ins><span class="cx"> 0, G_MAXUINT8, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -646,7 +654,7 @@
</span><span class="cx"> g_param_spec_int(
</span><span class="cx"> "short-attr",
</span><span class="cx"> "TestObj:short-attr",
</span><del>- "read-only gshort TestObj:short-attr",
</del><ins>+ "read-write gshort TestObj:short-attr",
</ins><span class="cx"> G_MININT, G_MAXINT, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -656,7 +664,7 @@
</span><span class="cx"> g_param_spec_uint(
</span><span class="cx"> "unsigned-short-attr",
</span><span class="cx"> "TestObj:unsigned-short-attr",
</span><del>- "read-only gushort TestObj:unsigned-short-attr",
</del><ins>+ "read-write gushort TestObj:unsigned-short-attr",
</ins><span class="cx"> 0, G_MAXUINT, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -666,7 +674,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "long-attr",
</span><span class="cx"> "TestObj:long-attr",
</span><del>- "read-only glong TestObj:long-attr",
</del><ins>+ "read-write glong TestObj:long-attr",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -676,7 +684,7 @@
</span><span class="cx"> g_param_spec_int64(
</span><span class="cx"> "long-long-attr",
</span><span class="cx"> "TestObj:long-long-attr",
</span><del>- "read-only gint64 TestObj:long-long-attr",
</del><ins>+ "read-write gint64 TestObj:long-long-attr",
</ins><span class="cx"> G_MININT64, G_MAXINT64, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -686,7 +694,7 @@
</span><span class="cx"> g_param_spec_uint64(
</span><span class="cx"> "unsigned-long-long-attr",
</span><span class="cx"> "TestObj:unsigned-long-long-attr",
</span><del>- "read-only guint64 TestObj:unsigned-long-long-attr",
</del><ins>+ "read-write guint64 TestObj:unsigned-long-long-attr",
</ins><span class="cx"> 0, G_MAXUINT64, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -696,7 +704,7 @@
</span><span class="cx"> g_param_spec_string(
</span><span class="cx"> "string-attr",
</span><span class="cx"> "TestObj:string-attr",
</span><del>- "read-only gchar* TestObj:string-attr",
</del><ins>+ "read-write gchar* TestObj:string-attr",
</ins><span class="cx"> "",
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -708,7 +716,7 @@
</span><span class="cx"> "TestObj:test-obj-attr",
</span><span class="cx"> "read-only WebKitDOMTestObj* TestObj:test-obj-attr",
</span><span class="cx"> WEBKIT_TYPE_DOM_TEST_OBJ,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -718,7 +726,7 @@
</span><span class="cx"> "TestObj:xml-obj-attr",
</span><span class="cx"> "read-only WebKitDOMTestObj* TestObj:xml-obj-attr",
</span><span class="cx"> WEBKIT_TYPE_DOM_TEST_OBJ,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -726,7 +734,7 @@
</span><span class="cx"> g_param_spec_boolean(
</span><span class="cx"> "create",
</span><span class="cx"> "TestObj:create",
</span><del>- "read-only gboolean TestObj:create",
</del><ins>+ "read-write gboolean TestObj:create",
</ins><span class="cx"> FALSE,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -736,7 +744,7 @@
</span><span class="cx"> g_param_spec_string(
</span><span class="cx"> "reflected-string-attr",
</span><span class="cx"> "TestObj:reflected-string-attr",
</span><del>- "read-only gchar* TestObj:reflected-string-attr",
</del><ins>+ "read-write gchar* TestObj:reflected-string-attr",
</ins><span class="cx"> "",
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -746,7 +754,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "reflected-integral-attr",
</span><span class="cx"> "TestObj:reflected-integral-attr",
</span><del>- "read-only glong TestObj:reflected-integral-attr",
</del><ins>+ "read-write glong TestObj:reflected-integral-attr",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -756,7 +764,7 @@
</span><span class="cx"> g_param_spec_ulong(
</span><span class="cx"> "reflected-unsigned-integral-attr",
</span><span class="cx"> "TestObj:reflected-unsigned-integral-attr",
</span><del>- "read-only gulong TestObj:reflected-unsigned-integral-attr",
</del><ins>+ "read-write gulong TestObj:reflected-unsigned-integral-attr",
</ins><span class="cx"> 0, G_MAXULONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -766,7 +774,7 @@
</span><span class="cx"> g_param_spec_boolean(
</span><span class="cx"> "reflected-boolean-attr",
</span><span class="cx"> "TestObj:reflected-boolean-attr",
</span><del>- "read-only gboolean TestObj:reflected-boolean-attr",
</del><ins>+ "read-write gboolean TestObj:reflected-boolean-attr",
</ins><span class="cx"> FALSE,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -776,7 +784,7 @@
</span><span class="cx"> g_param_spec_string(
</span><span class="cx"> "reflected-url-attr",
</span><span class="cx"> "TestObj:reflected-url-attr",
</span><del>- "read-only gchar* TestObj:reflected-url-attr",
</del><ins>+ "read-write gchar* TestObj:reflected-url-attr",
</ins><span class="cx"> "",
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -786,7 +794,7 @@
</span><span class="cx"> g_param_spec_string(
</span><span class="cx"> "reflected-string-attr",
</span><span class="cx"> "TestObj:reflected-string-attr",
</span><del>- "read-only gchar* TestObj:reflected-string-attr",
</del><ins>+ "read-write gchar* TestObj:reflected-string-attr",
</ins><span class="cx"> "",
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -796,7 +804,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "reflected-custom-integral-attr",
</span><span class="cx"> "TestObj:reflected-custom-integral-attr",
</span><del>- "read-only glong TestObj:reflected-custom-integral-attr",
</del><ins>+ "read-write glong TestObj:reflected-custom-integral-attr",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -806,7 +814,7 @@
</span><span class="cx"> g_param_spec_boolean(
</span><span class="cx"> "reflected-custom-boolean-attr",
</span><span class="cx"> "TestObj:reflected-custom-boolean-attr",
</span><del>- "read-only gboolean TestObj:reflected-custom-boolean-attr",
</del><ins>+ "read-write gboolean TestObj:reflected-custom-boolean-attr",
</ins><span class="cx"> FALSE,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -816,7 +824,7 @@
</span><span class="cx"> g_param_spec_string(
</span><span class="cx"> "reflected-custom-url-attr",
</span><span class="cx"> "TestObj:reflected-custom-url-attr",
</span><del>- "read-only gchar* TestObj:reflected-custom-url-attr",
</del><ins>+ "read-write gchar* TestObj:reflected-custom-url-attr",
</ins><span class="cx"> "",
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -826,7 +834,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "attr-with-getter-exception",
</span><span class="cx"> "TestObj:attr-with-getter-exception",
</span><del>- "read-only glong TestObj:attr-with-getter-exception",
</del><ins>+ "read-write glong TestObj:attr-with-getter-exception",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -836,7 +844,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "attr-with-setter-exception",
</span><span class="cx"> "TestObj:attr-with-setter-exception",
</span><del>- "read-only glong TestObj:attr-with-setter-exception",
</del><ins>+ "read-write glong TestObj:attr-with-setter-exception",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -846,7 +854,7 @@
</span><span class="cx"> g_param_spec_string(
</span><span class="cx"> "string-attr-with-getter-exception",
</span><span class="cx"> "TestObj:string-attr-with-getter-exception",
</span><del>- "read-only gchar* TestObj:string-attr-with-getter-exception",
</del><ins>+ "read-write gchar* TestObj:string-attr-with-getter-exception",
</ins><span class="cx"> "",
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -856,7 +864,7 @@
</span><span class="cx"> g_param_spec_string(
</span><span class="cx"> "string-attr-with-setter-exception",
</span><span class="cx"> "TestObj:string-attr-with-setter-exception",
</span><del>- "read-only gchar* TestObj:string-attr-with-setter-exception",
</del><ins>+ "read-write gchar* TestObj:string-attr-with-setter-exception",
</ins><span class="cx"> "",
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -866,7 +874,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "with-script-state-attribute",
</span><span class="cx"> "TestObj:with-script-state-attribute",
</span><del>- "read-only glong TestObj:with-script-state-attribute",
</del><ins>+ "read-write glong TestObj:with-script-state-attribute",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -878,7 +886,7 @@
</span><span class="cx"> "TestObj:with-script-execution-context-attribute",
</span><span class="cx"> "read-only WebKitDOMTestObj* TestObj:with-script-execution-context-attribute",
</span><span class="cx"> WEBKIT_TYPE_DOM_TEST_OBJ,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -888,7 +896,7 @@
</span><span class="cx"> "TestObj:with-script-state-attribute-raises",
</span><span class="cx"> "read-only WebKitDOMTestObj* TestObj:with-script-state-attribute-raises",
</span><span class="cx"> WEBKIT_TYPE_DOM_TEST_OBJ,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -898,7 +906,7 @@
</span><span class="cx"> "TestObj:with-script-execution-context-attribute-raises",
</span><span class="cx"> "read-only WebKitDOMTestObj* TestObj:with-script-execution-context-attribute-raises",
</span><span class="cx"> WEBKIT_TYPE_DOM_TEST_OBJ,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -908,7 +916,7 @@
</span><span class="cx"> "TestObj:with-script-execution-context-and-script-state-attribute",
</span><span class="cx"> "read-only WebKitDOMTestObj* TestObj:with-script-execution-context-and-script-state-attribute",
</span><span class="cx"> WEBKIT_TYPE_DOM_TEST_OBJ,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -918,7 +926,7 @@
</span><span class="cx"> "TestObj:with-script-execution-context-and-script-state-attribute-raises",
</span><span class="cx"> "read-only WebKitDOMTestObj* TestObj:with-script-execution-context-and-script-state-attribute-raises",
</span><span class="cx"> WEBKIT_TYPE_DOM_TEST_OBJ,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -928,7 +936,7 @@
</span><span class="cx"> "TestObj:with-script-execution-context-and-script-state-with-spaces-attribute",
</span><span class="cx"> "read-only WebKitDOMTestObj* TestObj:with-script-execution-context-and-script-state-with-spaces-attribute",
</span><span class="cx"> WEBKIT_TYPE_DOM_TEST_OBJ,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -938,7 +946,7 @@
</span><span class="cx"> "TestObj:with-script-arguments-and-call-stack-attribute",
</span><span class="cx"> "read-only WebKitDOMTestObj* TestObj:with-script-arguments-and-call-stack-attribute",
</span><span class="cx"> WEBKIT_TYPE_DOM_TEST_OBJ,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -946,7 +954,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "conditional-attr1",
</span><span class="cx"> "TestObj:conditional-attr1",
</span><del>- "read-only glong TestObj:conditional-attr1",
</del><ins>+ "read-write glong TestObj:conditional-attr1",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -956,7 +964,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "conditional-attr2",
</span><span class="cx"> "TestObj:conditional-attr2",
</span><del>- "read-only glong TestObj:conditional-attr2",
</del><ins>+ "read-write glong TestObj:conditional-attr2",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -966,7 +974,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "conditional-attr3",
</span><span class="cx"> "TestObj:conditional-attr3",
</span><del>- "read-only glong TestObj:conditional-attr3",
</del><ins>+ "read-write glong TestObj:conditional-attr3",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -978,7 +986,7 @@
</span><span class="cx"> "TestObj:any-attribute",
</span><span class="cx"> "read-only WebKitDOMany* TestObj:any-attribute",
</span><span class="cx"> WEBKIT_TYPE_DOM_ANY,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -998,7 +1006,7 @@
</span><span class="cx"> "TestObj:mutable-point",
</span><span class="cx"> "read-only WebKitDOMSVGPoint* TestObj:mutable-point",
</span><span class="cx"> WEBKIT_TYPE_DOM_SVG_POINT,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -1008,7 +1016,7 @@
</span><span class="cx"> "TestObj:immutable-point",
</span><span class="cx"> "read-only WebKitDOMSVGPoint* TestObj:immutable-point",
</span><span class="cx"> WEBKIT_TYPE_DOM_SVG_POINT,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -1016,7 +1024,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "strawberry",
</span><span class="cx"> "TestObj:strawberry",
</span><del>- "read-only glong TestObj:strawberry",
</del><ins>+ "read-write glong TestObj:strawberry",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -1026,7 +1034,7 @@
</span><span class="cx"> g_param_spec_float(
</span><span class="cx"> "strict-float",
</span><span class="cx"> "TestObj:strict-float",
</span><del>- "read-only gfloat TestObj:strict-float",
</del><ins>+ "read-write gfloat TestObj:strict-float",
</ins><span class="cx"> -G_MAXFLOAT, G_MAXFLOAT, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -1046,7 +1054,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "id",
</span><span class="cx"> "TestObj:id",
</span><del>- "read-only glong TestObj:id",
</del><ins>+ "read-write glong TestObj:id",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -1116,7 +1124,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "nullable-long-settable-attribute",
</span><span class="cx"> "TestObj:nullable-long-settable-attribute",
</span><del>- "read-only glong TestObj:nullable-long-settable-attribute",
</del><ins>+ "read-write glong TestObj:nullable-long-settable-attribute",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -1126,7 +1134,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "nullable-string-value",
</span><span class="cx"> "TestObj:nullable-string-value",
</span><del>- "read-only glong TestObj:nullable-string-value",
</del><ins>+ "read-write glong TestObj:nullable-string-value",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestSerializedScriptValueInterfacecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp (166567 => 166568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp 2014-04-01 06:34:18 UTC (rev 166567)
+++ trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp 2014-04-01 07:28:14 UTC (rev 166568)
</span><span class="lines">@@ -175,7 +175,7 @@
</span><span class="cx"> "TestSerializedScriptValueInterface:value",
</span><span class="cx"> "read-only WebKitDOMSerializedScriptValue* TestSerializedScriptValueInterface:value",
</span><span class="cx"> WEBKIT_TYPE_DOM_SERIALIZED_SCRIPT_VALUE,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -195,7 +195,7 @@
</span><span class="cx"> "TestSerializedScriptValueInterface:cached-value",
</span><span class="cx"> "read-only WebKitDOMSerializedScriptValue* TestSerializedScriptValueInterface:cached-value",
</span><span class="cx"> WEBKIT_TYPE_DOM_SERIALIZED_SCRIPT_VALUE,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestTypedefscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp (166567 => 166568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp 2014-04-01 06:34:18 UTC (rev 166567)
+++ trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp 2014-04-01 07:28:14 UTC (rev 166568)
</span><span class="lines">@@ -191,7 +191,7 @@
</span><span class="cx"> g_param_spec_uint64(
</span><span class="cx"> "unsigned-long-long-attr",
</span><span class="cx"> "TestTypedefs:unsigned-long-long-attr",
</span><del>- "read-only guint64 TestTypedefs:unsigned-long-long-attr",
</del><ins>+ "read-write guint64 TestTypedefs:unsigned-long-long-attr",
</ins><span class="cx"> 0, G_MAXUINT64, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -203,7 +203,7 @@
</span><span class="cx"> "TestTypedefs:immutable-serialized-script-value",
</span><span class="cx"> "read-only WebKitDOMSerializedScriptValue* TestTypedefs:immutable-serialized-script-value",
</span><span class="cx"> WEBKIT_TYPE_DOM_SERIALIZED_SCRIPT_VALUE,
</span><del>- WEBKIT_PARAM_READWRITE));
</del><ins>+ WEBKIT_PARAM_READABLE));
</ins><span class="cx">
</span><span class="cx"> g_object_class_install_property(
</span><span class="cx"> gobjectClass,
</span><span class="lines">@@ -211,7 +211,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "attr-with-getter-exception",
</span><span class="cx"> "TestTypedefs:attr-with-getter-exception",
</span><del>- "read-only glong TestTypedefs:attr-with-getter-exception",
</del><ins>+ "read-write glong TestTypedefs:attr-with-getter-exception",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -221,7 +221,7 @@
</span><span class="cx"> g_param_spec_long(
</span><span class="cx"> "attr-with-setter-exception",
</span><span class="cx"> "TestTypedefs:attr-with-setter-exception",
</span><del>- "read-only glong TestTypedefs:attr-with-setter-exception",
</del><ins>+ "read-write glong TestTypedefs:attr-with-setter-exception",
</ins><span class="cx"> G_MINLONG, G_MAXLONG, 0,
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -231,7 +231,7 @@
</span><span class="cx"> g_param_spec_string(
</span><span class="cx"> "string-attr-with-getter-exception",
</span><span class="cx"> "TestTypedefs:string-attr-with-getter-exception",
</span><del>- "read-only gchar* TestTypedefs:string-attr-with-getter-exception",
</del><ins>+ "read-write gchar* TestTypedefs:string-attr-with-getter-exception",
</ins><span class="cx"> "",
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span><span class="lines">@@ -241,7 +241,7 @@
</span><span class="cx"> g_param_spec_string(
</span><span class="cx"> "string-attr-with-setter-exception",
</span><span class="cx"> "TestTypedefs:string-attr-with-setter-exception",
</span><del>- "read-only gchar* TestTypedefs:string-attr-with-setter-exception",
</del><ins>+ "read-write gchar* TestTypedefs:string-attr-with-setter-exception",
</ins><span class="cx"> "",
</span><span class="cx"> WEBKIT_PARAM_READWRITE));
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>