<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166461] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166461">166461</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-03-30 03:48:32 -0700 (Sun, 30 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make NodeList and HTMLCollection caching helpers use PassRef.
<https://webkit.org/b/130943>
Tweak the helpers in NodeListsNodeData to return PassRef instead of
PassRefPtr. This knocks 2 branches off of some pretty hot code on
Dromaeo/dom-query.
Reviewed by Antti Koivisto.
* dom/ChildNodeList.h:
* dom/ClassNodeList.h:
* dom/NameNodeList.h:
* dom/NodeRareData.h:
(WebCore::NodeListsNodeData::ensureChildNodeList):
(WebCore::NodeListsNodeData::ensureEmptyChildNodeList):
(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
(WebCore::NodeListsNodeData::addCachedCollection):
* dom/TagNodeList.h:
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::create):
* html/HTMLCollection.h:
* html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::create):
* html/HTMLFormControlsCollection.h:
* html/RadioNodeList.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomChildNodeListh">trunk/Source/WebCore/dom/ChildNodeList.h</a></li>
<li><a href="#trunkSourceWebCoredomClassNodeListh">trunk/Source/WebCore/dom/ClassNodeList.h</a></li>
<li><a href="#trunkSourceWebCoredomNameNodeListh">trunk/Source/WebCore/dom/NameNodeList.h</a></li>
<li><a href="#trunkSourceWebCoredomNodeRareDatah">trunk/Source/WebCore/dom/NodeRareData.h</a></li>
<li><a href="#trunkSourceWebCoredomTagNodeListh">trunk/Source/WebCore/dom/TagNodeList.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLCollectioncpp">trunk/Source/WebCore/html/HTMLCollection.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLCollectionh">trunk/Source/WebCore/html/HTMLCollection.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormControlsCollectioncpp">trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormControlsCollectionh">trunk/Source/WebCore/html/HTMLFormControlsCollection.h</a></li>
<li><a href="#trunkSourceWebCorehtmlRadioNodeListh">trunk/Source/WebCore/html/RadioNodeList.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (166460 => 166461)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-30 08:32:13 UTC (rev 166460)
+++ trunk/Source/WebCore/ChangeLog 2014-03-30 10:48:32 UTC (rev 166461)
</span><span class="lines">@@ -1,3 +1,33 @@
</span><ins>+2014-03-30 Andreas Kling <akling@apple.com>
+
+ Make NodeList and HTMLCollection caching helpers use PassRef.
+ <https://webkit.org/b/130943>
+
+ Tweak the helpers in NodeListsNodeData to return PassRef instead of
+ PassRefPtr. This knocks 2 branches off of some pretty hot code on
+ Dromaeo/dom-query.
+
+ Reviewed by Antti Koivisto.
+
+ * dom/ChildNodeList.h:
+ * dom/ClassNodeList.h:
+ * dom/NameNodeList.h:
+ * dom/NodeRareData.h:
+ (WebCore::NodeListsNodeData::ensureChildNodeList):
+ (WebCore::NodeListsNodeData::ensureEmptyChildNodeList):
+ (WebCore::NodeListsNodeData::addCacheWithAtomicName):
+ (WebCore::NodeListsNodeData::addCacheWithName):
+ (WebCore::NodeListsNodeData::addCacheWithQualifiedName):
+ (WebCore::NodeListsNodeData::addCachedCollection):
+ * dom/TagNodeList.h:
+ * html/HTMLCollection.cpp:
+ (WebCore::HTMLCollection::create):
+ * html/HTMLCollection.h:
+ * html/HTMLFormControlsCollection.cpp:
+ (WebCore::HTMLFormControlsCollection::create):
+ * html/HTMLFormControlsCollection.h:
+ * html/RadioNodeList.h:
+
</ins><span class="cx"> 2014-03-29 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> LiveNodeLists should use ElementDescendantIterator
</span></span></pre></div>
<a id="trunkSourceWebCoredomChildNodeListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ChildNodeList.h (166460 => 166461)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ChildNodeList.h 2014-03-30 08:32:13 UTC (rev 166460)
+++ trunk/Source/WebCore/dom/ChildNodeList.h 2014-03-30 10:48:32 UTC (rev 166461)
</span><span class="lines">@@ -35,9 +35,9 @@
</span><span class="cx">
</span><span class="cx"> class EmptyNodeList final : public NodeList {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<EmptyNodeList> create(Node& owner)
</del><ins>+ static PassRef<EmptyNodeList> create(Node& owner)
</ins><span class="cx"> {
</span><del>- return adoptRef(new EmptyNodeList(owner));
</del><ins>+ return adoptRef(*new EmptyNodeList(owner));
</ins><span class="cx"> }
</span><span class="cx"> virtual ~EmptyNodeList();
</span><span class="cx">
</span><span class="lines">@@ -58,9 +58,9 @@
</span><span class="cx">
</span><span class="cx"> class ChildNodeList final : public NodeList {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<ChildNodeList> create(ContainerNode& parent)
</del><ins>+ static PassRef<ChildNodeList> create(ContainerNode& parent)
</ins><span class="cx"> {
</span><del>- return adoptRef(new ChildNodeList(parent));
</del><ins>+ return adoptRef(*new ChildNodeList(parent));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> virtual ~ChildNodeList();
</span></span></pre></div>
<a id="trunkSourceWebCoredomClassNodeListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ClassNodeList.h (166460 => 166461)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ClassNodeList.h 2014-03-30 08:32:13 UTC (rev 166460)
+++ trunk/Source/WebCore/dom/ClassNodeList.h 2014-03-30 10:48:32 UTC (rev 166461)
</span><span class="lines">@@ -39,9 +39,9 @@
</span><span class="cx">
</span><span class="cx"> class ClassNodeList final : public CachedLiveNodeList<ClassNodeList> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<ClassNodeList> create(ContainerNode& rootNode, const String& classNames)
</del><ins>+ static PassRef<ClassNodeList> create(ContainerNode& rootNode, const String& classNames)
</ins><span class="cx"> {
</span><del>- return adoptRef(new ClassNodeList(rootNode, classNames));
</del><ins>+ return adoptRef(*new ClassNodeList(rootNode, classNames));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> virtual ~ClassNodeList();
</span></span></pre></div>
<a id="trunkSourceWebCoredomNameNodeListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/NameNodeList.h (166460 => 166461)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/NameNodeList.h 2014-03-30 08:32:13 UTC (rev 166460)
+++ trunk/Source/WebCore/dom/NameNodeList.h 2014-03-30 10:48:32 UTC (rev 166461)
</span><span class="lines">@@ -33,9 +33,9 @@
</span><span class="cx"> // NodeList which lists all Nodes in a Element with a given "name" attribute
</span><span class="cx"> class NameNodeList final : public CachedLiveNodeList<NameNodeList> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<NameNodeList> create(ContainerNode& rootNode, const AtomicString& name)
</del><ins>+ static PassRef<NameNodeList> create(ContainerNode& rootNode, const AtomicString& name)
</ins><span class="cx"> {
</span><del>- return adoptRef(new NameNodeList(rootNode, name));
</del><ins>+ return adoptRef(*new NameNodeList(rootNode, name));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> virtual ~NameNodeList();
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeRareDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/NodeRareData.h (166460 => 166461)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/NodeRareData.h 2014-03-30 08:32:13 UTC (rev 166460)
+++ trunk/Source/WebCore/dom/NodeRareData.h 2014-03-30 10:48:32 UTC (rev 166461)
</span><span class="lines">@@ -66,14 +66,14 @@
</span><span class="cx"> m_childNodeList->invalidateCache();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- PassRefPtr<ChildNodeList> ensureChildNodeList(ContainerNode& node)
</del><ins>+ PassRef<ChildNodeList> ensureChildNodeList(ContainerNode& node)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(!m_emptyChildNodeList);
</span><span class="cx"> if (m_childNodeList)
</span><del>- return m_childNodeList;
- RefPtr<ChildNodeList> list = ChildNodeList::create(node);
- m_childNodeList = list.get();
- return list.release();
</del><ins>+ return *m_childNodeList;
+ auto list = ChildNodeList::create(node);
+ m_childNodeList = &list.get();
+ return list;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void removeChildNodeList(ChildNodeList* list)
</span><span class="lines">@@ -84,14 +84,14 @@
</span><span class="cx"> m_childNodeList = nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- PassRefPtr<EmptyNodeList> ensureEmptyChildNodeList(Node& node)
</del><ins>+ PassRef<EmptyNodeList> ensureEmptyChildNodeList(Node& node)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(!m_childNodeList);
</span><span class="cx"> if (m_emptyChildNodeList)
</span><del>- return m_emptyChildNodeList;
- RefPtr<EmptyNodeList> list = EmptyNodeList::create(node);
- m_emptyChildNodeList = list.get();
- return list.release();
</del><ins>+ return *m_emptyChildNodeList;
+ auto list = EmptyNodeList::create(node);
+ m_emptyChildNodeList = &list.get();
+ return list;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void removeEmptyChildNodeList(EmptyNodeList* list)
</span><span class="lines">@@ -118,63 +118,63 @@
</span><span class="cx"> typedef HashMap<QualifiedName, TagNodeList*> TagNodeListCacheNS;
</span><span class="cx">
</span><span class="cx"> template<typename T, typename ContainerType>
</span><del>- PassRefPtr<T> addCacheWithAtomicName(ContainerType& container, const AtomicString& name)
</del><ins>+ PassRef<T> addCacheWithAtomicName(ContainerType& container, const AtomicString& name)
</ins><span class="cx"> {
</span><span class="cx"> NodeListAtomicNameCacheMap::AddResult result = m_atomicNameCaches.add(namedNodeListKey<T>(name), nullptr);
</span><span class="cx"> if (!result.isNewEntry)
</span><del>- return static_cast<T*>(result.iterator->value);
</del><ins>+ return static_cast<T&>(*result.iterator->value);
</ins><span class="cx">
</span><del>- RefPtr<T> list = T::create(container, name);
- result.iterator->value = list.get();
- return list.release();
</del><ins>+ auto list = T::create(container, name);
+ result.iterator->value = &list.get();
+ return list;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename T>
</span><del>- PassRefPtr<T> addCacheWithName(ContainerNode& node, const String& name)
</del><ins>+ PassRef<T> addCacheWithName(ContainerNode& node, const String& name)
</ins><span class="cx"> {
</span><span class="cx"> NodeListNameCacheMap::AddResult result = m_nameCaches.add(namedNodeListKey<T>(name), nullptr);
</span><span class="cx"> if (!result.isNewEntry)
</span><del>- return static_cast<T*>(result.iterator->value);
</del><ins>+ return static_cast<T&>(*result.iterator->value);
</ins><span class="cx">
</span><del>- RefPtr<T> list = T::create(node, name);
- result.iterator->value = list.get();
- return list.release();
</del><ins>+ auto list = T::create(node, name);
+ result.iterator->value = &list.get();
+ return list;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- PassRefPtr<TagNodeList> addCacheWithQualifiedName(ContainerNode& node, const AtomicString& namespaceURI, const AtomicString& localName)
</del><ins>+ PassRef<TagNodeList> addCacheWithQualifiedName(ContainerNode& node, const AtomicString& namespaceURI, const AtomicString& localName)
</ins><span class="cx"> {
</span><span class="cx"> QualifiedName name(nullAtom, localName, namespaceURI);
</span><span class="cx"> TagNodeListCacheNS::AddResult result = m_tagNodeListCacheNS.add(name, nullptr);
</span><span class="cx"> if (!result.isNewEntry)
</span><del>- return result.iterator->value;
</del><ins>+ return *result.iterator->value;
</ins><span class="cx">
</span><del>- RefPtr<TagNodeList> list = TagNodeList::create(node, namespaceURI, localName);
- result.iterator->value = list.get();
- return list.release();
</del><ins>+ auto list = TagNodeList::create(node, namespaceURI, localName);
+ result.iterator->value = &list.get();
+ return list;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename T, typename ContainerType>
</span><del>- PassRefPtr<T> addCachedCollection(ContainerType& container, CollectionType collectionType, const AtomicString& name)
</del><ins>+ PassRef<T> addCachedCollection(ContainerType& container, CollectionType collectionType, const AtomicString& name)
</ins><span class="cx"> {
</span><span class="cx"> CollectionCacheMap::AddResult result = m_cachedCollections.add(namedCollectionKey(collectionType, name), nullptr);
</span><span class="cx"> if (!result.isNewEntry)
</span><del>- return static_cast<T*>(result.iterator->value);
</del><ins>+ return static_cast<T&>(*result.iterator->value);
</ins><span class="cx">
</span><del>- RefPtr<T> list = T::create(container, collectionType, name);
- result.iterator->value = list.get();
- return list.release();
</del><ins>+ auto list = T::create(container, collectionType, name);
+ result.iterator->value = &list.get();
+ return list;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename T, typename ContainerType>
</span><del>- PassRefPtr<T> addCachedCollection(ContainerType& container, CollectionType collectionType)
</del><ins>+ PassRef<T> addCachedCollection(ContainerType& container, CollectionType collectionType)
</ins><span class="cx"> {
</span><span class="cx"> CollectionCacheMap::AddResult result = m_cachedCollections.add(namedCollectionKey(collectionType, starAtom), nullptr);
</span><span class="cx"> if (!result.isNewEntry)
</span><del>- return static_cast<T*>(result.iterator->value);
</del><ins>+ return static_cast<T&>(*result.iterator->value);
</ins><span class="cx">
</span><del>- RefPtr<T> list = T::create(container, collectionType);
- result.iterator->value = list.get();
- return list.release();
</del><ins>+ auto list = T::create(container, collectionType);
+ result.iterator->value = &list.get();
+ return list;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename T>
</span></span></pre></div>
<a id="trunkSourceWebCoredomTagNodeListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/TagNodeList.h (166460 => 166461)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/TagNodeList.h 2014-03-30 08:32:13 UTC (rev 166460)
+++ trunk/Source/WebCore/dom/TagNodeList.h 2014-03-30 10:48:32 UTC (rev 166461)
</span><span class="lines">@@ -33,15 +33,15 @@
</span><span class="cx"> // NodeList that limits to a particular tag.
</span><span class="cx"> class TagNodeList final : public CachedLiveNodeList<TagNodeList> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<TagNodeList> create(ContainerNode& rootNode, const AtomicString& namespaceURI, const AtomicString& localName)
</del><ins>+ static PassRef<TagNodeList> create(ContainerNode& rootNode, const AtomicString& namespaceURI, const AtomicString& localName)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(namespaceURI != starAtom);
</span><del>- return adoptRef(new TagNodeList(rootNode, namespaceURI, localName));
</del><ins>+ return adoptRef(*new TagNodeList(rootNode, namespaceURI, localName));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<TagNodeList> create(ContainerNode& rootNode, const AtomicString& localName)
</del><ins>+ static PassRef<TagNodeList> create(ContainerNode& rootNode, const AtomicString& localName)
</ins><span class="cx"> {
</span><del>- return adoptRef(new TagNodeList(rootNode, starAtom, localName));
</del><ins>+ return adoptRef(*new TagNodeList(rootNode, starAtom, localName));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> virtual ~TagNodeList();
</span><span class="lines">@@ -67,9 +67,9 @@
</span><span class="cx">
</span><span class="cx"> class HTMLTagNodeList final : public CachedLiveNodeList<HTMLTagNodeList> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<HTMLTagNodeList> create(ContainerNode& rootNode, const AtomicString& localName)
</del><ins>+ static PassRef<HTMLTagNodeList> create(ContainerNode& rootNode, const AtomicString& localName)
</ins><span class="cx"> {
</span><del>- return adoptRef(new HTMLTagNodeList(rootNode, localName));
</del><ins>+ return adoptRef(*new HTMLTagNodeList(rootNode, localName));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> virtual ~HTMLTagNodeList();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLCollectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLCollection.cpp (166460 => 166461)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLCollection.cpp 2014-03-30 08:32:13 UTC (rev 166460)
+++ trunk/Source/WebCore/html/HTMLCollection.cpp 2014-03-30 10:48:32 UTC (rev 166461)
</span><span class="lines">@@ -145,9 +145,9 @@
</span><span class="cx"> ASSERT(m_collectionType == static_cast<unsigned>(type));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<HTMLCollection> HTMLCollection::create(ContainerNode& base, CollectionType type)
</del><ins>+PassRef<HTMLCollection> HTMLCollection::create(ContainerNode& base, CollectionType type)
</ins><span class="cx"> {
</span><del>- return adoptRef(new HTMLCollection(base, type));
</del><ins>+ return adoptRef(*new HTMLCollection(base, type));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> HTMLCollection::~HTMLCollection()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLCollectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLCollection.h (166460 => 166461)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLCollection.h 2014-03-30 08:32:13 UTC (rev 166460)
+++ trunk/Source/WebCore/html/HTMLCollection.h 2014-03-30 10:48:32 UTC (rev 166461)
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx">
</span><span class="cx"> class HTMLCollection : public ScriptWrappable, public RefCounted<HTMLCollection> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<HTMLCollection> create(ContainerNode& base, CollectionType);
</del><ins>+ static PassRef<HTMLCollection> create(ContainerNode& base, CollectionType);
</ins><span class="cx"> virtual ~HTMLCollection();
</span><span class="cx">
</span><span class="cx"> // DOM API
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormControlsCollectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp (166460 => 166461)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp 2014-03-30 08:32:13 UTC (rev 166460)
+++ trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp 2014-03-30 10:48:32 UTC (rev 166461)
</span><span class="lines">@@ -43,9 +43,9 @@
</span><span class="cx"> ASSERT(isHTMLFormElement(ownerNode) || isHTMLFieldSetElement(ownerNode));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<HTMLFormControlsCollection> HTMLFormControlsCollection::create(ContainerNode& ownerNode, CollectionType)
</del><ins>+PassRef<HTMLFormControlsCollection> HTMLFormControlsCollection::create(ContainerNode& ownerNode, CollectionType)
</ins><span class="cx"> {
</span><del>- return adoptRef(new HTMLFormControlsCollection(ownerNode));
</del><ins>+ return adoptRef(*new HTMLFormControlsCollection(ownerNode));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> HTMLFormControlsCollection::~HTMLFormControlsCollection()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormControlsCollectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormControlsCollection.h (166460 => 166461)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormControlsCollection.h 2014-03-30 08:32:13 UTC (rev 166460)
+++ trunk/Source/WebCore/html/HTMLFormControlsCollection.h 2014-03-30 10:48:32 UTC (rev 166461)
</span><span class="lines">@@ -37,7 +37,7 @@
</span><span class="cx">
</span><span class="cx"> class HTMLFormControlsCollection : public HTMLCollection {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<HTMLFormControlsCollection> create(ContainerNode&, CollectionType);
</del><ins>+ static PassRef<HTMLFormControlsCollection> create(ContainerNode&, CollectionType);
</ins><span class="cx">
</span><span class="cx"> virtual ~HTMLFormControlsCollection();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlRadioNodeListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/RadioNodeList.h (166460 => 166461)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/RadioNodeList.h 2014-03-30 08:32:13 UTC (rev 166460)
+++ trunk/Source/WebCore/html/RadioNodeList.h 2014-03-30 10:48:32 UTC (rev 166461)
</span><span class="lines">@@ -35,9 +35,9 @@
</span><span class="cx">
</span><span class="cx"> class RadioNodeList final : public CachedLiveNodeList<RadioNodeList> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<RadioNodeList> create(ContainerNode& rootNode, const AtomicString& name)
</del><ins>+ static PassRef<RadioNodeList> create(ContainerNode& rootNode, const AtomicString& name)
</ins><span class="cx"> {
</span><del>- return adoptRef(new RadioNodeList(rootNode, name));
</del><ins>+ return adoptRef(*new RadioNodeList(rootNode, name));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ~RadioNodeList();
</span></span></pre>
</div>
</div>
</body>
</html>