<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166398] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166398">166398</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-03-27 23:00:39 -0700 (Thu, 27 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: AXI: expose selectedChildNodeIds of list boxes, tree controls, etc., and reconcile UI with childNodeIds
https://bugs.webkit.org/show_bug.cgi?id=130827
Patch by James Craig <jcraig@apple.com> on 2014-03-27
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
Support for selectedChildNodeIds in inspector-protocol: DOM.getAccessibilityPropertiesForNode.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
* inspector/protocol/DOM.json:
Source/WebInspectorUI:
UI updates for "Selected Item(s)" and "Child(ren)" rows in accessibility node inspector.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Models/DOMNode.js:
* UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
Websites/webkit.org:
Updated demo files with attr refresh to show off selected children changing.
Long term fix will be http://webkit.org/b/130883
* blog-files/aria1.0/combobox_with_live_region_status.html:
LayoutTests:
Tests selectedChildNodeIds in inspector-protocol: DOM.getAccessibilityPropertiesForNode.
* inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
* inspector-protocol/dom/getAccessibilityPropertiesForNode.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectorprotocoldomgetAccessibilityPropertiesForNodeexpectedtxt">trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectorprotocoldomgetAccessibilityPropertiesForNodehtml">trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMAgentcpp">trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorprotocolDOMjson">trunk/Source/WebCore/inspector/protocol/DOM.json</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsDOMNodejs">trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMNodeDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js</a></li>
<li><a href="#trunkWebsiteswebkitorgChangeLog">trunk/Websites/webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsiteswebkitorgblogfilesaria10combobox_with_live_region_statushtml">trunk/Websites/webkit.org/blog-files/aria1.0/combobox_with_live_region_status.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (166397 => 166398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-03-28 05:28:39 UTC (rev 166397)
+++ trunk/LayoutTests/ChangeLog 2014-03-28 06:00:39 UTC (rev 166398)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-03-27 James Craig <jcraig@apple.com>
+
+ Web Inspector: AXI: expose selectedChildNodeIds of list boxes, tree controls, etc., and reconcile UI with childNodeIds
+ https://bugs.webkit.org/show_bug.cgi?id=130827
+
+ Reviewed by Timothy Hatcher.
+
+ Tests selectedChildNodeIds in inspector-protocol: DOM.getAccessibilityPropertiesForNode.
+
+ * inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
+ * inspector-protocol/dom/getAccessibilityPropertiesForNode.html:
+
</ins><span class="cx"> 2014-03-27 Mark Rowe <mrowe@apple.com>
</span><span class="cx">
</span><span class="cx"> <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldomgetAccessibilityPropertiesForNodeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt (166397 => 166398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt 2014-03-28 05:28:39 UTC (rev 166397)
+++ trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt 2014-03-28 06:00:39 UTC (rev 166398)
</span><span class="lines">@@ -4,10 +4,10 @@
</span><span class="cx"> exists: true
</span><span class="cx"> label:
</span><span class="cx"> role:
</span><del>- childNodeIds.length: 19
</del><ins>+ childNodeIds.length: 20
</ins><span class="cx">
</span><span class="cx">
</span><del>-Total elements to be tested: 57.
</del><ins>+Total elements to be tested: 58.
</ins><span class="cx">
</span><span class="cx"> <li role="treeitem" aria-expanded="undefined">expanded</li>
</span><span class="cx"> exists: true
</span><span class="lines">@@ -16,13 +16,14 @@
</span><span class="cx"> childNodeIds.length: 1
</span><span class="cx"> parentNodeId: exists
</span><span class="cx">
</span><del>-<li role="treeitem" aria-expanded="false" id="activedescendant">collapsed</li>
</del><ins>+<li role="treeitem" aria-expanded="false" id="activedescendant" aria-selected="true">collapsed</li>
</ins><span class="cx"> exists: true
</span><span class="cx"> label:
</span><span class="cx"> role: treeitem
</span><span class="cx"> childNodeIds.length: 1
</span><span class="cx"> expanded: false
</span><span class="cx"> parentNodeId: exists
</span><ins>+ selected: true
</ins><span class="cx">
</span><span class="cx"> <li role="treeitem" aria-expanded="true">expanded</li>
</span><span class="cx"> exists: true
</span><span class="lines">@@ -34,7 +35,7 @@
</span><span class="cx">
</span><span class="cx"> <ul role="tree" id="flowedTo1" aria-activedescendant="activedescendant">
</span><span class="cx"> <li role="treeitem" aria-expanded="true">expanded</li>
</span><del>- <li role="treeitem" aria-expanded="false" id="activedescendant">collapsed</li>
</del><ins>+ <li role="treeitem" aria-expanded="false" id="activedescendant" aria-selected="true">collapsed</li>
</ins><span class="cx"> <li role="treeitem" aria-expanded="undefined">expanded</li>
</span><span class="cx"> </ul>
</span><span class="cx"> exists: true
</span><span class="lines">@@ -43,7 +44,21 @@
</span><span class="cx"> activeDescendantNodeId: exists
</span><span class="cx"> childNodeIds.length: 3
</span><span class="cx"> parentNodeId: exists
</span><ins>+ selectedChildNodeIds.length: 1
</ins><span class="cx">
</span><ins>+<div role="listbox" aria-multiselectable="true">
+ <div role="option" aria-selected="true">selected</div>
+ <div role="option" aria-selected="false">not selected</div>
+ <div role="option" aria-selected="true">selected</div>
+</div>
+ exists: true
+ label:
+ role: listbox
+ childNodeIds.length: 3
+ parentNodeId: exists
+ required: false
+ selectedChildNodeIds.length: 2
+
</ins><span class="cx"> <div role="tab" aria-selected="false">not selected</div>
</span><span class="cx"> exists: true
</span><span class="cx"> label:
</span><span class="lines">@@ -91,6 +106,7 @@
</span><span class="cx"> childNodeIds.length: 2
</span><span class="cx"> parentNodeId: exists
</span><span class="cx"> required: false
</span><ins>+ selectedChildNodeIds.length: 1
</ins><span class="cx">
</span><span class="cx"> <input role="combobox" aria-owns="ownedlistbox invalidIdRef" aria-controls="ownedlistbox invalidIdRef">
</span><span class="cx"> exists: true
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldomgetAccessibilityPropertiesForNodehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html (166397 => 166398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html 2014-03-28 05:28:39 UTC (rev 166397)
+++ trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html 2014-03-28 06:00:39 UTC (rev 166398)
</span><span class="lines">@@ -92,9 +92,15 @@
</span><span class="cx"> <div class="ex" role="tab" aria-selected="false">not selected</div>
</span><span class="cx"> </div>
</span><span class="cx">
</span><ins>+<div role="listbox" class="ex" aria-multiselectable="true">
+ <div role="option" aria-selected="true">selected</div>
+ <div role="option" aria-selected="false">not selected</div>
+ <div role="option" aria-selected="true">selected</div>
+</div>
+
</ins><span class="cx"> <ul role="tree" class="ex" id="flowedTo1" aria-activedescendant="activedescendant">
</span><span class="cx"> <li class="ex" role="treeitem" aria-expanded="true">expanded</li>
</span><del>- <li class="ex" role="treeitem" aria-expanded="false" id="activedescendant">collapsed</li>
</del><ins>+ <li class="ex" role="treeitem" aria-expanded="false" id="activedescendant" aria-selected="true">collapsed</li>
</ins><span class="cx"> <li class="ex" role="treeitem" aria-expanded="undefined">expanded</li>
</span><span class="cx"> </ul>
</span><span class="cx">
</span><span class="lines">@@ -175,6 +181,7 @@
</span><span class="cx"> case "controlledNodeIds":
</span><span class="cx"> case "flowedNodeIds":
</span><span class="cx"> case "ownedNodeIds":
</span><ins>+ case "selectedChildNodeIds":
</ins><span class="cx"> if (typeof value === "object" && value.length)
</span><span class="cx"> InspectorTest.log(" " + key + ".length: " + value.length);
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (166397 => 166398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-28 05:28:39 UTC (rev 166397)
+++ trunk/Source/WebCore/ChangeLog 2014-03-28 06:00:39 UTC (rev 166398)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-03-27 James Craig <jcraig@apple.com>
+
+ Web Inspector: AXI: expose selectedChildNodeIds of list boxes, tree controls, etc., and reconcile UI with childNodeIds
+ https://bugs.webkit.org/show_bug.cgi?id=130827
+
+ Reviewed by Timothy Hatcher.
+
+ Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
+
+ Support for selectedChildNodeIds in inspector-protocol: DOM.getAccessibilityPropertiesForNode.
+
+ * inspector/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
+ * inspector/protocol/DOM.json:
+
</ins><span class="cx"> 2014-03-27 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Specify Shadow DOM Pseudo IDs in Media Element Constructors
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (166397 => 166398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2014-03-28 05:28:39 UTC (rev 166397)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2014-03-28 06:00:39 UTC (rev 166398)
</span><span class="lines">@@ -1445,6 +1445,7 @@
</span><span class="cx"> bool required = false;
</span><span class="cx"> String role;
</span><span class="cx"> bool selected = false;
</span><ins>+ RefPtr<Inspector::TypeBuilder::Array<int>> selectedChildNodeIds;
</ins><span class="cx"> bool supportsChecked = false;
</span><span class="cx"> bool supportsExpanded = false;
</span><span class="cx"> bool supportsPressed = false;
</span><span class="lines">@@ -1552,6 +1553,16 @@
</span><span class="cx">
</span><span class="cx"> role = axObject->computedRoleString();
</span><span class="cx"> selected = axObject->isSelected();
</span><ins>+
+ AccessibilityObject::AccessibilityChildrenVector selectedChildren;
+ axObject->selectedChildren(selectedChildren);
+ if (selectedChildren.size()) {
+ selectedChildNodeIds = Inspector::TypeBuilder::Array<int>::create();
+ for (auto& selectedChildObject : selectedChildren) {
+ if (Node* selectedChildNode = selectedChildObject->node())
+ selectedChildNodeIds->addItem(pushNodePathToFrontend(selectedChildNode));
+ }
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1598,6 +1609,8 @@
</span><span class="cx"> value->setRequired(required);
</span><span class="cx"> if (selected)
</span><span class="cx"> value->setSelected(selected);
</span><ins>+ if (selectedChildNodeIds)
+ value->setSelectedChildNodeIds(selectedChildNodeIds);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return value.release();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorprotocolDOMjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/protocol/DOM.json (166397 => 166398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/protocol/DOM.json 2014-03-28 05:28:39 UTC (rev 166397)
+++ trunk/Source/WebCore/inspector/protocol/DOM.json 2014-03-28 06:00:39 UTC (rev 166398)
</span><span class="lines">@@ -81,7 +81,8 @@
</span><span class="cx"> { "name": "readonly", "type": "boolean", "optional": true, "description": "Readonly state of text controls." },
</span><span class="cx"> { "name": "required", "type": "boolean", "optional": true, "description": "Required state of form controls." },
</span><span class="cx"> { "name": "role", "type": "string", "description": "Computed value for first recognized role token, default role per element, or overridden role." },
</span><del>- { "name": "selected", "type": "boolean", "optional": true, "description": "Selected state of certain form controls." }
</del><ins>+ { "name": "selected", "type": "boolean", "optional": true, "description": "Selected state of certain form controls." },
+ { "name": "selectedChildNodeIds", "type": "array", "items": { "$ref": "NodeId" }, "optional": true, "description": "Array of <code>DOMNode</code> ids of any children marked as selected." }
</ins><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (166397 => 166398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-03-28 05:28:39 UTC (rev 166397)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-03-28 06:00:39 UTC (rev 166398)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-03-27 James Craig <jcraig@apple.com>
+
+ Web Inspector: AXI: expose selectedChildNodeIds of list boxes, tree controls, etc., and reconcile UI with childNodeIds
+ https://bugs.webkit.org/show_bug.cgi?id=130827
+
+ Reviewed by Timothy Hatcher.
+
+ UI updates for "Selected Item(s)" and "Child(ren)" rows in accessibility node inspector.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Models/DOMNode.js:
+ * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
+
</ins><span class="cx"> 2014-03-27 Antoine Quint <graouts@webkit.org>
</span><span class="cx">
</span><span class="cx"> Web Inspector: clearing the console log doesn't update the activity viewer
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (166397 => 166398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2014-03-28 05:28:39 UTC (rev 166397)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2014-03-28 06:00:39 UTC (rev 166398)
</span><span class="lines">@@ -362,6 +362,8 @@
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " S e c u r e " ] = " S e c u r e " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " S e c u r i t y I s s u e " ] = " S e c u r i t y I s s u e " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " S e l e c t e d " ] = " S e l e c t e d " ;
</span><ins>+ l o c a l i z e d S t r i n g s [ " S e l e c t e d I t e m " ] = " S e l e c t e d I t e m " ;
+ l o c a l i z e d S t r i n g s [ " S e l e c t e d I t e m s " ] = " S e l e c t e d I t e m s " ;
</ins><span class="cx"> l o c a l i z e d S t r i n g s [ " S e l f " ] = " S e l f " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " S e l f T i m e " ] = " S e l f T i m e " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " S e m a n t i c I s s u e " ] = " S e m a n t i c I s s u e " ;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsDOMNodejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js (166397 => 166398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js 2014-03-28 05:28:39 UTC (rev 166397)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js 2014-03-28 06:00:39 UTC (rev 166398)
</span><span class="lines">@@ -476,7 +476,8 @@
</span><span class="cx"> readonly: accessibilityProperties.readonly,
</span><span class="cx"> required: accessibilityProperties.required,
</span><span class="cx"> role: accessibilityProperties.role,
</span><del>- selected: accessibilityProperties.selected
</del><ins>+ selected: accessibilityProperties.selected,
+ selectedChildNodeIds: accessibilityProperties.selectedChildNodeIds
</ins><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMNodeDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js (166397 => 166398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2014-03-28 05:28:39 UTC (rev 166397)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2014-03-28 06:00:39 UTC (rev 166398)
</span><span class="lines">@@ -76,6 +76,7 @@
</span><span class="cx"> this._accessibilityNodeRequiredRow = new WebInspector.DetailsSectionSimpleRow(WebInspector.UIString("Required"));
</span><span class="cx"> this._accessibilityNodeRoleRow = new WebInspector.DetailsSectionSimpleRow(WebInspector.UIString("Role"));
</span><span class="cx"> this._accessibilityNodeSelectedRow = new WebInspector.DetailsSectionSimpleRow(WebInspector.UIString("Selected"));
</span><ins>+ this._accessibilityNodeSelectedChildrenRow = new WebInspector.DetailsSectionSimpleRow(WebInspector.UIString("Selected Items"));
</ins><span class="cx">
</span><span class="cx"> this._accessibilityGroup = new WebInspector.DetailsSectionGroup([this._accessibilityEmptyRow]);
</span><span class="cx"> var accessibilitySection = new WebInspector.DetailsSection("dom-node-accessibility", WebInspector.UIString("Accessibility"), [this._accessibilityGroup]);
</span><span class="lines">@@ -380,6 +381,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var selected = booleanValueToLocalizedStringIfTrue("selected");
</span><ins>+ var selectedChildNodeLinkList = linkListForNodeIds(accessibilityProperties.selectedChildNodeIds);
</ins><span class="cx">
</span><span class="cx"> // Assign all the properties to their respective views.
</span><span class="cx"> this._accessibilityNodeActiveDescendantRow.value = activeDescendantLink || "";
</span><span class="lines">@@ -401,6 +403,11 @@
</span><span class="cx"> this._accessibilityNodeRoleRow.value = role;
</span><span class="cx"> this._accessibilityNodeSelectedRow.value = selected;
</span><span class="cx">
</span><ins>+ this._accessibilityNodeSelectedChildrenRow.label = WebInspector.UIString("Selected Items");
+ this._accessibilityNodeSelectedChildrenRow.value = selectedChildNodeLinkList || "";
+ if (selectedChildNodeLinkList && accessibilityProperties.selectedChildNodeIds.length === 1)
+ this._accessibilityNodeSelectedChildrenRow.label = WebInspector.UIString("Selected Item");
+
</ins><span class="cx"> // Display order, not alphabetical as above.
</span><span class="cx"> this._accessibilityGroup.rows = [
</span><span class="cx"> // Global properties for all elements.
</span><span class="lines">@@ -408,8 +415,9 @@
</span><span class="cx"> this._accessibilityNodeRoleRow,
</span><span class="cx"> this._accessibilityNodeLabelRow,
</span><span class="cx"> this._accessibilityNodeParentRow,
</span><ins>+ this._accessibilityNodeActiveDescendantRow,
+ this._accessibilityNodeSelectedChildrenRow,
</ins><span class="cx"> this._accessibilityNodeChildrenRow,
</span><del>- this._accessibilityNodeActiveDescendantRow,
</del><span class="cx"> this._accessibilityNodeOwnsRow,
</span><span class="cx"> this._accessibilityNodeControlsRow,
</span><span class="cx"> this._accessibilityNodeFlowsRow,
</span></span></pre></div>
<a id="trunkWebsiteswebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/webkit.org/ChangeLog (166397 => 166398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/webkit.org/ChangeLog 2014-03-28 05:28:39 UTC (rev 166397)
+++ trunk/Websites/webkit.org/ChangeLog 2014-03-28 06:00:39 UTC (rev 166398)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-03-27 James Craig <jcraig@apple.com>
+
+ Web Inspector: AXI: expose selectedChildNodeIds of list boxes, tree controls, etc., and reconcile UI with childNodeIds
+ https://bugs.webkit.org/show_bug.cgi?id=130827
+
+ Reviewed by Timothy Hatcher.
+
+ Updated demo files with attr refresh to show off selected children changing.
+ Long term fix will be http://webkit.org/b/130883
+
+ * blog-files/aria1.0/combobox_with_live_region_status.html:
+
</ins><span class="cx"> 2014-03-25 James Craig <jcraig@apple.com>
</span><span class="cx">
</span><span class="cx"> Blog-files: combobox demo needs aria-expanded support
</span></span></pre></div>
<a id="trunkWebsiteswebkitorgblogfilesaria10combobox_with_live_region_statushtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/webkit.org/blog-files/aria1.0/combobox_with_live_region_status.html (166397 => 166398)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/webkit.org/blog-files/aria1.0/combobox_with_live_region_status.html 2014-03-28 05:28:39 UTC (rev 166397)
+++ trunk/Websites/webkit.org/blog-files/aria1.0/combobox_with_live_region_status.html 2014-03-28 06:00:39 UTC (rev 166398)
</span><span class="lines">@@ -160,6 +160,7 @@
</span><span class="cx"> var clearSelectedOption = function (){
</span><span class="cx"> if (selectedOption) {
</span><span class="cx"> field.removeAttribute('aria-activedescendant');
</span><ins>+ list.removeAttribute('data-selection');
</ins><span class="cx"> selectedOption.removeAttribute('aria-selected');
</span><span class="cx"> }
</span><span class="cx"> selectedOption = null;
</span><span class="lines">@@ -172,6 +173,7 @@
</span><span class="cx"> }
</span><span class="cx"> if (selectedOption) selectedOption.removeAttribute('aria-selected');
</span><span class="cx"> selectedOption = el;
</span><ins>+ list.setAttribute('data-selection', el.id);
</ins><span class="cx"> el.setAttribute('aria-selected', 'true');
</span><span class="cx"> field.setAttribute('aria-activedescendant', el.id);
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>