<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166327] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166327">166327</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2014-03-26 16:36:08 -0700 (Wed, 26 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Change MiniBrowser to hold on to window controllers instead of windows
https://bugs.webkit.org/show_bug.cgi?id=130797
Reviewed by Oliver Hunt.
* MiniBrowser/mac/AppDelegate.h:
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate browserWindowWillClose:]):
(-[BrowserAppDelegate applicationWillTerminate:]):
(-[BrowserAppDelegate frontmostBrowserWindowController]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsMiniBrowsermacAppDelegateh">trunk/Tools/MiniBrowser/mac/AppDelegate.h</a></li>
<li><a href="#trunkToolsMiniBrowsermacAppDelegatem">trunk/Tools/MiniBrowser/mac/AppDelegate.m</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (166326 => 166327)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-03-26 23:35:39 UTC (rev 166326)
+++ trunk/Tools/ChangeLog 2014-03-26 23:36:08 UTC (rev 166327)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-03-26 Anders Carlsson <andersca@apple.com>
+
+ Change MiniBrowser to hold on to window controllers instead of windows
+ https://bugs.webkit.org/show_bug.cgi?id=130797
+
+ Reviewed by Oliver Hunt.
+
+ * MiniBrowser/mac/AppDelegate.h:
+ * MiniBrowser/mac/AppDelegate.m:
+ (-[BrowserAppDelegate init]):
+ (-[BrowserAppDelegate newWindow:]):
+ (-[BrowserAppDelegate browserWindowWillClose:]):
+ (-[BrowserAppDelegate applicationWillTerminate:]):
+ (-[BrowserAppDelegate frontmostBrowserWindowController]):
+
</ins><span class="cx"> 2014-03-26 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r166264.
</span></span></pre></div>
<a id="trunkToolsMiniBrowsermacAppDelegateh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.h (166326 => 166327)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/mac/AppDelegate.h 2014-03-26 23:35:39 UTC (rev 166326)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.h 2014-03-26 23:36:08 UTC (rev 166327)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> @interface BrowserAppDelegate : NSObject <NSApplicationDelegate> {
</span><del>- NSMutableSet *_browserWindows;
</del><ins>+ NSMutableSet *_browserWindowControllers;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (void)browserWindowWillClose:(NSWindow *)window;
</span></span></pre></div>
<a id="trunkToolsMiniBrowsermacAppDelegatem"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.m (166326 => 166327)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/mac/AppDelegate.m 2014-03-26 23:35:39 UTC (rev 166326)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.m 2014-03-26 23:36:08 UTC (rev 166327)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx"> {
</span><span class="cx"> self = [super init];
</span><span class="cx"> if (self) {
</span><del>- _browserWindows = [[NSMutableSet alloc] init];
</del><ins>+ _browserWindowControllers = [[NSMutableSet alloc] init];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return self;
</span><span class="lines">@@ -63,14 +63,14 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> [[controller window] makeKeyAndOrderFront:sender];
</span><del>- [_browserWindows addObject:[controller window]];
</del><ins>+ [_browserWindowControllers addObject:controller];
</ins><span class="cx">
</span><span class="cx"> [controller loadURLString:defaultURL];
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (void)browserWindowWillClose:(NSWindow *)window
</span><span class="cx"> {
</span><del>- [_browserWindows removeObject:window];
</del><ins>+ [_browserWindowControllers removeObject:window.windowController];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (void)applicationDidFinishLaunching:(NSNotification *)aNotification
</span><span class="lines">@@ -84,12 +84,8 @@
</span><span class="cx">
</span><span class="cx"> - (void)applicationWillTerminate:(NSNotification *)notification
</span><span class="cx"> {
</span><del>- for (NSWindow* window in _browserWindows) {
- id delegate = [window delegate];
- assert([delegate isKindOfClass:[BrowserWindowController class]]);
- BrowserWindowController *controller = (BrowserWindowController *)delegate;
</del><ins>+ for (BrowserWindowController* controller in _browserWindowControllers)
</ins><span class="cx"> [controller applicationTerminating];
</span><del>- }
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (BrowserWindowController *)frontmostBrowserWindowController
</span><span class="lines">@@ -101,11 +97,11 @@
</span><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> BrowserWindowController *controller = (BrowserWindowController *)delegate;
</span><del>- assert([_browserWindows containsObject:[controller window]]);
</del><ins>+ assert([_browserWindowControllers containsObject:controller]);
</ins><span class="cx"> return controller;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return 0;
</del><ins>+ return nil;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (IBAction)openDocument:(id)sender
</span></span></pre>
</div>
</div>
</body>
</html>