<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166243] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166243">166243</a></dd>
<dt>Author</dt> <dd>oliver@apple.com</dd>
<dt>Date</dt> <dd>2014-03-25 13:06:07 -0700 (Tue, 25 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>AST incorrectly conflates readable and writable locations
https://bugs.webkit.org/show_bug.cgi?id=130734
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
We need to distinguish between "locations" that are valid for reading
and writing, vs those that may only be written.
* bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
* parser/Nodes.h:
(JSC::ExpressionNode::isAssignmentLocation):
LayoutTests:
More tests
* js/parser-syntax-check-expected.txt:
* js/script-tests/parser-syntax-check.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsjsparsersyntaxcheckexpectedtxt">trunk/LayoutTests/js/parser-syntax-check-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsscripttestsparsersyntaxcheckjs">trunk/LayoutTests/js/script-tests/parser-syntax-check.js</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecompilerNodesCodegencpp">trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserNodesh">trunk/Source/JavaScriptCore/parser/Nodes.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (166242 => 166243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-03-25 19:48:15 UTC (rev 166242)
+++ trunk/LayoutTests/ChangeLog 2014-03-25 20:06:07 UTC (rev 166243)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-03-25 Oliver Hunt <oliver@apple.com>
+
+ AST incorrectly conflates readable and writable locations
+ https://bugs.webkit.org/show_bug.cgi?id=130734
+
+ Reviewed by Filip Pizlo.
+
+ More tests
+
+ * js/parser-syntax-check-expected.txt:
+ * js/script-tests/parser-syntax-check.js:
+
</ins><span class="cx"> 2014-03-24 Oliver Hunt <oliver@apple.com>
</span><span class="cx">
</span><span class="cx"> ASSERTION FAILED in Parser: dst != localReg
</span></span></pre></div>
<a id="trunkLayoutTestsjsparsersyntaxcheckexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/parser-syntax-check-expected.txt (166242 => 166243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/parser-syntax-check-expected.txt 2014-03-25 19:48:15 UTC (rev 166242)
+++ trunk/LayoutTests/js/parser-syntax-check-expected.txt 2014-03-25 20:06:07 UTC (rev 166243)
</span><span class="lines">@@ -738,6 +738,22 @@
</span><span class="cx"> PASS Valid: "function f() { var [x]=1 }"
</span><span class="cx"> PASS Valid: "({[x]: 1})"
</span><span class="cx"> PASS Valid: "function f() { ({[x]: 1}) }"
</span><ins>+PASS Valid: "delete ({a}=1)"
+PASS Valid: "function f() { delete ({a}=1) }"
+PASS Valid: "delete ({a:a}=1)"
+PASS Valid: "function f() { delete ({a:a}=1) }"
+PASS Valid: "({a}=1)()"
+PASS Valid: "function f() { ({a}=1)() }"
+PASS Valid: "({a:a}=1)()"
+PASS Valid: "function f() { ({a:a}=1)() }"
+PASS Valid: "({a}=1)=1"
+PASS Valid: "function f() { ({a}=1)=1 }"
+PASS Valid: "({a:a}=1)=1"
+PASS Valid: "function f() { ({a:a}=1)=1 }"
+PASS Valid: "({a}=1=1)"
+PASS Valid: "function f() { ({a}=1=1) }"
+PASS Valid: "({a:a}=1=1)"
+PASS Valid: "function f() { ({a:a}=1=1) }"
</ins><span class="cx"> PASS Invalid: "({get [x](){}})"
</span><span class="cx"> PASS Invalid: "function f() { ({get [x](){}}) }"
</span><span class="cx"> PASS Invalid: "({set [x](){}})"
</span></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsparsersyntaxcheckjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/script-tests/parser-syntax-check.js (166242 => 166243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/parser-syntax-check.js 2014-03-25 19:48:15 UTC (rev 166242)
+++ trunk/LayoutTests/js/script-tests/parser-syntax-check.js 2014-03-25 20:06:07 UTC (rev 166243)
</span><span class="lines">@@ -453,6 +453,14 @@
</span><span class="cx"> valid("[x]=1")
</span><span class="cx"> valid("var [x]=1")
</span><span class="cx"> valid("({[x]: 1})")
</span><ins>+valid("delete ({a}=1)")
+valid("delete ({a:a}=1)")
+valid("({a}=1)()")
+valid("({a:a}=1)()")
+valid("({a}=1)=1")
+valid("({a:a}=1)=1")
+valid("({a}=1=1)")
+valid("({a:a}=1=1)")
</ins><span class="cx"> invalid("({get [x](){}})")
</span><span class="cx"> invalid("({set [x](){}})")
</span><span class="cx"> invalid("({[...x]: 1})")
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (166242 => 166243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-03-25 19:48:15 UTC (rev 166242)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-03-25 20:06:07 UTC (rev 166243)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-03-25 Oliver Hunt <oliver@apple.com>
+
+ AST incorrectly conflates readable and writable locations
+ https://bugs.webkit.org/show_bug.cgi?id=130734
+
+ Reviewed by Filip Pizlo.
+
+ We need to distinguish between "locations" that are valid for reading
+ and writing, vs those that may only be written.
+
+ * bytecompiler/NodesCodegen.cpp:
+ (JSC::ForInNode::emitBytecode):
+ (JSC::ForOfNode::emitBytecode):
+ * parser/Nodes.h:
+ (JSC::ExpressionNode::isAssignmentLocation):
+
</ins><span class="cx"> 2014-03-24 Oliver Hunt <oliver@apple.com>
</span><span class="cx">
</span><span class="cx"> ASSERTION FAILED in Parser: dst != localReg
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecompilerNodesCodegencpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp (166242 => 166243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp 2014-03-25 19:48:15 UTC (rev 166242)
+++ trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp 2014-03-25 20:06:07 UTC (rev 166243)
</span><span class="lines">@@ -1805,7 +1805,7 @@
</span><span class="cx"> {
</span><span class="cx"> LabelScopePtr scope = generator.newLabelScope(LabelScope::Loop);
</span><span class="cx">
</span><del>- if (!m_lexpr->isLocation()) {
</del><ins>+ if (!m_lexpr->isAssignmentLocation()) {
</ins><span class="cx"> emitThrowReferenceError(generator, "Left side of for-in statement is not a reference.");
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -1901,7 +1901,7 @@
</span><span class="cx"> // ------------------------------ ForOfNode ------------------------------------
</span><span class="cx"> void ForOfNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
</span><span class="cx"> {
</span><del>- if (!m_lexpr->isLocation()) {
</del><ins>+ if (!m_lexpr->isAssignmentLocation()) {
</ins><span class="cx"> emitThrowReferenceError(generator, "Left side of for-of statement is not a reference.");
</span><span class="cx"> return;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserNodesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/Nodes.h (166242 => 166243)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/Nodes.h 2014-03-25 19:48:15 UTC (rev 166242)
+++ trunk/Source/JavaScriptCore/parser/Nodes.h 2014-03-25 20:06:07 UTC (rev 166243)
</span><span class="lines">@@ -152,6 +152,7 @@
</span><span class="cx"> virtual bool isPure(BytecodeGenerator&) const { return false; }
</span><span class="cx"> virtual bool isConstant() const { return false; }
</span><span class="cx"> virtual bool isLocation() const { return false; }
</span><ins>+ virtual bool isAssignmentLocation() const { return isLocation(); }
</ins><span class="cx"> virtual bool isResolveNode() const { return false; }
</span><span class="cx"> virtual bool isBracketAccessorNode() const { return false; }
</span><span class="cx"> virtual bool isDotAccessorNode() const { return false; }
</span><span class="lines">@@ -1676,7 +1677,7 @@
</span><span class="cx"> using ParserArenaDeletable::operator new;
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual bool isLocation() const override { return true; }
</del><ins>+ virtual bool isAssignmentLocation() const override { return true; }
</ins><span class="cx"> virtual bool isDeconstructionNode() const override { return true; }
</span><span class="cx"> virtual RegisterID* emitBytecode(BytecodeGenerator&, RegisterID* = 0) override;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>