<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166114] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166114">166114</a></dd>
<dt>Author</dt> <dd>darin@apple.com</dd>
<dt>Date</dt> <dd>2014-03-22 08:16:42 -0700 (Sat, 22 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>ASSERTION FAILED: std::isfinite(num) in WebCore::CSSPrimitiveValue::CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=127361
Source/WebCore:
Huge numbers represented by the 'INF' value can not be used
in CSS rules, so they make the assert fail. We have to make
sure that the parsed property value is finite, otherwise
the property will be dropped.
Test: fast/css/infinite-floating-value.html
Patch by Martin Hodovan <mhodovan@inf.u-szeged.hu> on 2014-03-22
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createValue):
LayoutTests:
Added test shows that CSS rules containing huge numbers
(which are transformed into 'INF' values after parsing)
are dropped.
Patch by Martin Hodovan <mhodovan@inf.u-szeged.hu> on 2014-03-22
Reviewed by Darin Adler.
* fast/css/infinite-floating-value-expected.txt: Added.
* fast/css/infinite-floating-value.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSValuePoolcpp">trunk/Source/WebCore/css/CSSValuePool.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssinfinitefloatingvalueexpectedtxt">trunk/LayoutTests/fast/css/infinite-floating-value-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssinfinitefloatingvaluehtml">trunk/LayoutTests/fast/css/infinite-floating-value.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (166113 => 166114)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-03-22 14:31:08 UTC (rev 166113)
+++ trunk/LayoutTests/ChangeLog 2014-03-22 15:16:42 UTC (rev 166114)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-03-22 Martin Hodovan <mhodovan@inf.u-szeged.hu>
+
+ ASSERTION FAILED: std::isfinite(num) in WebCore::CSSPrimitiveValue::CSSPrimitiveValue
+ https://bugs.webkit.org/show_bug.cgi?id=127361
+
+ Added test shows that CSS rules containing huge numbers
+ (which are transformed into 'INF' values after parsing)
+ are dropped.
+
+ Reviewed by Darin Adler.
+
+ * fast/css/infinite-floating-value-expected.txt: Added.
+ * fast/css/infinite-floating-value.html: Added.
+
</ins><span class="cx"> 2014-03-21 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> Crash when BytecodeGenerator::emitJump calls Label::bind on null pointer.
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssinfinitefloatingvalueexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/infinite-floating-value-expected.txt (0 => 166114)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/infinite-floating-value-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/infinite-floating-value-expected.txt 2014-03-22 15:16:42 UTC (rev 166114)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+This test passes if it does not crash.
+
+fontsize aaa
+fontsize bbb
+line-height
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/css/infinite-floating-value-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<a id="trunkLayoutTestsfastcssinfinitefloatingvaluehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/infinite-floating-value.html (0 => 166114)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/infinite-floating-value.html (rev 0)
+++ trunk/LayoutTests/fast/css/infinite-floating-value.html 2014-03-22 15:16:42 UTC (rev 166114)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+<html>
+ <head>
+ <script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+ </script>
+ </head>
+ <body>
+ <p>This test passes if it does not crash.</p>
+ <div style="font-size: 900000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000%;">fontsize aaa</div>
+
+ <svg xmlns="http://www.w3.org/2000/svg">
+ <text y="150" font-size="8E+2%">fontsize bbb</text>
+ </svg>
+
+ <span style="line-height:900000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000%">
+ line-height
+ </span>
+ </body>
+</html>
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/css/infinite-floating-value.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (166113 => 166114)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-22 14:31:08 UTC (rev 166113)
+++ trunk/Source/WebCore/ChangeLog 2014-03-22 15:16:42 UTC (rev 166114)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-03-22 Martin Hodovan <mhodovan@inf.u-szeged.hu>
+
+ ASSERTION FAILED: std::isfinite(num) in WebCore::CSSPrimitiveValue::CSSPrimitiveValue
+ https://bugs.webkit.org/show_bug.cgi?id=127361
+
+ Huge numbers represented by the 'INF' value can not be used
+ in CSS rules, so they make the assert fail. We have to make
+ sure that the parsed property value is finite, otherwise
+ the property will be dropped.
+
+ Test: fast/css/infinite-floating-value.html
+
+ * css/CSSValuePool.cpp:
+ (WebCore::CSSValuePool::createValue):
+
</ins><span class="cx"> 2014-03-21 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove redundant friending from class Image.
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSValuePoolcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSValuePool.cpp (166113 => 166114)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSValuePool.cpp 2014-03-22 14:31:08 UTC (rev 166113)
+++ trunk/Source/WebCore/css/CSSValuePool.cpp 2014-03-22 15:16:42 UTC (rev 166114)
</span><span class="lines">@@ -89,6 +89,9 @@
</span><span class="cx">
</span><span class="cx"> PassRef<CSSPrimitiveValue> CSSValuePool::createValue(double value, CSSPrimitiveValue::UnitTypes type)
</span><span class="cx"> {
</span><ins>+ if (std::isinf(value))
+ return createIdentifierValue(CSSValueID::CSSValueInvalid);
+
</ins><span class="cx"> if (value < 0 || value > maximumCacheableIntegerValue)
</span><span class="cx"> return CSSPrimitiveValue::create(value, type);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>