<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166124] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166124">166124</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2014-03-22 13:02:26 -0700 (Sat, 22 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Some #include hygiene in Node/Element etc
https://bugs.webkit.org/show_bug.cgi?id=130642
Reviewed by Geoffrey Garen.
Clean up various #includes.
* accessibility/AccessibilityObject.h:
* bindings/js/WebCoreTypedArrayController.h:
* dom/Element.h:
* dom/EventListenerMap.h:
* dom/EventTarget.h:
* dom/Node.h:
* rendering/RenderObject.h:
* rendering/svg/RenderSVGRoot.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjecth">trunk/Source/WebCore/accessibility/AccessibilityObject.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsWebCoreTypedArrayControllerh">trunk/Source/WebCore/bindings/js/WebCoreTypedArrayController.h</a></li>
<li><a href="#trunkSourceWebCoredomElementh">trunk/Source/WebCore/dom/Element.h</a></li>
<li><a href="#trunkSourceWebCoredomEventListenerMaph">trunk/Source/WebCore/dom/EventListenerMap.h</a></li>
<li><a href="#trunkSourceWebCoredomEventTargeth">trunk/Source/WebCore/dom/EventTarget.h</a></li>
<li><a href="#trunkSourceWebCoredomNodeh">trunk/Source/WebCore/dom/Node.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjecth">trunk/Source/WebCore/rendering/RenderObject.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGRooth">trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (166123 => 166124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/ChangeLog 2014-03-22 20:02:26 UTC (rev 166124)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2014-03-22 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ Some #include hygiene in Node/Element etc
+ https://bugs.webkit.org/show_bug.cgi?id=130642
+
+ Reviewed by Geoffrey Garen.
+
+ Clean up various #includes.
+
+ * accessibility/AccessibilityObject.h:
+ * bindings/js/WebCoreTypedArrayController.h:
+ * dom/Element.h:
+ * dom/EventListenerMap.h:
+ * dom/EventTarget.h:
+ * dom/Node.h:
+ * rendering/RenderObject.h:
+ * rendering/svg/RenderSVGRoot.h:
+
+2014-03-22 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> FloatRect.h on iOS should not suck in a system header
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=130641
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (166123 => 166124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.h 2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h 2014-03-22 20:02:26 UTC (rev 166124)
</span><span class="lines">@@ -86,7 +86,6 @@
</span><span class="cx"> class RenderObject;
</span><span class="cx"> class RenderListItem;
</span><span class="cx"> class ScrollableArea;
</span><del>-class VisibleSelection;
</del><span class="cx"> class Widget;
</span><span class="cx">
</span><span class="cx"> typedef unsigned AXID;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsWebCoreTypedArrayControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/WebCoreTypedArrayController.h (166123 => 166124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/WebCoreTypedArrayController.h 2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/bindings/js/WebCoreTypedArrayController.h 2014-03-22 20:02:26 UTC (rev 166124)
</span><span class="lines">@@ -26,10 +26,13 @@
</span><span class="cx"> #ifndef WebCoreTypedArrayController_h
</span><span class="cx"> #define WebCoreTypedArrayController_h
</span><span class="cx">
</span><del>-#include <heap/Weak.h>
</del><span class="cx"> #include <runtime/JSGlobalObject.h>
</span><span class="cx"> #include <runtime/TypedArrayController.h>
</span><span class="cx">
</span><ins>+namespace JSC {
+class WeakHandleOwner;
+}
+
</ins><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> class WebCoreTypedArrayController : public JSC::TypedArrayController {
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.h (166123 => 166124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.h 2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/dom/Element.h 2014-03-22 20:02:26 UTC (rev 166124)
</span><span class="lines">@@ -31,6 +31,7 @@
</span><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "RegionOversetState.h"
</span><span class="cx"> #include "ScrollTypes.h"
</span><ins>+#include "SimulatedClickOptions.h"
</ins><span class="cx"> #include "StyleResolveTree.h"
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventListenerMaph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventListenerMap.h (166123 => 166124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventListenerMap.h 2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/dom/EventListenerMap.h 2014-03-22 20:02:26 UTC (rev 166124)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx"> #include "RegisteredEventListener.h"
</span><span class="cx"> #include <memory>
</span><span class="cx"> #include <wtf/Forward.h>
</span><del>-#include <wtf/text/AtomicStringHash.h>
</del><ins>+#include <wtf/text/AtomicString.h>
</ins><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventTargeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventTarget.h (166123 => 166124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventTarget.h 2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/dom/EventTarget.h 2014-03-22 20:02:26 UTC (rev 166124)
</span><span class="lines">@@ -38,10 +38,13 @@
</span><span class="cx"> #include <memory>
</span><span class="cx"> #include <wtf/Forward.h>
</span><span class="cx"> #include <wtf/HashMap.h>
</span><del>-#include <wtf/text/AtomicStringHash.h>
</del><span class="cx">
</span><ins>+namespace WTF {
+class AtomicString;
+}
+
</ins><span class="cx"> namespace WebCore {
</span><del>-
</del><ins>+
</ins><span class="cx"> class AudioNode;
</span><span class="cx"> class AudioContext;
</span><span class="cx"> class AudioTrackList;
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.h (166123 => 166124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.h 2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/dom/Node.h 2014-03-22 20:02:26 UTC (rev 166124)
</span><span class="lines">@@ -32,18 +32,20 @@
</span><span class="cx"> #include "MutationObserver.h"
</span><span class="cx"> #include "RenderStyleConstants.h"
</span><span class="cx"> #include "ScriptWrappable.h"
</span><del>-#include "SimulatedClickOptions.h"
</del><span class="cx"> #include "TreeScope.h"
</span><span class="cx"> #include "TreeShared.h"
</span><span class="cx"> #include <wtf/Forward.h>
</span><span class="cx"> #include <wtf/ListHashSet.h>
</span><del>-#include <wtf/text/AtomicString.h>
</del><span class="cx">
</span><span class="cx"> namespace JSC {
</span><del>- class VM;
- class SlotVisitor;
</del><ins>+class VM;
+class SlotVisitor;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+namespace WTF {
+class AtomicString;
+}
+
</ins><span class="cx"> // This needs to be here because Document.h also depends on it.
</span><span class="cx"> #define DUMP_NODE_STATISTICS 0
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.h (166123 => 166124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.h 2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2014-03-22 20:02:26 UTC (rev 166124)
</span><span class="lines">@@ -62,7 +62,6 @@
</span><span class="cx"> class RenderTheme;
</span><span class="cx"> class TransformState;
</span><span class="cx"> class VisiblePosition;
</span><del>-class RenderSVGResourceContainer;
</del><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> class SelectionRect;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGRooth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h (166123 => 166124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h 2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h 2014-03-22 20:02:26 UTC (rev 166124)
</span><span class="lines">@@ -31,6 +31,7 @@
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> class AffineTransform;
</span><ins>+class RenderSVGResourceContainer;
</ins><span class="cx"> class SVGSVGElement;
</span><span class="cx">
</span><span class="cx"> class RenderSVGRoot final : public RenderReplaced {
</span></span></pre>
</div>
</div>
</body>
</html>