<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166121] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166121">166121</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-03-22 11:56:56 -0700 (Sat, 22 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Cut down on JSC profiler includes in WebCore & co.
<https://webkit.org/b/130637>
Most of WebKit was pulling in JSC's profiler headers via VM.h.
Reviewed by Darin Adler.
* dfg/DFGDisassembler.cpp:
* dfg/DFGDisassembler.h:
* dfg/DFGJITFinalizer.cpp:
* jsc.cpp:
* runtime/VM.cpp:
* runtime/VM.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGDisassemblercpp">trunk/Source/JavaScriptCore/dfg/DFGDisassembler.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGDisassemblerh">trunk/Source/JavaScriptCore/dfg/DFGDisassembler.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGJITFinalizercpp">trunk/Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorejsccpp">trunk/Source/JavaScriptCore/jsc.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeVMcpp">trunk/Source/JavaScriptCore/runtime/VM.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeVMh">trunk/Source/JavaScriptCore/runtime/VM.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreForwardingHeadersprofilerProfilerDatabaseh">trunk/Source/WebCore/ForwardingHeaders/profiler/ProfilerDatabase.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (166120 => 166121)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-03-22 18:52:22 UTC (rev 166120)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-03-22 18:56:56 UTC (rev 166121)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-03-22 Andreas Kling <akling@apple.com>
+
+ Cut down on JSC profiler includes in WebCore & co.
+ <https://webkit.org/b/130637>
+
+ Most of WebKit was pulling in JSC's profiler headers via VM.h.
+
+ Reviewed by Darin Adler.
+
+ * dfg/DFGDisassembler.cpp:
+ * dfg/DFGDisassembler.h:
+ * dfg/DFGJITFinalizer.cpp:
+ * jsc.cpp:
+ * runtime/VM.cpp:
+ * runtime/VM.h:
+
</ins><span class="cx"> 2014-03-22 Landry Breuil <landry@openbsd.org>
</span><span class="cx">
</span><span class="cx"> Use pthread_stackseg_np() to find the stack bounds on OpenBSD.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGDisassemblercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGDisassembler.cpp (166120 => 166121)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGDisassembler.cpp 2014-03-22 18:52:22 UTC (rev 166120)
+++ trunk/Source/JavaScriptCore/dfg/DFGDisassembler.cpp 2014-03-22 18:56:56 UTC (rev 166121)
</span><span class="lines">@@ -32,6 +32,7 @@
</span><span class="cx"> #include "DFGGraph.h"
</span><span class="cx"> #include "DFGJITCode.h"
</span><span class="cx"> #include "JSCInlines.h"
</span><ins>+#include "ProfilerDatabase.h"
</ins><span class="cx"> #include <wtf/StdLibExtras.h>
</span><span class="cx">
</span><span class="cx"> namespace JSC { namespace DFG {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGDisassemblerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGDisassembler.h (166120 => 166121)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGDisassembler.h 2014-03-22 18:52:22 UTC (rev 166120)
+++ trunk/Source/JavaScriptCore/dfg/DFGDisassembler.h 2014-03-22 18:56:56 UTC (rev 166121)
</span><span class="lines">@@ -32,6 +32,7 @@
</span><span class="cx"> #include "DumpContext.h"
</span><span class="cx"> #include "LinkBuffer.h"
</span><span class="cx"> #include "MacroAssembler.h"
</span><ins>+#include "ProfilerDatabase.h"
</ins><span class="cx"> #include <wtf/HashMap.h>
</span><span class="cx"> #include <wtf/StringPrintStream.h>
</span><span class="cx"> #include <wtf/Vector.h>
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGJITFinalizercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp (166120 => 166121)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp 2014-03-22 18:52:22 UTC (rev 166120)
+++ trunk/Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp 2014-03-22 18:56:56 UTC (rev 166121)
</span><span class="lines">@@ -32,6 +32,7 @@
</span><span class="cx"> #include "DFGCommon.h"
</span><span class="cx"> #include "DFGPlan.h"
</span><span class="cx"> #include "JSCInlines.h"
</span><ins>+#include "ProfilerDatabase.h"
</ins><span class="cx">
</span><span class="cx"> namespace JSC { namespace DFG {
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejsccpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jsc.cpp (166120 => 166121)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jsc.cpp 2014-03-22 18:52:22 UTC (rev 166120)
+++ trunk/Source/JavaScriptCore/jsc.cpp 2014-03-22 18:56:56 UTC (rev 166121)
</span><span class="lines">@@ -37,6 +37,7 @@
</span><span class="cx"> #include "JSLock.h"
</span><span class="cx"> #include "JSProxy.h"
</span><span class="cx"> #include "JSString.h"
</span><ins>+#include "ProfilerDatabase.h"
</ins><span class="cx"> #include "SamplingTool.h"
</span><span class="cx"> #include "StackVisitor.h"
</span><span class="cx"> #include "StructureRareDataInlines.h"
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeVMcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/VM.cpp (166120 => 166121)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/VM.cpp 2014-03-22 18:52:22 UTC (rev 166120)
+++ trunk/Source/JavaScriptCore/runtime/VM.cpp 2014-03-22 18:56:56 UTC (rev 166121)
</span><span class="lines">@@ -71,6 +71,7 @@
</span><span class="cx"> #include "Nodes.h"
</span><span class="cx"> #include "Parser.h"
</span><span class="cx"> #include "ParserArena.h"
</span><ins>+#include "ProfilerDatabase.h"
</ins><span class="cx"> #include "PropertyMapHashTable.h"
</span><span class="cx"> #include "RegExpCache.h"
</span><span class="cx"> #include "RegExpObject.h"
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeVMh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/VM.h (166120 => 166121)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/VM.h 2014-03-22 18:52:22 UTC (rev 166120)
+++ trunk/Source/JavaScriptCore/runtime/VM.h 2014-03-22 18:56:56 UTC (rev 166121)
</span><span class="lines">@@ -40,7 +40,6 @@
</span><span class="cx"> #include "LLIntData.h"
</span><span class="cx"> #include "MacroAssemblerCodeRef.h"
</span><span class="cx"> #include "NumericStrings.h"
</span><del>-#include "ProfilerDatabase.h"
</del><span class="cx"> #include "PrivateName.h"
</span><span class="cx"> #include "PrototypeMap.h"
</span><span class="cx"> #include "SmallStrings.h"
</span><span class="lines">@@ -115,6 +114,9 @@
</span><span class="cx"> namespace CommonSlowPaths {
</span><span class="cx"> struct ArityCheckData;
</span><span class="cx"> }
</span><ins>+ namespace Profiler {
+ class Database;
+ }
</ins><span class="cx">
</span><span class="cx"> struct HashTable;
</span><span class="cx"> struct Instruction;
</span></span></pre></div>
<a id="trunkSourceWebCoreForwardingHeadersprofilerProfilerDatabaseh"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/ForwardingHeaders/profiler/ProfilerDatabase.h (0 => 166121)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ForwardingHeaders/profiler/ProfilerDatabase.h (rev 0)
+++ trunk/Source/WebCore/ForwardingHeaders/profiler/ProfilerDatabase.h 2014-03-22 18:56:56 UTC (rev 166121)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+#ifndef WebCore_FWD_ProfilerDatabase_h
+#define WebCore_FWD_ProfilerDatabase_h
+#include <JavaScriptCore/ProfilerDatabase.h>
+#endif
+
</ins></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (166120 => 166121)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-03-22 18:52:22 UTC (rev 166120)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-03-22 18:56:56 UTC (rev 166121)
</span><span class="lines">@@ -147,6 +147,7 @@
</span><span class="cx"> #include <WebCore/VisibleUnits.h>
</span><span class="cx"> #include <WebCore/markup.h>
</span><span class="cx"> #include <bindings/ScriptValue.h>
</span><ins>+#include <profiler/ProfilerDatabase.h>
</ins><span class="cx"> #include <runtime/JSCInlines.h>
</span><span class="cx"> #include <runtime/JSCJSValue.h>
</span><span class="cx"> #include <runtime/JSLock.h>
</span></span></pre>
</div>
</div>
</body>
</html>