<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166062] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166062">166062</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-03-21 07:49:34 -0700 (Fri, 21 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[webkitpy] Fix has_valid_reviewer()
https://bugs.webkit.org/show_bug.cgi?id=130589
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-03-21
Reviewed by Csaba Osztrogonác.
* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry.has_valid_reviewer):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_has_valid_reviewer):
* Scripts/webkitpy/common/config/committers.py:
(CommitterList._reviewer_only):
(CommitterList.committer_by_name):
(CommitterList.reviewer_by_email):
(CommitterList):
(CommitterList.reviewer_by_name):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpycommoncheckoutchangelogpy">trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py</a></li>
<li><a href="#trunkToolsScriptswebkitpycommoncheckoutchangelog_unittestpy">trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py</a></li>
<li><a href="#trunkToolsScriptswebkitpycommonconfigcommitterspy">trunk/Tools/Scripts/webkitpy/common/config/committers.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (166061 => 166062)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-03-21 14:44:10 UTC (rev 166061)
+++ trunk/Tools/ChangeLog 2014-03-21 14:49:34 UTC (rev 166062)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-03-21 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
+
+ [webkitpy] Fix has_valid_reviewer()
+ https://bugs.webkit.org/show_bug.cgi?id=130589
+
+ Reviewed by Csaba Osztrogonác.
+
+ * Scripts/webkitpy/common/checkout/changelog.py:
+ (ChangeLogEntry.has_valid_reviewer):
+ * Scripts/webkitpy/common/checkout/changelog_unittest.py:
+ (test_has_valid_reviewer):
+ * Scripts/webkitpy/common/config/committers.py:
+ (CommitterList._reviewer_only):
+ (CommitterList.committer_by_name):
+ (CommitterList.reviewer_by_email):
+ (CommitterList):
+ (CommitterList.reviewer_by_name):
+
</ins><span class="cx"> 2014-03-21 Jozsef Berta <jberta.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> Add cache support for jhbuild
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpycommoncheckoutchangelogpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py (166061 => 166062)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2014-03-21 14:44:10 UTC (rev 166061)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2014-03-21 14:49:34 UTC (rev 166062)
</span><span class="lines">@@ -257,7 +257,7 @@
</span><span class="cx"> def has_valid_reviewer(self):
</span><span class="cx"> if self._reviewers_text_list:
</span><span class="cx"> for reviewer in self._reviewers_text_list:
</span><del>- reviewer = self._committer_list.committer_by_name(reviewer)
</del><ins>+ reviewer = self._committer_list.reviewer_by_name(reviewer)
</ins><span class="cx"> if reviewer:
</span><span class="cx"> return True
</span><span class="cx"> return bool(re.search("unreviewed", self._contents, re.IGNORECASE))
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpycommoncheckoutchangelog_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py (166061 => 166062)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2014-03-21 14:44:10 UTC (rev 166061)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2014-03-21 14:49:34 UTC (rev 166062)
</span><span class="lines">@@ -471,6 +471,7 @@
</span><span class="cx"> self._assert_has_valid_reviewer("Rubber stamped by Eric.", False)
</span><span class="cx"> self._assert_has_valid_reviewer("Rubber stamped by Eric Seidel.", True)
</span><span class="cx"> self._assert_has_valid_reviewer("Unreviewed build fix.", True)
</span><ins>+ self._assert_has_valid_reviewer("Reviewed by Gabor Rapcsanyi.", False)
</ins><span class="cx">
</span><span class="cx"> def test_is_touched_files_text_clean(self):
</span><span class="cx"> tests = [
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpycommonconfigcommitterspy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (166061 => 166062)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2014-03-21 14:44:10 UTC (rev 166061)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2014-03-21 14:49:34 UTC (rev 166062)
</span><span class="lines">@@ -184,9 +184,6 @@
</span><span class="cx"> return None
</span><span class="cx"> return record
</span><span class="cx">
</span><del>- def committer_by_name(self, name):
- return self._committer_only(self.contributor_by_name(name))
-
</del><span class="cx"> def contributor_by_irc_nickname(self, irc_nickname):
</span><span class="cx"> for contributor in self.contributors():
</span><span class="cx"> # FIXME: This should do case-insensitive comparison or assert that all IRC nicknames are in lowercase
</span><span class="lines">@@ -269,5 +266,11 @@
</span><span class="cx"> def committer_by_email(self, email):
</span><span class="cx"> return self._committer_only(self.contributor_by_email(email))
</span><span class="cx">
</span><ins>+ def committer_by_name(self, name):
+ return self._committer_only(self.contributor_by_name(name))
+
</ins><span class="cx"> def reviewer_by_email(self, email):
</span><span class="cx"> return self._reviewer_only(self.contributor_by_email(email))
</span><ins>+
+ def reviewer_by_name(self, email):
+ return self._reviewer_only(self.contributor_by_name(email))
</ins></span></pre>
</div>
</div>
</body>
</html>