<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165969] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165969">165969</a></dd>
<dt>Author</dt> <dd>stavila@adobe.com</dd>
<dt>Date</dt> <dd>2014-03-20 10:28:53 -0700 (Thu, 20 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Regions] Remove "visibility:hidden" from overflow-scrollable* tests
https://bugs.webkit.org/show_bug.cgi?id=130510
Reviewed by Andrei Bucur.
The visibility hidden option was needed to prevent these tests from failing before the
visual overflow was properly implemented (bug 118665). It is now no longer required.
* fast/regions/overflow-scrollable-rel-pos-fragment-expected.html:
* fast/regions/overflow-scrollable-rel-pos-fragment.html:
* fast/regions/overflow-scrollable-rotated-fragment-expected.html:
* fast/regions/overflow-scrollable-rotated-fragment.html:
* fast/regions/overflow-scrollable-unsplittable-fragment-expected.html:
* fast/regions/overflow-scrollable-unsplittable-fragment.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastregionsoverflowscrollablerelposfragmentexpectedhtml">trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastregionsoverflowscrollablerelposfragmenthtml">trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment.html</a></li>
<li><a href="#trunkLayoutTestsfastregionsoverflowscrollablerotatedfragmentexpectedhtml">trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastregionsoverflowscrollablerotatedfragmenthtml">trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment.html</a></li>
<li><a href="#trunkLayoutTestsfastregionsoverflowscrollableunsplittablefragmentexpectedhtml">trunk/LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastregionsoverflowscrollableunsplittablefragmenthtml">trunk/LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (165968 => 165969)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-03-20 17:20:58 UTC (rev 165968)
+++ trunk/LayoutTests/ChangeLog 2014-03-20 17:28:53 UTC (rev 165969)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-03-20 Radu Stavila <stavila@adobe.com>
+
+ [CSS Regions] Remove "visibility:hidden" from overflow-scrollable* tests
+ https://bugs.webkit.org/show_bug.cgi?id=130510
+
+ Reviewed by Andrei Bucur.
+
+ The visibility hidden option was needed to prevent these tests from failing before the
+ visual overflow was properly implemented (bug 118665). It is now no longer required.
+
+ * fast/regions/overflow-scrollable-rel-pos-fragment-expected.html:
+ * fast/regions/overflow-scrollable-rel-pos-fragment.html:
+ * fast/regions/overflow-scrollable-rotated-fragment-expected.html:
+ * fast/regions/overflow-scrollable-rotated-fragment.html:
+ * fast/regions/overflow-scrollable-unsplittable-fragment-expected.html:
+ * fast/regions/overflow-scrollable-unsplittable-fragment.html:
+
</ins><span class="cx"> 2014-03-20 Lorenzo Tilve <ltilve@igalia.com>
</span><span class="cx">
</span><span class="cx"> "input" event is not fired when changing a select element's value
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsoverflowscrollablerelposfragmentexpectedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment-expected.html (165968 => 165969)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment-expected.html 2014-03-20 17:20:58 UTC (rev 165968)
+++ trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment-expected.html 2014-03-20 17:28:53 UTC (rev 165969)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx"> <p class="no_overflow">Linetext1</p>
</span><span class="cx"> <p class="no_overflow">Linetext2</p>
</span><span class="cx"> <p class="no_overflow">Linetext3</p>
</span><del>- <p class="no_overflow" style="visibility: hidden;">Linetext4</p>
</del><ins>+ <p class="no_overflow">Linetext4</p>
</ins><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx"> <div class="container">
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsoverflowscrollablerelposfragmenthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment.html (165968 => 165969)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment.html 2014-03-20 17:20:58 UTC (rev 165968)
+++ trunk/LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment.html 2014-03-20 17:28:53 UTC (rev 165969)
</span><span class="lines">@@ -26,7 +26,7 @@
</span><span class="cx"> <p class="no_overflow">Linetext1</p>
</span><span class="cx"> <p class="no_overflow">Linetext2</p>
</span><span class="cx"> <p class="no_overflow">Linetext3</p>
</span><del>- <p class="no_overflow" style="-webkit-region-break-after: always; visibility: hidden;">Linetext4</p>
</del><ins>+ <p class="no_overflow" style="-webkit-region-break-after: always;">Linetext4</p>
</ins><span class="cx"> <p class="no_overflow">LineText5</p>
</span><span class="cx"> <p class="no_overflow">Linetext6</p>
</span><span class="cx"> <p class="no_overflow">Linetext7</p>
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsoverflowscrollablerotatedfragmentexpectedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment-expected.html (165968 => 165969)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment-expected.html 2014-03-20 17:20:58 UTC (rev 165968)
+++ trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment-expected.html 2014-03-20 17:28:53 UTC (rev 165969)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx"> <p class="no_overflow">Linetext1</p>
</span><span class="cx"> <p class="no_overflow">Linetext2</p>
</span><span class="cx"> <p class="no_overflow">Linetext3</p>
</span><del>- <p class="no_overflow" style="visibility: hidden;">Linetext4</p>
</del><ins>+ <p class="no_overflow">Linetext4</p>
</ins><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx"> <div class="container">
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsoverflowscrollablerotatedfragmenthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment.html (165968 => 165969)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment.html 2014-03-20 17:20:58 UTC (rev 165968)
+++ trunk/LayoutTests/fast/regions/overflow-scrollable-rotated-fragment.html 2014-03-20 17:28:53 UTC (rev 165969)
</span><span class="lines">@@ -26,7 +26,7 @@
</span><span class="cx"> <p class="no_overflow">Linetext1</p>
</span><span class="cx"> <p class="no_overflow">Linetext2</p>
</span><span class="cx"> <p class="no_overflow">Linetext3</p>
</span><del>- <p class="no_overflow" style="-webkit-region-break-after: always; visibility: hidden;">Linetext4</p>
</del><ins>+ <p class="no_overflow" style="-webkit-region-break-after: always;">Linetext4</p>
</ins><span class="cx"> <p class="no_overflow">LineText5</p>
</span><span class="cx"> <p class="no_overflow">Linetext6</p>
</span><span class="cx"> <p class="no_overflow">Linetext7</p>
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsoverflowscrollableunsplittablefragmentexpectedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment-expected.html (165968 => 165969)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment-expected.html 2014-03-20 17:20:58 UTC (rev 165968)
+++ trunk/LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment-expected.html 2014-03-20 17:28:53 UTC (rev 165969)
</span><span class="lines">@@ -18,7 +18,7 @@
</span><span class="cx"> <p>On success, the green region should generate scrollbars.</p>
</span><span class="cx"> <div class="container">
</span><span class="cx"> <div class="region" id="region1">
</span><del>- <div class="no_overflow" style="overflow: scroll; width: 50px; height: 150px; visibility: hidden;"></div>
</del><ins>+ <div class="no_overflow" style="overflow: scroll; width: 50px; height: 150px;"></div>
</ins><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx"> <div class="container">
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsoverflowscrollableunsplittablefragmenthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment.html (165968 => 165969)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment.html 2014-03-20 17:20:58 UTC (rev 165968)
+++ trunk/LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment.html 2014-03-20 17:28:53 UTC (rev 165969)
</span><span class="lines">@@ -21,7 +21,7 @@
</span><span class="cx"> <p>Test that unsplittable boxes generate correct fragment layout overflow.</p>
</span><span class="cx"> <p>On success, the green region should generate scrollbars.</p>
</span><span class="cx"> <div id="content">
</span><del>- <div class="no_overflow" style="overflow: scroll; width: 50px; height: 150px; visibility: hidden;"></div>
</del><ins>+ <div class="no_overflow" style="overflow: scroll; width: 50px; height: 150px;"></div>
</ins><span class="cx"> </div>
</span><span class="cx"> <div class="container">
</span><span class="cx"> <div class="region" id="region1"></div>
</span></span></pre>
</div>
</div>
</body>
</html>