<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[166038] trunk/PerformanceTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/166038">166038</a></dd>
<dt>Author</dt> <dd>zoltan@webkit.org</dd>
<dt>Date</dt> <dd>2014-03-20 21:05:05 -0700 (Thu, 20 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add option for hiding Confidence Interval Delta on the performance tests results page
https://bugs.webkit.org/show_bug.cgi?id=130483
Reviewed by Ryosuke Niwa.
I've found it useful to hide the confidence interval delta from the results table
sometimes, for example on copying data, or for a clearer look. This patch introduces
a new button for it on the local results page.
* resources/results-template.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkPerformanceTestsChangeLog">trunk/PerformanceTests/ChangeLog</a></li>
<li><a href="#trunkPerformanceTestsresourcesresultstemplatehtml">trunk/PerformanceTests/resources/results-template.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkPerformanceTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/ChangeLog (166037 => 166038)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/ChangeLog 2014-03-21 03:47:26 UTC (rev 166037)
+++ trunk/PerformanceTests/ChangeLog 2014-03-21 04:05:05 UTC (rev 166038)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-03-20 Zoltan Horvath <zoltan@webkit.org>
+
+ Add option for hiding Confidence Interval Delta on the performance tests results page
+ https://bugs.webkit.org/show_bug.cgi?id=130483
+
+ Reviewed by Ryosuke Niwa.
+
+ I've found it useful to hide the confidence interval delta from the results table
+ sometimes, for example on copying data, or for a clearer look. This patch introduces
+ a new button for it on the local results page.
+
+ * resources/results-template.html:
+
</ins><span class="cx"> 2014-03-20 Laszlo Vidacs <lvidacs.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> Optimize RenderTable::colToEffCol() for tables without colspans
</span></span></pre></div>
<a id="trunkPerformanceTestsresourcesresultstemplatehtml"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/resources/results-template.html (166037 => 166038)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/resources/results-template.html 2014-03-21 03:47:26 UTC (rev 166037)
+++ trunk/PerformanceTests/resources/results-template.html 2014-03-21 04:05:05 UTC (rev 166038)
</span><span class="lines">@@ -132,6 +132,7 @@
</span><span class="cx"> <div style="padding: 0 10px;">
</span><span class="cx"> Result <span id="time-memory" class="checkbox"><span class="checked">Time</span><span>Memory</span></span>
</span><span class="cx"> Reference <span id="reference" class="checkbox"></span>
</span><ins>+<span title="Confidence Interval Delta">CI&#916;</span> <span id="confidenceIntervalDelta" class="checkbox"><span class="checked">Show</span><span>Hide</span></span>
</ins><span class="cx"> </div>
</span><span class="cx"> <table id="container"></table>
</span><span class="cx"> <script>
</span><span class="lines">@@ -389,9 +390,14 @@
</span><span class="cx"> return (fraction * 100).toFixed(2) + '%';
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function createTable(tests, runs, shouldIgnoreMemory, referenceIndex) {
</del><ins>+function createTable(tests, runs, shouldIgnoreMemory, referenceIndex, hideConfidenceIntervalDelta) {
</ins><span class="cx"> $('#container').html('<thead><tr><th>Test</th><th>Unit</th>' + runs.map(function (run, index) {
</span><del>- return '<th colspan="' + (index == referenceIndex ? 2 : 3) + '" class="{sorter: \'comparison\'}">' + run.label() + '</th>';
</del><ins>+ var colspan = 2;
+ if (index != referenceIndex)
+ colspan = 3;
+ if (hideConfidenceIntervalDelta)
+ colspan--;
+ return '<th colspan="' + colspan + '" class="{sorter: \'comparison\'}">' + run.label() + '</th>';
</ins><span class="cx"> }).reduce(function (markup, cell) { return markup + cell; }, '') + '</tr></head><tbody></tbody>');
</span><span class="cx">
</span><span class="cx"> var testNames = [];
</span><span class="lines">@@ -401,7 +407,7 @@
</span><span class="cx"> testNames.sort().map(function (testName) {
</span><span class="cx"> var test = tests[testName];
</span><span class="cx"> if (test.isMemoryTest() != shouldIgnoreMemory)
</span><del>- createTableRow(runs, test, referenceIndex);
</del><ins>+ createTableRow(runs, test, referenceIndex, hideConfidenceIntervalDelta);
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> $('#container').tablesorter({widgets: ['zebra']});
</span><span class="lines">@@ -445,7 +451,7 @@
</span><span class="cx"> + '<circle cx="50" cy="73" r="6" fill="white" />'
</span><span class="cx"> + '</svg>';
</span><span class="cx">
</span><del>-function createTableRow(runs, test, referenceIndex) {
</del><ins>+function createTableRow(runs, test, referenceIndex, hideConfidenceIntervalDelta) {
</ins><span class="cx"> var tableRow = $('<tr><td class="test">' + test.name() + '</td><td class="unit">' + test.unit() + '</td></tr>');
</span><span class="cx">
</span><span class="cx"> function markupForRun(result, referenceResult) {
</span><span class="lines">@@ -481,10 +487,15 @@
</span><span class="cx"> var statistics = '&sigma;=' + toFixedWidthPrecision(result.confidenceIntervalDelta()) + ', min=' + toFixedWidthPrecision(result.min())
</span><span class="cx"> + ', max=' + toFixedWidthPrecision(result.max()) + '\n' + regressionAnalysis;
</span><span class="cx">
</span><ins>+ var confidenceIntervalDeltaCell = '';
+ if (!hideConfidenceIntervalDelta) {
+ confidenceIntervalDeltaCell = '<td class="confidenceIntervalDelta" title="' + statistics + '">&plusmn; '
+ + formatPercentage(result.confidenceIntervalDeltaRatio()) + warning + '</td>';
+ }
+
</ins><span class="cx"> // Tablesorter doesn't know about the second cell so put the comparison in the invisible element.
</span><span class="cx"> return '<td class="result" title="' + statistics + '">' + toFixedWidthPrecision(result.mean()) + hiddenValue
</span><del>- + '</td><td class="confidenceIntervalDelta" title="' + statistics + '">&plusmn; '
- + formatPercentage(result.confidenceIntervalDeltaRatio()) + warning + '</td>' + comparisonCell;
</del><ins>+ + '</td>' + confidenceIntervalDeltaCell + comparisonCell;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function markupForMissingRun(isReference) {
</span><span class="lines">@@ -580,12 +591,13 @@
</span><span class="cx">
</span><span class="cx"> var shouldIgnoreMemory= true;
</span><span class="cx"> var referenceIndex = 0;
</span><ins>+ var hideConfidenceIntervalDelta = false;
</ins><span class="cx">
</span><span class="cx"> createTable(metrics, runs, shouldIgnoreMemory, referenceIndex);
</span><span class="cx">
</span><span class="cx"> $('#time-memory').bind('change', function (event, checkedElement) {
</span><span class="cx"> shouldIgnoreMemory = checkedElement.textContent == 'Time';
</span><del>- createTable(metrics, runs, shouldIgnoreMemory, referenceIndex);
</del><ins>+ createTable(metrics, runs, shouldIgnoreMemory, referenceIndex, hideConfidenceIntervalDelta);
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> runs.map(function (run, index) {
</span><span class="lines">@@ -594,9 +606,14 @@
</span><span class="cx">
</span><span class="cx"> $('#reference').bind('change', function (event, checkedElement) {
</span><span class="cx"> referenceIndex = parseInt(checkedElement.getAttribute('value'));
</span><del>- createTable(metrics, runs, shouldIgnoreMemory, referenceIndex);
</del><ins>+ createTable(metrics, runs, shouldIgnoreMemory, referenceIndex, hideConfidenceIntervalDelta);
</ins><span class="cx"> });
</span><span class="cx">
</span><ins>+ $('#confidenceIntervalDelta').bind('change', function (event, checkedElement) {
+ hideConfidenceIntervalDelta = checkedElement.textContent == 'Hide';
+ createTable(metrics, runs, shouldIgnoreMemory, referenceIndex, hideConfidenceIntervalDelta);
+ });
+
</ins><span class="cx"> $('.checkbox').each(function (index, checkbox) {
</span><span class="cx"> $(checkbox).children('span').click(function (event) {
</span><span class="cx"> if ($(this).hasClass('checked'))
</span></span></pre>
</div>
</div>
</body>
</html>