<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165810] trunk/Source/WebKit/gtk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165810">165810</a></dd>
<dt>Author</dt> <dd>jaepark@webkit.org</dd>
<dt>Date</dt> <dd>2014-03-18 07:08:50 -0700 (Tue, 18 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK][CMake] Fix WebKit unused parameter warnings
https://bugs.webkit.org/show_bug.cgi?id=130383
Reviewed by Martin Robinson.
* WebCoreSupport/AcceleratedCompositingContextGL.cpp: Fix unused parameters warning.
* WebCoreSupport/ChromeClientGtk.cpp: Ditto.
* WebCoreSupport/DragClientGtk.cpp: Ditto.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Ditto.
* WebCoreSupport/EditorClientGtk.cpp: Ditto.
* WebCoreSupport/FrameLoaderClientGtk.cpp: Ditto.
* WebCoreSupport/InspectorClientGtk.cpp: Ditto.
* WebCoreSupport/PlatformStrategiesGtk.cpp: Ditto.
* WebCoreSupport/ProgressTrackerClientGtk.cpp: Ditto.
* WebCoreSupport/WebViewInputMethodFilter.cpp: Ditto.
* webkit/webkitdownload.cpp: Ditto.
* webkit/webkitfavicondatabase.cpp: Ditto.
* webkit/webkitsoupauthdialog.cpp: Ditto.
* webkit/webkitspellchecker.cpp: Ditto.
* webkit/webkitspellcheckerenchant.cpp: Ditto.
* webkit/webkitwebframe.cpp: Ditto.
* webkit/webkitwebinspector.cpp: Ditto.
* webkit/webkitwebview.cpp: Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitgtkChangeLog">trunk/Source/WebKit/gtk/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportAcceleratedCompositingContextGLcpp">trunk/Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportChromeClientGtkcpp">trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportDragClientGtkcpp">trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportDumpRenderTreeSupportGtkcpp">trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportEditorClientGtkcpp">trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportFrameLoaderClientGtkcpp">trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportInspectorClientGtkcpp">trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportPlatformStrategiesGtkcpp">trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportProgressTrackerClientGtkcpp">trunk/Source/WebKit/gtk/WebCoreSupport/ProgressTrackerClientGtk.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportWebViewInputMethodFiltercpp">trunk/Source/WebKit/gtk/WebCoreSupport/WebViewInputMethodFilter.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkwebkitwebkitdownloadcpp">trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkwebkitwebkitfavicondatabasecpp">trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkwebkitwebkitsoupauthdialogcpp">trunk/Source/WebKit/gtk/webkit/webkitsoupauthdialog.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkwebkitwebkitspellcheckercpp">trunk/Source/WebKit/gtk/webkit/webkitspellchecker.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkwebkitwebkitspellcheckerenchantcpp">trunk/Source/WebKit/gtk/webkit/webkitspellcheckerenchant.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkwebkitwebkitwebframecpp">trunk/Source/WebKit/gtk/webkit/webkitwebframe.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkwebkitwebkitwebinspectorcpp">trunk/Source/WebKit/gtk/webkit/webkitwebinspector.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkwebkitwebkitwebviewcpp">trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitgtkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/ChangeLog (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/ChangeLog 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/ChangeLog 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2014-03-18 Jae Hyun Park <jaepark@webkit.org>
+
+ [GTK][CMake] Fix WebKit unused parameter warnings
+ https://bugs.webkit.org/show_bug.cgi?id=130383
+
+ Reviewed by Martin Robinson.
+
+ * WebCoreSupport/AcceleratedCompositingContextGL.cpp: Fix unused parameters warning.
+ * WebCoreSupport/ChromeClientGtk.cpp: Ditto.
+ * WebCoreSupport/DragClientGtk.cpp: Ditto.
+ * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Ditto.
+ * WebCoreSupport/EditorClientGtk.cpp: Ditto.
+ * WebCoreSupport/FrameLoaderClientGtk.cpp: Ditto.
+ * WebCoreSupport/InspectorClientGtk.cpp: Ditto.
+ * WebCoreSupport/PlatformStrategiesGtk.cpp: Ditto.
+ * WebCoreSupport/ProgressTrackerClientGtk.cpp: Ditto.
+ * WebCoreSupport/WebViewInputMethodFilter.cpp: Ditto.
+ * webkit/webkitdownload.cpp: Ditto.
+ * webkit/webkitfavicondatabase.cpp: Ditto.
+ * webkit/webkitsoupauthdialog.cpp: Ditto.
+ * webkit/webkitspellchecker.cpp: Ditto.
+ * webkit/webkitspellcheckerenchant.cpp: Ditto.
+ * webkit/webkitwebframe.cpp: Ditto.
+ * webkit/webkitwebinspector.cpp: Ditto.
+ * webkit/webkitwebview.cpp: Ditto.
+
</ins><span class="cx"> 2014-03-14 Maciej Stachowiak <mjs@apple.com>
</span><span class="cx">
</span><span class="cx"> Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportAcceleratedCompositingContextGLcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -314,7 +314,7 @@
</span><span class="cx"> scheduleLayerFlush();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void AcceleratedCompositingContext::scrollNonCompositedContents(const IntRect& scrollRect, const IntSize& scrollOffset)
</del><ins>+void AcceleratedCompositingContext::scrollNonCompositedContents(const IntRect& scrollRect, const IntSize& /* scrollOffset */)
</ins><span class="cx"> {
</span><span class="cx"> m_nonCompositedContentLayer->setNeedsDisplayInRect(scrollRect);
</span><span class="cx"> scheduleLayerFlush();
</span><span class="lines">@@ -387,7 +387,7 @@
</span><span class="cx"> flushAndRenderLayers();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void AcceleratedCompositingContext::notifyAnimationStarted(const GraphicsLayer*, double time)
</del><ins>+void AcceleratedCompositingContext::notifyAnimationStarted(const GraphicsLayer*, double /* time */)
</ins><span class="cx"> {
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportChromeClientGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -195,7 +195,7 @@
</span><span class="cx"> gtk_window_set_focus(GTK_WINDOW(window), NULL);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Page* ChromeClient::createWindow(Frame* frame, const FrameLoadRequest& frameLoadRequest, const WindowFeatures& coreFeatures, const NavigationAction&)
</del><ins>+Page* ChromeClient::createWindow(Frame* frame, const FrameLoadRequest&, const WindowFeatures& coreFeatures, const NavigationAction&)
</ins><span class="cx"> {
</span><span class="cx"> WebKitWebView* webView = 0;
</span><span class="cx">
</span><span class="lines">@@ -361,7 +361,7 @@
</span><span class="cx"> return runJavaScriptConfirm(frame, message);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClient::addMessageToConsole(JSC::MessageSource source, JSC::MessageLevel level, const WTF::String& message, unsigned lineNumber, unsigned columnNumber, const WTF::String& sourceId)
</del><ins>+void ChromeClient::addMessageToConsole(JSC::MessageSource, JSC::MessageLevel, const WTF::String& message, unsigned lineNumber, unsigned /* columnNumber */, const WTF::String& sourceId)
</ins><span class="cx"> {
</span><span class="cx"> gboolean retval;
</span><span class="cx"> g_signal_emit_by_name(m_webView, "console-message", message.utf8().data(), lineNumber, sourceId.utf8().data(), &retval);
</span><span class="lines">@@ -668,7 +668,7 @@
</span><span class="cx"> invalidateContentsAndRootView(updateRect);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClient::scroll(const IntSize& delta, const IntRect& rectToScroll, const IntRect& clipRect)
</del><ins>+void ChromeClient::scroll(const IntSize& delta, const IntRect& rectToScroll, const IntRect& /* clipRect */)
</ins><span class="cx"> {
</span><span class="cx"> m_adjustmentWatcher.updateAdjustmentsFromScrollbarsLater();
</span><span class="cx">
</span><span class="lines">@@ -784,7 +784,7 @@
</span><span class="cx"> horizontalPolicy, verticalPolicy);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClient::mouseDidMoveOverElement(const HitTestResult& hit, unsigned modifierFlags)
</del><ins>+void ChromeClient::mouseDidMoveOverElement(const HitTestResult& hit, unsigned /* modifierFlags */)
</ins><span class="cx"> {
</span><span class="cx"> // check if the element is a link...
</span><span class="cx"> bool isLink = hit.isLiveLink();
</span><span class="lines">@@ -840,7 +840,7 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-void ChromeClient::reachedMaxAppCacheSize(int64_t spaceNeeded)
</del><ins>+void ChromeClient::reachedMaxAppCacheSize(int64_t /* spaceNeeded */)
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: Free some space.
</span><span class="cx"> notImplemented();
</span><span class="lines">@@ -862,7 +862,7 @@
</span><span class="cx"> loader->notifyFinished(Icon::createIconForFiles(filenames));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClient::dispatchViewportPropertiesDidChange(const ViewportArguments& arguments) const
</del><ins>+void ChromeClient::dispatchViewportPropertiesDidChange(const ViewportArguments&) const
</ins><span class="cx"> {
</span><span class="cx"> // Recompute the viewport attributes making it valid.
</span><span class="cx"> webkitViewportAttributesRecompute(webkit_web_view_get_viewport_attributes(m_webView));
</span><span class="lines">@@ -916,12 +916,12 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(FULLSCREEN_API)
</span><del>-bool ChromeClient::supportsFullScreenForElement(const WebCore::Element* element, bool withKeyboard)
</del><ins>+bool ChromeClient::supportsFullScreenForElement(const WebCore::Element*, bool withKeyboard)
</ins><span class="cx"> {
</span><span class="cx"> return !withKeyboard;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static gboolean onFullscreenGtkKeyPressEvent(GtkWidget* widget, GdkEventKey* event, ChromeClient* chromeClient)
</del><ins>+static gboolean onFullscreenGtkKeyPressEvent(GtkWidget*, GdkEventKey* event, ChromeClient* chromeClient)
</ins><span class="cx"> {
</span><span class="cx"> switch (event->keyval) {
</span><span class="cx"> case GDK_KEY_Escape:
</span><span class="lines">@@ -989,7 +989,7 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-void ChromeClient::attachRootGraphicsLayer(Frame* frame, GraphicsLayer* rootLayer)
</del><ins>+void ChromeClient::attachRootGraphicsLayer(Frame*, GraphicsLayer* rootLayer)
</ins><span class="cx"> {
</span><span class="cx"> AcceleratedCompositingContext* context = m_webView->priv->acceleratedCompositingContext.get();
</span><span class="cx"> bool turningOffCompositing = !rootLayer && context->enabled();
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportDragClientGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx"> return DragSourceActionAny;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DragClient::startDrag(DragImageRef image, const IntPoint& dragImageOrigin, const IntPoint& eventPos, Clipboard& clipboard, Frame& frame, bool linkDrag)
</del><ins>+void DragClient::startDrag(DragImageRef image, const IntPoint& dragImageOrigin, const IntPoint& eventPos, Clipboard& clipboard, Frame& frame, bool /* linkDrag */)
</ins><span class="cx"> {
</span><span class="cx"> WebKitWebView* webView = webkit_web_frame_get_web_view(kit(&frame));
</span><span class="cx"> RefPtr<DataObjectGtk> dataObject = clipboard.pasteboard().dataObject();
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportDumpRenderTreeSupportGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -584,7 +584,7 @@
</span><span class="cx"> core(webView)->settings().setCSSGridLayoutEnabled(enabled);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DumpRenderTreeSupportGtk::setCSSRegionsEnabled(WebKitWebView* webView, bool enabled)
</del><ins>+void DumpRenderTreeSupportGtk::setCSSRegionsEnabled(WebKitWebView*, bool enabled)
</ins><span class="cx"> {
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setCSSRegionsEnabled(enabled);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportEditorClientGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -204,7 +204,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static WebKitWebView* viewSettingClipboard = 0;
</span><del>-static void collapseSelection(GtkClipboard* clipboard, WebKitWebView* webView)
</del><ins>+static void collapseSelection(GtkClipboard*, WebKitWebView* webView)
</ins><span class="cx"> {
</span><span class="cx"> if (viewSettingClipboard && viewSettingClipboard == webView)
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportFrameLoaderClientGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -226,7 +226,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool FrameLoaderClient::shouldUseCredentialStorage(WebCore::DocumentLoader*, unsigned long identifier)
</del><ins>+bool FrameLoaderClient::shouldUseCredentialStorage(WebCore::DocumentLoader*, unsigned long /* identifier */)
</ins><span class="cx"> {
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -268,7 +268,7 @@
</span><span class="cx"> gtk_widget_show(authDialog);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void FrameLoaderClient::dispatchDidCancelAuthenticationChallenge(WebCore::DocumentLoader*, unsigned long identifier, const AuthenticationChallenge&)
</del><ins>+void FrameLoaderClient::dispatchDidCancelAuthenticationChallenge(WebCore::DocumentLoader*, unsigned long /* identifier */, const AuthenticationChallenge&)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="lines">@@ -528,8 +528,7 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Frame> FrameLoaderClient::createFrame(const URL& url, const String& name, HTMLFrameOwnerElement* ownerElement,
- const String& referrer, bool allowsScrolling, int marginWidth, int marginHeight)
</del><ins>+PassRefPtr<Frame> FrameLoaderClient::createFrame(const URL& url, const String& name, HTMLFrameOwnerElement* ownerElement, const String& referrer, bool /* allowsScrolling */, int /* marginWidth */, int /* marginHeight */)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(m_frame);
</span><span class="cx"> Frame* parentFrame = core(m_frame);
</span><span class="lines">@@ -919,7 +918,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool FrameLoaderClient::canShowMIMETypeAsHTML(const String& MIMEType) const
</del><ins>+bool FrameLoaderClient::canShowMIMETypeAsHTML(const String& /* MIMEType */) const
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> return false;
</span><span class="lines">@@ -967,7 +966,7 @@
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void FrameLoaderClient::setTitle(const StringWithDirection& title, const URL& url)
</del><ins>+void FrameLoaderClient::setTitle(const StringWithDirection& title, const URL&)
</ins><span class="cx"> {
</span><span class="cx"> WebKitWebFramePrivate* frameData = m_frame->priv;
</span><span class="cx"> g_free(frameData->title);
</span><span class="lines">@@ -1042,7 +1041,7 @@
</span><span class="cx"> webkitWebViewRemoveSubresource(webView, identifierString.get());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache(WebCore::DocumentLoader*, const ResourceRequest&, const ResourceResponse&, int length)
</del><ins>+bool FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache(WebCore::DocumentLoader*, const ResourceRequest&, const ResourceResponse&, int /* length */)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> return false;
</span><span class="lines">@@ -1190,7 +1189,7 @@
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void FrameLoaderClient::savePlatformDataToCachedFrame(CachedFrame* cachedFrame)
</del><ins>+void FrameLoaderClient::savePlatformDataToCachedFrame(CachedFrame*)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1217,7 +1216,7 @@
</span><span class="cx">
</span><span class="cx"> void FrameLoaderClient::transitionToCommittedFromCachedFrame(CachedFrame* cachedFrame)
</span><span class="cx"> {
</span><del>- ASSERT(cachedFrame->view());
</del><ins>+ ASSERT_UNUSED(cachedFrame, cachedFrame->view());
</ins><span class="cx">
</span><span class="cx"> Frame* frame = core(m_frame);
</span><span class="cx"> if (frame != &frame->page()->mainFrame())
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportInspectorClientGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx">
</span><span class="cx"> namespace WebKit {
</span><span class="cx">
</span><del>-static void notifyWebViewDestroyed(WebKitWebView* webView, InspectorFrontendClient* inspectorFrontendClient)
</del><ins>+static void notifyWebViewDestroyed(WebKitWebView*, InspectorFrontendClient* inspectorFrontendClient)
</ins><span class="cx"> {
</span><span class="cx"> inspectorFrontendClient->destroyInspectorWindow(true);
</span><span class="cx"> }
</span><span class="lines">@@ -50,13 +50,13 @@
</span><span class="cx"> virtual ~InspectorFrontendSettingsGtk() { }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual String getProperty(const String& name)
</del><ins>+ virtual String getProperty(const String& /* name */)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> return String();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual void setProperty(const String& name, const String& value)
</del><ins>+ virtual void setProperty(const String& /* name */, const String& /* value */)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> delete this;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-InspectorFrontendChannel* InspectorClient::openInspectorFrontend(InspectorController* controller)
</del><ins>+InspectorFrontendChannel* InspectorClient::openInspectorFrontend(InspectorController*)
</ins><span class="cx"> {
</span><span class="cx"> // This g_object_get will ref the inspector. We're not doing an
</span><span class="cx"> // unref if this method succeeds because the inspector object must
</span><span class="lines">@@ -241,17 +241,17 @@
</span><span class="cx"> g_signal_emit_by_name(m_webInspector.get(), "detach-window", &handled);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorFrontendClient::setAttachedWindowHeight(unsigned height)
</del><ins>+void InspectorFrontendClient::setAttachedWindowHeight(unsigned /* height */)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorFrontendClient::setAttachedWindowWidth(unsigned width)
</del><ins>+void InspectorFrontendClient::setAttachedWindowWidth(unsigned /* width */)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorFrontendClient::setToolbarHeight(unsigned height)
</del><ins>+void InspectorFrontendClient::setToolbarHeight(unsigned /* height */)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportPlatformStrategiesGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -112,7 +112,7 @@
</span><span class="cx"> PluginDatabase::installedPlugins()->refresh();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PlatformStrategiesGtk::getPluginInfo(const Page* page, Vector<PluginInfo>& outPlugins)
</del><ins>+void PlatformStrategiesGtk::getPluginInfo(const Page*, Vector<PluginInfo>& outPlugins)
</ins><span class="cx"> {
</span><span class="cx"> PluginDatabase* database = PluginDatabase::installedPlugins();
</span><span class="cx"> const Vector<PluginPackage*> &plugins = database->plugins();
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportProgressTrackerClientGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/ProgressTrackerClientGtk.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/ProgressTrackerClientGtk.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/ProgressTrackerClientGtk.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx">
</span><span class="cx"> void ProgressTrackerClient::progressEstimateChanged(WebCore::Frame& originatingProgressFrame)
</span><span class="cx"> {
</span><del>- ASSERT(m_webView == getViewFromFrame(kit(&originatingProgressFrame)));
</del><ins>+ ASSERT_UNUSED(originatingProgressFrame, (m_webView == getViewFromFrame(kit(&originatingProgressFrame))));
</ins><span class="cx">
</span><span class="cx"> WebCore::Page* corePage = core(m_webView);
</span><span class="cx"> g_signal_emit_by_name(m_webView, "load-progress-changed", lround(corePage->progress().estimatedProgress()*100));
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportWebViewInputMethodFiltercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/WebViewInputMethodFilter.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/WebViewInputMethodFilter.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/WebViewInputMethodFilter.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -102,7 +102,7 @@
</span><span class="cx"> frame->editor().cancelComposition();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebViewInputMethodFilter::setPreedit(String newPreedit, int cursorOffset)
</del><ins>+void WebViewInputMethodFilter::setPreedit(String newPreedit, int /* cursorOffset */)
</ins><span class="cx"> {
</span><span class="cx"> Frame* frame = focusedOrMainFrame();
</span><span class="cx"> if (!frame || !frame->editor().canEdit())
</span></span></pre></div>
<a id="trunkSourceWebKitgtkwebkitwebkitdownloadcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -943,12 +943,12 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DownloadClient::didReceiveData(ResourceHandle*, const char* data, unsigned length, int encodedDataLength)
</del><ins>+void DownloadClient::didReceiveData(ResourceHandle*, const char* /* data */, unsigned /* length */, int /* encodedDataLength */)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void DownloadClient::didReceiveBuffer(ResourceHandle*, PassRefPtr<SharedBuffer> buffer, int encodedLength)
</del><ins>+void DownloadClient::didReceiveBuffer(ResourceHandle*, PassRefPtr<SharedBuffer> buffer, int /* encodedLength */)
</ins><span class="cx"> {
</span><span class="cx"> // This pattern is suggested by SharedBuffer.h.
</span><span class="cx"> const char* segment;
</span></span></pre></div>
<a id="trunkSourceWebKitgtkwebkitwebkitfavicondatabasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx">
</span><span class="cx"> // Called when an icon is requested while the initial import is
</span><span class="cx"> // going on.
</span><del>- virtual void didImportIconURLForPageURL(const String& URL) { };
</del><ins>+ virtual void didImportIconURLForPageURL(const String& /* URL */) { };
</ins><span class="cx">
</span><span class="cx"> // Called whenever a retained icon is read from database.
</span><span class="cx"> virtual void didImportIconDataForPageURL(const String& URL)
</span><span class="lines">@@ -96,7 +96,7 @@
</span><span class="cx"> webkitFaviconDatabaseProcessPendingIconsForURI(database, URL);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual void didChangeIconForPageURL(const String& URL)
</del><ins>+ virtual void didChangeIconForPageURL(const String& /* URL */)
</ins><span class="cx"> {
</span><span class="cx"> // Called when the the favicon for a particular URL changes.
</span><span class="cx"> // It does not mean that the new icon data is available yet.
</span><span class="lines">@@ -315,7 +315,7 @@
</span><span class="cx"> return database->priv->path.get();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void webkitFaviconDatabaseClose(WebKitFaviconDatabase* database)
</del><ins>+static void webkitFaviconDatabaseClose(WebKitFaviconDatabase*)
</ins><span class="cx"> {
</span><span class="cx"> if (iconDatabase().isEnabled()) {
</span><span class="cx"> iconDatabase().setEnabled(false);
</span><span class="lines">@@ -386,7 +386,7 @@
</span><span class="cx"> return g_strdup(iconURI.utf8().data());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static GdkPixbuf* getIconPixbufSynchronously(WebKitFaviconDatabase* database, const String& pageURL, const IntSize& iconSize)
</del><ins>+static GdkPixbuf* getIconPixbufSynchronously(WebKitFaviconDatabase*, const String& pageURL, const IntSize& iconSize)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(isMainThread());
</span><span class="cx">
</span><span class="lines">@@ -484,7 +484,7 @@
</span><span class="cx"> webkitfavicondatabaseDeleteRequests(database, icons, pageURL);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void webkitFaviconDatabaseGetIconPixbufCancelled(GCancellable* cancellable, PendingIconRequest* request)
</del><ins>+static void webkitFaviconDatabaseGetIconPixbufCancelled(GCancellable*, PendingIconRequest* request)
</ins><span class="cx"> {
</span><span class="cx"> // Handle cancelled in a in idle since it might be called from any thread.
</span><span class="cx"> callOnMainThread(getIconPixbufCancelled, request);
</span><span class="lines">@@ -573,7 +573,7 @@
</span><span class="cx"> *
</span><span class="cx"> * Since: 1.8
</span><span class="cx"> */
</span><del>-GdkPixbuf* webkit_favicon_database_get_favicon_pixbuf_finish(WebKitFaviconDatabase* database, GAsyncResult* result, GError** error)
</del><ins>+GdkPixbuf* webkit_favicon_database_get_favicon_pixbuf_finish(WebKitFaviconDatabase*, GAsyncResult* result, GError** error)
</ins><span class="cx"> {
</span><span class="cx"> GSimpleAsyncResult* simpleResult = G_SIMPLE_ASYNC_RESULT(result);
</span><span class="cx"> g_return_val_if_fail(g_simple_async_result_get_source_tag(simpleResult) == webkit_favicon_database_get_favicon_pixbuf, 0);
</span></span></pre></div>
<a id="trunkSourceWebKitgtkwebkitwebkitsoupauthdialogcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/webkit/webkitsoupauthdialog.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/webkit/webkitsoupauthdialog.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/webkit/webkitsoupauthdialog.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> using RefCounted<WebKitSoupAuthDialogAuthenticationClient>::ref;
</span><span class="cx"> using RefCounted<WebKitSoupAuthDialogAuthenticationClient>::deref;
</span><span class="cx"> public:
</span><del>- virtual void didReceiveAuthenticationChallenge(const AuthenticationChallenge& challenge)
</del><ins>+ virtual void didReceiveAuthenticationChallenge(const AuthenticationChallenge&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitgtkwebkitwebkitspellcheckercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/webkit/webkitspellchecker.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/webkit/webkitspellchecker.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/webkit/webkitspellchecker.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx">
</span><span class="cx"> G_DEFINE_INTERFACE(WebKitSpellChecker, webkit_spell_checker, G_TYPE_OBJECT);
</span><span class="cx">
</span><del>-static void webkit_spell_checker_default_init(WebKitSpellCheckerInterface* interface)
</del><ins>+static void webkit_spell_checker_default_init(WebKitSpellCheckerInterface*)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitgtkwebkitwebkitspellcheckerenchantcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/webkit/webkitspellcheckerenchant.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/webkit/webkitspellcheckerenchant.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/webkit/webkitspellcheckerenchant.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx"> priv->textCheckerEnchant->checkSpellingOfString(String::fromUTF8(string), *misspellingLocation, *misspellingLength);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static char** getGuessesForWord(WebKitSpellChecker* checker, const char* word, const char* context)
</del><ins>+static char** getGuessesForWord(WebKitSpellChecker* checker, const char* word, const char* /* context */)
</ins><span class="cx"> {
</span><span class="cx"> WebKitSpellCheckerEnchantPrivate* priv = WEBKIT_SPELL_CHECKER_ENCHANT(checker)->priv;
</span><span class="cx">
</span><span class="lines">@@ -104,7 +104,7 @@
</span><span class="cx"> priv->textCheckerEnchant->updateSpellCheckingLanguages(languagesVector);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static char* getAutocorrectSuggestionsForMisspelledWord(WebKitSpellChecker* checker, const char* word)
</del><ins>+static char* getAutocorrectSuggestionsForMisspelledWord(WebKitSpellChecker*, const char* /* word */)
</ins><span class="cx"> {
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitgtkwebkitwebkitwebframecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/webkit/webkitwebframe.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/webkit/webkitwebframe.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebframe.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -921,7 +921,7 @@
</span><span class="cx"> corePrintContext->spoolPage(graphicsContext, pageNumber, pageWidth);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void end_print_callback(GtkPrintOperation* op, GtkPrintContext* context, gpointer user_data)
</del><ins>+static void end_print_callback(GtkPrintOperation*, GtkPrintContext*, gpointer user_data)
</ins><span class="cx"> {
</span><span class="cx"> PrintContext* printContext = reinterpret_cast<PrintContext*>(user_data);
</span><span class="cx"> printContext->end();
</span></span></pre></div>
<a id="trunkSourceWebKitgtkwebkitwebkitwebinspectorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/webkit/webkitwebinspector.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/webkit/webkitwebinspector.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebinspector.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx">
</span><span class="cx"> static void webkit_web_inspector_get_property(GObject* object, guint prop_id, GValue* value, GParamSpec* pspec);
</span><span class="cx">
</span><del>-static gboolean webkit_inspect_web_view_request_handled(GSignalInvocationHint* ihint, GValue* returnAccu, const GValue* handlerReturn, gpointer dummy)
</del><ins>+static gboolean webkit_inspect_web_view_request_handled(GSignalInvocationHint*, GValue* returnAccu, const GValue* handlerReturn, gpointer)
</ins><span class="cx"> {
</span><span class="cx"> gboolean continueEmission = TRUE;
</span><span class="cx"> gpointer newWebView = g_value_get_object(handlerReturn);
</span></span></pre></div>
<a id="trunkSourceWebKitgtkwebkitwebkitwebviewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp (165809 => 165810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2014-03-18 13:44:28 UTC (rev 165809)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2014-03-18 14:08:50 UTC (rev 165810)
</span><span class="lines">@@ -1128,7 +1128,7 @@
</span><span class="cx"> return WEBKIT_NAVIGATION_RESPONSE_ACCEPT;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void webkit_web_view_real_window_object_cleared(WebKitWebView*, WebKitWebFrame*, JSGlobalContextRef context, JSObjectRef window_object)
</del><ins>+static void webkit_web_view_real_window_object_cleared(WebKitWebView*, WebKitWebFrame*, JSGlobalContextRef, JSObjectRef)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="lines">@@ -1232,7 +1232,7 @@
</span><span class="cx"> return TRUE;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static gboolean webkit_web_view_real_console_message(WebKitWebView* webView, const gchar* message, unsigned int line, const gchar* sourceId)
</del><ins>+static gboolean webkit_web_view_real_console_message(WebKitWebView*, const gchar* message, unsigned line, const gchar* sourceId)
</ins><span class="cx"> {
</span><span class="cx"> g_message("console message: %s @%d: %s\n", sourceId, line, message);
</span><span class="cx"> return TRUE;
</span><span class="lines">@@ -1332,12 +1332,12 @@
</span><span class="cx"> return TRUE;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static gboolean webkit_web_view_real_entering_fullscreen(WebKitWebView* webView)
</del><ins>+static gboolean webkit_web_view_real_entering_fullscreen(WebKitWebView*)
</ins><span class="cx"> {
</span><span class="cx"> return FALSE;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static gboolean webkit_web_view_real_leaving_fullscreen(WebKitWebView* webView)
</del><ins>+static gboolean webkit_web_view_real_leaving_fullscreen(WebKitWebView*)
</ins><span class="cx"> {
</span><span class="cx"> return FALSE;
</span><span class="cx"> }
</span><span class="lines">@@ -1440,7 +1440,7 @@
</span><span class="cx"> G_OBJECT_CLASS(webkit_web_view_parent_class)->finalize(object);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static gboolean webkit_signal_accumulator_object_handled(GSignalInvocationHint* ihint, GValue* returnAccu, const GValue* handlerReturn, gpointer dummy)
</del><ins>+static gboolean webkit_signal_accumulator_object_handled(GSignalInvocationHint*, GValue* returnAccu, const GValue* handlerReturn, gpointer)
</ins><span class="cx"> {
</span><span class="cx"> gpointer newWebView = g_value_get_object(handlerReturn);
</span><span class="cx"> g_value_set_object(returnAccu, newWebView);
</span><span class="lines">@@ -1449,7 +1449,7 @@
</span><span class="cx"> return !newWebView;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static gboolean webkit_navigation_request_handled(GSignalInvocationHint* ihint, GValue* returnAccu, const GValue* handlerReturn, gpointer dummy)
</del><ins>+static gboolean webkit_navigation_request_handled(GSignalInvocationHint*, GValue* returnAccu, const GValue* handlerReturn, gpointer)
</ins><span class="cx"> {
</span><span class="cx"> WebKitNavigationResponse navigationResponse = (WebKitNavigationResponse)g_value_get_enum(handlerReturn);
</span><span class="cx"> g_value_set_enum(returnAccu, navigationResponse);
</span><span class="lines">@@ -1522,7 +1522,7 @@
</span><span class="cx"> return fontSize / 72.0 * webViewGetDPI(webView);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void webkit_web_view_screen_changed(GtkWidget* widget, GdkScreen* previousScreen)
</del><ins>+static void webkit_web_view_screen_changed(GtkWidget* widget, GdkScreen*)
</ins><span class="cx"> {
</span><span class="cx"> WebKitWebView* webView = WEBKIT_WEB_VIEW(widget);
</span><span class="cx"> WebKitWebViewPrivate* priv = webView->priv;
</span><span class="lines">@@ -1596,7 +1596,7 @@
</span><span class="cx"> core(WEBKIT_WEB_VIEW(widget))->dragController().dragEnded();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void webkit_web_view_drag_leave(GtkWidget* widget, GdkDragContext* context, guint time)
</del><ins>+static void webkit_web_view_drag_leave(GtkWidget* widget, GdkDragContext* context, guint /* time */)
</ins><span class="cx"> {
</span><span class="cx"> WEBKIT_WEB_VIEW(widget)->priv->dragAndDropHelper.handleDragLeave(context, dragExitedCallback);
</span><span class="cx"> }
</span><span class="lines">@@ -1615,7 +1615,7 @@
</span><span class="cx"> return TRUE;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void webkit_web_view_drag_data_received(GtkWidget* widget, GdkDragContext* context, gint x, gint y, GtkSelectionData* selectionData, guint info, guint time)
</del><ins>+static void webkit_web_view_drag_data_received(GtkWidget* widget, GdkDragContext* context, gint /* x */, gint /* y */, GtkSelectionData* selectionData, guint info, guint time)
</ins><span class="cx"> {
</span><span class="cx"> WebKitWebView* webView = WEBKIT_WEB_VIEW(widget);
</span><span class="cx"> IntPoint position;
</span><span class="lines">@@ -1643,7 +1643,7 @@
</span><span class="cx"> }
</span><span class="cx"> #endif // ENABLE(DRAG_SUPPORT)
</span><span class="cx">
</span><del>-static gboolean webkit_web_view_query_tooltip(GtkWidget *widget, gint x, gint y, gboolean keyboard_mode, GtkTooltip *tooltip)
</del><ins>+static gboolean webkit_web_view_query_tooltip(GtkWidget *widget, gint /* x */, gint /* y */, gboolean keyboard_mode, GtkTooltip *tooltip)
</ins><span class="cx"> {
</span><span class="cx"> WebKitWebViewPrivate* priv = WEBKIT_WEB_VIEW(widget)->priv;
</span><span class="cx">
</span><span class="lines">@@ -5235,7 +5235,7 @@
</span><span class="cx"> * Since: 1.1.14
</span><span class="cx"> * Deprecated: 2.6
</span><span class="cx"> */
</span><del>-void webkit_web_view_set_view_source_mode (WebKitWebView* webView, gboolean mode)
</del><ins>+void webkit_web_view_set_view_source_mode (WebKitWebView* webView, gboolean /* mode */)
</ins><span class="cx"> {
</span><span class="cx"> g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
</span><span class="cx">
</span><span class="lines">@@ -5544,7 +5544,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(ICONDATABASE)
</span><del>-void webkitWebViewIconLoaded(WebKitFaviconDatabase* database, const char* frameURI, WebKitWebView* webView)
</del><ins>+void webkitWebViewIconLoaded(WebKitFaviconDatabase*, const char* /* frameURI */, WebKitWebView* webView)
</ins><span class="cx"> {
</span><span class="cx"> // Since we definitely have an icon the WebView doesn't need to
</span><span class="cx"> // listen for notifications any longer.
</span><span class="lines">@@ -5568,7 +5568,7 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-void webkitWebViewDirectionChanged(WebKitWebView* webView, GtkTextDirection previousDirection, gpointer)
</del><ins>+void webkitWebViewDirectionChanged(WebKitWebView* webView, GtkTextDirection, gpointer)
</ins><span class="cx"> {
</span><span class="cx"> g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>