<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165830] branches/safari-537.75-branch/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165830">165830</a></dd>
<dt>Author</dt> <dd>matthew_hanson@apple.com</dd>
<dt>Date</dt> <dd>2014-03-18 12:30:39 -0700 (Tue, 18 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Follow-up fix for the merge of <a href="http://trac.webkit.org/projects/webkit/changeset/163579">r163579</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari53775branchSourceWebCoreChangeLog">branches/safari-537.75-branch/Source/WebCore/ChangeLog</a></li>
<li><a href="#branchessafari53775branchSourceWebCorehtmlparserHTMLConstructionSitecpp">branches/safari-537.75-branch/Source/WebCore/html/parser/HTMLConstructionSite.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari53775branchSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-537.75-branch/Source/WebCore/ChangeLog (165829 => 165830)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-537.75-branch/Source/WebCore/ChangeLog 2014-03-18 19:16:01 UTC (rev 165829)
+++ branches/safari-537.75-branch/Source/WebCore/ChangeLog 2014-03-18 19:30:39 UTC (rev 165830)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-03-18 Matthew Hanson <matthew_hanson@apple.com>
+
+ Follow-up fix for the merge of r163579.
+
+ 2014-03-17 Jeffrey Pfau <jpfau@apple.com>
+
+ Merge parts from Blink CLs 169865acce3b6bc85ac1adf07b2798aaf9aad67a and 04f613e7f0c35f444d5a9bd42da55c69df65cf64 that weren't merged to trunk
+ <rdar://problem/16307742>
+
+ Unreviewed Layout Test fix.
+
+ * html/parser/HTMLConstructionSite.cpp:
+ (WebCore::insert):
+ (WebCore::executeInsertTask):
+ (WebCore::executeReparentTask):
+ (WebCore::executeInsertAlreadyParsedChildTask):
+
</ins><span class="cx"> 2014-03-17 Matthew Hanson <matthew_hanson@apple.com>
</span><span class="cx">
</span><span class="cx"> Merge r165753.
</span></span></pre></div>
<a id="branchessafari53775branchSourceWebCorehtmlparserHTMLConstructionSitecpp"></a>
<div class="modfile"><h4>Modified: branches/safari-537.75-branch/Source/WebCore/html/parser/HTMLConstructionSite.cpp (165829 => 165830)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-537.75-branch/Source/WebCore/html/parser/HTMLConstructionSite.cpp 2014-03-18 19:16:01 UTC (rev 165829)
+++ branches/safari-537.75-branch/Source/WebCore/html/parser/HTMLConstructionSite.cpp 2014-03-18 19:30:39 UTC (rev 165830)
</span><span class="lines">@@ -86,8 +86,11 @@
</span><span class="cx"> {
</span><span class="cx"> return string.isAllSpecialCharacters<isHTMLSpace>();
</span><span class="cx"> }
</span><del>-
-static inline void insert(HTMLConstructionSiteTask& task)
</del><ins>+// The |lazyAttach| parameter to this function exists for historical reasons.
+// There used to be two code paths, one that used lazyAttach and one that
+// didn't. We should make the two code paths consistent and either use
+// lazyAttach or non-lazyAttach, but we wanted to make that change separately.
+static inline void insert(HTMLConstructionSiteTask& task, bool lazyAttach)
</ins><span class="cx"> {
</span><span class="cx"> #if ENABLE(TEMPLATE_ELEMENT)
</span><span class="cx"> if (task.parent->hasTagName(templateTag))
</span><span class="lines">@@ -105,15 +108,19 @@
</span><span class="cx"> // JavaScript run from beforeload (or DOM Mutation or event handlers)
</span><span class="cx"> // might have removed the child, in which case we should not attach it.
</span><span class="cx">
</span><del>- if (task.child->parentNode() && task.parent->attached() && !task.child->attached())
- task.child->attach();
</del><ins>+ if (task.child->parentNode() && task.parent->attached() && !task.child->attached()) {
+ if (lazyAttach)
+ task.child->lazyAttach();
+ else
+ task.child->attach();
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static inline void executeInsertTask(HTMLConstructionSiteTask& task)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(task.operation == HTMLConstructionSiteTask::Insert);
</span><span class="cx">
</span><del>- insert(task);
</del><ins>+ insert(task, false);
</ins><span class="cx">
</span><span class="cx"> task.child->beginParsingChildren();
</span><span class="cx">
</span><span class="lines">@@ -129,13 +136,16 @@
</span><span class="cx"> parent->parserRemoveChild(task.child.get());
</span><span class="cx">
</span><span class="cx"> task.parent->parserAppendChild(task.child);
</span><ins>+
+ if (task.child->parentElement()->attached() && !task.child->attached())
+ task.child->lazyAttach();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static inline void executeInsertAlreadyParsedChildTask(HTMLConstructionSiteTask& task)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(task.operation == HTMLConstructionSiteTask::InsertAlreadyParsedChild);
</span><span class="cx">
</span><del>- insert(task);
</del><ins>+ insert(task, true);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static inline void executeTakeAllChildrenTask(HTMLConstructionSiteTask& task)
</span></span></pre>
</div>
</div>
</body>
</html>