<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165753] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165753">165753</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2014-03-17 13:33:20 -0700 (Mon, 17 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Provide preference to enable additional AVFoundation options
https://bugs.webkit.org/show_bug.cgi?id=130275
Reviewed by Eric Carlson.
../WebCore:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::doesHaveAttribute): Added.
* html/HTMLMediaElement.h:
* page/Settings.in: Add new attribute.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::doesHaveAttribute): Added stub to call private player object's
implementation of doesHaveAttribute.
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::doesHaveAttribute):
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::AVFWrapper::createAssetForURL): Check the <media> object,
and notify AVFoundationCF to use URI option if relevant.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Check the <media> object,
and notify AVFoundation to use URI option if relevant.
../WebKit/mac:
* WebView/WebPreferenceKeysPrivate.h: Added new preference.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Initialize preference to false.
(-[WebPreferences isInheritURIQueryComponentEnabled]): Added.
(-[WebPreferences setEnableInheritURIQueryComponent:]): Added.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Handle new preference.
../WebKit/win:
* Interfaces/IWebPreferencesPrivate.idl: Added new preference.
* WebPreferenceKeysPrivate.h: Ditto.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Initialize preference to false.
(WebPreferences::isInheritURIQueryComponentEnabled): Added.
(WebPreferences::setEnableInheritURIQueryComponent): Added.
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): Handle new preference.
../WebKit2:
* Shared/WebPreferencesStore.h: Added new preference.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetEnableInheritURIQueryComponent): Added.
(WKPreferencesGetEnableInheritURIQueryComponent): Added.
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Handle new preference.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAttributeNamesin">trunk/Source/WebCore/html/HTMLAttributeNames.in</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementcpp">trunk/Source/WebCore/html/HTMLMediaElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementh">trunk/Source/WebCore/html/HTMLMediaElement.h</a></li>
<li><a href="#trunkSourceWebCorepageSettingsin">trunk/Source/WebCore/page/Settings.in</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsMediaPlayercpp">trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsMediaPlayerh">trunk/Source/WebCore/platform/graphics/MediaPlayer.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationcfAVFoundationCFSoftLinkingh">trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationcfMediaPlayerPrivateAVFoundationCFcpp">trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationobjcMediaPlayerPrivateAVFoundationObjCmm">trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesmm">trunk/Source/WebKit/mac/WebView/WebPreferences.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinInterfacesIWebPreferencesPrivateidl">trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferenceKeysPrivateh">trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferencescpp">trunk/Source/WebKit/win/WebPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferencesh">trunk/Source/WebKit/win/WebPreferences.h</a></li>
<li><a href="#trunkSourceWebKitwinWebViewcpp">trunk/Source/WebKit/win/WebView.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPreferencesStoreh">trunk/Source/WebKit2/Shared/WebPreferencesStore.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencescpp">trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencesPrivateh">trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebCore/ChangeLog 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2014-03-16 Brent Fulgham <bfulgham@apple.com>
+
+ Provide preference to enable additional AVFoundation options
+ https://bugs.webkit.org/show_bug.cgi?id=130275
+
+ Reviewed by Eric Carlson.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::doesHaveAttribute): Added.
+ * html/HTMLMediaElement.h:
+ * page/Settings.in: Add new attribute.
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::doesHaveAttribute): Added stub to call private player object's
+ implementation of doesHaveAttribute.
+ * platform/graphics/MediaPlayer.h:
+ (WebCore::MediaPlayerClient::doesHaveAttribute):
+ * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
+ (WebCore::MediaPlayerPrivateAVFoundationCF::AVFWrapper::createAssetForURL): Check the <media> object,
+ and notify AVFoundationCF to use URI option if relevant.
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Check the <media> object,
+ and notify AVFoundation to use URI option if relevant.
+
</ins><span class="cx"> 2014-03-17 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> [EME] Add NULL protections in SourceBuffer and MediaSource.
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAttributeNamesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAttributeNames.in (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAttributeNames.in 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebCore/html/HTMLAttributeNames.in 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -356,3 +356,4 @@
</span><span class="cx"> webkit-playsinline
</span><span class="cx"> x-webkit-airplay
</span><span class="cx"> x-webkit-wirelessvideoplaybackdisabled
</span><ins>+x-itunes-inherit-uri-query-component
</ins></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -5973,6 +5973,20 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+bool HTMLMediaElement::doesHaveAttribute(const AtomicString& attribute) const
+{
+ QualifiedName attributeName(nullAtom, attribute, nullAtom);
+ if (!fastHasAttribute(attributeName))
+ return false;
+
+ if (Settings* settings = document().settings()) {
+ if (attributeName == HTMLNames::x_itunes_inherit_uri_query_componentAttr)
+ return settings->enableInheritURIQueryComponent();
+ }
+
+ return true;
</ins><span class="cx"> }
</span><ins>+
+}
</ins><span class="cx">
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.h 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -131,6 +131,8 @@
</span><span class="cx"> virtual bool supportsSave() const;
</span><span class="cx"> virtual bool supportsScanning() const override;
</span><span class="cx">
</span><ins>+ virtual bool doesHaveAttribute(const AtomicString&) const override;
+
</ins><span class="cx"> PlatformMedia platformMedia() const;
</span><span class="cx"> PlatformLayer* platformLayer() const;
</span><span class="cx"> #if PLATFORM(IOS)
</span></span></pre></div>
<a id="trunkSourceWebCorepageSettingsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.in (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Settings.in 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebCore/page/Settings.in 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -218,3 +218,5 @@
</span><span class="cx">
</span><span class="cx"> # FIXME: This is unneeded and should be removed.
</span><span class="cx"> alwaysUseBaselineOfPrimaryFont initial=false
</span><ins>+
+enableInheritURIQueryComponent initial=false
</ins></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsMediaPlayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -1404,6 +1404,14 @@
</span><span class="cx"> registerMediaEngine(addMediaEngine);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+bool MediaPlayer::doesHaveAttribute(const AtomicString& attribute) const
+{
+ if (!m_mediaPlayerClient)
+ return false;
+
+ return m_mediaPlayerClient->doesHaveAttribute(attribute);
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+}
+
</ins><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsMediaPlayerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.h (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/MediaPlayer.h 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.h 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -247,6 +247,7 @@
</span><span class="cx"> virtual HostWindow* mediaPlayerHostWindow() { return 0; }
</span><span class="cx"> virtual IntRect mediaPlayerWindowClipRect() { return IntRect(); }
</span><span class="cx"> virtual CachedResourceLoader* mediaPlayerCachedResourceLoader() { return 0; }
</span><ins>+ virtual bool doesHaveAttribute(const AtomicString&) const { return false; }
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><span class="cx"> virtual void mediaPlayerDidAddAudioTrack(PassRefPtr<AudioTrackPrivate>) { }
</span><span class="lines">@@ -262,7 +263,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-
</del><span class="cx"> virtual bool mediaPlayerShouldWaitForResponseToAuthenticationChallenge(const AuthenticationChallenge&) { return false; }
</span><span class="cx"> };
</span><span class="cx">
</span><span class="lines">@@ -298,6 +298,7 @@
</span><span class="cx"> bool supportsSave() const;
</span><span class="cx"> bool supportsScanning() const;
</span><span class="cx"> bool requiresImmediateCompositing() const;
</span><ins>+ bool doesHaveAttribute(const AtomicString&) const;
</ins><span class="cx"> PlatformMedia platformMedia() const;
</span><span class="cx"> PlatformLayer* platformLayer() const;
</span><span class="cx"> #if PLATFORM(IOS)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationcfAVFoundationCFSoftLinkingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -384,4 +384,7 @@
</span><span class="cx"> SOFT_LINK_VARIABLE_DLL_IMPORT(AVFoundationCF, AVCFPlayerItemLegibleOutputTextStylingResolutionSourceAndRulesOnly, const CFStringRef);
</span><span class="cx"> #define AVCFPlayerItemLegibleOutputTextStylingResolutionSourceAndRulesOnly getAVCFPlayerItemLegibleOutputTextStylingResolutionSourceAndRulesOnly()
</span><span class="cx">
</span><ins>+SOFT_LINK_VARIABLE_DLL_IMPORT(AVFoundationCF, AVCFURLAssetInheritURIQueryComponentFromReferencingURIKey, const CFStringRef);
+#define AVCFURLAssetInheritURIQueryComponentFromReferencingURIKey getAVCFURLAssetInheritURIQueryComponentFromReferencingURIKey()
+
</ins><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationcfMediaPlayerPrivateAVFoundationCFcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> /*
</span><del>- * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.
</del><ins>+ * Copyright (C) 2011-2014 Apple Inc. All rights reserved.
</ins><span class="cx"> *
</span><span class="cx"> * Redistribution and use in source and binary forms, with or without
</span><span class="cx"> * modification, are permitted provided that the following conditions
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> void destroyImageGenerator();
</span><span class="cx"> RetainPtr<CGImageRef> createImageForTimeInRect(float, const IntRect&);
</span><span class="cx">
</span><del>- void createAssetForURL(const String& url);
</del><ins>+ void createAssetForURL(const String& url, bool inheritURI);
</ins><span class="cx"> void setAsset(AVCFURLAssetRef);
</span><span class="cx">
</span><span class="cx"> void createPlayer(IDirect3DDevice9*);
</span><span class="lines">@@ -412,8 +412,10 @@
</span><span class="cx">
</span><span class="cx"> setDelayCallbacks(true);
</span><span class="cx">
</span><ins>+ bool inheritURI = player()->doesHaveAttribute("x-itunes-inherit-uri-query-component");
+
</ins><span class="cx"> m_avfWrapper = new AVFWrapper(this);
</span><del>- m_avfWrapper->createAssetForURL(url);
</del><ins>+ m_avfWrapper->createAssetForURL(url, inheritURI);
</ins><span class="cx"> setDelayCallbacks(false);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1324,13 +1326,18 @@
</span><span class="cx"> dispatch_async_f(dispatch_get_main_queue(), context, destroyAVFWrapper);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void AVFWrapper::createAssetForURL(const String& url)
</del><ins>+void AVFWrapper::createAssetForURL(const String& url, bool inheritURI)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(!avAsset());
</span><span class="cx">
</span><span class="cx"> RetainPtr<CFURLRef> urlRef = URL(ParsedURLString, url).createCFURL();
</span><span class="cx">
</span><del>- AVCFURLAssetRef assetRef = AVCFURLAssetCreateWithURLAndOptions(kCFAllocatorDefault, urlRef.get(), 0, m_notificationQueue);
</del><ins>+ RetainPtr<CFMutableDictionaryRef> optionsRef = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
+
+ if (inheritURI)
+ CFDictionarySetValue(optionsRef.get(), AVCFURLAssetInheritURIQueryComponentFromReferencingURIKey, kCFBooleanTrue);
+
+ AVCFURLAssetRef assetRef = AVCFURLAssetCreateWithURLAndOptions(kCFAllocatorDefault, urlRef.get(), optionsRef.get(), m_notificationQueue);
</ins><span class="cx"> m_avAsset = adoptCF(assetRef);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationobjcMediaPlayerPrivateAVFoundationObjCmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -62,6 +62,7 @@
</span><span class="cx"> #import <wtf/CurrentTime.h>
</span><span class="cx"> #import <wtf/Functional.h>
</span><span class="cx"> #import <wtf/text/CString.h>
</span><ins>+#import <wtf/text/StringBuilder.h>
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(AVF_CAPTIONS)
</span><span class="cx"> #include "TextTrack.h"
</span><span class="lines">@@ -132,6 +133,7 @@
</span><span class="cx"> SOFT_LINK_POINTER(AVFoundation, AVMediaTypeVideo, NSString *)
</span><span class="cx"> SOFT_LINK_POINTER(AVFoundation, AVMediaTypeAudio, NSString *)
</span><span class="cx"> SOFT_LINK_POINTER(AVFoundation, AVPlayerItemDidPlayToEndTimeNotification, NSString *)
</span><ins>+SOFT_LINK_POINTER(AVFoundation, AVURLAssetInheritURIQueryComponentFromReferencingURIKey, NSString *)
</ins><span class="cx"> SOFT_LINK_POINTER(AVFoundation, AVAssetImageGeneratorApertureModeCleanAperture, NSString *)
</span><span class="cx"> SOFT_LINK_POINTER(AVFoundation, AVURLAssetReferenceRestrictionsKey, NSString *)
</span><span class="cx"> SOFT_LINK_POINTER(AVFoundation, AVLayerVideoGravityResizeAspect, NSString *)
</span><span class="lines">@@ -153,6 +155,7 @@
</span><span class="cx"> #define AVMediaTypeVideo getAVMediaTypeVideo()
</span><span class="cx"> #define AVMediaTypeAudio getAVMediaTypeAudio()
</span><span class="cx"> #define AVPlayerItemDidPlayToEndTimeNotification getAVPlayerItemDidPlayToEndTimeNotification()
</span><ins>+#define AVURLAssetInheritURIQueryComponentFromReferencingURIKey getAVURLAssetInheritURIQueryComponentFromReferencingURIKey()
</ins><span class="cx"> #define AVAssetImageGeneratorApertureModeCleanAperture getAVAssetImageGeneratorApertureModeCleanAperture()
</span><span class="cx"> #define AVURLAssetReferenceRestrictionsKey getAVURLAssetReferenceRestrictionsKey()
</span><span class="cx"> #define AVLayerVideoGravityResizeAspect getAVLayerVideoGravityResizeAspect()
</span><span class="lines">@@ -610,6 +613,9 @@
</span><span class="cx"> if ([headerFields.get() count])
</span><span class="cx"> [options.get() setObject:headerFields.get() forKey:@"AVURLAssetHTTPHeaderFieldsKey"];
</span><span class="cx">
</span><ins>+ if (player()->doesHaveAttribute("x-itunes-inherit-uri-query-component"))
+ [options.get() setObject: [NSNumber numberWithBool: TRUE] forKey: AVURLAssetInheritURIQueryComponentFromReferencingURIKey];
+
</ins><span class="cx"> #if ENABLE(AVF_CAPTIONS)
</span><span class="cx"> const Vector<RefPtr<PlatformTextTrack>>& outOfBandTrackSources = player()->outOfBandTrackSources();
</span><span class="cx"> if (!outOfBandTrackSources.isEmpty()) {
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-03-16 Brent Fulgham <bfulgham@apple.com>
+
+ Provide preference to enable additional AVFoundation options
+ https://bugs.webkit.org/show_bug.cgi?id=130275
+
+ Reviewed by Eric Carlson.
+
+ * WebView/WebPreferenceKeysPrivate.h: Added new preference.
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]): Initialize preference to false.
+ (-[WebPreferences isInheritURIQueryComponentEnabled]): Added.
+ (-[WebPreferences setEnableInheritURIQueryComponent:]): Added.
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]): Handle new preference.
+
</ins><span class="cx"> 2014-03-16 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove all deprecatedCharacters use from WebKit directory
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -209,3 +209,5 @@
</span><span class="cx"> #define WebKitTextFieldRemoteInspectionEnabledPreferenceKey @"WebKitTextFieldRemoteInspectionEnabled"
</span><span class="cx"> #endif
</span><span class="cx"> #endif
</span><ins>+
+#define WebKitEnableInheritURIQueryComponentPreferenceKey @"WebKitEnableInheritURIQueryComponent"
</ins></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> /*
</span><del>- * Copyright (C) 2005, 2006, 2007, 2011, 2012 Apple Inc. All rights reserved.
</del><ins>+ * Copyright (C) 2005, 2006, 2007, 2011, 2012, 2014 Apple Inc. All rights reserved.
</ins><span class="cx"> * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
</span><span class="cx"> *
</span><span class="cx"> * Redistribution and use in source and binary forms, with or without
</span><span class="lines">@@ -598,6 +598,7 @@
</span><span class="cx"> #if ENABLE(IMAGE_CONTROLS)
</span><span class="cx"> [NSNumber numberWithBool:NO], WebKitImageControlsEnabledPreferenceKey,
</span><span class="cx"> #endif
</span><ins>+ [NSNumber numberWithBool:NO], WebKitEnableInheritURIQueryComponentPreferenceKey,
</ins><span class="cx"> nil];
</span><span class="cx">
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="lines">@@ -2156,6 +2157,16 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (BOOL)isInheritURIQueryComponentEnabled
+{
+ return [self _boolValueForKey: WebKitEnableInheritURIQueryComponentPreferenceKey];
+}
+
+- (void)setEnableInheritURIQueryComponent:(BOOL)flag
+{
+ [self _setBoolValue:flag forKey: WebKitEnableInheritURIQueryComponentPreferenceKey];
+}
+
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> - (BOOL)mediaPlaybackAllowsAirPlay
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -287,6 +287,9 @@
</span><span class="cx"> - (BOOL)mediaPlaybackAllowsAirPlay;
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+- (BOOL)isInheritURIQueryComponentEnabled;
+- (void)setEnableInheritURIQueryComponent:(BOOL)flag;
+
</ins><span class="cx"> // Other private methods
</span><span class="cx"> #if TARGET_OS_IPHONE
</span><span class="cx"> - (size_t)_maximumImageSize;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -2392,6 +2392,8 @@
</span><span class="cx">
</span><span class="cx"> settings.setShouldConvertPositionStyleOnCopy([preferences shouldConvertPositionStyleOnCopy]);
</span><span class="cx">
</span><ins>+ settings.setEnableInheritURIQueryComponent([preferences isInheritURIQueryComponentEnabled]);
+
</ins><span class="cx"> switch ([preferences storageBlockingPolicy]) {
</span><span class="cx"> case WebAllowAllStorage:
</span><span class="cx"> settings.setStorageBlockingPolicy(SecurityOrigin::AllowAllStorage);
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit/win/ChangeLog 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-03-17 Brent Fulgham <bfulgham@apple.com>
+
+ Provide preference to enable additional AVFoundation options
+ https://bugs.webkit.org/show_bug.cgi?id=130275
+
+ Reviewed by Eric Carlson.
+
+ * Interfaces/IWebPreferencesPrivate.idl: Added new preference.
+ * WebPreferenceKeysPrivate.h: Ditto.
+ * WebPreferences.cpp:
+ (WebPreferences::initializeDefaultSettings): Initialize preference to false.
+ (WebPreferences::isInheritURIQueryComponentEnabled): Added.
+ (WebPreferences::setEnableInheritURIQueryComponent): Added.
+ * WebPreferences.h:
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged): Handle new preference.
+
</ins><span class="cx"> 2014-03-16 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove all deprecatedCharacters use from WebKit
</span></span></pre></div>
<a id="trunkSourceWebKitwinInterfacesIWebPreferencesPrivateidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -148,4 +148,7 @@
</span><span class="cx">
</span><span class="cx"> HRESULT screenFontSubstitutionEnabled([out, retval] BOOL* enabled);
</span><span class="cx"> HRESULT setScreenFontSubstitutionEnabled([in] BOOL enabled);
</span><ins>+
+ HRESULT isInheritURIQueryComponentEnabled([out, retval] BOOL* enabled);
+ HRESULT setEnableInheritURIQueryComponent([in] BOOL enabled);
</ins><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -166,3 +166,5 @@
</span><span class="cx"> #define WebKitMockScrollbarsEnabledPreferenceKey "WebKitMockScrollbarsEnabled"
</span><span class="cx">
</span><span class="cx"> #define WebKitScreenFontSubstitutionEnabledPreferenceKey "WebKitScreenFontSubstitutionEnabledPreferenceKey"
</span><ins>+
+#define WebKitEnableInheritURIQueryComponentPreferenceKey "WebKitEnableInheritURIQueryComponent"
</ins></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferences.cpp (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferences.cpp 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit/win/WebPreferences.cpp 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -280,6 +280,8 @@
</span><span class="cx">
</span><span class="cx"> CFDictionaryAddValue(defaults, CFSTR(WebKitFullScreenEnabledPreferenceKey), kCFBooleanFalse);
</span><span class="cx">
</span><ins>+ CFDictionaryAddValue(defaults, CFSTR(WebKitRequestAnimationFrameEnabledPreferenceKey), kCFBooleanFalse);
+
</ins><span class="cx"> defaultSettings = defaults;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1802,3 +1804,14 @@
</span><span class="cx"> return S_OK;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+HRESULT WebPreferences::isInheritURIQueryComponentEnabled(BOOL* enabled)
+{
+ *enabled = boolValueForKey(WebKitEnableInheritURIQueryComponentPreferenceKey);
+ return S_OK;
+}
+
+HRESULT WebPreferences::setEnableInheritURIQueryComponent(BOOL enabled)
+{
+ setBoolValue(WebKitEnableInheritURIQueryComponentPreferenceKey, enabled);
+ return S_OK;
+}
</ins></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferencesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferences.h (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferences.h 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit/win/WebPreferences.h 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -483,6 +483,9 @@
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE screenFontSubstitutionEnabled(BOOL*);
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE setScreenFontSubstitutionEnabled(BOOL);
</span><span class="cx">
</span><ins>+ virtual HRESULT STDMETHODCALLTYPE isInheritURIQueryComponentEnabled(BOOL*);
+ virtual HRESULT STDMETHODCALLTYPE setEnableInheritURIQueryComponent(BOOL);
+
</ins><span class="cx"> // WebPreferences
</span><span class="cx">
</span><span class="cx"> // This method accesses a different preference key than developerExtrasEnabled.
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebView.cpp (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebView.cpp 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit/win/WebView.cpp 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -5052,6 +5052,11 @@
</span><span class="cx"> return hr;
</span><span class="cx"> settings.setMockScrollbarsEnabled(enabled);
</span><span class="cx">
</span><ins>+ hr = prefsPrivate->isInheritURIQueryComponentEnabled(&enabled);
+ if (FAILED(hr))
+ return hr;
+ settings.setEnableInheritURIQueryComponent(enabled);
+
</ins><span class="cx"> hr = prefsPrivate->screenFontSubstitutionEnabled(&enabled);
</span><span class="cx"> if (FAILED(hr))
</span><span class="cx"> return hr;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-03-17 Brent Fulgham <bfulgham@apple.com>
+
+ Provide preference to enable additional AVFoundation options
+ https://bugs.webkit.org/show_bug.cgi?id=130275
+
+ Reviewed by Eric Carlson.
+
+ * Shared/WebPreferencesStore.h: Added new preference.
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetEnableInheritURIQueryComponent): Added.
+ (WKPreferencesGetEnableInheritURIQueryComponent): Added.
+ * UIProcess/API/C/WKPreferencesPrivate.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences): Handle new preference.
+
</ins><span class="cx"> 2014-03-17 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac] getAttributedSubstringFromRange arguments are incorrectly named
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPreferencesStoreh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -214,6 +214,7 @@
</span><span class="cx"> macro(AlwaysUseAcceleratedOverflowScroll, alwaysUseAcceleratedOverflowScroll, Bool, bool, false) \
</span><span class="cx"> macro(PasswordEchoEnabled, passwordEchoEnabled, Bool, bool, DEFAULT_PASSWORD_ECHO_ENABLED) \
</span><span class="cx"> macro(ImageControlsEnabled, imageControlsEnabled, Bool, bool, false) \
</span><ins>+ macro(EnableInheritURIQueryComponent, enableInheritURIQueryComponent, Bool, bool, false) \
</ins><span class="cx">
</span><span class="cx"> #define FOR_EACH_WEBKIT_DOUBLE_PREFERENCE(macro) \
</span><span class="cx"> macro(PDFScaleFactor, pdfScaleFactor, Double, double, 0) \
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -1255,3 +1255,13 @@
</span><span class="cx"> {
</span><span class="cx"> return toImpl(preferencesRef)->telephoneNumberParsingEnabled();
</span><span class="cx"> }
</span><ins>+
+void WKPreferencesSetEnableInheritURIQueryComponent(WKPreferencesRef preferencesRef, bool enabled)
+{
+ toImpl(preferencesRef)->setEnableInheritURIQueryComponent(enabled);
+}
+
+bool WKPreferencesGetEnableInheritURIQueryComponent(WKPreferencesRef preferencesRef)
+{
+ return toImpl(preferencesRef)->enableInheritURIQueryComponent();
+}
</ins></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> /*
</span><del>- * Copyright (C) 2010 Apple Inc. All rights reserved.
</del><ins>+ * Copyright (C) 2010, 2014 Apple Inc. All rights reserved.
</ins><span class="cx"> *
</span><span class="cx"> * Redistribution and use in source and binary forms, with or without
</span><span class="cx"> * modification, are permitted provided that the following conditions
</span><span class="lines">@@ -322,6 +322,10 @@
</span><span class="cx"> WK_EXPORT void WKPreferencesSetTelephoneNumberParsingEnabled(WKPreferencesRef preferencesRef, bool enabled);
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetTelephoneNumberParsingEnabled(WKPreferencesRef preferencesRef);
</span><span class="cx">
</span><ins>+// Default to false.
+WK_EXPORT void WKPreferencesSetEnableInheritURIQueryComponent(WKPreferencesRef preferencesRef, bool enabled);
+WK_EXPORT bool WKPreferencesGetEnableInheritURIQueryComponent(WKPreferencesRef preferencesRef);
+
</ins><span class="cx"> #ifdef __cplusplus
</span><span class="cx"> }
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (165752 => 165753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-03-17 20:32:10 UTC (rev 165752)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-03-17 20:33:20 UTC (rev 165753)
</span><span class="lines">@@ -2638,6 +2638,8 @@
</span><span class="cx"> settings.setLayoutInterval(std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::duration<double>(store.getDoubleValueForKey(WebPreferencesKey::layoutIntervalKey()))));
</span><span class="cx"> settings.setMaxParseDuration(store.getDoubleValueForKey(WebPreferencesKey::maxParseDurationKey()));
</span><span class="cx">
</span><ins>+ settings.setEnableInheritURIQueryComponent(store.getBoolValueForKey(WebPreferencesKey::enableInheritURIQueryComponentKey()));
+
</ins><span class="cx"> if (store.getBoolValueForKey(WebPreferencesKey::pageVisibilityBasedProcessSuppressionEnabledKey()))
</span><span class="cx"> m_processSuppressionDisabledByWebPreference.stop();
</span><span class="cx"> else
</span></span></pre>
</div>
</div>
</body>
</html>