<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165602] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165602">165602</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-03-13 22:54:11 -0700 (Thu, 13 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Scroll size is not recalculated when absolute left of child is updated
https://bugs.webkit.org/show_bug.cgi?id=123958
Patch by Manish R Gurnaney <m.gurnaney@samsung.com> on 2014-03-13
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/css/display-inline-block-scrollbar.html
Actual issue was that whenever there is the content change in the
RenderBlock having inline-block children, The InlineFlowBox while
computing overflow never resets previous value.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeOverflow):
Added code to clear overflow when we start computing overflow for
InlineFlowBox. So as to ScrollSize can be recalculated properly.
LayoutTests:
* fast/css/display-inline-block-scrollbar-expected.txt: Added.
* fast/css/display-inline-block-scrollbar.html: Added.
Added test case to check that scroll size is recalculated when absolute
left of child is updated.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingInlineFlowBoxcpp">trunk/Source/WebCore/rendering/InlineFlowBox.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssdisplayinlineblockscrollbarexpectedtxt">trunk/LayoutTests/fast/css/display-inline-block-scrollbar-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssdisplayinlineblockscrollbarhtml">trunk/LayoutTests/fast/css/display-inline-block-scrollbar.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (165601 => 165602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-03-14 05:19:02 UTC (rev 165601)
+++ trunk/LayoutTests/ChangeLog 2014-03-14 05:54:11 UTC (rev 165602)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-03-13 Manish R Gurnaney <m.gurnaney@samsung.com>
+
+ Scroll size is not recalculated when absolute left of child is updated
+ https://bugs.webkit.org/show_bug.cgi?id=123958
+
+ Reviewed by Simon Fraser.
+
+ * fast/css/display-inline-block-scrollbar-expected.txt: Added.
+ * fast/css/display-inline-block-scrollbar.html: Added.
+ Added test case to check that scroll size is recalculated when absolute
+ left of child is updated.
+
</ins><span class="cx"> 2014-03-13 Dirk Schulze <krit@webkit.org>
</span><span class="cx">
</span><span class="cx"> [SVG2] support paint-order presentation attribute
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssdisplayinlineblockscrollbarexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/display-inline-block-scrollbar-expected.txt (0 => 165602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/display-inline-block-scrollbar-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/display-inline-block-scrollbar-expected.txt 2014-03-14 05:54:11 UTC (rev 165602)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+Tests that the div element with id=scrollable scroll width is 250.
+
+ PASS
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/css/display-inline-block-scrollbar-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
<a id="trunkLayoutTestsfastcssdisplayinlineblockscrollbarhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/display-inline-block-scrollbar.html (0 => 165602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/display-inline-block-scrollbar.html (rev 0)
+++ trunk/LayoutTests/fast/css/display-inline-block-scrollbar.html 2014-03-14 05:54:11 UTC (rev 165602)
</span><span class="lines">@@ -0,0 +1,62 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <script src="../../resources/check-layout.js"></script>
+ <script>
+ if (window.testRunner)
+ testRunner.waitUntilDone();
+
+ function runTest() {
+ document.getElementById("container").style.width="110%";
+ document.getElementById("margin").style.left="200px";
+ document.getElementById("container").style.width="100%";
+ setTimeout( function() {
+ document.getElementById("margin").style.left="12px";
+ window.checkLayout("#scrollable",document.getElementById("output"));
+ if (window.testRunner)
+ testRunner.notifyDone();
+ },0);
+ }
+ </script>
+ <style>
+ #spacer {
+ width: 100px;
+ height: 100px;
+ background: blue;
+ }
+ #scrollable {
+ background: white;
+ border: 1px solid black;
+ overflow: auto;
+ position: relative;
+ width: 250px;
+ }
+ #container {
+ position:relative;
+ display:inline-block;
+ width:100%;
+ height:130px;
+ }
+ #margin {
+ position: absolute;
+ width: 200px;
+ top: 12px;
+ margin-right: 12px;
+ left: 12px;
+ height: 110px;
+ }
+ </style>
+ </head>
+ <body onload="runTest();">
+ <p>Tests that the div element with id=scrollable scroll width is 250.</p>
+ <div id="scrollable" data-expected-scroll-width="250">
+ <div id="container" style="width: 100%;">
+ <div id="margin" style="left: 12px;">
+ <div id="spacer" style="height: 100px; width: 100%;">
+ </div>
+ </div>
+ </div>
+ </div>
+ <div id="output"></div>
+ </body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span><span class="cx">Property changes on: trunk/LayoutTests/fast/css/display-inline-block-scrollbar.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (165601 => 165602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-14 05:19:02 UTC (rev 165601)
+++ trunk/Source/WebCore/ChangeLog 2014-03-14 05:54:11 UTC (rev 165602)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-03-13 Manish R Gurnaney <m.gurnaney@samsung.com>
+
+ Scroll size is not recalculated when absolute left of child is updated
+ https://bugs.webkit.org/show_bug.cgi?id=123958
+
+ Reviewed by Simon Fraser.
+
+ Test: fast/css/display-inline-block-scrollbar.html
+ Actual issue was that whenever there is the content change in the
+ RenderBlock having inline-block children, The InlineFlowBox while
+ computing overflow never resets previous value.
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::computeOverflow):
+ Added code to clear overflow when we start computing overflow for
+ InlineFlowBox. So as to ScrollSize can be recalculated properly.
+
</ins><span class="cx"> 2014-03-13 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Pass const RenderStyle& to box decoration functions.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingInlineFlowBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/InlineFlowBox.cpp (165601 => 165602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/InlineFlowBox.cpp 2014-03-14 05:19:02 UTC (rev 165601)
+++ trunk/Source/WebCore/rendering/InlineFlowBox.cpp 2014-03-14 05:54:11 UTC (rev 165602)
</span><span class="lines">@@ -938,6 +938,9 @@
</span><span class="cx"> if (knownToHaveNoOverflow())
</span><span class="cx"> return;
</span><span class="cx">
</span><ins>+ if (m_overflow)
+ m_overflow.clear();
+
</ins><span class="cx"> // Visual overflow just includes overflow for stuff we need to repaint ourselves. Self-painting layers are ignored.
</span><span class="cx"> // Layout overflow is used to determine scrolling extent, so it still includes child layers and also factors in
</span><span class="cx"> // transforms, relative positioning, etc.
</span></span></pre>
</div>
</div>
</body>
</html>