<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165597] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165597">165597</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-03-13 19:49:04 -0700 (Thu, 13 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: AXI: Use loc strings for known aria-invalid types
https://bugs.webkit.org/show_bug.cgi?id=129952
Patch by James Craig <jcraig@apple.com> on 2014-03-13
Reviewed by Joseph Pecoraro.
Source/WebCore:
Updating inspector-protocol enum and UI display values for @aria-invalid.
Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
* inspector/InspectorDOMAgent.cpp: Enum for DOM.AccessibilityPropertiesInvalid
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
* inspector/protocol/DOM.json: Enum for DOM.AccessibilityPropertiesInvalid
Source/WebInspectorUI:
Updating inspector-protocol and UI display values for @aria-invalid.
Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
* Localizations/en.lproj/localizedStrings.js: "Grammar" and "Spelling" value strings.
* UserInterface/Protocol/InspectorWebBackendCommands.js: New enum for DOM.AccessibilityPropertiesInvalid
* UserInterface/Views/DOMNodeDetailsSidebarPanel.js: Use enum instead of passing value through directly.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMAgentcpp">trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorprotocolDOMjson">trunk/Source/WebCore/inspector/protocol/DOM.json</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolInspectorWebBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorWebBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMNodeDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (165596 => 165597)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-14 02:31:25 UTC (rev 165596)
+++ trunk/Source/WebCore/ChangeLog 2014-03-14 02:49:04 UTC (rev 165597)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-03-13 James Craig <jcraig@apple.com>
+
+ Web Inspector: AXI: Use loc strings for known aria-invalid types
+ https://bugs.webkit.org/show_bug.cgi?id=129952
+
+ Reviewed by Joseph Pecoraro.
+
+ Updating inspector-protocol enum and UI display values for @aria-invalid.
+
+ Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
+
+ * inspector/InspectorDOMAgent.cpp: Enum for DOM.AccessibilityPropertiesInvalid
+ (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
+ * inspector/protocol/DOM.json: Enum for DOM.AccessibilityPropertiesInvalid
+
</ins><span class="cx"> 2014-03-13 Dirk Schulze <krit@webkit.org>
</span><span class="cx">
</span><span class="cx"> [SVG2] support paint-order presentation attribute
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (165596 => 165597)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2014-03-14 02:31:25 UTC (rev 165596)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2014-03-14 02:49:04 UTC (rev 165597)
</span><span class="lines">@@ -1421,7 +1421,7 @@
</span><span class="cx"> bool focused = false;
</span><span class="cx"> bool ignored = true;
</span><span class="cx"> bool ignoredByDefault = false;
</span><del>- String invalid = "false"; // String values: true, false, spelling, grammar, etc.
</del><ins>+ TypeBuilder::DOM::AccessibilityProperties::Invalid::Enum invalid = TypeBuilder::DOM::AccessibilityProperties::Invalid::False;
</ins><span class="cx"> bool hidden = false;
</span><span class="cx"> String label; // FIXME: Waiting on http://webkit.org/b/121134
</span><span class="cx"> bool pressed = false;
</span><span class="lines">@@ -1462,8 +1462,17 @@
</span><span class="cx">
</span><span class="cx"> ignored = axObject->accessibilityIsIgnored();
</span><span class="cx"> ignoredByDefault = axObject->accessibilityIsIgnoredByDefault();
</span><del>- invalid = axObject->invalidStatus();
</del><span class="cx">
</span><ins>+ String invalidValue = axObject->invalidStatus();
+ if (invalidValue == "false")
+ invalid = TypeBuilder::DOM::AccessibilityProperties::Invalid::False;
+ else if (invalidValue == "grammar")
+ invalid = TypeBuilder::DOM::AccessibilityProperties::Invalid::Grammar;
+ else if (invalidValue == "spelling")
+ invalid = TypeBuilder::DOM::AccessibilityProperties::Invalid::Spelling;
+ else // Future versions of ARIA may allow additional truthy values. Ex. format, order, or size.
+ invalid = TypeBuilder::DOM::AccessibilityProperties::Invalid::True;
+
</ins><span class="cx"> if (axObject->isARIAHidden() || axObject->isDOMHidden())
</span><span class="cx"> hidden = true;
</span><span class="cx">
</span><span class="lines">@@ -1502,7 +1511,7 @@
</span><span class="cx"> value->setIgnored(ignored);
</span><span class="cx"> if (ignoredByDefault)
</span><span class="cx"> value->setIgnoredByDefault(ignoredByDefault);
</span><del>- if (invalid != "false")
</del><ins>+ if (invalid != TypeBuilder::DOM::AccessibilityProperties::Invalid::False)
</ins><span class="cx"> value->setInvalid(invalid);
</span><span class="cx"> if (hidden)
</span><span class="cx"> value->setHidden(hidden);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorprotocolDOMjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/protocol/DOM.json (165596 => 165597)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/protocol/DOM.json 2014-03-14 02:31:25 UTC (rev 165596)
+++ trunk/Source/WebCore/inspector/protocol/DOM.json 2014-03-14 02:49:04 UTC (rev 165597)
</span><span class="lines">@@ -66,7 +66,7 @@
</span><span class="cx"> { "name": "focused", "type": "boolean", "optional": true, "description": "Focused state. Only defined on focusable elements." },
</span><span class="cx"> { "name": "ignored", "type": "boolean", "optional": true, "description": "Indicates whether the accessibility of the associated AX object node is ignored, whether heuristically or explicitly." },
</span><span class="cx"> { "name": "ignoredByDefault", "type": "boolean", "optional": true, "description": "State indicating whether the accessibility of the associated AX object node is ignored by default for node type." },
</span><del>- { "name": "invalid", "type": "string", "optional": true, "description": "Invalid status of form controls: true, false, grammar, spelling." },
</del><ins>+ { "name": "invalid", "type": "string", "optional": true, "enum": ["true", "false", "grammar", "spelling"], "description": "Invalid status of form controls." },
</ins><span class="cx"> { "name": "hidden", "type": "boolean", "optional": true, "description": "Hidden state. True if node or an ancestor is hidden via CSS or explicit @aria-hidden, to clarify why the element is ignored." },
</span><span class="cx"> { "name": "label", "type": "string", "description": "Computed label value for the node, sometimes calculated by referencing other nodes." },
</span><span class="cx"> { "name": "nodeId", "$ref": "NodeId", "description": "Target <code>DOMNode</code> id." },
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (165596 => 165597)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-03-14 02:31:25 UTC (rev 165596)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-03-14 02:49:04 UTC (rev 165597)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-03-13 James Craig <jcraig@apple.com>
+
+ Web Inspector: AXI: Use loc strings for known aria-invalid types
+ https://bugs.webkit.org/show_bug.cgi?id=129952
+
+ Reviewed by Joseph Pecoraro.
+
+ Updating inspector-protocol and UI display values for @aria-invalid.
+
+ Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
+
+ * Localizations/en.lproj/localizedStrings.js: "Grammar" and "Spelling" value strings.
+ * UserInterface/Protocol/InspectorWebBackendCommands.js: New enum for DOM.AccessibilityPropertiesInvalid
+ * UserInterface/Views/DOMNodeDetailsSidebarPanel.js: Use enum instead of passing value through directly.
+
</ins><span class="cx"> 2014-03-13 Diego Pino Garcia <dpino@igalia.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: AXI: Expose focused/focusable state in the Accessibility Node Inspector
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (165596 => 165597)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2014-03-14 02:31:25 UTC (rev 165596)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2014-03-14 02:49:04 UTC (rev 165597)
</span><span class="lines">@@ -201,6 +201,7 @@
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " F u l l U R L " ] = " F u l l U R L " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " F u n c t i o n " ] = " F u n c t i o n " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " G l o b a l V a r i a b l e s " ] = " G l o b a l V a r i a b l e s " ;
</span><ins>+ l o c a l i z e d S t r i n g s [ " G r a m m a r " ] = " G r a m m a r " ;
</ins><span class="cx"> l o c a l i z e d S t r i n g s [ " H T M L A t t r i b u t e s " ] = " H T M L A t t r i b u t e s " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " H T T P " ] = " H T T P " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " H e i g h t " ] = " H e i g h t " ;
</span><span class="lines">@@ -380,6 +381,7 @@
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " S o c k e t " ] = " S o c k e t " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " S o c k e t s " ] = " S o c k e t s " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " S o u r c e C o d e " ] = " S o u r c e C o d e " ;
</span><ins>+ l o c a l i z e d S t r i n g s [ " S p e l l i n g " ] = " S p e l l i n g " ;
</ins><span class="cx"> l o c a l i z e d S t r i n g s [ " S t a r t J a v a S c r i p t p r o f i l i n g . " ] = " S t a r t J a v a S c r i p t p r o f i l i n g . " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " S t a r t R e c o r d i n g " ] = " S t a r t R e c o r d i n g " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " S t a r t T i m e " ] = " S t a r t T i m e " ;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolInspectorWebBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorWebBackendCommands.js (165596 => 165597)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorWebBackendCommands.js 2014-03-14 02:31:25 UTC (rev 165596)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorWebBackendCommands.js 2014-03-14 02:49:04 UTC (rev 165597)
</span><span class="lines">@@ -66,6 +66,7 @@
</span><span class="cx"> // DOM.
</span><span class="cx"> InspectorBackend.registerDOMDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "DOM");
</span><span class="cx"> InspectorBackend.registerEnum("DOM.AccessibilityPropertiesChecked", {True: "true", False: "false", Mixed: "mixed"});
</span><ins>+InspectorBackend.registerEnum("DOM.AccessibilityPropertiesInvalid", {True: "true", False: "false", Grammar: "grammar", Spelling: "spelling"});
</ins><span class="cx"> InspectorBackend.registerEvent("DOM.documentUpdated", []);
</span><span class="cx"> InspectorBackend.registerEvent("DOM.setChildNodes", ["parentId", "nodes"]);
</span><span class="cx"> InspectorBackend.registerEvent("DOM.attributeModified", ["nodeId", "name", "value"]);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMNodeDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js (165596 => 165597)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2014-03-14 02:31:25 UTC (rev 165596)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2014-03-14 02:49:04 UTC (rev 165597)
</span><span class="lines">@@ -302,7 +302,13 @@
</span><span class="cx"> ignored = WebInspector.UIString("%s (default)").format(ignored);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- var invalid = accessibilityProperties.invalid ? accessibilityProperties.invalid : "";
</del><ins>+ var invalid = "";
+ if (accessibilityProperties.invalid === DOMAgent.AccessibilityPropertiesInvalid.True)
+ invalid = WebInspector.UIString("Yes");
+ else if (accessibilityProperties.invalid === DOMAgent.AccessibilityPropertiesInvalid.Grammar)
+ invalid = WebInspector.UIString("Grammar");
+ else if (accessibilityProperties.invalid === DOMAgent.AccessibilityPropertiesInvalid.Spelling)
+ invalid = WebInspector.UIString("Spelling");
</ins><span class="cx">
</span><span class="cx"> // FIXME: label will always come back as empty. Blocked by http://webkit.org/b/121134
</span><span class="cx"> var label = accessibilityProperties.label;
</span></span></pre>
</div>
</div>
</body>
</html>