<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165395] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165395">165395</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-03-10 12:56:38 -0700 (Mon, 10 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>ASSERTION FAILED: span >= 1
https://bugs.webkit.org/show_bug.cgi?id=129148
Patch by Zsolt Borbely <borbezs@inf.u-szeged.hu> on 2014-03-10
Reviewed by Andreas Kling.
Source/WebCore:
Set the value of span to 1 if the given number is too big or zero.
Test: fast/table/incorrect-colgroup-span-values.html
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::parseAttribute):
LayoutTests:
Added test demonstrates the behavior of colgroup in case of large negative, large positive, zero and null span values.
* fast/table/incorrect-colgroup-span-values-expected.txt: Added.
* fast/table/incorrect-colgroup-span-values.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableColElementcpp">trunk/Source/WebCore/html/HTMLTableColElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasttableincorrectcolgroupspanvaluesexpectedtxt">trunk/LayoutTests/fast/table/incorrect-colgroup-span-values-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasttableincorrectcolgroupspanvalueshtml">trunk/LayoutTests/fast/table/incorrect-colgroup-span-values.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (165394 => 165395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-03-10 19:28:54 UTC (rev 165394)
+++ trunk/LayoutTests/ChangeLog 2014-03-10 19:56:38 UTC (rev 165395)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-03-10 Zsolt Borbely <borbezs@inf.u-szeged.hu>
+
+ ASSERTION FAILED: span >= 1
+ https://bugs.webkit.org/show_bug.cgi?id=129148
+
+ Reviewed by Andreas Kling.
+
+ Added test demonstrates the behavior of colgroup in case of large negative, large positive, zero and null span values.
+
+ * fast/table/incorrect-colgroup-span-values-expected.txt: Added.
+ * fast/table/incorrect-colgroup-span-values.html: Added.
+
</ins><span class="cx"> 2014-03-10 Radu Stavila <stavila@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSS Regions] Hit-testing is not working properly inside scrollable regions
</span></span></pre></div>
<a id="trunkLayoutTestsfasttableincorrectcolgroupspanvaluesexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/table/incorrect-colgroup-span-values-expected.txt (0 => 165395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/table/incorrect-colgroup-span-values-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/table/incorrect-colgroup-span-values-expected.txt 2014-03-10 19:56:38 UTC (rev 165395)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+This test passes if it does not crash.
+
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfasttableincorrectcolgroupspanvalueshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/table/incorrect-colgroup-span-values.html (0 => 165395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/table/incorrect-colgroup-span-values.html (rev 0)
+++ trunk/LayoutTests/fast/table/incorrect-colgroup-span-values.html 2014-03-10 19:56:38 UTC (rev 165395)
</span><span class="lines">@@ -0,0 +1,36 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+ function removeSpan() {
+ document.getElementById("colGroup").removeAttribute("span");
+ }
+ </script>
+ </head>
+ <body onload="removeSpan()">
+ <p>This test passes if it does not crash.</p>
+ <table>
+ <colgroup id="colGroup" span="10000000000">
+ <th></th>
+ </colgroup>
+ </table>
+ <table>
+ <colgroup span="0">
+ <th></th>
+ </colgroup>
+ </table>
+ <table>
+ <colgroup span="10000000000">
+ <th></th>
+ </colgroup>
+ </table>
+ <table>
+ <colgroup span="-10000000000">
+ <th></th>
+ </colgroup>
+ </table>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (165394 => 165395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-10 19:28:54 UTC (rev 165394)
+++ trunk/Source/WebCore/ChangeLog 2014-03-10 19:56:38 UTC (rev 165395)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-03-10 Zsolt Borbely <borbezs@inf.u-szeged.hu>
+
+ ASSERTION FAILED: span >= 1
+ https://bugs.webkit.org/show_bug.cgi?id=129148
+
+ Reviewed by Andreas Kling.
+
+ Set the value of span to 1 if the given number is too big or zero.
+
+ Test: fast/table/incorrect-colgroup-span-values.html
+
+ * html/HTMLTableColElement.cpp:
+ (WebCore::HTMLTableColElement::parseAttribute):
+
</ins><span class="cx"> 2014-03-10 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableColElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableColElement.cpp (165394 => 165395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableColElement.cpp 2014-03-10 19:28:54 UTC (rev 165394)
+++ trunk/Source/WebCore/html/HTMLTableColElement.cpp 2014-03-10 19:56:38 UTC (rev 165395)
</span><span class="lines">@@ -65,7 +65,8 @@
</span><span class="cx"> void HTMLTableColElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
</span><span class="cx"> {
</span><span class="cx"> if (name == spanAttr) {
</span><del>- m_span = !value.isNull() ? value.toInt() : 1;
</del><ins>+ int newSpan = value.toInt();
+ m_span = newSpan ? newSpan : 1;
</ins><span class="cx"> if (renderer() && renderer()->isRenderTableCol())
</span><span class="cx"> renderer()->updateFromElement();
</span><span class="cx"> } else if (name == widthAttr) {
</span></span></pre>
</div>
</div>
</body>
</html>