<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165185] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165185">165185</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-03-06 05:28:03 -0800 (Thu, 06 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/158254">r158254</a>): Rubber-banding at Bing image search causes the toolbar to move up and away
https://bugs.webkit.org/show_bug.cgi?id=128873
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2014-03-06
Reviewed by Antonio Gomes.
Source/WebCore:
This regression is caused by http://trac.webkit.org/changeset/154614
and http://trac.webkit.org/changeset/156605. So reverting the changes
to make it Web compatible as earlier.
* dom/Element.cpp:
(WebCore::Element::scrollLeft):
(WebCore::Element::scrollTop):
(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):
Reverting changes as it caused regression.
LayoutTests:
* fast/css/zoom-body-scroll-expected.txt:
* fast/css/zoom-body-scroll.html:
* fast/dom/Element/documentElement-scrollLeft-expected.txt:
* fast/dom/Element/documentElement-scrollLeft.html:
* fast/dom/Element/documentElement-scrollTop-expected.txt:
* fast/dom/Element/documentElement-scrollTop.html:
* fast/dom/Element/scrollLeft-expected.txt:
* fast/dom/Element/scrollLeft.html:
* fast/dom/Element/scrollTop-expected.txt:
* fast/dom/Element/scrollTop.html:
* fast/events/mouse-cursor.html:
* fast/multicol/scrolling-overflow.html:
* http/tests/navigation/anchor-frames-expected.txt:
* http/tests/navigation/anchor-frames-gbk-expected.txt:
* http/tests/navigation/resources/frame-with-anchor-gbk.html:
* http/tests/navigation/resources/frame-with-anchor-same-origin.html:
* http/tests/navigation/resources/frame-with-anchor.html:
* platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html:
* platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html:
Reverting changes as it caused regression.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastcsszoombodyscrollexpectedtxt">trunk/LayoutTests/fast/css/zoom-body-scroll-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcsszoombodyscrollhtml">trunk/LayoutTests/fast/css/zoom-body-scroll.html</a></li>
<li><a href="#trunkLayoutTestsfastdomElementdocumentElementscrollLeftexpectedtxt">trunk/LayoutTests/fast/dom/Element/documentElement-scrollLeft-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomElementdocumentElementscrollLefthtml">trunk/LayoutTests/fast/dom/Element/documentElement-scrollLeft.html</a></li>
<li><a href="#trunkLayoutTestsfastdomElementdocumentElementscrollTopexpectedtxt">trunk/LayoutTests/fast/dom/Element/documentElement-scrollTop-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomElementdocumentElementscrollTophtml">trunk/LayoutTests/fast/dom/Element/documentElement-scrollTop.html</a></li>
<li><a href="#trunkLayoutTestsfastdomElementscrollLeftexpectedtxt">trunk/LayoutTests/fast/dom/Element/scrollLeft-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomElementscrollLefthtml">trunk/LayoutTests/fast/dom/Element/scrollLeft.html</a></li>
<li><a href="#trunkLayoutTestsfastdomElementscrollTopexpectedtxt">trunk/LayoutTests/fast/dom/Element/scrollTop-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomElementscrollTophtml">trunk/LayoutTests/fast/dom/Element/scrollTop.html</a></li>
<li><a href="#trunkLayoutTestsfasteventsmousecursorhtml">trunk/LayoutTests/fast/events/mouse-cursor.html</a></li>
<li><a href="#trunkLayoutTestsfastmulticolscrollingoverflowhtml">trunk/LayoutTests/fast/multicol/scrolling-overflow.html</a></li>
<li><a href="#trunkLayoutTestshttptestsnavigationanchorframesexpectedtxt">trunk/LayoutTests/http/tests/navigation/anchor-frames-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestsnavigationanchorframesgbkexpectedtxt">trunk/LayoutTests/http/tests/navigation/anchor-frames-gbk-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestsnavigationresourcesframewithanchorgbkhtml">trunk/LayoutTests/http/tests/navigation/resources/frame-with-anchor-gbk.html</a></li>
<li><a href="#trunkLayoutTestshttptestsnavigationresourcesframewithanchorsameoriginhtml">trunk/LayoutTests/http/tests/navigation/resources/frame-with-anchor-same-origin.html</a></li>
<li><a href="#trunkLayoutTestshttptestsnavigationresourcesframewithanchorhtml">trunk/LayoutTests/http/tests/navigation/resources/frame-with-anchor.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2tileddrawingresourcesscrollandloadpagehtml">trunk/LayoutTests/platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2tileddrawingtileddrawingscrollpositionpagecacherestorationhtml">trunk/LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/ChangeLog 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2014-03-06 Gurpreet Kaur <k.gurpreet@samsung.com>
+
+ REGRESSION (r158254): Rubber-banding at Bing image search causes the toolbar to move up and away
+ https://bugs.webkit.org/show_bug.cgi?id=128873
+
+ Reviewed by Antonio Gomes.
+
+ * fast/css/zoom-body-scroll-expected.txt:
+ * fast/css/zoom-body-scroll.html:
+ * fast/dom/Element/documentElement-scrollLeft-expected.txt:
+ * fast/dom/Element/documentElement-scrollLeft.html:
+ * fast/dom/Element/documentElement-scrollTop-expected.txt:
+ * fast/dom/Element/documentElement-scrollTop.html:
+ * fast/dom/Element/scrollLeft-expected.txt:
+ * fast/dom/Element/scrollLeft.html:
+ * fast/dom/Element/scrollTop-expected.txt:
+ * fast/dom/Element/scrollTop.html:
+ * fast/events/mouse-cursor.html:
+ * fast/multicol/scrolling-overflow.html:
+ * http/tests/navigation/anchor-frames-expected.txt:
+ * http/tests/navigation/anchor-frames-gbk-expected.txt:
+ * http/tests/navigation/resources/frame-with-anchor-gbk.html:
+ * http/tests/navigation/resources/frame-with-anchor-same-origin.html:
+ * http/tests/navigation/resources/frame-with-anchor.html:
+ * platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html:
+ * platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html:
+ Reverting changes as it caused regression.
+
</ins><span class="cx"> 2014-03-05 Jinwoo Song <jinwoo7.song@samsung.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed EFL gardening.
</span></span></pre></div>
<a id="trunkLayoutTestsfastcsszoombodyscrollexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/zoom-body-scroll-expected.txt (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/zoom-body-scroll-expected.txt 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/fast/css/zoom-body-scroll-expected.txt 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -9,7 +9,7 @@
</span><span class="cx"> Zooming in
</span><span class="cx"> scrollHeight: 1000
</span><span class="cx"> scrollWidth: 1000
</span><del>-scrollTop: 100
</del><ins>+scrollTop: 0
</ins><span class="cx"> scrollLeft: 50
</span><span class="cx">
</span><span class="cx"> Scrolling down to 100
</span></span></pre></div>
<a id="trunkLayoutTestsfastcsszoombodyscrollhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/zoom-body-scroll.html (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/zoom-body-scroll.html 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/fast/css/zoom-body-scroll.html 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> <html>
</span><del>-<body onload="bodyScroll()">
</del><ins>+<body>
</ins><span class="cx"> <div style="width: 1000px; height: 1000px; position: absolute; top: 0; left: 0;"></div>
</span><span class="cx"> <div style="width: 100px; height: 100px; position: absolute; top: 100px; left: 0; background: green"></div>
</span><span class="cx"> <p>
</span><span class="lines">@@ -14,35 +14,32 @@
</span><span class="cx"> console.appendChild(document.createTextNode(message + "\n"));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- function bodyScroll() {
- if (window.testRunner) {
- testRunner.dumpAsText();
- var body = document.body;
- window.scrollTo(50,100);
- log("scrollHeight: " + body.scrollHeight);
- log("scrollWidth: " + body.scrollWidth);
</del><ins>+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ var body = document.body;
+ log("scrollHeight: " + body.scrollHeight);
+ log("scrollWidth: " + body.scrollWidth);
</ins><span class="cx">
</span><del>- log("\nScrolling right to 50");
- body.scrollLeft = 50;
- log("scrollLeft: " + body.scrollLeft);
</del><ins>+ log("\nScrolling right to 50");
+ body.scrollLeft = 50;
+ log("scrollLeft: " + body.scrollLeft);
</ins><span class="cx">
</span><del>- log("\nZooming in");
- eventSender.zoomPageIn();
- log("scrollHeight: " + body.scrollHeight);
- log("scrollWidth: " + body.scrollWidth);
- log("scrollTop: " + body.scrollTop);
- log("scrollLeft: " + body.scrollLeft);
</del><ins>+ log("\nZooming in");
+ eventSender.zoomPageIn();
+ log("scrollHeight: " + body.scrollHeight);
+ log("scrollWidth: " + body.scrollWidth);
+ log("scrollTop: " + body.scrollTop);
+ log("scrollLeft: " + body.scrollLeft);
</ins><span class="cx">
</span><del>- log("\nScrolling down to 100");
- body.scrollTop = 100;
- log("scrollTop: " + body.scrollTop);
</del><ins>+ log("\nScrolling down to 100");
+ body.scrollTop = 100;
+ log("scrollTop: " + body.scrollTop);
</ins><span class="cx">
</span><del>- log("\nZooming back out");
- eventSender.zoomPageOut();
- log("scrollTop: " + body.scrollTop);
- log("scrollLeft: " + body.scrollLeft);
- }
- }
</del><ins>+ log("\nZooming back out");
+ eventSender.zoomPageOut();
+ log("scrollTop: " + body.scrollTop);
+ log("scrollLeft: " + body.scrollLeft);
+ }
</ins><span class="cx"> </script>
</span><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomElementdocumentElementscrollLeftexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Element/documentElement-scrollLeft-expected.txt (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Element/documentElement-scrollLeft-expected.txt 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/fast/dom/Element/documentElement-scrollLeft-expected.txt 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -6,7 +6,7 @@
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><del>-PASS document.documentElement.scrollLeft is 500
</del><ins>+PASS document.documentElement.scrollLeft is 0
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomElementdocumentElementscrollLefthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Element/documentElement-scrollLeft.html (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Element/documentElement-scrollLeft.html 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/fast/dom/Element/documentElement-scrollLeft.html 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -13,7 +13,7 @@
</span><span class="cx"> description('Tests that for standard mode document.documentElement.scrollLeft returns the scroll left value');
</span><span class="cx">
</span><span class="cx"> document.documentElement.scrollLeft = 500;
</span><del>- shouldBe("document.documentElement.scrollLeft","500");
</del><ins>+ shouldBe("document.documentElement.scrollLeft","0");
</ins><span class="cx"> isSuccessfullyParsed();
</span><span class="cx"> }
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomElementdocumentElementscrollTopexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Element/documentElement-scrollTop-expected.txt (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Element/documentElement-scrollTop-expected.txt 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/fast/dom/Element/documentElement-scrollTop-expected.txt 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS document.documentElement.scrollTop is 500
</del><ins>+PASS document.documentElement.scrollTop is 0
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomElementdocumentElementscrollTophtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Element/documentElement-scrollTop.html (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Element/documentElement-scrollTop.html 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/fast/dom/Element/documentElement-scrollTop.html 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -13,7 +13,7 @@
</span><span class="cx"> description('Tests that for standard mode document.documentElement.scrollTop returns the scroll top value');
</span><span class="cx">
</span><span class="cx"> document.documentElement.scrollTop = 500;
</span><del>- shouldBe("document.documentElement.scrollTop","500");
</del><ins>+ shouldBe("document.documentElement.scrollTop","0");
</ins><span class="cx"> isSuccessfullyParsed();
</span><span class="cx"> }
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomElementscrollLeftexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Element/scrollLeft-expected.txt (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Element/scrollLeft-expected.txt 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/fast/dom/Element/scrollLeft-expected.txt 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -5,7 +5,7 @@
</span><span class="cx">
</span><span class="cx"> PASS window.pageXOffset is 500
</span><span class="cx"> PASS document.body.scrollLeft is 500
</span><del>-PASS document.documentElement.scrollLeft is 500
</del><ins>+PASS document.documentElement.scrollLeft is 0
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomElementscrollLefthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Element/scrollLeft.html (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Element/scrollLeft.html 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/fast/dom/Element/scrollLeft.html 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -16,7 +16,7 @@
</span><span class="cx"> window.scrollTo(500,0);
</span><span class="cx"> shouldBe("window.pageXOffset","500");
</span><span class="cx"> shouldBe("document.body.scrollLeft","500");
</span><del>- shouldBe("document.documentElement.scrollLeft","500");
</del><ins>+ shouldBe("document.documentElement.scrollLeft","0");
</ins><span class="cx"> finishJSTest();
</span><span class="cx"> }, 0);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomElementscrollTopexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Element/scrollTop-expected.txt (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Element/scrollTop-expected.txt 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/fast/dom/Element/scrollTop-expected.txt 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -5,7 +5,7 @@
</span><span class="cx">
</span><span class="cx"> PASS window.pageYOffset is 500
</span><span class="cx"> PASS document.body.scrollTop is 500
</span><del>-PASS document.documentElement.scrollTop is 500
</del><ins>+PASS document.documentElement.scrollTop is 0
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomElementscrollTophtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Element/scrollTop.html (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Element/scrollTop.html 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/fast/dom/Element/scrollTop.html 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -16,7 +16,7 @@
</span><span class="cx"> window.scrollTo(0,500);
</span><span class="cx"> shouldBe("window.pageYOffset","500");
</span><span class="cx"> shouldBe("document.body.scrollTop","500");
</span><del>- shouldBe("document.documentElement.scrollTop","500");
</del><ins>+ shouldBe("document.documentElement.scrollTop","0");
</ins><span class="cx"> finishJSTest();
</span><span class="cx"> }, 0);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsmousecursorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/mouse-cursor.html (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/mouse-cursor.html 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/fast/events/mouse-cursor.html 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -1,3 +1,4 @@
</span><ins>+<!DOCTYPE html>
</ins><span class="cx"> <html>
</span><span class="cx"> <head>
</span><span class="cx"> <script src="../../resources/js-test-pre.js"></script>
</span></span></pre></div>
<a id="trunkLayoutTestsfastmulticolscrollingoverflowhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/multicol/scrolling-overflow.html (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/multicol/scrolling-overflow.html 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/fast/multicol/scrolling-overflow.html 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -14,9 +14,9 @@
</span><span class="cx"> <script>
</span><span class="cx"> function doTest()
</span><span class="cx"> {
</span><del>- document.documentElement.offsetLeft;
- document.documentElement.scrollLeft = 100;
- document.documentElement.offsetLeft;
</del><ins>+ document.body.offsetLeft;
+ document.body.scrollLeft = 100;
+ document.body.offsetLeft;
</ins><span class="cx"> }
</span><span class="cx"> </script>
</span><span class="cx"> </head>
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsnavigationanchorframesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/navigation/anchor-frames-expected.txt (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/navigation/anchor-frames-expected.txt 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/http/tests/navigation/anchor-frames-expected.txt 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -8,7 +8,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS document.body.offsetHeight > window.innerHeight is true
</del><ins>+PASS document.body.offsetHeight > document.documentElement.clientHeight is true
</ins><span class="cx"> PASS document.body.scrollTop > 0 is true
</span><span class="cx"> PASS document.body.scrollTop + document.documentElement.clientHeight > 2000 is true
</span><span class="cx"> PASS successfullyParsed is true
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsnavigationanchorframesgbkexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/navigation/anchor-frames-gbk-expected.txt (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/navigation/anchor-frames-gbk-expected.txt 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/http/tests/navigation/anchor-frames-gbk-expected.txt 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -8,7 +8,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS document.body.offsetHeight > window.innerHeight is true
</del><ins>+PASS document.body.offsetHeight > document.documentElement.clientHeight is true
</ins><span class="cx"> PASS document.body.scrollTop > 0 is true
</span><span class="cx"> PASS document.body.scrollTop + document.documentElement.clientHeight > 2000 is true
</span><span class="cx"> PASS successfullyParsed is true
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsnavigationresourcesframewithanchorgbkhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/navigation/resources/frame-with-anchor-gbk.html (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/navigation/resources/frame-with-anchor-gbk.html 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/http/tests/navigation/resources/frame-with-anchor-gbk.html 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -1,3 +1,4 @@
</span><ins>+<!DOCTYPE html>
</ins><span class="cx"> <html>
</span><span class="cx"> <head>
</span><span class="cx"> <meta http-equiv="Content-Type" content="text/html; charset=gbk"/>
</span><span class="lines">@@ -11,7 +12,7 @@
</span><span class="cx"> setTimeout(function() {
</span><span class="cx"> // Make sure that the body is taller than the viewport (i.e. scrolling is
</span><span class="cx"> // required).
</span><del>- shouldBeTrue('document.body.offsetHeight > window.innerHeight');
</del><ins>+ shouldBeTrue('document.body.offsetHeight > document.documentElement.clientHeight');
</ins><span class="cx">
</span><span class="cx"> // We should be scrolled at least a little bit
</span><span class="cx"> shouldBeTrue('document.body.scrollTop > 0');
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsnavigationresourcesframewithanchorsameoriginhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/navigation/resources/frame-with-anchor-same-origin.html (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/navigation/resources/frame-with-anchor-same-origin.html 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/http/tests/navigation/resources/frame-with-anchor-same-origin.html 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -1,3 +1,4 @@
</span><ins>+<!DOCTYPE html>
</ins><span class="cx"> <html>
</span><span class="cx"> <head>
</span><span class="cx"> <script src="../../../js-test-resources/js-test-pre.js"></script>
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsnavigationresourcesframewithanchorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/navigation/resources/frame-with-anchor.html (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/navigation/resources/frame-with-anchor.html 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/http/tests/navigation/resources/frame-with-anchor.html 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -1,3 +1,4 @@
</span><ins>+<!DOCTYPE html>
</ins><span class="cx"> <html>
</span><span class="cx"> <head>
</span><span class="cx"> <script src="../../../js-test-resources/js-test-pre.js"></script>
</span><span class="lines">@@ -10,7 +11,7 @@
</span><span class="cx"> setTimeout(function() {
</span><span class="cx"> // Make sure that the body is taller than the viewport (i.e. scrolling is
</span><span class="cx"> // required).
</span><del>- shouldBeTrue('document.body.offsetHeight > window.innerHeight');
</del><ins>+ shouldBeTrue('document.body.offsetHeight > document.documentElement.clientHeight');
</ins><span class="cx">
</span><span class="cx"> // We should be scrolled at least a little bit
</span><span class="cx"> shouldBeTrue('document.body.scrollTop > 0');
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2tileddrawingresourcesscrollandloadpagehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -1,3 +1,4 @@
</span><ins>+<!DOCTYPE html>
</ins><span class="cx"> <html>
</span><span class="cx"> <head>
</span><span class="cx"> <style>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2tileddrawingtileddrawingscrollpositionpagecacherestorationhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -1,3 +1,4 @@
</span><ins>+<!DOCTYPE html>
</ins><span class="cx"> <html>
</span><span class="cx"> <head>
</span><span class="cx"> <script>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/Source/WebCore/ChangeLog 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-03-06 Gurpreet Kaur <k.gurpreet@samsung.com>
+
+ REGRESSION (r158254): Rubber-banding at Bing image search causes the toolbar to move up and away
+ https://bugs.webkit.org/show_bug.cgi?id=128873
+
+ Reviewed by Antonio Gomes.
+
+ This regression is caused by http://trac.webkit.org/changeset/154614
+ and http://trac.webkit.org/changeset/156605. So reverting the changes
+ to make it Web compatible as earlier.
+
+ * dom/Element.cpp:
+ (WebCore::Element::scrollLeft):
+ (WebCore::Element::scrollTop):
+ (WebCore::Element::setScrollLeft):
+ (WebCore::Element::setScrollTop):
+ Reverting changes as it caused regression.
+
</ins><span class="cx"> 2014-03-06 Zan Dobersek <zdobersek@igalia.com>
</span><span class="cx">
</span><span class="cx"> Move Source/WebCore/html/canvas/ code to std::unique_ptr
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (165184 => 165185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2014-03-06 12:16:06 UTC (rev 165184)
+++ trunk/Source/WebCore/dom/Element.cpp 2014-03-06 13:28:03 UTC (rev 165185)
</span><span class="lines">@@ -784,18 +784,8 @@
</span><span class="cx">
</span><span class="cx"> int Element::scrollLeft()
</span><span class="cx"> {
</span><del>- if (document().documentElement() == this && document().inQuirksMode())
- return 0;
-
</del><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><del>- if (!document().hasLivingRenderTree())
- return 0;
- RenderView& renderView = *document().renderView();
-
- if (document().documentElement() == this)
- return adjustForAbsoluteZoom(renderView.frameView().scrollX(), renderView);
-
</del><span class="cx"> if (RenderBox* rend = renderBox())
</span><span class="cx"> return adjustForAbsoluteZoom(rend->scrollLeft(), *rend);
</span><span class="cx"> return 0;
</span><span class="lines">@@ -803,18 +793,8 @@
</span><span class="cx">
</span><span class="cx"> int Element::scrollTop()
</span><span class="cx"> {
</span><del>- if (document().documentElement() == this && document().inQuirksMode())
- return 0;
-
</del><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><del>- if (!document().hasLivingRenderTree())
- return 0;
- RenderView& renderView = *document().renderView();
-
- if (document().documentElement() == this)
- return adjustForAbsoluteZoom(renderView.frameView().scrollY(), renderView);
-
</del><span class="cx"> if (RenderBox* rend = renderBox())
</span><span class="cx"> return adjustForAbsoluteZoom(rend->scrollTop(), *rend);
</span><span class="cx"> return 0;
</span><span class="lines">@@ -822,42 +802,16 @@
</span><span class="cx">
</span><span class="cx"> void Element::setScrollLeft(int newLeft)
</span><span class="cx"> {
</span><del>- if (document().documentElement() == this && document().inQuirksMode())
- return;
-
</del><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><del>- if (!document().hasLivingRenderTree())
- return;
-
- if (document().documentElement() == this) {
- RenderView& renderView = *document().renderView();
- int zoom = renderView.style().effectiveZoom();
- renderView.frameView().setScrollPosition(IntPoint(newLeft * zoom, renderView.frameView().scrollY() * zoom));
- return;
- }
-
</del><span class="cx"> if (RenderBox* rend = renderBox())
</span><span class="cx"> rend->setScrollLeft(static_cast<int>(newLeft * rend->style().effectiveZoom()));
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Element::setScrollTop(int newTop)
</span><span class="cx"> {
</span><del>- if (document().documentElement() == this && document().inQuirksMode())
- return;
-
</del><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><del>- if (!document().hasLivingRenderTree())
- return;
-
- if (document().documentElement() == this) {
- RenderView& renderView = *document().renderView();
- int zoom = renderView.style().effectiveZoom();
- renderView.frameView().setScrollPosition(IntPoint(renderView.frameView().scrollX() * zoom, newTop * zoom));
- return;
- }
-
</del><span class="cx"> if (RenderBox* rend = renderBox())
</span><span class="cx"> rend->setScrollTop(static_cast<int>(newTop * rend->style().effectiveZoom()));
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>