<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165108] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165108">165108</a></dd>
<dt>Author</dt> <dd>mrobinson@webkit.org</dd>
<dt>Date</dt> <dd>2014-03-05 07:48:29 -0800 (Wed, 05 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
https://bugs.webkit.org/show_bug.cgi?id=129637
Reviewed by Carlos Garcia Campos.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
(RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
(RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
New API typically just requires a rebaseline and isn't necessarily a faiulre.
(TestFactory.__init__): Add the test for GTK+.
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigmastercfg">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigmastercfg_unittestpy">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigmastercfg"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (165107 => 165108)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-03-05 15:16:08 UTC (rev 165107)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-03-05 15:48:29 UTC (rev 165108)
</span><span class="lines">@@ -635,6 +635,35 @@
</span><span class="cx">
</span><span class="cx"> return [self.name]
</span><span class="cx">
</span><ins>+class RunGtkWebKitGObjectDOMBindingsAPIBreakTests(shell.Test):
+ name = "WebKit GObject DOM bindings API break tests"
+ description = ["WebKit GObject DOM bindings API break tests running"]
+ descriptionDone = ["WebKit GObject DOM bindings API break tests"]
+ command = ["./Tools/gtk/check-for-webkitdom-api-breaks"]
+
+ def commandComplete(self, cmd):
+ shell.Test.commandComplete(self, cmd)
+
+ logText = cmd.logs['stdio'].getText()
+
+ self.missingAPI = bool(re.findall("Missing API", logText))
+ self.newAPI = bool(re.findall("New API", logText))
+
+ line = ""
+ if self.newAPI:
+ line += "Found new API."
+ if self.missingAPI:
+ line += "Found missing API."
+ if line:
+ self.statusLine = [ line ]
+
+ def evaluateCommand(self, cmd):
+ if self.missingAPI:
+ return FAILURE
+ if self.newAPI:
+ return WARNINGS
+ return SUCCESS
+
</ins><span class="cx"> class RunWebKitLeakTests(RunWebKitTests):
</span><span class="cx"> warnOnWarnings = True
</span><span class="cx"> def start(self):
</span><span class="lines">@@ -797,6 +826,7 @@
</span><span class="cx"> self.addStep(RunEflAPITests)
</span><span class="cx"> if platform == "gtk":
</span><span class="cx"> self.addStep(RunGtkAPITests())
</span><ins>+ self.addStep(RunGtkWebKitGObjectDOMBindingsAPIBreakTests())
</ins><span class="cx">
</span><span class="cx"> class BuildAndTestFactory(Factory):
</span><span class="cx"> CompileClass = CompileWebKit
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigmastercfg_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py (165107 => 165108)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py 2014-03-05 15:16:08 UTC (rev 165107)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py 2014-03-05 15:48:29 UTC (rev 165108)
</span><span class="lines">@@ -381,6 +381,51 @@
</span><span class="cx"> self.fail("Error during instantiation %s buildstep for %s builder: %s\n" % (buildStepName, builderName, e))
</span><span class="cx"> return doTest
</span><span class="cx">
</span><ins>+class RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest(unittest.TestCase):
+ def assertResults(self, expected_missing, expected_new, stdio):
+ expected_text = ""
+ expected_results = SUCCESS
+ if expected_new:
+ expected_results = WARNINGS
+ if expected_missing:
+ expected_results = FAILURE
+
+ cmd = StubRemoteCommand(0, stdio)
+ step = RunGtkWebKitGObjectDOMBindingsAPIBreakTests()
+ step.commandComplete(cmd)
+
+ actual_results = step.evaluateCommand(cmd)
+ self.assertEqual(expected_results, actual_results)
+ self.assertEqual(expected_missing, step.missingAPI)
+ self.assertEqual(expected_new, step.newAPI)
+
+ def test_missing_and_new_api(self):
+ self.assertResults(expected_missing=True, expected_new=True, stdio="""Missing API (API break!) detected in GObject DOM bindings
+ gboolean webkit_dom_html_input_element_get_webkitdirectory(WebKitDOMHTMLInputElement*)
+ gchar* webkit_dom_text_track_cue_get_text(WebKitDOMTextTrackCue*)
+
+New API detected in GObject DOM bindings
+ void webkit_dom_html_input_element_set_capture(WebKitDOMHTMLInputElement*, gboolean)
+ gboolean webkit_dom_html_input_element_get_capture(WebKitDOMHTMLInputElement*)
+ void webkit_dom_text_track_add_cue(WebKitDOMTextTrack*, WebKitDOMTextTrackCue*, GError**)
+ gchar* webkit_dom_document_get_origin(WebKitDOMDocument*)""")
+
+ def test_missing_api(self):
+ self.assertResults(expected_missing=True, expected_new=False, stdio="""Missing API (API break!) detected in GObject DOM bindings
+ gboolean webkit_dom_html_input_element_get_webkitdirectory(WebKitDOMHTMLInputElement*)
+ gchar* webkit_dom_text_track_cue_get_text(WebKitDOMTextTrackCue*)""")
+
+ def test_new_api(self):
+ self.assertResults(expected_missing=False, expected_new=True, stdio="""New API detected in GObject DOM bindings
+ void webkit_dom_html_input_element_set_capture(WebKitDOMHTMLInputElement*, gboolean)
+ gboolean webkit_dom_html_input_element_get_capture(WebKitDOMHTMLInputElement*)
+ void webkit_dom_text_track_add_cue(WebKitDOMTextTrack*, WebKitDOMTextTrackCue*, GError**)
+ gchar* webkit_dom_document_get_origin(WebKitDOMDocument*)""")
+
+ def test_success(self):
+ self.assertResults(expected_missing=False, expected_new=False, stdio="")
+
+
</ins><span class="cx"> # FIXME: We should run this file as part of test-webkitpy.
</span><span class="cx"> # Unfortunately test-webkitpy currently requires that unittests
</span><span class="cx"> # be located in a directory with a valid module name.
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (165107 => 165108)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-03-05 15:16:08 UTC (rev 165107)
+++ trunk/Tools/ChangeLog 2014-03-05 15:48:29 UTC (rev 165108)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-03-05 Martin Robinson <mrobinson@igalia.com>
+
+ [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
+ https://bugs.webkit.org/show_bug.cgi?id=129637
+
+ Reviewed by Carlos Garcia Campos.
+
+ * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+ (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
+ (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
+ (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
+ New API typically just requires a rebaseline and isn't necessarily a faiulre.
+ (TestFactory.__init__): Add the test for GTK+.
+ * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
+
</ins><span class="cx"> 2014-03-05 Krzysztof Czech <k.czech@samsung.com>
</span><span class="cx">
</span><span class="cx"> [ATK] Expose missing functionalities of AtkTableCell to AT
</span></span></pre>
</div>
</div>
</body>
</html>