<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165113] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165113">165113</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-03-05 10:11:50 -0800 (Wed, 05 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel rendering: Wrong cliprect on absolute positioned elements.
https://bugs.webkit.org/show_bug.cgi?id=129656
Reviewed by Simon Fraser.
outlineBoundsForRepaint() is expected to return the outline repaint rect. Using enclosingIntRect()
to calculate the outline boundaries breaks repaint logic in RenderElement::repaintAfterLayoutIfNeeded().
Since enclosingIntRect() can return bigger rect than repaint rect, the old/new bounds' dimensions could end up
being different which triggers the size change repaint code path.
Source/WebCore:
Test: fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::outlineBoundsForRepaint):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::repaintAfterLayoutIfNeeded):
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
LayoutTests:
* fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move-expected.txt: Added.
* fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderElementcpp">trunk/Source/WebCore/rendering/RenderElement.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGModelObjectcpp">trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastrepainthidpiabsolutepositionedelementwrongcliprectaftermoveexpectedtxt">trunk/LayoutTests/fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastrepainthidpiabsolutepositionedelementwrongcliprectaftermovehtml">trunk/LayoutTests/fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (165112 => 165113)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-03-05 17:43:57 UTC (rev 165112)
+++ trunk/LayoutTests/ChangeLog 2014-03-05 18:11:50 UTC (rev 165113)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-03-05 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Wrong cliprect on absolute positioned elements.
+ https://bugs.webkit.org/show_bug.cgi?id=129656
+
+ Reviewed by Simon Fraser.
+
+ outlineBoundsForRepaint() is expected to return the outline repaint rect. Using enclosingIntRect()
+ to calculate the outline boundaries breaks repaint logic in RenderElement::repaintAfterLayoutIfNeeded().
+ Since enclosingIntRect() can return bigger rect than repaint rect, the old/new bounds' dimensions could end up
+ being different which triggers the size change repaint code path.
+
+ * fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move-expected.txt: Added.
+ * fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html: Added.
+
</ins><span class="cx"> 2014-03-05 Chang Shu <cshu@webkit.org>
</span><span class="cx">
</span><span class="cx"> Copying wrapping text results in multiple spaces between wrapped lines stripped.
</span></span></pre></div>
<a id="trunkLayoutTestsfastrepainthidpiabsolutepositionedelementwrongcliprectaftermoveexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move-expected.txt (0 => 165113)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move-expected.txt 2014-03-05 18:11:50 UTC (rev 165113)
</span><span class="lines">@@ -0,0 +1,23 @@
</span><ins>+(repaint rects
+ (rect 0 0 22 22)
+ (rect 0.50 0 22 22)
+ (rect 25 0 22 22)
+ (rect 25.50 0 22 22)
+ (rect 50 0 22 22)
+ (rect 50.50 0 22 22)
+ (rect 75 0 22 22)
+ (rect 75.50 0 22 22)
+ (rect 100 0 22 22)
+ (rect 100.50 0 22 22)
+ (rect 125 0 22 22)
+ (rect 125.50 0 22 22)
+ (rect 150 0 22 22)
+ (rect 150.50 0 22 22)
+ (rect 175 0 22 22)
+ (rect 175.50 0 22 22)
+ (rect 200 0 22 22)
+ (rect 200.50 0 22 22)
+ (rect 225 0 22 22)
+ (rect 225.50 0 22 22)
+)
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastrepainthidpiabsolutepositionedelementwrongcliprectaftermovehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html (0 => 165113)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html (rev 0)
+++ trunk/LayoutTests/fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html 2014-03-05 18:11:50 UTC (rev 165113)
</span><span class="lines">@@ -0,0 +1,53 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests absolute positioned elements' repaint clipping after move. Pass if all borders are painted properly.</title>
+<head>
+<style>
+ div {
+ position: absolute;
+ border: green solid 1px;
+ width: 20px;
+ height: 20px;
+ left: 0px;
+ top: 0px;
+ }
+</style>
+</head>
+<body>
+<p id="container"></p>
+<script>
+ var container = document.getElementById("container");
+ for (j = 0; j < 10; ++j) {
+ var e = document.createElement("div");
+ e.style.left = (25 * j) + "px";
+ container.appendChild(e);
+ }
+
+ function move() {
+ divs = document.getElementsByTagName("div");
+ for (i = 0; i < divs.length; ++i)
+ divs[i].style.left = (parseFloat(divs[i].style.left) + 0.3) + "px";
+
+ if (window.testRunner && window.internals) {
+ var dummy = document.body.offsetTop;
+ var repaintRects = window.internals.repaintRectsAsText();
+ window.internals.stopTrackingRepaints();
+
+ var pre = document.createElement('pre');
+ document.body.appendChild(pre);
+ pre.innerHTML = repaintRects;
+ testRunner.notifyDone();
+ }
+ }
+
+ if (window.testRunner && window.internals) {
+ window.testRunner.dumpAsText(false);
+ window.internals.startTrackingRepaints();
+ testRunner.waitUntilDone();
+ }
+
+ setTimeout(move, 0);
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (165112 => 165113)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-05 17:43:57 UTC (rev 165112)
+++ trunk/Source/WebCore/ChangeLog 2014-03-05 18:11:50 UTC (rev 165113)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-03-05 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Wrong cliprect on absolute positioned elements.
+ https://bugs.webkit.org/show_bug.cgi?id=129656
+
+ Reviewed by Simon Fraser.
+
+ outlineBoundsForRepaint() is expected to return the outline repaint rect. Using enclosingIntRect()
+ to calculate the outline boundaries breaks repaint logic in RenderElement::repaintAfterLayoutIfNeeded().
+ Since enclosingIntRect() can return bigger rect than repaint rect, the old/new bounds' dimensions could end up
+ being different which triggers the size change repaint code path.
+
+ Test: fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::outlineBoundsForRepaint):
+ * rendering/RenderElement.cpp:
+ (WebCore::RenderElement::repaintAfterLayoutIfNeeded):
+ * rendering/svg/RenderSVGModelObject.cpp:
+ (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
+
</ins><span class="cx"> 2014-03-05 Krzysztof Czech <k.czech@samsung.com>
</span><span class="cx">
</span><span class="cx"> [ATK] Expose missing functionalities of AtkTableCell to AT.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (165112 => 165113)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp 2014-03-05 17:43:57 UTC (rev 165112)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2014-03-05 18:11:50 UTC (rev 165113)
</span><span class="lines">@@ -639,14 +639,14 @@
</span><span class="cx"> else
</span><span class="cx"> containerRelativeQuad = localToContainerQuad(FloatRect(box), repaintContainer);
</span><span class="cx">
</span><del>- box = containerRelativeQuad.enclosingBoundingBox();
</del><ins>+ box = LayoutRect(containerRelativeQuad.boundingBox());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // FIXME: layoutDelta needs to be applied in parts before/after transforms and
</span><span class="cx"> // repaint containers. https://bugs.webkit.org/show_bug.cgi?id=23308
</span><span class="cx"> box.move(view().layoutDelta());
</span><span class="cx">
</span><del>- return box;
</del><ins>+ return LayoutRect(pixelSnappedForPainting(box, document().deviceScaleFactor()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderBox::addFocusRingRects(Vector<IntRect>& rects, const LayoutPoint& additionalOffset, const RenderLayerModelObject*)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (165112 => 165113)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderElement.cpp 2014-03-05 17:43:57 UTC (rev 165112)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp 2014-03-05 18:11:50 UTC (rev 165113)
</span><span class="lines">@@ -1254,7 +1254,7 @@
</span><span class="cx"> LayoutUnit shadowLeft;
</span><span class="cx"> LayoutUnit shadowRight;
</span><span class="cx"> style().getBoxShadowHorizontalExtent(shadowLeft, shadowRight);
</span><del>- int borderRight = isBox() ? toRenderBox(this)->borderRight() : LayoutUnit::fromPixel(0);
</del><ins>+ LayoutUnit borderRight = isBox() ? toRenderBox(this)->borderRight() : LayoutUnit::fromPixel(0);
</ins><span class="cx"> LayoutUnit boxWidth = isBox() ? toRenderBox(this)->width() : LayoutUnit();
</span><span class="cx"> LayoutUnit minInsetRightShadowExtent = std::min<LayoutUnit>(-insetShadowExtent.right(), std::min<LayoutUnit>(newBounds.width(), oldBounds.width()));
</span><span class="cx"> LayoutUnit borderWidth = std::max<LayoutUnit>(borderRight, std::max<LayoutUnit>(valueForLength(style().borderTopRightRadius().width(), boxWidth, &view()), valueForLength(style().borderBottomRightRadius().width(), boxWidth)));
</span><span class="lines">@@ -1274,7 +1274,7 @@
</span><span class="cx"> LayoutUnit shadowTop;
</span><span class="cx"> LayoutUnit shadowBottom;
</span><span class="cx"> style().getBoxShadowVerticalExtent(shadowTop, shadowBottom);
</span><del>- int borderBottom = isBox() ? toRenderBox(this)->borderBottom() : LayoutUnit::fromPixel(0);
</del><ins>+ LayoutUnit borderBottom = isBox() ? toRenderBox(this)->borderBottom() : LayoutUnit::fromPixel(0);
</ins><span class="cx"> LayoutUnit boxHeight = isBox() ? toRenderBox(this)->height() : LayoutUnit();
</span><span class="cx"> LayoutUnit minInsetBottomShadowExtent = std::min<LayoutUnit>(-insetShadowExtent.bottom(), std::min<LayoutUnit>(newBounds.height(), oldBounds.height()));
</span><span class="cx"> LayoutUnit borderHeight = std::max<LayoutUnit>(borderBottom, std::max<LayoutUnit>(valueForLength(style().borderBottomLeftRadius().height(), boxHeight), valueForLength(style().borderBottomRightRadius().height(), boxHeight, &view())));
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGModelObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp (165112 => 165113)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp 2014-03-05 17:43:57 UTC (rev 165112)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp 2014-03-05 18:11:50 UTC (rev 165113)
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx"> adjustRectForOutlineAndShadow(box);
</span><span class="cx">
</span><span class="cx"> FloatQuad containerRelativeQuad = localToContainerQuad(FloatRect(box), repaintContainer);
</span><del>- return containerRelativeQuad.enclosingBoundingBox();
</del><ins>+ return LayoutRect(pixelSnappedForPainting(LayoutRect(containerRelativeQuad.boundingBox()), document().deviceScaleFactor()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderSVGModelObject::absoluteRects(Vector<IntRect>& rects, const LayoutPoint& accumulatedOffset) const
</span></span></pre>
</div>
</div>
</body>
</html>