<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165050] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165050">165050</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-03-04 08:17:46 -0800 (Tue, 04 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel rendering: Incorrect repaint rect cuts off content's right edge after move.
https://bugs.webkit.org/show_bug.cgi?id=129652
Reviewed by Simon Fraser.
When repaint rect is adjusted in order to take the distance from renderer into account,
the accumulated fraction value need to be added too. This is always a positive value.
Source/WebCore:
Test: fast/borders/hidpi-border-clipping-right-after-move.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
LayoutTests:
* fast/borders/hidpi-border-clipping-right-after-move-expected.html: Added.
* fast/borders/hidpi-border-clipping-right-after-move.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerBackingcpp">trunk/Source/WebCore/rendering/RenderLayerBacking.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastbordershidpiborderclippingrightaftermoveexpectedhtml">trunk/LayoutTests/fast/borders/hidpi-border-clipping-right-after-move-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastbordershidpiborderclippingrightaftermovehtml">trunk/LayoutTests/fast/borders/hidpi-border-clipping-right-after-move.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (165049 => 165050)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-03-04 13:19:34 UTC (rev 165049)
+++ trunk/LayoutTests/ChangeLog 2014-03-04 16:17:46 UTC (rev 165050)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-03-04 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Incorrect repaint rect cuts off content's right edge after move.
+ https://bugs.webkit.org/show_bug.cgi?id=129652
+
+ Reviewed by Simon Fraser.
+
+ When repaint rect is adjusted in order to take the distance from renderer into account,
+ the accumulated fraction value need to be added too. This is always a positive value.
+
+ * fast/borders/hidpi-border-clipping-right-after-move-expected.html: Added.
+ * fast/borders/hidpi-border-clipping-right-after-move.html: Added.
+
</ins><span class="cx"> 2014-02-07 Sergio Villar Senin <svillar@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CSS Grid Layout] Percentages of indefinite sizes should compute to auto
</span></span></pre></div>
<a id="trunkLayoutTestsfastbordershidpiborderclippingrightaftermoveexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/borders/hidpi-border-clipping-right-after-move-expected.html (0 => 165050)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/borders/hidpi-border-clipping-right-after-move-expected.html (rev 0)
+++ trunk/LayoutTests/fast/borders/hidpi-border-clipping-right-after-move-expected.html 2014-03-04 16:17:46 UTC (rev 165050)
</span><span class="lines">@@ -0,0 +1,33 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests repaint clipping after move. Pass if all borders are painted.</title>
+<head>
+<style>
+ div {
+ position: fixed;
+ border: red solid 0.5px;
+ width: 20px;
+ height: 20px;
+ left: 0px;
+ top: 0px;
+ }
+</style>
+</head>
+<body>
+<p id="container"></p>
+<script>
+ var container = document.getElementById("container");
+ adjustment = 0;
+ for (i = 0; i < 4; ++i) {
+ adjustment+=0.1;
+ for (j = 0; j < 40; ++j) {
+ var e = document.createElement("div");
+ e.style.top = (25 * i + adjustment) + "px";
+ e.style.left = (25 * j + adjustment + 0.3) + "px";
+ container.appendChild(e);
+ }
+ }
+</script>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastbordershidpiborderclippingrightaftermovehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/borders/hidpi-border-clipping-right-after-move.html (0 => 165050)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/borders/hidpi-border-clipping-right-after-move.html (rev 0)
+++ trunk/LayoutTests/fast/borders/hidpi-border-clipping-right-after-move.html 2014-03-04 16:17:46 UTC (rev 165050)
</span><span class="lines">@@ -0,0 +1,47 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests repaint clipping after move. Pass if all borders are painted.</title>
+<head>
+<style>
+ div {
+ position: fixed;
+ border: red solid 0.5px;
+ width: 20px;
+ height: 20px;
+ left: 0px;
+ top: 0px;
+ }
+</style>
+</head>
+<body>
+<p id="container"></p>
+<script>
+ var container = document.getElementById("container");
+ adjustment = 0;
+ for (i = 0; i < 4; ++i) {
+ adjustment+=0.1;
+ for (j = 0; j < 40; ++j) {
+ var e = document.createElement("div");
+ e.style.top = (25 * i + adjustment) + "px";
+ e.style.left = (25 * j + adjustment) + "px";
+ container.appendChild(e);
+ }
+ }
+
+ function move() {
+ divs = document.getElementsByTagName("div");
+ for (i = 0; i < divs.length; ++i)
+ divs[i].style.left = (parseFloat(divs[i].style.left) + 0.2) + "px";
+
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }
+
+ if (window.testRunner)
+ testRunner.waitUntilDone();
+
+ setTimeout(move, 100);
+</script>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (165049 => 165050)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-04 13:19:34 UTC (rev 165049)
+++ trunk/Source/WebCore/ChangeLog 2014-03-04 16:17:46 UTC (rev 165050)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-03-04 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Incorrect repaint rect cuts off content's right edge after move.
+ https://bugs.webkit.org/show_bug.cgi?id=129652
+
+ Reviewed by Simon Fraser.
+
+ When repaint rect is adjusted in order to take the distance from renderer into account,
+ the accumulated fraction value need to be added too. This is always a positive value.
+
+ Test: fast/borders/hidpi-border-clipping-right-after-move.html
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
+
</ins><span class="cx"> 2014-03-04 Ryuan Choi <ryuan.choi@samsung.com>
</span><span class="cx">
</span><span class="cx"> Remove unused member variable of NetworkInfoController
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerBackingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (165049 => 165050)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2014-03-04 13:19:34 UTC (rev 165049)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2014-03-04 16:17:46 UTC (rev 165050)
</span><span class="lines">@@ -2104,35 +2104,35 @@
</span><span class="cx">
</span><span class="cx"> if (m_graphicsLayer && m_graphicsLayer->drawsContent()) {
</span><span class="cx"> FloatRect layerDirtyRect = pixelSnappedRectForPainting;
</span><del>- layerDirtyRect.move(-m_graphicsLayer->offsetFromRenderer());
</del><ins>+ layerDirtyRect.move(-m_graphicsLayer->offsetFromRenderer() + m_devicePixelFractionFromRenderer);
</ins><span class="cx"> m_graphicsLayer->setNeedsDisplayInRect(layerDirtyRect, shouldClip);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (m_foregroundLayer && m_foregroundLayer->drawsContent()) {
</span><span class="cx"> FloatRect layerDirtyRect = pixelSnappedRectForPainting;
</span><del>- layerDirtyRect.move(-m_foregroundLayer->offsetFromRenderer());
</del><ins>+ layerDirtyRect.move(-m_foregroundLayer->offsetFromRenderer() + m_devicePixelFractionFromRenderer);
</ins><span class="cx"> m_foregroundLayer->setNeedsDisplayInRect(layerDirtyRect, shouldClip);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // FIXME: need to split out repaints for the background.
</span><span class="cx"> if (m_backgroundLayer && m_backgroundLayer->drawsContent()) {
</span><span class="cx"> FloatRect layerDirtyRect = pixelSnappedRectForPainting;
</span><del>- layerDirtyRect.move(-m_backgroundLayer->offsetFromRenderer());
</del><ins>+ layerDirtyRect.move(-m_backgroundLayer->offsetFromRenderer() + m_devicePixelFractionFromRenderer);
</ins><span class="cx"> m_backgroundLayer->setNeedsDisplayInRect(layerDirtyRect, shouldClip);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (m_maskLayer && m_maskLayer->drawsContent()) {
</span><span class="cx"> FloatRect layerDirtyRect = pixelSnappedRectForPainting;
</span><del>- layerDirtyRect.move(-m_maskLayer->offsetFromRenderer());
</del><ins>+ layerDirtyRect.move(-m_maskLayer->offsetFromRenderer() + m_devicePixelFractionFromRenderer);
</ins><span class="cx"> m_maskLayer->setNeedsDisplayInRect(layerDirtyRect, shouldClip);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (m_scrollingContentsLayer && m_scrollingContentsLayer->drawsContent()) {
</span><span class="cx"> FloatRect layerDirtyRect = pixelSnappedRectForPainting;
</span><del>- layerDirtyRect.move(-m_scrollingContentsLayer->offsetFromRenderer());
</del><ins>+ layerDirtyRect.move(-m_scrollingContentsLayer->offsetFromRenderer() + m_devicePixelFractionFromRenderer);
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> // Account for the fact that RenderLayerBacking::updateGraphicsLayerGeometry() bakes scrollOffset into offsetFromRenderer on iOS.
</span><del>- layerDirtyRect.move(-m_owningLayer.scrollOffset());
</del><ins>+ layerDirtyRect.move(-m_owningLayer.scrollOffset() + m_devicePixelFractionFromRenderer);
</ins><span class="cx"> #endif
</span><span class="cx"> m_scrollingContentsLayer->setNeedsDisplayInRect(layerDirtyRect, shouldClip);
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>