<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165046] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165046">165046</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-03-04 02:48:48 -0800 (Tue, 04 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Don't synchronize attributes in reflect setters when we don't need to
https://bugs.webkit.org/show_bug.cgi?id=129662
Reviewed by Andreas Kling.
The vast majority of attributes don't need synchronization. Avoid calling synchronizeAttribute in setters
for those content attributes generated by "Reflect" keyword in IDL.
* bindings/scripts/CodeGenerator.pm:
(SetterExpression):
* dom/Element.cpp:
(WebCore::Element::setAttributeWithoutSynchronization): Added.
* dom/Element.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorpm">trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoredomElementh">trunk/Source/WebCore/dom/Element.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (165045 => 165046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-04 10:28:38 UTC (rev 165045)
+++ trunk/Source/WebCore/ChangeLog 2014-03-04 10:48:48 UTC (rev 165046)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-03-04 Ryosuke Niwa <rniwa@webkit.org>
+
+ Don't synchronize attributes in reflect setters when we don't need to
+ https://bugs.webkit.org/show_bug.cgi?id=129662
+
+ Reviewed by Andreas Kling.
+
+ The vast majority of attributes don't need synchronization. Avoid calling synchronizeAttribute in setters
+ for those content attributes generated by "Reflect" keyword in IDL.
+
+ * bindings/scripts/CodeGenerator.pm:
+ (SetterExpression):
+ * dom/Element.cpp:
+ (WebCore::Element::setAttributeWithoutSynchronization): Added.
+ * dom/Element.h:
+
</ins><span class="cx"> 2014-03-04 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove Document::idAttributeName().
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (165045 => 165046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2014-03-04 10:28:38 UTC (rev 165045)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2014-03-04 10:48:48 UTC (rev 165046)
</span><span class="lines">@@ -593,15 +593,19 @@
</span><span class="cx"> return ("set" . $generator->WK_ucfirst($generator->AttributeNameForGetterAndSetter($attribute)));
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ my $attributeType = $attribute->signature->type;
+
</ins><span class="cx"> my $functionName;
</span><del>- if ($attribute->signature->type eq "boolean") {
</del><ins>+ if ($attributeType eq "boolean") {
</ins><span class="cx"> $functionName = "setBooleanAttribute";
</span><del>- } elsif ($attribute->signature->type eq "long") {
</del><ins>+ } elsif ($attributeType eq "long") {
</ins><span class="cx"> $functionName = "setIntegralAttribute";
</span><del>- } elsif ($attribute->signature->type eq "unsigned long") {
</del><ins>+ } elsif ($attributeType eq "unsigned long") {
</ins><span class="cx"> $functionName = "setUnsignedIntegralAttribute";
</span><ins>+ } elsif ($generator->IsSVGAnimatedType($attributeType)) {
+ $functionName = "setAttribute";
</ins><span class="cx"> } else {
</span><del>- $functionName = "setAttribute";
</del><ins>+ $functionName = "setAttributeWithoutSynchronization";
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return ($functionName, $contentAttributeName);
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (165045 => 165046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2014-03-04 10:28:38 UTC (rev 165045)
+++ trunk/Source/WebCore/dom/Element.cpp 2014-03-04 10:48:48 UTC (rev 165046)
</span><span class="lines">@@ -1007,6 +1007,12 @@
</span><span class="cx"> setAttributeInternal(index, name, value, NotInSynchronizationOfLazyAttribute);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void Element::setAttributeWithoutSynchronization(const QualifiedName& name, const AtomicString& value)
+{
+ unsigned index = elementData() ? elementData()->findAttributeIndexByName(name) : ElementData::attributeNotFound;
+ setAttributeInternal(index, name, value, NotInSynchronizationOfLazyAttribute);
+}
+
</ins><span class="cx"> void Element::setSynchronizedLazyAttribute(const QualifiedName& name, const AtomicString& value)
</span><span class="cx"> {
</span><span class="cx"> unsigned index = elementData() ? elementData()->findAttributeIndexByName(name) : ElementData::attributeNotFound;
</span><span class="lines">@@ -2054,7 +2060,7 @@
</span><span class="cx">
</span><span class="cx"> void Element::setPseudo(const AtomicString& value)
</span><span class="cx"> {
</span><del>- setAttribute(pseudoAttr, value);
</del><ins>+ setAttributeWithoutSynchronization(pseudoAttr, value);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> LayoutSize Element::minimumSizeForResizing() const
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.h (165045 => 165046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.h 2014-03-04 10:28:38 UTC (rev 165045)
+++ trunk/Source/WebCore/dom/Element.h 2014-03-04 10:48:48 UTC (rev 165046)
</span><span class="lines">@@ -144,6 +144,7 @@
</span><span class="cx"> bool hasAttribute(const QualifiedName&) const;
</span><span class="cx"> const AtomicString& getAttribute(const QualifiedName&) const;
</span><span class="cx"> void setAttribute(const QualifiedName&, const AtomicString& value);
</span><ins>+ void setAttributeWithoutSynchronization(const QualifiedName&, const AtomicString& value);
</ins><span class="cx"> void setSynchronizedLazyAttribute(const QualifiedName&, const AtomicString& value);
</span><span class="cx"> bool removeAttribute(const QualifiedName&);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>