<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[165037] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/165037">165037</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-03-03 22:37:43 -0800 (Mon, 03 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>:active style is not cleared when its display property is set to none before mouse released.
https://bugs.webkit.org/show_bug.cgi?id=129465
Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2014-03-03
Reviewed by Antonio Gomes.
Source/WebCore:
We currently clearing the :active style when element has a renderer.
This patch makes elements clear its active style regardless of renderer.
* dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
LayoutTests:
* fast/css/active-display-none-expected.txt: Added.
* fast/css/active-display-none.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssactivedisplaynoneexpectedtxt">trunk/LayoutTests/fast/css/active-display-none-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssactivedisplaynonehtml">trunk/LayoutTests/fast/css/active-display-none.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsfastcssactivedisplaynoneexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/active-display-none-expected.txt (0 => 165037)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/active-display-none-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/active-display-none-expected.txt 2014-03-04 06:37:43 UTC (rev 165037)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+:active style should be cleared even if display property is set to none before mouse released.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS background is "rgb(255, 0, 0)"
+PASS background is "rgb(255, 0, 0)"
+PASS background is "rgb(0, 0, 0)"
+PASS background is "rgb(0, 0, 0)"
+
+
+
+
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssactivedisplaynonehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/active-display-none.html (0 => 165037)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/active-display-none.html (rev 0)
+++ trunk/LayoutTests/fast/css/active-display-none.html 2014-03-04 06:37:43 UTC (rev 165037)
</span><span class="lines">@@ -0,0 +1,53 @@
</span><ins>+<!DOCTYPE html>
+<style>
+ div { background: rgb(0, 0, 0); }
+ div:active { background: rgb(255, 0, 0); }
+ #parent {
+ width: 200px;
+ height: 200px;
+ border: 2px solid rgb(0, 0, 255);
+ }
+ #child {
+ width: 100px;
+ height: 100px;
+ border: 2px solid rgb(0, 0, 255);
+ }
+</style>
+
+<body>
+ <div id="parent">
+ <div id="child"></div>
+ </div>
+ <pre id="description"></div>
+ <pre id="console"></pre>
+</body>
+
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+ function shouldHaveBackground(element, bg) {
+ background = getComputedStyle(element, null).getPropertyValue("background-color")
+ shouldBeEqualToString('background', bg)
+ }
+
+ if (window.testRunner) {
+ description(":active style should be cleared even if display property is set to none before mouse released.")
+ var child = document.getElementById('child')
+ var parent = document.getElementById('parent')
+ testRunner.dumpAsText();
+
+ // Move and down into the child box.
+ eventSender.mouseMoveTo(50, 50)
+ eventSender.mouseDown()
+ shouldHaveBackground(child, 'rgb(255, 0, 0)')
+ shouldHaveBackground(parent, 'rgb(255, 0, 0)')
+
+ // With the mouse still down, set parent box to display:none.
+ parent.style.display = "none";
+
+ // Mouse up to clear active style.
+ eventSender.mouseUp()
+ parent.style.display = "block";
+ shouldHaveBackground(child, 'rgb(0, 0, 0)')
+ shouldHaveBackground(parent, 'rgb(0, 0, 0)')
+ }
+</script>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (165036 => 165037)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-04 04:21:39 UTC (rev 165036)
+++ trunk/Source/WebCore/ChangeLog 2014-03-04 06:37:43 UTC (rev 165037)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-03-03 Sanghyup Lee <sh53.lee@samsung.com>
+
+ :active style is not cleared when its display property is set to none before mouse released.
+ https://bugs.webkit.org/show_bug.cgi?id=129465
+
+ Reviewed by Antonio Gomes.
+
+ Source/WebCore:
+
+ We currently clearing the :active style when element has a renderer.
+ This patch makes elements clear its active style regardless of renderer.
+
+ * dom/Document.cpp:
+ (WebCore::Document::updateHoverActiveState):
+
+ LayoutTests:
+
+ * fast/css/active-display-none-expected.txt: Added.
+ * fast/css/active-display-none.html: Added.
+
+
</ins><span class="cx"> 2014-03-03 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove 2 unnecessary includes from JSDOMBinding.h
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (165036 => 165037)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2014-03-04 04:21:39 UTC (rev 165036)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-03-04 06:37:43 UTC (rev 165037)
</span><span class="lines">@@ -5835,12 +5835,9 @@
</span><span class="cx"> Element* oldActiveElement = m_activeElement.get();
</span><span class="cx"> if (oldActiveElement && !request.active()) {
</span><span class="cx"> // We are clearing the :active chain because the mouse has been released.
</span><del>- for (RenderElement* curr = oldActiveElement->renderer(); curr; curr = curr->parent()) {
- Element* element = curr->element();
- if (!element)
- continue;
- element->setActive(false);
- m_userActionElements.setInActiveChain(element, false);
</del><ins>+ for (Element* curr = oldActiveElement; curr; curr = curr->parentElement()) {
+ curr->setActive(false);
+ m_userActionElements.setInActiveChain(curr, false);
</ins><span class="cx"> }
</span><span class="cx"> m_activeElement.clear();
</span><span class="cx"> } else {
</span></span></pre>
</div>
</div>
</body>
</html>