<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164935] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164935">164935</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2014-03-01 19:45:06 -0800 (Sat, 01 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Source/JavaScriptCore: This shouldn't have been a layout test since it runs only under jsc. Moving it to JSC
stress tests.
* tests/stress/generational-opaque-roots.js: Copied from LayoutTests/js/script-tests/generational-opaque-roots.js.
LayoutTests: This shouldn't be a layout test since it runs only under jsc. Moving it to JSC
stress tests.
* js/script-tests/generational-opaque-roots.js: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoretestsstressgenerationalopaquerootsjs">trunk/Source/JavaScriptCore/tests/stress/generational-opaque-roots.js</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsjsscripttestsgenerationalopaquerootsjs">trunk/LayoutTests/js/script-tests/generational-opaque-roots.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164934 => 164935)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-03-02 00:35:13 UTC (rev 164934)
+++ trunk/LayoutTests/ChangeLog 2014-03-02 03:45:06 UTC (rev 164935)
</span><span class="lines">@@ -1,3 +1,10 @@
</span><ins>+2014-03-01 Filip Pizlo <fpizlo@apple.com>
+
+ This shouldn't be a layout test since it runs only under jsc. Moving it to JSC
+ stress tests.
+
+ * js/script-tests/generational-opaque-roots.js: Removed.
+
</ins><span class="cx"> 2014-03-01 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> Ensure keySplines is valid in SMIL animations
</span></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsgenerationalopaquerootsjs"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/js/script-tests/generational-opaque-roots.js (164934 => 164935)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/generational-opaque-roots.js 2014-03-02 00:35:13 UTC (rev 164934)
+++ trunk/LayoutTests/js/script-tests/generational-opaque-roots.js 2014-03-02 03:45:06 UTC (rev 164935)
</span><span class="lines">@@ -1,29 +0,0 @@
</span><del>-description("Tests that opaque roots behave correctly during young generation collections.");
-
-// Create the primary Root.
-var root = new Root();
-// This secondary root is for allocating a second Element without overriding
-// the primary Root's Element.
-var otherRoot = new Root();
-
-// Run an Eden collection so that the Root will be in the old gen (and won't be rescanned).
-edenGC();
-
-// Create a new Element and set a custom property on it.
-var elem = new Element(root);
-elem.customProperty = "hello";
-
-// Make the Element unreachable except through the ephemeron with the Root.
-elem = null;
-
-// Create another Element so that we process the weak handles in block of the original Element.
-var test = new Element(otherRoot);
-
-// Run another Eden collection to process the weak handles in the Element's block. If opaque roots
-// are cleared then we'll think that the original Element is dead because the Root won't be in the
-// set of opaque roots.
-edenGC();
-
-// Check if the primary Root's Element exists and has our custom property.
-var elem = getElement(root);
-shouldBe("elem.customProperty", "\"hello\"");
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (164934 => 164935)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-03-02 00:35:13 UTC (rev 164934)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-03-02 03:45:06 UTC (rev 164935)
</span><span class="lines">@@ -1,3 +1,10 @@
</span><ins>+2014-03-01 Filip Pizlo <fpizlo@apple.com>
+
+ This shouldn't have been a layout test since it runs only under jsc. Moving it to JSC
+ stress tests.
+
+ * tests/stress/generational-opaque-roots.js: Copied from LayoutTests/js/script-tests/generational-opaque-roots.js.
+
</ins><span class="cx"> 2014-03-01 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> JSCell::fastGetOwnProperty() should get the Structure more efficiently.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressgenerationalopaquerootsjsfromrev164934trunkLayoutTestsjsscripttestsgenerationalopaquerootsjs"></a>
<div class="copfile"><h4>Copied: trunk/Source/JavaScriptCore/tests/stress/generational-opaque-roots.js (from rev 164934, trunk/LayoutTests/js/script-tests/generational-opaque-roots.js) (0 => 164935)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/generational-opaque-roots.js (rev 0)
+++ trunk/Source/JavaScriptCore/tests/stress/generational-opaque-roots.js 2014-03-02 03:45:06 UTC (rev 164935)
</span><span class="lines">@@ -0,0 +1,30 @@
</span><ins>+// Tests that opaque roots behave correctly during young generation collections
+
+// Create the primary Root.
+var root = new Root();
+// This secondary root is for allocating a second Element without overriding
+// the primary Root's Element.
+var otherRoot = new Root();
+
+// Run an Eden collection so that the Root will be in the old gen (and won't be rescanned).
+edenGC();
+
+// Create a new Element and set a custom property on it.
+var elem = new Element(root);
+elem.customProperty = "hello";
+
+// Make the Element unreachable except through the ephemeron with the Root.
+elem = null;
+
+// Create another Element so that we process the weak handles in block of the original Element.
+var test = new Element(otherRoot);
+
+// Run another Eden collection to process the weak handles in the Element's block. If opaque roots
+// are cleared then we'll think that the original Element is dead because the Root won't be in the
+// set of opaque roots.
+edenGC();
+
+// Check if the primary Root's Element exists and has our custom property.
+var elem = getElement(root);
+if (elem.customProperty != "hello")
+ throw new Error("bad value of customProperty: " + elem.customProperty);
</ins></span></pre>
</div>
</div>
</body>
</html>