<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164930] trunk/Websites/webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164930">164930</a></dd>
<dt>Author</dt> <dd>darin@apple.com</dd>
<dt>Date</dt> <dd>2014-03-01 15:30:51 -0800 (Sat, 01 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Some small modernizing tweaks to the coding style guide
https://bugs.webkit.org/show_bug.cgi?id=129427
Reviewed by Alexey Proskuryakov.
My intent here was originally to do the nullptr style guide update, but that was already done.
I did some other improvements. There's still quite a bit to do -- the guide is out of date in
a number of subtle ways.
* coding/coding-style.html: Change "left side operator" example to be a more modern example
without non-WebKit-style abbreviations and such. Use auto& instead of const auto& in for loop
example, since that's normally preferred. Changed section title to say "zero" instead of "0".
Use words instead of abbreviations in code examples. Show that a modern C++ for loop is preferred
over index iteration in vector iteration example and also showed use of unsigned rather than
size_t since that is almost always what we want. Eliminated the use of PassOwnPtr in the "return
a newly created object" example. Use references instead of pointers in one example.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsiteswebkitorgChangeLog">trunk/Websites/webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsiteswebkitorgcodingcodingstylehtml">trunk/Websites/webkit.org/coding/coding-style.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsiteswebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/webkit.org/ChangeLog (164929 => 164930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/webkit.org/ChangeLog 2014-03-01 23:28:40 UTC (rev 164929)
+++ trunk/Websites/webkit.org/ChangeLog 2014-03-01 23:30:51 UTC (rev 164930)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-02-27 Darin Adler <darin@apple.com>
+
+ Some small modernizing tweaks to the coding style guide
+ https://bugs.webkit.org/show_bug.cgi?id=129427
+
+ Reviewed by Alexey Proskuryakov.
+
+ My intent here was originally to do the nullptr style guide update, but that was already done.
+ I did some other improvements. There's still quite a bit to do -- the guide is out of date in
+ a number of subtle ways.
+
+ * coding/coding-style.html: Change "left side operator" example to be a more modern example
+ without non-WebKit-style abbreviations and such. Use auto& instead of const auto& in for loop
+ example, since that's normally preferred. Changed section title to say "zero" instead of "0".
+ Use words instead of abbreviations in code examples. Show that a modern C++ for loop is preferred
+ over index iteration in vector iteration example and also showed use of unsigned rather than
+ size_t since that is almost always what we want. Eliminated the use of PassOwnPtr in the "return
+ a newly created object" example. Use references instead of pointers in one example.
+
</ins><span class="cx"> 2014-02-26 Julien Brianceau <jbriance@cisco.com>
</span><span class="cx">
</span><span class="cx"> Add Cisco to team.html
</span></span></pre></div>
<a id="trunkWebsiteswebkitorgcodingcodingstylehtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/webkit.org/coding/coding-style.html (164929 => 164930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/webkit.org/coding/coding-style.html 2014-03-01 23:28:40 UTC (rev 164929)
+++ trunk/Websites/webkit.org/coding/coding-style.html 2014-03-01 23:30:51 UTC (rev 164930)
</span><span class="lines">@@ -139,18 +139,16 @@
</span><span class="cx">
</span><span class="cx"> <h4 class="right">Right:</h4>
</span><span class="cx"> <pre class="code">
</span><del>-if (attr->name() == srcAttr
- || attr->name() == lowsrcAttr
- || (attr->name() == usemapAttr && attr->value().domString()[0] != '#'))
- return;
</del><ins>+return attribute.name() == srcAttr
+ || attribute.name() == lowsrcAttr
+ || (attribute.name() == usemapAttr &amp;&amp; attribute.value().string()[0] != '#');
</ins><span class="cx"> </pre>
</span><span class="cx">
</span><span class="cx"> <h4 class="wrong">Wrong:</h4>
</span><span class="cx"> <pre class="code">
</span><del>-if (attr->name() == srcAttr ||
- attr->name() == lowsrcAttr ||
- (attr->name() == usemapAttr && attr->value().domString()[0] != '#'))
- return;
</del><ins>+return attribute.name() == srcAttr ||
+ attribute.name() == lowsrcAttr ||
+ (attribute.name() == usemapAttr &amp;&amp; attr->value().string()[0] != '#');
</ins><span class="cx"> </pre>
</span><span class="cx"> </li>
</span><span class="cx">
</span><span class="lines">@@ -192,14 +190,14 @@
</span><span class="cx"> <h4 class="right">Right:</h4>
</span><span class="cx"> <pre class="code">
</span><span class="cx"> Vector&lt;PluginModuleInfo> plugins;
</span><del>-for (const auto&amp; plugin : plugins)
</del><ins>+for (auto&amp; plugin : plugins)
</ins><span class="cx"> registerPlugin(plugin);
</span><span class="cx"> </pre>
</span><span class="cx">
</span><span class="cx"> <h4 class="wrong">Wrong:</h4>
</span><span class="cx"> <pre class="code">
</span><span class="cx"> Vector&lt;PluginModuleInfo> plugins;
</span><del>-for (const auto&amp; plugin: plugins)
</del><ins>+for (auto&amp; plugin: plugins)
</ins><span class="cx"> registerPlugin(plugin);
</span><span class="cx"> </pre>
</span><span class="cx"> </li>
</span><span class="lines">@@ -421,7 +419,7 @@
</span><span class="cx"> </li>
</span><span class="cx"> </ol>
</span><span class="cx">
</span><del>-<h3 id="zero">Null, false and 0</h3>
</del><ins>+<h3 id="zero">Null, false and zero</h3>
</ins><span class="cx"> <ol>
</span><span class="cx"> <li id="zero-null">In C++, the null pointer value should be written as <code>nullptr</code>. In C, it should be written as <code>NULL</code>. In Objective-C and Objective-C++, follow the guideline for C or C++, respectively, but use <code>nil</code> to represent a null Objective-C object.</li>
</span><span class="cx">
</span><span class="lines">@@ -716,10 +714,10 @@
</span><span class="cx">
</span><span class="cx"> <h4 class="right">Right:</h4>
</span><span class="cx"> <pre class="code">
</span><del>-MyClass::MyClass(Document* doc)
</del><ins>+MyClass::MyClass(Document* document)
</ins><span class="cx"> : MySuperClass()
</span><span class="cx"> , m_myMember(0)
</span><del>- , m_doc(doc)
</del><ins>+ , m_document(document)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -731,21 +729,27 @@
</span><span class="cx">
</span><span class="cx"> <h4 class="wrong">Wrong:</h4>
</span><span class="cx"> <pre class="code">
</span><del>-MyClass::MyClass(Document* doc) : MySuperClass()
</del><ins>+MyClass::MyClass(Document* document) : MySuperClass()
</ins><span class="cx"> {
</span><span class="cx"> m_myMember = 0;
</span><del>- m_doc = doc;
</del><ins>+ m_document = document;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> MyOtherClass::MyOtherClass() : MySuperClass() {}
</span><span class="cx"> </pre>
</span><span class="cx">
</span><del>-<li id="punctuation-vector-index">Prefer index over iterator in Vector iterations for a terse, easier-to-read code.
</del><ins>+<li id="punctuation-vector-index">Prefer index over iterator in Vector iterations for terse, easier-to-read code.
</ins><span class="cx">
</span><span class="cx"> <h4 class="right">Right:</h4>
</span><span class="cx"> <pre class="code">
</span><del>-size_t frameViewsCount = frameViews.size();
-for (size_t i = 0; i &lt; frameViewsCount; ++i)
</del><ins>+for (auto&amp; frameView : frameViews)
+ frameView->updateLayoutAndStyleIfNeededRecursive();
+</pre>
+
+<h4 class="right">OK:</h4>
+<pre class="code">
+unsigned frameViewsCount = frameViews.size();
+for (unsigned i = 0; i &lt; frameViewsCount; ++i)
</ins><span class="cx"> frameViews[i]->updateLayoutAndStyleIfNeededRecursive();
</span><span class="cx"> </pre>
</span><span class="cx">
</span><span class="lines">@@ -855,7 +859,6 @@
</span><span class="cx"> #include "Attribute.h"
</span><span class="cx"> #include "HTMLElement.h"
</span><span class="cx"> #include "QualifiedName.h"
</span><del>-
</del><span class="cx"> </pre>
</span><span class="cx">
</span><span class="cx"> <h4 class="wrong">Wrong:</h4>
</span><span class="lines">@@ -1099,7 +1102,7 @@
</span><span class="cx"> class Vector {
</span><span class="cx"> public:
</span><span class="cx"> explicit Vector(int size); // Not a type conversion.
</span><del>- PassOwnPtr&lt;Vector&gt; create(Array); // Costly conversion.
</del><ins>+ Vector create(Array); // Costly conversion.
</ins><span class="cx"> ...
</span><span class="cx">
</span><span class="cx"> </pre>
</span><span class="lines">@@ -1108,9 +1111,9 @@
</span><span class="cx"> <pre class="code">
</span><span class="cx"> class Task {
</span><span class="cx"> public:
</span><del>- Task(ScriptExecutionContext*); // Not a type conversion.
</del><ins>+ Task(ScriptExecutionContext&amp;); // Not a type conversion.
</ins><span class="cx"> explicit Task(); // No arguments.
</span><del>- explicit Task(ScriptExecutionContext*, Other); // More than one argument.
</del><ins>+ explicit Task(ScriptExecutionContext&amp;, Other); // More than one argument.
</ins><span class="cx"> ...
</span><span class="cx"> </pre>
</span><span class="cx"> </li>
</span></span></pre>
</div>
</div>
</body>
</html>