<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164895] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164895">164895</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2014-02-28 16:40:22 -0800 (Fri, 28 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>VisitedLinkStore should be able to invalidate link styles for associated pages
https://bugs.webkit.org/show_bug.cgi?id=129515
Reviewed by Dan Bernstein.
* page/Page.cpp:
(WebCore::Page::Page):
Add the VisitedLinkStore if we have one.
(WebCore::Page::~Page):
Remove the VisitedLinkStore if we have one.
* page/VisitedLinkStore.cpp:
(WebCore::VisitedLinkStore::~VisitedLinkStore):
Assert that we don't have any pages.
(WebCore::VisitedLinkStore::addPage):
Add the page to the set.
(WebCore::VisitedLinkStore::removePage):
Remove the page from the set.
(WebCore::VisitedLinkStore::invalidateStylesForAllLinks):
Traverse all the pages and invalidate the style for all links.
(WebCore::VisitedLinkStore::invalidateStylesForLink):
Traverse all the pages and invalidate the style for a given link.
* page/VisitedLinkStore.h:
Add new members.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepagePagecpp">trunk/Source/WebCore/page/Page.cpp</a></li>
<li><a href="#trunkSourceWebCorepageVisitedLinkStorecpp">trunk/Source/WebCore/page/VisitedLinkStore.cpp</a></li>
<li><a href="#trunkSourceWebCorepageVisitedLinkStoreh">trunk/Source/WebCore/page/VisitedLinkStore.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164894 => 164895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-03-01 00:27:07 UTC (rev 164894)
+++ trunk/Source/WebCore/ChangeLog 2014-03-01 00:40:22 UTC (rev 164895)
</span><span class="lines">@@ -1,3 +1,36 @@
</span><ins>+2014-02-28 Anders Carlsson <andersca@apple.com>
+
+ VisitedLinkStore should be able to invalidate link styles for associated pages
+ https://bugs.webkit.org/show_bug.cgi?id=129515
+
+ Reviewed by Dan Bernstein.
+
+ * page/Page.cpp:
+ (WebCore::Page::Page):
+ Add the VisitedLinkStore if we have one.
+
+ (WebCore::Page::~Page):
+ Remove the VisitedLinkStore if we have one.
+
+ * page/VisitedLinkStore.cpp:
+ (WebCore::VisitedLinkStore::~VisitedLinkStore):
+ Assert that we don't have any pages.
+
+ (WebCore::VisitedLinkStore::addPage):
+ Add the page to the set.
+
+ (WebCore::VisitedLinkStore::removePage):
+ Remove the page from the set.
+
+ (WebCore::VisitedLinkStore::invalidateStylesForAllLinks):
+ Traverse all the pages and invalidate the style for all links.
+
+ (WebCore::VisitedLinkStore::invalidateStylesForLink):
+ Traverse all the pages and invalidate the style for a given link.
+
+ * page/VisitedLinkStore.h:
+ Add new members.
+
</ins><span class="cx"> 2014-02-28 Benjamin Poulain <bpoulain@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS][WK2] highlight rects should never big bigger than the view
</span></span></pre></div>
<a id="trunkSourceWebCorepagePagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.cpp (164894 => 164895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.cpp 2014-03-01 00:27:07 UTC (rev 164894)
+++ trunk/Source/WebCore/page/Page.cpp 2014-03-01 00:40:22 UTC (rev 164895)
</span><span class="lines">@@ -189,6 +189,9 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_editorClient);
</span><span class="cx">
</span><ins>+ if (m_visitedLinkStore)
+ m_visitedLinkStore->addPage(*this);
+
</ins><span class="cx"> if (!allPages) {
</span><span class="cx"> allPages = new HashSet<Page*>;
</span><span class="cx">
</span><span class="lines">@@ -239,6 +242,8 @@
</span><span class="cx">
</span><span class="cx"> if (m_userContentController)
</span><span class="cx"> m_userContentController->removePage(*this);
</span><ins>+ if (m_visitedLinkStore)
+ m_visitedLinkStore->removePage(*this);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> uint64_t Page::renderTreeSize() const
</span></span></pre></div>
<a id="trunkSourceWebCorepageVisitedLinkStorecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/VisitedLinkStore.cpp (164894 => 164895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/VisitedLinkStore.cpp 2014-03-01 00:27:07 UTC (rev 164894)
+++ trunk/Source/WebCore/page/VisitedLinkStore.cpp 2014-03-01 00:40:22 UTC (rev 164895)
</span><span class="lines">@@ -26,6 +26,8 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "VisitedLinkStore.h"
</span><span class="cx">
</span><ins>+#include "Page.h"
+
</ins><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> VisitedLinkStore::VisitedLinkStore()
</span><span class="lines">@@ -34,6 +36,33 @@
</span><span class="cx">
</span><span class="cx"> VisitedLinkStore::~VisitedLinkStore()
</span><span class="cx"> {
</span><ins>+ ASSERT(m_pages.isEmpty());
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+void VisitedLinkStore::addPage(Page& page)
+{
+ ASSERT(!m_pages.contains(&page));
+
+ m_pages.add(&page);
</ins><span class="cx"> }
</span><ins>+
+void VisitedLinkStore::removePage(Page& page)
+{
+ ASSERT(m_pages.contains(&page));
+
+ m_pages.remove(&page);
+}
+
+void VisitedLinkStore::invalidateStylesForAllLinks()
+{
+ for (auto& page : m_pages)
+ page->invalidateStylesForAllLinks();
+}
+
+void VisitedLinkStore::invalidateStylesForLink(LinkHash linkHash)
+{
+ for (auto& page : m_pages)
+ page->invalidateStylesForLink(linkHash);
+}
+
+} // namespace WebCore
</ins></span></pre></div>
<a id="trunkSourceWebCorepageVisitedLinkStoreh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/VisitedLinkStore.h (164894 => 164895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/VisitedLinkStore.h 2014-03-01 00:27:07 UTC (rev 164894)
+++ trunk/Source/WebCore/page/VisitedLinkStore.h 2014-03-01 00:40:22 UTC (rev 164895)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx"> #define VisitedLinkStore_h
</span><span class="cx">
</span><span class="cx"> #include <wtf/Forward.h>
</span><ins>+#include <wtf/HashSet.h>
</ins><span class="cx"> #include <wtf/PassRefPtr.h>
</span><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx">
</span><span class="lines">@@ -44,6 +45,15 @@
</span><span class="cx"> // FIXME: These two members should only take the link hash.
</span><span class="cx"> virtual bool isLinkVisited(Page&, LinkHash, const URL& baseURL, const AtomicString& attributeURL) = 0;
</span><span class="cx"> virtual void addVisitedLink(Page&, LinkHash) = 0;
</span><ins>+
+ void addPage(Page&);
+ void removePage(Page&);
+
+ void invalidateStylesForAllLinks();
+ void invalidateStylesForLink(LinkHash);
+
+private:
+ HashSet<Page*> m_pages;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre>
</div>
</div>
</body>
</html>