<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164871] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164871">164871</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-02-28 10:44:10 -0800 (Fri, 28 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>MouseEvent.offsetX/Y should just return 0,0 for simulated clicks.
<https://webkit.org/b/129477>
Source/WebCore:
There's no need to compute the exact target-relative coordinates for
simulated mouse events, e.g those fired by HTMLElement.click().
The offsetX/Y properties are not supported by Firefox.
Test: fast/events/relative-offset-of-simulated-click.html
Reviewed by Alexey Proskuryakov.
* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::offsetX):
(WebCore::MouseRelatedEvent::offsetY):
LayoutTests:
Add a test documenting the behavior of offsetX/Y on the simulated
mouse events that get sent by HTMLElement.click().
Reviewed by Alexey Proskuryakov.
* fast/events/relative-offset-of-simulated-click-expected.txt: Added.
* fast/events/relative-offset-of-simulated-click.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomMouseRelatedEventcpp">trunk/Source/WebCore/dom/MouseRelatedEvent.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasteventsrelativeoffsetofsimulatedclickexpectedtxt">trunk/LayoutTests/fast/events/relative-offset-of-simulated-click-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsrelativeoffsetofsimulatedclickhtml">trunk/LayoutTests/fast/events/relative-offset-of-simulated-click.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164870 => 164871)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-28 18:36:03 UTC (rev 164870)
+++ trunk/LayoutTests/ChangeLog 2014-02-28 18:44:10 UTC (rev 164871)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-02-28 Andreas Kling <akling@apple.com>
+
+ MouseEvent.offsetX/Y should just return 0,0 for simulated clicks.
+ <https://webkit.org/b/129477>
+
+ Add a test documenting the behavior of offsetX/Y on the simulated
+ mouse events that get sent by HTMLElement.click().
+
+ Reviewed by Alexey Proskuryakov.
+
+ * fast/events/relative-offset-of-simulated-click-expected.txt: Added.
+ * fast/events/relative-offset-of-simulated-click.html: Added.
+
</ins><span class="cx"> 2014-02-27 Sergio Villar Senin <svillar@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CSS Grid Layout] Fix positioning grid items using named grid lines/areas
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsrelativeoffsetofsimulatedclickexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/relative-offset-of-simulated-click-expected.txt (0 => 164871)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/relative-offset-of-simulated-click-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/relative-offset-of-simulated-click-expected.txt 2014-02-28 18:44:10 UTC (rev 164871)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+This test documents the behavior of MouseEvent.offsetX/Y in response to HTMLElement.click().
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Simulated click with .click():
+PASS event.offsetX is 0
+PASS event.offsetY is 0
+Click with mouse at 0,0:
+PASS event.offsetX is 0
+PASS event.offsetY is 0
+Click with mouse at 40,50:
+PASS event.offsetX is 40
+PASS event.offsetY is 50
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventsrelativeoffsetofsimulatedclickhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/relative-offset-of-simulated-click.html (0 => 164871)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/relative-offset-of-simulated-click.html (rev 0)
+++ trunk/LayoutTests/fast/events/relative-offset-of-simulated-click.html 2014-02-28 18:44:10 UTC (rev 164871)
</span><span class="lines">@@ -0,0 +1,50 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<script src="../../resources/js-test-pre.js"></script>
+</head>
+<body>
+<script>
+
+description("This test documents the behavior of MouseEvent.offsetX/Y in response to HTMLElement.click().");
+
+var testDiv = document.createElement("div");
+testDiv.setAttribute("style", "background: green; width: 100px; height: 100px; position: absolute; top: 100px; left: 100px;");
+document.body.appendChild(testDiv);
+
+testDiv.addEventListener("click", function(e) {
+ event = e;
+ shouldBe("event.offsetX", expectedX);
+ shouldBe("event.offsetY", expectedY);
+});
+
+debug("Simulated click with .click():");
+expectedX = "0";
+expectedY = "0";
+testDiv.click();
+
+if (!window.eventSender)
+ debug("This part of the test requires eventSender!");
+else {
+ debug("Click with mouse at 0,0:");
+ expectedX = "0";
+ expectedY = "0";
+ eventSender.mouseMoveTo(100, 100);
+ eventSender.mouseDown();
+ eventSender.mouseUp();
+
+ debug("Click with mouse at 40,50:");
+ expectedX = "40";
+ expectedY = "50";
+ eventSender.mouseMoveTo(140, 150);
+ eventSender.mouseDown();
+ eventSender.mouseUp();
+}
+
+testDiv.remove();
+
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164870 => 164871)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-28 18:36:03 UTC (rev 164870)
+++ trunk/Source/WebCore/ChangeLog 2014-02-28 18:44:10 UTC (rev 164871)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-02-28 Andreas Kling <akling@apple.com>
+
+ MouseEvent.offsetX/Y should just return 0,0 for simulated clicks.
+ <https://webkit.org/b/129477>
+
+ There's no need to compute the exact target-relative coordinates for
+ simulated mouse events, e.g those fired by HTMLElement.click().
+
+ The offsetX/Y properties are not supported by Firefox.
+
+ Test: fast/events/relative-offset-of-simulated-click.html
+
+ Reviewed by Alexey Proskuryakov.
+
+ * dom/MouseRelatedEvent.cpp:
+ (WebCore::MouseRelatedEvent::offsetX):
+ (WebCore::MouseRelatedEvent::offsetY):
+
</ins><span class="cx"> 2014-02-27 Sergio Villar Senin <svillar@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CSS Grid Layout] Fix positioning grid items using named grid lines/areas
</span></span></pre></div>
<a id="trunkSourceWebCoredomMouseRelatedEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MouseRelatedEvent.cpp (164870 => 164871)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MouseRelatedEvent.cpp 2014-02-28 18:36:03 UTC (rev 164870)
+++ trunk/Source/WebCore/dom/MouseRelatedEvent.cpp 2014-02-28 18:44:10 UTC (rev 164871)
</span><span class="lines">@@ -208,6 +208,8 @@
</span><span class="cx">
</span><span class="cx"> int MouseRelatedEvent::offsetX()
</span><span class="cx"> {
</span><ins>+ if (isSimulated())
+ return 0;
</ins><span class="cx"> if (!m_hasCachedRelativePosition)
</span><span class="cx"> computeRelativePosition();
</span><span class="cx"> return roundToInt(m_offsetLocation.x());
</span><span class="lines">@@ -215,6 +217,8 @@
</span><span class="cx">
</span><span class="cx"> int MouseRelatedEvent::offsetY()
</span><span class="cx"> {
</span><ins>+ if (isSimulated())
+ return 0;
</ins><span class="cx"> if (!m_hasCachedRelativePosition)
</span><span class="cx"> computeRelativePosition();
</span><span class="cx"> return roundToInt(m_offsetLocation.y());
</span></span></pre>
</div>
</div>
</body>
</html>