<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164730] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164730">164730</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2014-02-26 11:34:34 -0800 (Wed, 26 Feb 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: Remove console.profiles from window.console API
https://bugs.webkit.org/show_bug.cgi?id=116883

Reviewed by Timothy Hatcher.

Source/WebCore:

console.profiles has been removed or never implemented by other
browsers. We should remove it as well. However, since tests
rely on it, keep it as window.internals.consoleProfiles.

* WebCore.exp.in:
* page/Console.idl:
* testing/Internals.cpp:
(WebCore::Internals::consoleProfiles):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

LayoutTests:

* fast/profiler/resources/profiler-test-JS-resources.js:
(printHeavyProfilesDataWithoutTime):
(printProfilesDataWithoutTime):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastprofilerresourcesprofilertestJSresourcesjs">trunk/LayoutTests/fast/profiler/resources/profiler-test-JS-resources.js</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCoreexpin">trunk/Source/WebCore/WebCore.exp.in</a></li>
<li><a href="#trunkSourceWebCorepageConsoleidl">trunk/Source/WebCore/page/Console.idl</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingInternalsh">trunk/Source/WebCore/testing/Internals.h</a></li>
<li><a href="#trunkSourceWebCoretestingInternalsidl">trunk/Source/WebCore/testing/Internals.idl</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitWebKitvcxprojWebKitExportGeneratorWebKitExportsdefin">trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in</a></li>
<li><a href="#trunkSourceWebKitgtkChangeLog">trunk/Source/WebKit/gtk/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitgtkwebkitwebkitwebinspectorcpp">trunk/Source/WebKit/gtk/webkit/webkitwebinspector.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164729 => 164730)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2014-02-26 19:22:45 UTC (rev 164729)
+++ trunk/LayoutTests/ChangeLog        2014-02-26 19:34:34 UTC (rev 164730)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-02-26  Joseph Pecoraro  &lt;pecoraro@apple.com&gt;
+
+        Web Inspector: Remove console.profiles from window.console API
+        https://bugs.webkit.org/show_bug.cgi?id=116883
+
+        Reviewed by Timothy Hatcher.
+
+        * fast/profiler/resources/profiler-test-JS-resources.js:
+        (printHeavyProfilesDataWithoutTime):
+        (printProfilesDataWithoutTime):
+
</ins><span class="cx"> 2014-02-26  Sergio Villar Senin  &lt;svillar@igalia.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [CSS Grid Layout] Check default getComputedStyle() return values for grid properties
</span></span></pre></div>
<a id="trunkLayoutTestsfastprofilerresourcesprofilertestJSresourcesjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/profiler/resources/profiler-test-JS-resources.js (164729 => 164730)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/profiler/resources/profiler-test-JS-resources.js        2014-02-26 19:22:45 UTC (rev 164729)
+++ trunk/LayoutTests/fast/profiler/resources/profiler-test-JS-resources.js        2014-02-26 19:34:34 UTC (rev 164730)
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx">     var preElement = document.createElement(&quot;pre&quot;);
</span><span class="cx">     preElement.appendChild(document.createTextNode(&quot;\n&quot;));
</span><span class="cx"> 
</span><del>-    var profiles = console.profiles;
</del><ins>+    var profiles = internals.consoleProfiles;
</ins><span class="cx">     for (var i = 0; i &lt; profiles.length; ++i) {
</span><span class="cx">         preElement.appendChild(document.createTextNode(&quot;Profile title: &quot; + profiles[i].title + &quot;\n&quot;));
</span><span class="cx">         printProfileNodeWithoutTime(preElement, profiles[i].heavyProfile.head, 0);
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx">     var preElement = document.createElement(&quot;pre&quot;);
</span><span class="cx">     preElement.appendChild(document.createTextNode(&quot;\n&quot;));
</span><span class="cx"> 
</span><del>-    var profiles = console.profiles;
</del><ins>+    var profiles = internals.consoleProfiles;
</ins><span class="cx">     for (var i = 0; i &lt; profiles.length; ++i) {
</span><span class="cx">         preElement.appendChild(document.createTextNode(&quot;Profile title: &quot; + profiles[i].title + &quot;\n&quot;));
</span><span class="cx">         printProfileNodeWithoutTime(preElement, profiles[i].head, 0);
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164729 => 164730)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-02-26 19:22:45 UTC (rev 164729)
+++ trunk/Source/WebCore/ChangeLog        2014-02-26 19:34:34 UTC (rev 164730)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-02-26  Joseph Pecoraro  &lt;pecoraro@apple.com&gt;
+
+        Web Inspector: Remove console.profiles from window.console API
+        https://bugs.webkit.org/show_bug.cgi?id=116883
+
+        Reviewed by Timothy Hatcher.
+
+        console.profiles has been removed or never implemented by other
+        browsers. We should remove it as well. However, since tests
+        rely on it, keep it as window.internals.consoleProfiles.
+
+        * WebCore.exp.in:
+        * page/Console.idl:
+        * testing/Internals.cpp:
+        (WebCore::Internals::consoleProfiles):
+        * testing/Internals.h:
+        * testing/Internals.idl:
+
</ins><span class="cx"> 2014-02-26  Martin Hock  &lt;mhock@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Create SessionID value-style class for session IDs.
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCoreexpin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.exp.in (164729 => 164730)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.exp.in        2014-02-26 19:22:45 UTC (rev 164729)
+++ trunk/Source/WebCore/WebCore.exp.in        2014-02-26 19:34:34 UTC (rev 164730)
</span><span class="lines">@@ -1078,6 +1078,7 @@
</span><span class="cx"> __ZN7WebCore4coreEP28NSURLAuthenticationChallenge
</span><span class="cx"> __ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_10ClientRectE
</span><span class="cx"> __ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_13DOMStringListE
</span><ins>+__ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_13ScriptProfileE
</ins><span class="cx"> __ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_14ClientRectListE
</span><span class="cx"> __ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_19CSSStyleDeclarationE
</span><span class="cx"> __ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_5RangeE
</span><span class="lines">@@ -1869,6 +1870,7 @@
</span><span class="cx"> __ZNK7WebCore8Settings19sansSerifFontFamilyE11UScriptCode
</span><span class="cx"> __ZNK7WebCore8Settings20pictographFontFamilyE11UScriptCode
</span><span class="cx"> __ZNK7WebCore9DOMWindow27pendingUnloadEventListenersEv
</span><ins>+__ZNK7WebCore9DOMWindow7consoleEv
</ins><span class="cx"> __ZNK7WebCore9FloatQuad11boundingBoxEv
</span><span class="cx"> __ZNK7WebCore9FloatRect10intersectsERKS0_
</span><span class="cx"> __ZNK7WebCore9FloatRectcv6CGRectEv
</span></span></pre></div>
<a id="trunkSourceWebCorepageConsoleidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Console.idl (164729 => 164730)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Console.idl        2014-02-26 19:22:45 UTC (rev 164729)
+++ trunk/Source/WebCore/page/Console.idl        2014-02-26 19:34:34 UTC (rev 164730)
</span><span class="lines">@@ -43,10 +43,6 @@
</span><span class="cx">     [CallWith=ScriptArguments&amp;ScriptState, ImplementedAs=assertCondition] void assert(boolean condition);
</span><span class="cx">     [CallWith=ScriptArguments&amp;ScriptState] void count();
</span><span class="cx"> 
</span><del>-    // As per spec: http://www.w3.org/TR/WebIDL/#idl-sequence
-    // &quot;Sequences must not be used as the type of an attribute, constant or exception field.&quot;
-    // FIXME: this will lead to BUG console.profiles !== console.profiles as profile will always returns new array.
-    readonly attribute ScriptProfile[] profiles;
</del><span class="cx">     [CallWith=ScriptState] void profile([TreatNullAs=NullString, TreatUndefinedAs=NullString] optional DOMString title);
</span><span class="cx">     [CallWith=ScriptState] void profileEnd([TreatNullAs=NullString, TreatUndefinedAs=NullString] optional DOMString title);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (164729 => 164730)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp        2014-02-26 19:22:45 UTC (rev 164729)
+++ trunk/Source/WebCore/testing/Internals.cpp        2014-02-26 19:34:34 UTC (rev 164730)
</span><span class="lines">@@ -36,6 +36,7 @@
</span><span class="cx"> #include &quot;ChromeClient.h&quot;
</span><span class="cx"> #include &quot;ClientRect.h&quot;
</span><span class="cx"> #include &quot;ClientRectList.h&quot;
</span><ins>+#include &quot;Console.h&quot;
</ins><span class="cx"> #include &quot;ContentDistributor.h&quot;
</span><span class="cx"> #include &quot;Cursor.h&quot;
</span><span class="cx"> #include &quot;DOMStringList.h&quot;
</span><span class="lines">@@ -1435,6 +1436,11 @@
</span><span class="cx">     document-&gt;frame()-&gt;editor().toggleOverwriteModeEnabled();
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+const ProfilesArray&amp; Internals::consoleProfiles() const
+{
+    return contextDocument()-&gt;domWindow()-&gt;console()-&gt;profiles();
+}
+
</ins><span class="cx"> #if ENABLE(INSPECTOR)
</span><span class="cx"> unsigned Internals::numberOfLiveNodes() const
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.h (164729 => 164730)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.h        2014-02-26 19:22:45 UTC (rev 164729)
+++ trunk/Source/WebCore/testing/Internals.h        2014-02-26 19:34:34 UTC (rev 164730)
</span><span class="lines">@@ -50,17 +50,19 @@
</span><span class="cx"> class Frame;
</span><span class="cx"> class InspectorFrontendChannelDummy;
</span><span class="cx"> class InternalSettings;
</span><ins>+class MallocStatistics;
</ins><span class="cx"> class MemoryInfo;
</span><span class="cx"> class Node;
</span><span class="cx"> class Page;
</span><span class="cx"> class Range;
</span><span class="cx"> class ScriptExecutionContext;
</span><del>-class MallocStatistics;
</del><ins>+class ScriptProfile;
</ins><span class="cx"> class SerializedScriptValue;
</span><span class="cx"> class TimeRanges;
</span><span class="cx"> class TypeConversions;
</span><span class="cx"> 
</span><span class="cx"> typedef int ExceptionCode;
</span><ins>+typedef Vector&lt;RefPtr&lt;ScriptProfile&gt;&gt; ProfilesArray;
</ins><span class="cx"> 
</span><span class="cx"> class Internals : public RefCounted&lt;Internals&gt;
</span><span class="cx">                 , public ContextDestructionObserver {
</span><span class="lines">@@ -222,6 +224,8 @@
</span><span class="cx">     void insertAuthorCSS(const String&amp;, ExceptionCode&amp;) const;
</span><span class="cx">     void insertUserCSS(const String&amp;, ExceptionCode&amp;) const;
</span><span class="cx"> 
</span><ins>+    const ProfilesArray&amp; consoleProfiles() const;
+
</ins><span class="cx"> #if ENABLE(INSPECTOR)
</span><span class="cx">     unsigned numberOfLiveNodes() const;
</span><span class="cx">     unsigned numberOfLiveDocuments() const;
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalsidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.idl (164729 => 164730)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.idl        2014-02-26 19:22:45 UTC (rev 164729)
+++ trunk/Source/WebCore/testing/Internals.idl        2014-02-26 19:34:34 UTC (rev 164730)
</span><span class="lines">@@ -186,6 +186,11 @@
</span><span class="cx">     [RaisesException] void setDeviceProximity(DOMString eventType, double value, double min, double max);
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><ins>+    // As per spec: http://www.w3.org/TR/WebIDL/#idl-sequence
+    // &quot;Sequences must not be used as the type of an attribute, constant or exception field.&quot;
+    // FIXME: this will lead to BUG interals.consoleProfiles !== interals.consoleProfiles as profile will always returns new array.
+    readonly attribute ScriptProfile[] consoleProfiles;
+
</ins><span class="cx">     [Conditional=INSPECTOR] unsigned long numberOfLiveNodes();
</span><span class="cx">     [Conditional=INSPECTOR] unsigned long numberOfLiveDocuments();
</span><span class="cx">     [Conditional=INSPECTOR] sequence&lt;DOMString&gt; consoleMessageArgumentCounts();
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (164729 => 164730)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog        2014-02-26 19:22:45 UTC (rev 164729)
+++ trunk/Source/WebKit/ChangeLog        2014-02-26 19:34:34 UTC (rev 164730)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2014-02-26  Joseph Pecoraro  &lt;pecoraro@apple.com&gt;
+
+        Web Inspector: Remove console.profiles from window.console API
+        https://bugs.webkit.org/show_bug.cgi?id=116883
+
+        Reviewed by Timothy Hatcher.
+
+        * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
+
</ins><span class="cx"> 2014-02-24  Martin Robinson  &lt;mrobinson@igalia.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
</span></span></pre></div>
<a id="trunkSourceWebKitWebKitvcxprojWebKitExportGeneratorWebKitExportsdefin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in (164729 => 164730)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in        2014-02-26 19:22:45 UTC (rev 164729)
+++ trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in        2014-02-26 19:34:34 UTC (rev 164730)
</span><span class="lines">@@ -357,6 +357,8 @@
</span><span class="cx">         symbolWithPointer(?pageProperty@PrintContext@WebCore@@SA?AVString@WTF@@PAVFrame@2@PBDH@Z, ?pageProperty@PrintContext@WebCore@@SA?AVString@WTF@@PEAVFrame@2@PEBDH@Z)
</span><span class="cx">         symbolWithPointer(?pageSizeAndMarginsInPixels@PrintContext@WebCore@@SA?AVString@WTF@@PAVFrame@2@HHHHHHH@Z, ?pageSizeAndMarginsInPixels@PrintContext@WebCore@@SA?AVString@WTF@@PEAVFrame@2@HHHHHHH@Z)
</span><span class="cx">         symbolWithPointer(?close@DOMWindow@WebCore@@QAEXPAVScriptExecutionContext@2@@Z, ?close@DOMWindow@WebCore@@QEAAXPEAVScriptExecutionContext@2@@Z)
</span><ins>+        symbolWithPointer(?console@DOMWindow@WebCore@@QBEPAVConsole@2@XZ, ?console@DOMWindow@WebCore@@QBEPAVConsole@2@XZ)
+        symbolWithPointer(?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVScriptProfile@1@@Z, ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVScriptProfile@1@@Z)
</ins><span class="cx">         symbolWithPointer(?document@DOMWindow@WebCore@@QBEPAVDocument@2@XZ, ?document@DOMWindow@WebCore@@QEBAPEAVDocument@2@XZ)
</span><span class="cx">         symbolWithPointer(?open@DOMWindow@WebCore@@QAE?AV?$PassRefPtr@VDOMWindow@WebCore@@@WTF@@ABVString@4@ABVAtomicString@4@0AAV12@2@Z, ?open@DOMWindow@WebCore@@QEAA?AV?$PassRefPtr@VDOMWindow@WebCore@@@WTF@@AEBVString@4@AEBVAtomicString@4@0AEAV12@2@Z)
</span><span class="cx">         symbolWithPointer(?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVDOMWindow@1@@Z, ?toJS@WebCore@@YA?AVJSValue@JSC@@PEAVExecState@3@PEAVJSDOMGlobalObject@1@PEAVDOMWindow@1@@Z)
</span></span></pre></div>
<a id="trunkSourceWebKitgtkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/ChangeLog (164729 => 164730)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/ChangeLog        2014-02-26 19:22:45 UTC (rev 164729)
+++ trunk/Source/WebKit/gtk/ChangeLog        2014-02-26 19:34:34 UTC (rev 164730)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-02-26  Joseph Pecoraro  &lt;pecoraro@apple.com&gt;
+
+        Web Inspector: Remove console.profiles from window.console API
+        https://bugs.webkit.org/show_bug.cgi?id=116883
+
+        Reviewed by Timothy Hatcher.
+
+        * webkit/webkitwebinspector.cpp:
+        (webkit_web_inspector_class_init):
+        Removed stale part of comment.
+
</ins><span class="cx"> 2014-02-26  Martin Robinson  &lt;mrobinson@igalia.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
</span></span></pre></div>
<a id="trunkSourceWebKitgtkwebkitwebkitwebinspectorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/webkit/webkitwebinspector.cpp (164729 => 164730)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/webkit/webkitwebinspector.cpp        2014-02-26 19:22:45 UTC (rev 164729)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebinspector.cpp        2014-02-26 19:34:34 UTC (rev 164730)
</span><span class="lines">@@ -292,8 +292,7 @@
</span><span class="cx">     /**
</span><span class="cx">     * WebKitWebInspector:javascript-profiling-enabled:
</span><span class="cx">     *
</span><del>-    * This is enabling JavaScript profiling in the Inspector. This means
-    * that Console.profiles will return the profiles.
</del><ins>+    * This is enabling JavaScript profiling in the Inspector.
</ins><span class="cx">     *
</span><span class="cx">     * Since: 1.1.1
</span><span class="cx">     */
</span></span></pre>
</div>
</div>

</body>
</html>