<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164685] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164685">164685</a></dd>
<dt>Author</dt> <dd>samuel_white@apple.com</dd>
<dt>Date</dt> <dd>2014-02-25 17:27:55 -0800 (Tue, 25 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add accessibility search predicate support for AXOutlines
https://bugs.webkit.org/show_bug.cgi?id=123748
Reviewed by Chris Fleizach.
Source/WebCore:
Added new AXOutlineSearchKey to support finding elements with aria role=tree.
No new tests, updated existing search-predicate.html test to cover AXOutlineSearchKey.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):
* accessibility/AccessibilityObject.h:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilitySearchKeyMap):
LayoutTests:
Updated test to validate support for AXOutlineSearchKey (elements with aria role=tree).
* platform/mac/accessibility/search-predicate-expected.txt:
* platform/mac/accessibility/search-predicate.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitysearchpredicateexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitysearchpredicatehtml">trunk/LayoutTests/platform/mac/accessibility/search-predicate.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjecth">trunk/Source/WebCore/accessibility/AccessibilityObject.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164684 => 164685)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-26 01:06:00 UTC (rev 164684)
+++ trunk/LayoutTests/ChangeLog 2014-02-26 01:27:55 UTC (rev 164685)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-02-25 Samuel White <samuel_white@apple.com>
+
+ Add accessibility search predicate support for AXOutlines
+ https://bugs.webkit.org/show_bug.cgi?id=123748
+
+ Reviewed by Chris Fleizach.
+
+ Updated test to validate support for AXOutlineSearchKey (elements with aria role=tree).
+
+ * platform/mac/accessibility/search-predicate-expected.txt:
+ * platform/mac/accessibility/search-predicate.html:
+
</ins><span class="cx"> 2014-02-25 Laszlo Vidacs <lvidacs.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> display:table with padding and/or borders in border-box calculates height incorrectly
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitysearchpredicateexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt (164684 => 164685)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt 2014-02-26 01:06:00 UTC (rev 164684)
+++ trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt 2014-02-26 01:27:55 UTC (rev 164685)
</span><span class="lines">@@ -33,6 +33,7 @@
</span><span class="cx"> first table body level 1
</span><span class="cx"> second table heading level 1
</span><span class="cx"> second table body level 1
</span><ins>+tree item
</ins><span class="cx"> isVisible test start
</span><span class="cx">
</span><span class="cx"> test button 1
</span><span class="lines">@@ -95,6 +96,8 @@
</span><span class="cx"> PASS resultElement.role is 'AXRole: AXList'
</span><span class="cx"> PASS resultElement.role is 'AXRole: AXGroup'
</span><span class="cx"> PASS resultElement.stringAttributeValue('AXARIALive') is 'polite'
</span><ins>+PASS resultElement.role is 'AXRole: AXOutline'
+PASS resultElement.childAtIndex(0).childAtIndex(0).stringValue is 'AXValue: tree item'
</ins><span class="cx"> PASS resultElement.role is 'AXRole: AXStaticText'
</span><span class="cx"> PASS resultElement.stringValue is 'AXValue: first blockquote level 1'
</span><span class="cx"> PASS resultElement.role is 'AXRole: AXRadioGroup'
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitysearchpredicatehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/search-predicate.html (164684 => 164685)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/search-predicate.html 2014-02-26 01:06:00 UTC (rev 164684)
+++ trunk/LayoutTests/platform/mac/accessibility/search-predicate.html 2014-02-26 01:27:55 UTC (rev 164685)
</span><span class="lines">@@ -35,6 +35,7 @@
</span><span class="cx"> <thead><tr><td>second table heading level 1</td></tr></thead>
</span><span class="cx"> <tbody><tr><td>second table body level 1</td></tr></tbody>
</span><span class="cx"> </table>
</span><ins>+<ul role="tree"><li role="treeitem">tree item</li></ul>
</ins><span class="cx">
</span><span class="cx"> <h1>isVisible test start</h1>
</span><span class="cx"> <div id="group" style="overflow: scroll; width:100px; height:100px;">
</span><span class="lines">@@ -210,6 +211,12 @@
</span><span class="cx"> // Misspelled word.
</span><span class="cx"> // FIXME: Handle this search key.
</span><span class="cx">
</span><ins>+ // Outline.
+ startElement = accessibilityController.focusedElement.childAtIndex(0);
+ resultElement = containerElement.uiElementForSearchPredicate(startElement, true, "AXOutlineSearchKey", "", false);
+ shouldBe("resultElement.role", "'AXRole: AXOutline'");
+ shouldBe("resultElement.childAtIndex(0).childAtIndex(0).stringValue", "'AXValue: tree item'");
+
</ins><span class="cx"> // Plain text.
</span><span class="cx"> startElement = accessibilityController.focusedElement.childAtIndex(0);
</span><span class="cx"> resultElement = containerElement.uiElementForSearchPredicate(startElement, true, "AXPlainTextSearchKey", "", false);
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164684 => 164685)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-26 01:06:00 UTC (rev 164684)
+++ trunk/Source/WebCore/ChangeLog 2014-02-26 01:27:55 UTC (rev 164685)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-02-25 Samuel White <samuel_white@apple.com>
+
+ Add accessibility search predicate support for AXOutlines
+ https://bugs.webkit.org/show_bug.cgi?id=123748
+
+ Reviewed by Chris Fleizach.
+
+ Added new AXOutlineSearchKey to support finding elements with aria role=tree.
+
+ No new tests, updated existing search-predicate.html test to cover AXOutlineSearchKey.
+
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):
+ * accessibility/AccessibilityObject.h:
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (createAccessibilitySearchKeyMap):
+
</ins><span class="cx"> 2014-02-25 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> Need to initialize VM stack data even when the VM is on an exclusive thread.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (164684 => 164685)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2014-02-26 01:06:00 UTC (rev 164684)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2014-02-26 01:27:55 UTC (rev 164685)
</span><span class="lines">@@ -203,6 +203,9 @@
</span><span class="cx"> case MisspelledWordSearchKey:
</span><span class="cx"> return axObject->hasMisspelling();
</span><span class="cx">
</span><ins>+ case OutlineSearchKey:
+ return axObject->isTree();
+
</ins><span class="cx"> case PlainTextSearchKey:
</span><span class="cx"> return axObject->hasPlainText();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (164684 => 164685)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.h 2014-02-26 01:06:00 UTC (rev 164684)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h 2014-02-26 01:27:55 UTC (rev 164685)
</span><span class="lines">@@ -316,6 +316,7 @@
</span><span class="cx"> ListSearchKey,
</span><span class="cx"> LiveRegionSearchKey,
</span><span class="cx"> MisspelledWordSearchKey,
</span><ins>+ OutlineSearchKey,
</ins><span class="cx"> PlainTextSearchKey,
</span><span class="cx"> RadioGroupSearchKey,
</span><span class="cx"> SameTypeSearchKey,
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (164684 => 164685)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-02-26 01:06:00 UTC (rev 164684)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-02-26 01:27:55 UTC (rev 164685)
</span><span class="lines">@@ -326,6 +326,10 @@
</span><span class="cx"> #define NSAccessibilityMisspelledWordSearchKey @"AXMisspelledWordSearchKey"
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+#ifndef NSAccessibilityOutlineSearchKey
+#define NSAccessibilityOutlineSearchKey @"AXOutlineSearchKey"
+#endif
+
</ins><span class="cx"> #ifndef NSAccessibilityPlainTextSearchKey
</span><span class="cx"> #define NSAccessibilityPlainTextSearchKey @"AXPlainTextSearchKey"
</span><span class="cx"> #endif
</span><span class="lines">@@ -553,6 +557,7 @@
</span><span class="cx"> { NSAccessibilityListSearchKey, ListSearchKey },
</span><span class="cx"> { NSAccessibilityLiveRegionSearchKey, LiveRegionSearchKey },
</span><span class="cx"> { NSAccessibilityMisspelledWordSearchKey, MisspelledWordSearchKey },
</span><ins>+ { NSAccessibilityOutlineSearchKey, OutlineSearchKey },
</ins><span class="cx"> { NSAccessibilityPlainTextSearchKey, PlainTextSearchKey },
</span><span class="cx"> { NSAccessibilityRadioGroupSearchKey, RadioGroupSearchKey },
</span><span class="cx"> { NSAccessibilitySameTypeSearchKey, SameTypeSearchKey },
</span></span></pre>
</div>
</div>
</body>
</html>