<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164588] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164588">164588</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-02-24 09:05:33 -0800 (Mon, 24 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Remove single quote characters from Web Inspector JavaScript files
https://bugs.webkit.org/show_bug.cgi?id=129253
Patch by Diego Pino Garcia <dpino@igalia.com> on 2014-02-24
Reviewed by Timothy Hatcher.
* UserInterface/Base/Main.js:
(WebInspector.openURL):
* UserInterface/Views/CookieStorageContentView.js:
(WebInspector.cookieDomainMatchesResourceDomain):
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
(WebInspector.DOMTreeElement.prototype._startEditingTagName.editingComitted):
(WebInspector.DOMTreeElement.prototype._startEditingTagName.editingCancelled):
(WebInspector.DOMTreeElement.prototype._startEditingTagName):
* UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype._ondragover):
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.addPlaceholderNode):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseMainjs">trunk/Source/WebInspectorUI/UserInterface/Base/Main.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsCookieStorageContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeOutlinejs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDataGridjs">trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (164587 => 164588)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-02-24 15:52:42 UTC (rev 164587)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-02-24 17:05:33 UTC (rev 164588)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-02-24 Diego Pino Garcia <dpino@igalia.com>
+
+ Web Inspector: Remove single quote characters from Web Inspector JavaScript files
+ https://bugs.webkit.org/show_bug.cgi?id=129253
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector.openURL):
+ * UserInterface/Views/CookieStorageContentView.js:
+ (WebInspector.cookieDomainMatchesResourceDomain):
+ * UserInterface/Views/DOMTreeElement.js:
+ (WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
+ (WebInspector.DOMTreeElement.prototype._startEditingTagName.editingComitted):
+ (WebInspector.DOMTreeElement.prototype._startEditingTagName.editingCancelled):
+ (WebInspector.DOMTreeElement.prototype._startEditingTagName):
+ * UserInterface/Views/DOMTreeOutline.js:
+ (WebInspector.DOMTreeOutline.prototype._ondragover):
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGrid.prototype.addPlaceholderNode):
+
</ins><span class="cx"> 2014-02-23 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> Removed -Wno-format-y2k from WARNING_CFLAGS
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseMainjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (164587 => 164588)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2014-02-24 15:52:42 UTC (rev 164587)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2014-02-24 17:05:33 UTC (rev 164588)
</span><span class="lines">@@ -491,7 +491,7 @@
</span><span class="cx">
</span><span class="cx"> // The path of of the profile URL starts with a slash, remove it, so
</span><span class="cx"> // we can get the actual title.
</span><del>- console.assert(profileTitle[0] === '/');
</del><ins>+ console.assert(profileTitle[0] === "/");
</ins><span class="cx"> profileTitle = profileTitle.substring(1);
</span><span class="cx">
</span><span class="cx"> this.timelineSidebarPanel.showProfile(profileType, profileTitle);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsCookieStorageContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js (164587 => 164588)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js 2014-02-24 15:52:42 UTC (rev 164587)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js 2014-02-24 17:05:33 UTC (rev 164588)
</span><span class="lines">@@ -251,7 +251,7 @@
</span><span class="cx">
</span><span class="cx"> WebInspector.cookieDomainMatchesResourceDomain = function(cookieDomain, resourceDomain)
</span><span class="cx"> {
</span><del>- if (cookieDomain.charAt(0) !== '.')
</del><ins>+ if (cookieDomain.charAt(0) !== ".")
</ins><span class="cx"> return resourceDomain === cookieDomain;
</span><span class="cx"> return !!resourceDomain.match(new RegExp("^([^\\.]+\\.)?" + cookieDomain.substring(1).escapeForRegExp() + "$"), "i");
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (164587 => 164588)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2014-02-24 15:52:42 UTC (rev 164587)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2014-02-24 17:05:33 UTC (rev 164588)
</span><span class="lines">@@ -536,10 +536,10 @@
</span><span class="cx"> tag.insertBefore(node, tag.lastChild);
</span><span class="cx"> else {
</span><span class="cx"> var nodeName = tag.textContent.match(/^<(.*?)>$/)[1];
</span><del>- tag.textContent = '';
- tag.appendChild(document.createTextNode('<'+nodeName));
</del><ins>+ tag.textContent = "";
+ tag.appendChild(document.createTextNode("<"+nodeName));
</ins><span class="cx"> tag.appendChild(node);
</span><del>- tag.appendChild(document.createTextNode('>'));
</del><ins>+ tag.appendChild(document.createTextNode(">"));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> this.updateSelection();
</span><span class="lines">@@ -749,17 +749,17 @@
</span><span class="cx">
</span><span class="cx"> function editingComitted(element, newTagName)
</span><span class="cx"> {
</span><del>- tagNameElement.removeEventListener('keyup', keyupListener, false);
</del><ins>+ tagNameElement.removeEventListener("keyup", keyupListener, false);
</ins><span class="cx"> this._tagNameEditingCommitted.apply(this, arguments);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function editingCancelled()
</span><span class="cx"> {
</span><del>- tagNameElement.removeEventListener('keyup', keyupListener, false);
</del><ins>+ tagNameElement.removeEventListener("keyup", keyupListener, false);
</ins><span class="cx"> this._editingCancelled.apply(this, arguments);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- tagNameElement.addEventListener('keyup', keyupListener, false);
</del><ins>+ tagNameElement.addEventListener("keyup", keyupListener, false);
</ins><span class="cx">
</span><span class="cx"> var config = new WebInspector.EditingConfig(editingComitted.bind(this), editingCancelled.bind(this), tagName);
</span><span class="cx"> this._editing = WebInspector.startEditing(tagNameElement, config);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeOutlinejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js (164587 => 164588)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2014-02-24 15:52:42 UTC (rev 164587)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2014-02-24 17:05:33 UTC (rev 164588)
</span><span class="lines">@@ -377,7 +377,7 @@
</span><span class="cx"> treeElement.listItemElement.classList.add("elements-drag-over");
</span><span class="cx"> this._dragOverTreeElement = treeElement;
</span><span class="cx"> event.preventDefault();
</span><del>- event.dataTransfer.dropEffect = 'move';
</del><ins>+ event.dataTransfer.dropEffect = "move";
</ins><span class="cx"> return false;
</span><span class="cx"> },
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDataGridjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (164587 => 164588)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2014-02-24 15:52:42 UTC (rev 164587)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2014-02-24 17:05:33 UTC (rev 164588)
</span><span class="lines">@@ -657,7 +657,7 @@
</span><span class="cx">
</span><span class="cx"> var emptyData = {};
</span><span class="cx"> for (var identifier of this.columns.keys())
</span><del>- emptyData[identifier] = '';
</del><ins>+ emptyData[identifier] = "";
</ins><span class="cx"> this.placeholderNode = new WebInspector.PlaceholderDataGridNode(emptyData);
</span><span class="cx"> this.appendChild(this.placeholderNode);
</span><span class="cx"> },
</span><span class="lines">@@ -1108,7 +1108,7 @@
</span><span class="cx"> else {
</span><span class="cx"> var element = event.target.enclosingNodeOrSelfWithNodeName("td");
</span><span class="cx"> var columnIdentifier = element.__columnIdentifier;
</span><del>- var columnTitle = this.dataGrid.columns.get(columnIdentifier).get('title');
</del><ins>+ var columnTitle = this.dataGrid.columns.get(columnIdentifier).get("title");
</ins><span class="cx"> contextMenu.appendItem(WebInspector.UIString("Edit “%s”").format(columnTitle), this._startEditing.bind(this, event.target));
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>