<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164594] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164594">164594</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-02-24 11:05:21 -0800 (Mon, 24 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Get rid of the unused 'immediate' parameters from repaint related functions
https://bugs.webkit.org/show_bug.cgi?id=129111
Patch by Renata Hodovan <rhodovan.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Simon Fraser.
Removing the 'immediate' parameters from repaint related functions - accoring
to the FIXME in RenderView::repaintViewRectangle() - since they have no effect.
Source/WebCore:
No new tests are necessary because there is no behavior change
* dom/Element.cpp:
(WebCore::Element::setActive):
* loader/EmptyClients.h:
* page/Chrome.cpp:
(WebCore::Chrome::invalidateRootView):
(WebCore::Chrome::invalidateContentsAndRootView):
(WebCore::Chrome::invalidateContentsForSlowScroll):
* page/Chrome.h:
* page/ChromeClient.h:
* page/Frame.cpp:
(WebCore::Frame::tiledBackingStorePaintEnd):
* page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::shouldUpdate):
* page/FrameView.h:
* platform/HostWindow.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::scrollContentsSlowPath):
(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::updateOverhangAreas):
(WebCore::ScrollView::addPanScrollIcon):
(WebCore::ScrollView::removePanScrollIcon):
(WebCore::ScrollView::platformRepaintContentRectangle):
* platform/ScrollView.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintLayerRectsForImage):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
* rendering/RenderLayer.h:
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
* rendering/RenderMultiColumnSet.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintSlowRepaintObject):
* rendering/RenderObject.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::repaintFlowThreadContent):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::flushAccumulatedRepaintRegion):
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
* rendering/RenderView.h:
* svg/graphics/SVGImageChromeClient.h:
Source/WebKit/efl:
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::invalidateContents):
(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore::ChromeClientEfl::invalidateContentsAndRootView):
(WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):
* WebCoreSupport/ChromeClientEfl.h:
Source/WebKit/gtk:
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::invalidateRootView):
(WebKit::ChromeClient::invalidateContentsAndRootView):
(WebKit::ChromeClient::invalidateContentsForSlowScroll):
* WebCoreSupport/ChromeClientGtk.h:
Source/WebKit/win:
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):
(WebChromeClient::invalidateContentsForSlowScroll):
* WebCoreSupport/WebChromeClient.h:
Source/WebKit/wince:
* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::invalidateRootView):
(WebKit::ChromeClientWinCE::invalidateContentsAndRootView):
(WebKit::ChromeClientWinCE::invalidateContentsForSlowScroll):
(WebKit::ChromeClientWinCE::scroll):
* WebCoreSupport/ChromeClientWinCE.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCoreexpin">trunk/Source/WebCore/WebCore.exp.in</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderEmptyClientsh">trunk/Source/WebCore/loader/EmptyClients.h</a></li>
<li><a href="#trunkSourceWebCorepageChromecpp">trunk/Source/WebCore/page/Chrome.cpp</a></li>
<li><a href="#trunkSourceWebCorepageChromeh">trunk/Source/WebCore/page/Chrome.h</a></li>
<li><a href="#trunkSourceWebCorepageChromeClienth">trunk/Source/WebCore/page/ChromeClient.h</a></li>
<li><a href="#trunkSourceWebCorepageFramecpp">trunk/Source/WebCore/page/Frame.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFrameViewcpp">trunk/Source/WebCore/page/FrameView.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFrameViewh">trunk/Source/WebCore/page/FrameView.h</a></li>
<li><a href="#trunkSourceWebCoreplatformHostWindowh">trunk/Source/WebCore/platform/HostWindow.h</a></li>
<li><a href="#trunkSourceWebCoreplatformScrollViewcpp">trunk/Source/WebCore/platform/ScrollView.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformScrollViewh">trunk/Source/WebCore/platform/ScrollView.h</a></li>
<li><a href="#trunkSourceWebCoreplatformiosScrollViewIOSmm">trunk/Source/WebCore/platform/ios/ScrollViewIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformmacScrollViewMacmm">trunk/Source/WebCore/platform/mac/ScrollViewMac.mm</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderFlowThreadcpp">trunk/Source/WebCore/rendering/RenderFlowThread.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderFlowThreadh">trunk/Source/WebCore/rendering/RenderFlowThread.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerh">trunk/Source/WebCore/rendering/RenderLayer.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMultiColumnSetcpp">trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMultiColumnSeth">trunk/Source/WebCore/rendering/RenderMultiColumnSet.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjectcpp">trunk/Source/WebCore/rendering/RenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjecth">trunk/Source/WebCore/rendering/RenderObject.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderRegioncpp">trunk/Source/WebCore/rendering/RenderRegion.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderRegionh">trunk/Source/WebCore/rendering/RenderRegion.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderViewcpp">trunk/Source/WebCore/rendering/RenderView.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderViewh">trunk/Source/WebCore/rendering/RenderView.h</a></li>
<li><a href="#trunkSourceWebCoresvggraphicsSVGImageChromeClienth">trunk/Source/WebCore/svg/graphics/SVGImageChromeClient.h</a></li>
<li><a href="#trunkSourceWebKiteflChangeLog">trunk/Source/WebKit/efl/ChangeLog</a></li>
<li><a href="#trunkSourceWebKiteflWebCoreSupportChromeClientEflcpp">trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp</a></li>
<li><a href="#trunkSourceWebKiteflWebCoreSupportChromeClientEflh">trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h</a></li>
<li><a href="#trunkSourceWebKitgtkChangeLog">trunk/Source/WebKit/gtk/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportChromeClientGtkcpp">trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp</a></li>
<li><a href="#trunkSourceWebKitgtkWebCoreSupportChromeClientGtkh">trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebChromeClienth">trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebChromeClientmm">trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinWebCoreSupportWebChromeClientcpp">trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebCoreSupportWebChromeClienth">trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h</a></li>
<li><a href="#trunkSourceWebKitwinceChangeLog">trunk/Source/WebKit/wince/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinceWebCoreSupportChromeClientWinCEcpp">trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.cpp</a></li>
<li><a href="#trunkSourceWebKitwinceWebCoreSupportChromeClientWinCEh">trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClientcpp">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClienth">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/ChangeLog 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -1,3 +1,70 @@
</span><ins>+2014-02-24 Renata Hodovan <rhodovan.u-szeged@partner.samsung.com>
+
+ Get rid of the unused 'immediate' parameters from repaint related functions
+ https://bugs.webkit.org/show_bug.cgi?id=129111
+
+ Reviewed by Simon Fraser.
+
+ Removing the 'immediate' parameters from repaint related functions - accoring
+ to the FIXME in RenderView::repaintViewRectangle() - since they have no effect.
+
+ No new tests are necessary because there is no behavior change
+
+ * dom/Element.cpp:
+ (WebCore::Element::setActive):
+ * loader/EmptyClients.h:
+ * page/Chrome.cpp:
+ (WebCore::Chrome::invalidateRootView):
+ (WebCore::Chrome::invalidateContentsAndRootView):
+ (WebCore::Chrome::invalidateContentsForSlowScroll):
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * page/Frame.cpp:
+ (WebCore::Frame::tiledBackingStorePaintEnd):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::invalidateRect):
+ (WebCore::FrameView::scrollContentsFastPath):
+ (WebCore::FrameView::repaintContentRectangle):
+ (WebCore::FrameView::shouldUpdate):
+ * page/FrameView.h:
+ * platform/HostWindow.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollContents):
+ (WebCore::ScrollView::scrollContentsSlowPath):
+ (WebCore::ScrollView::repaintContentRectangle):
+ (WebCore::ScrollView::updateOverhangAreas):
+ (WebCore::ScrollView::addPanScrollIcon):
+ (WebCore::ScrollView::removePanScrollIcon):
+ (WebCore::ScrollView::platformRepaintContentRectangle):
+ * platform/ScrollView.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::repaintLayerRectsForImage):
+ * rendering/RenderFlowThread.cpp:
+ (WebCore::RenderFlowThread::repaintRectangleInRegions):
+ * rendering/RenderFlowThread.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
+ * rendering/RenderLayer.h:
+ * rendering/RenderMultiColumnSet.cpp:
+ (WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
+ * rendering/RenderMultiColumnSet.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::repaintUsingContainer):
+ (WebCore::RenderObject::repaint):
+ (WebCore::RenderObject::repaintRectangle):
+ (WebCore::RenderObject::repaintSlowRepaintObject):
+ * rendering/RenderObject.h:
+ * rendering/RenderRegion.cpp:
+ (WebCore::RenderRegion::repaintFlowThreadContent):
+ (WebCore::RenderRegion::repaintFlowThreadContentRectangle):
+ * rendering/RenderRegion.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::repaintViewRectangle):
+ (WebCore::RenderView::flushAccumulatedRepaintRegion):
+ (WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
+ * rendering/RenderView.h:
+ * svg/graphics/SVGImageChromeClient.h:
+
</ins><span class="cx"> 2014-02-24 Tamas Gergely <tgergely.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> Code cleanup: remove leftover ENABLE(WORKERS) macros and support.
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCoreexpin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.exp.in (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.exp.in 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/WebCore.exp.in 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -1504,7 +1504,7 @@
</span><span class="cx"> __ZNK7WebCore11RenderStyle4fontEv
</span><span class="cx"> __ZNK7WebCore12RenderObject14enclosingLayerEv
</span><span class="cx"> __ZNK7WebCore12RenderObject15localToAbsoluteERKNS_10FloatPointEj
</span><del>-__ZNK7WebCore12RenderObject16repaintRectangleERKNS_10LayoutRectEbb
</del><ins>+__ZNK7WebCore12RenderObject16repaintRectangleERKNS_10LayoutRectEb
</ins><span class="cx"> __ZNK7WebCore12RenderObject20localToContainerQuadERKNS_9FloatQuadEPKNS_22RenderLayerModelObjectEjPb
</span><span class="cx"> __ZNK7WebCore12RenderObject23absoluteBoundingBoxRectEb
</span><span class="cx"> __ZNK7WebCore12RenderObject39pixelSnappedAbsoluteClippedOverflowRectEv
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/dom/Element.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -514,7 +514,7 @@
</span><span class="cx">
</span><span class="cx"> // Do an immediate repaint.
</span><span class="cx"> if (renderer())
</span><del>- renderer()->repaint(true);
</del><ins>+ renderer()->repaint();
</ins><span class="cx">
</span><span class="cx"> // FIXME: Come up with a less ridiculous way of doing this.
</span><span class="cx"> #ifdef HAVE_FUNC_USLEEP
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderEmptyClientsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/EmptyClients.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/EmptyClients.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -126,9 +126,9 @@
</span><span class="cx">
</span><span class="cx"> virtual IntRect windowResizerRect() const override { return IntRect(); }
</span><span class="cx">
</span><del>- virtual void invalidateRootView(const IntRect&, bool) override { }
- virtual void invalidateContentsAndRootView(const IntRect&, bool) override { }
- virtual void invalidateContentsForSlowScroll(const IntRect&, bool) override { }
</del><ins>+ virtual void invalidateRootView(const IntRect&) override { }
+ virtual void invalidateContentsAndRootView(const IntRect&) override { }
+ virtual void invalidateContentsForSlowScroll(const IntRect&) override { }
</ins><span class="cx"> virtual void scroll(const IntSize&, const IntRect&, const IntRect&) override { }
</span><span class="cx"> #if USE(TILED_BACKING_STORE)
</span><span class="cx"> virtual void delegatedScrollRequested(const IntPoint&) { }
</span></span></pre></div>
<a id="trunkSourceWebCorepageChromecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Chrome.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Chrome.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/page/Chrome.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -77,19 +77,19 @@
</span><span class="cx"> m_client.chromeDestroyed();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void Chrome::invalidateRootView(const IntRect& updateRect, bool immediate)
</del><ins>+void Chrome::invalidateRootView(const IntRect& updateRect)
</ins><span class="cx"> {
</span><del>- m_client.invalidateRootView(updateRect, immediate);
</del><ins>+ m_client.invalidateRootView(updateRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void Chrome::invalidateContentsAndRootView(const IntRect& updateRect, bool immediate)
</del><ins>+void Chrome::invalidateContentsAndRootView(const IntRect& updateRect)
</ins><span class="cx"> {
</span><del>- m_client.invalidateContentsAndRootView(updateRect, immediate);
</del><ins>+ m_client.invalidateContentsAndRootView(updateRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void Chrome::invalidateContentsForSlowScroll(const IntRect& updateRect, bool immediate)
</del><ins>+void Chrome::invalidateContentsForSlowScroll(const IntRect& updateRect)
</ins><span class="cx"> {
</span><del>- m_client.invalidateContentsForSlowScroll(updateRect, immediate);
</del><ins>+ m_client.invalidateContentsForSlowScroll(updateRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Chrome::scroll(const IntSize& scrollDelta, const IntRect& rectToScroll, const IntRect& clipRect)
</span></span></pre></div>
<a id="trunkSourceWebCorepageChromeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Chrome.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Chrome.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/page/Chrome.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -69,9 +69,9 @@
</span><span class="cx"> ChromeClient& client() { return m_client; }
</span><span class="cx">
</span><span class="cx"> // HostWindow methods.
</span><del>- virtual void invalidateRootView(const IntRect&, bool) override;
- virtual void invalidateContentsAndRootView(const IntRect&, bool) override;
- virtual void invalidateContentsForSlowScroll(const IntRect&, bool) override;
</del><ins>+ virtual void invalidateRootView(const IntRect&) override;
+ virtual void invalidateContentsAndRootView(const IntRect&) override;
+ virtual void invalidateContentsForSlowScroll(const IntRect&) override;
</ins><span class="cx"> virtual void scroll(const IntSize&, const IntRect&, const IntRect&) override;
</span><span class="cx"> #if USE(TILED_BACKING_STORE)
</span><span class="cx"> virtual void delegatedScrollRequested(const IntPoint& scrollPoint) override;
</span></span></pre></div>
<a id="trunkSourceWebCorepageChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/ChromeClient.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/ChromeClient.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/page/ChromeClient.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -156,9 +156,9 @@
</span><span class="cx">
</span><span class="cx"> // Methods used by HostWindow.
</span><span class="cx"> virtual bool supportsImmediateInvalidation() { return false; }
</span><del>- virtual void invalidateRootView(const IntRect&, bool immediate) = 0;
- virtual void invalidateContentsAndRootView(const IntRect&, bool immediate) = 0;
- virtual void invalidateContentsForSlowScroll(const IntRect&, bool immediate) = 0;
</del><ins>+ virtual void invalidateRootView(const IntRect&) = 0;
+ virtual void invalidateContentsAndRootView(const IntRect&) = 0;
+ virtual void invalidateContentsForSlowScroll(const IntRect&) = 0;
</ins><span class="cx"> virtual void scroll(const IntSize&, const IntRect&, const IntRect&) = 0;
</span><span class="cx"> #if USE(TILED_BACKING_STORE)
</span><span class="cx"> virtual void delegatedScrollRequested(const IntPoint&) = 0;
</span></span></pre></div>
<a id="trunkSourceWebCorepageFramecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Frame.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Frame.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/page/Frame.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -965,7 +965,7 @@
</span><span class="cx"> unsigned size = paintedArea.size();
</span><span class="cx"> // Request repaint from the system
</span><span class="cx"> for (unsigned n = 0; n < size; ++n)
</span><del>- m_page->chrome().invalidateContentsAndRootView(m_view->contentsToRootView(paintedArea[n]), false);
</del><ins>+ m_page->chrome().invalidateContentsAndRootView(m_view->contentsToRootView(paintedArea[n]));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> IntRect Frame::tiledBackingStoreContentsRect()
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FrameView.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FrameView.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/page/FrameView.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -392,7 +392,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (!parent()) {
</span><span class="cx"> if (HostWindow* window = hostWindow())
</span><del>- window->invalidateContentsAndRootView(rect, false /*immediate*/);
</del><ins>+ window->invalidateContentsAndRootView(rect);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1687,7 +1687,7 @@
</span><span class="cx"> }
</span><span class="cx"> if (clipsRepaints())
</span><span class="cx"> updateRect.intersect(rectToScroll);
</span><del>- hostWindow()->invalidateContentsAndRootView(updateRect, false);
</del><ins>+ hostWindow()->invalidateContentsAndRootView(updateRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return true;
</span><span class="lines">@@ -2067,11 +2067,11 @@
</span><span class="cx"> m_trackedRepaintRects.append(repaintRect);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void FrameView::repaintContentRectangle(const IntRect& r, bool immediate)
</del><ins>+void FrameView::repaintContentRectangle(const IntRect& r)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(!frame().ownerElement());
</span><span class="cx">
</span><del>- if (!shouldUpdate(immediate))
</del><ins>+ if (!shouldUpdate())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> #if USE(TILED_BACKING_STORE)
</span><span class="lines">@@ -2080,7 +2080,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><del>- ScrollView::repaintContentRectangle(r, immediate);
</del><ins>+ ScrollView::repaintContentRectangle(r);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static unsigned countRenderedCharactersInRenderObjectWithThreshold(const RenderObject& renderer, unsigned countSoFar, unsigned threshold)
</span><span class="lines">@@ -2517,9 +2517,9 @@
</span><span class="cx"> m_shouldUpdateWhileOffscreen = shouldUpdateWhileOffscreen;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool FrameView::shouldUpdate(bool immediateRequested) const
</del><ins>+bool FrameView::shouldUpdate() const
</ins><span class="cx"> {
</span><del>- if (!immediateRequested && isOffscreen() && !shouldUpdateWhileOffscreen())
</del><ins>+ if (isOffscreen() && !shouldUpdateWhileOffscreen())
</ins><span class="cx"> return false;
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FrameView.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FrameView.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/page/FrameView.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -208,7 +208,7 @@
</span><span class="cx">
</span><span class="cx"> bool shouldUpdateWhileOffscreen() const;
</span><span class="cx"> void setShouldUpdateWhileOffscreen(bool);
</span><del>- bool shouldUpdate(bool = false) const;
</del><ins>+ bool shouldUpdate() const;
</ins><span class="cx">
</span><span class="cx"> void adjustViewSize();
</span><span class="cx">
</span><span class="lines">@@ -503,7 +503,7 @@
</span><span class="cx"> void performPostLayoutTasks();
</span><span class="cx"> void autoSizeIfEnabled();
</span><span class="cx">
</span><del>- virtual void repaintContentRectangle(const IntRect&, bool immediate) override;
</del><ins>+ virtual void repaintContentRectangle(const IntRect&) override;
</ins><span class="cx"> virtual void contentsResized() override;
</span><span class="cx"> virtual void visibleContentsResized() override;
</span><span class="cx"> virtual void addedOrRemovedScrollbar() override;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformHostWindowh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/HostWindow.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/HostWindow.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/platform/HostWindow.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -38,17 +38,17 @@
</span><span class="cx"> HostWindow() { }
</span><span class="cx"> virtual ~HostWindow() { }
</span><span class="cx">
</span><del>- // Requests the host invalidate the root view, not the contents. If immediate is true do so synchronously, otherwise async.
- virtual void invalidateRootView(const IntRect& updateRect, bool immediate) = 0;
</del><ins>+ // Requests the host invalidate the root view, not the contents.
+ virtual void invalidateRootView(const IntRect& updateRect) = 0;
</ins><span class="cx">
</span><del>- // Requests the host invalidate the contents and the root view. If immediate is true do so synchronously, otherwise async.
- virtual void invalidateContentsAndRootView(const IntRect& updateRect, bool immediate) = 0;
</del><ins>+ // Requests the host invalidate the contents and the root view.
+ virtual void invalidateContentsAndRootView(const IntRect& updateRect) = 0;
</ins><span class="cx">
</span><span class="cx"> // Requests the host scroll backingstore by the specified delta, rect to scroll, and clip rect.
</span><span class="cx"> virtual void scroll(const IntSize& scrollDelta, const IntRect& rectToScroll, const IntRect& clipRect) = 0;
</span><span class="cx">
</span><span class="cx"> // Requests the host invalidate the contents, not the root view. This is the slow path for scrolling.
</span><del>- virtual void invalidateContentsForSlowScroll(const IntRect& updateRect, bool immediate) = 0;
</del><ins>+ virtual void invalidateContentsForSlowScroll(const IntRect& updateRect) = 0;
</ins><span class="cx">
</span><span class="cx"> #if USE(TILED_BACKING_STORE)
</span><span class="cx"> // Requests the host to do the actual scrolling. This is only used in combination with a tiled backing store.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformScrollViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ScrollView.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ScrollView.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -735,7 +735,7 @@
</span><span class="cx"> updateRect.intersect(scrollViewRect);
</span><span class="cx">
</span><span class="cx"> // Invalidate the root view (not the backing store).
</span><del>- window->invalidateRootView(updateRect, false /*immediate*/);
</del><ins>+ window->invalidateRootView(updateRect);
</ins><span class="cx">
</span><span class="cx"> if (m_drawPanScrollIcon) {
</span><span class="cx"> // FIXME: the pan icon is broken when accelerated compositing is on, since it will draw under the compositing layers.
</span><span class="lines">@@ -744,7 +744,7 @@
</span><span class="cx"> IntPoint panIconDirtySquareLocation = IntPoint(m_panScrollIconPoint.x() - (panIconDirtySquareSizeLength / 2), m_panScrollIconPoint.y() - (panIconDirtySquareSizeLength / 2));
</span><span class="cx"> IntRect panScrollIconDirtyRect = IntRect(panIconDirtySquareLocation, IntSize(panIconDirtySquareSizeLength, panIconDirtySquareSizeLength));
</span><span class="cx"> panScrollIconDirtyRect.intersect(clipRect);
</span><del>- window->invalidateContentsAndRootView(panScrollIconDirtyRect, false /*immediate*/);
</del><ins>+ window->invalidateContentsAndRootView(panScrollIconDirtyRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (canBlitOnScroll()) { // The main frame can just blit the WebView window
</span><span class="lines">@@ -764,7 +764,7 @@
</span><span class="cx"> frameRectsChanged();
</span><span class="cx">
</span><span class="cx"> // Now blit the backingstore into the window which should be very fast.
</span><del>- window->invalidateRootView(IntRect(), true);
</del><ins>+ window->invalidateRootView(IntRect());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool ScrollView::scrollContentsFastPath(const IntSize& scrollDelta, const IntRect& rectToScroll, const IntRect& clipRect)
</span><span class="lines">@@ -775,7 +775,7 @@
</span><span class="cx">
</span><span class="cx"> void ScrollView::scrollContentsSlowPath(const IntRect& updateRect)
</span><span class="cx"> {
</span><del>- hostWindow()->invalidateContentsForSlowScroll(updateRect, false);
</del><ins>+ hostWindow()->invalidateContentsForSlowScroll(updateRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> IntPoint ScrollView::rootViewToContents(const IntPoint& rootViewPoint) const
</span><span class="lines">@@ -1031,7 +1031,7 @@
</span><span class="cx"> positionScrollCornerLayer(layerForScrollCorner(), scrollCornerRect());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ScrollView::repaintContentRectangle(const IntRect& rect, bool now)
</del><ins>+void ScrollView::repaintContentRectangle(const IntRect& rect)
</ins><span class="cx"> {
</span><span class="cx"> IntRect paintRect = rect;
</span><span class="cx"> if (clipsRepaints() && !paintsEntireContents())
</span><span class="lines">@@ -1041,12 +1041,12 @@
</span><span class="cx">
</span><span class="cx"> if (platformWidget()) {
</span><span class="cx"> notifyPageThatContentAreaWillPaint();
</span><del>- platformRepaintContentRectangle(paintRect, now);
</del><ins>+ platformRepaintContentRectangle(paintRect);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (HostWindow* window = hostWindow())
</span><del>- window->invalidateContentsAndRootView(contentsToWindow(paintRect), now /*immediate*/);
</del><ins>+ window->invalidateContentsAndRootView(contentsToWindow(paintRect));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> IntRect ScrollView::scrollCornerRect() const
</span><span class="lines">@@ -1238,9 +1238,9 @@
</span><span class="cx"> IntRect verticalOverhangRect;
</span><span class="cx"> calculateOverhangAreasForPainting(horizontalOverhangRect, verticalOverhangRect);
</span><span class="cx"> if (!horizontalOverhangRect.isEmpty())
</span><del>- window->invalidateContentsAndRootView(horizontalOverhangRect, false /*immediate*/);
</del><ins>+ window->invalidateContentsAndRootView(horizontalOverhangRect);
</ins><span class="cx"> if (!verticalOverhangRect.isEmpty())
</span><del>- window->invalidateContentsAndRootView(verticalOverhangRect, false /*immediate*/);
</del><ins>+ window->invalidateContentsAndRootView(verticalOverhangRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ScrollView::paintOverhangAreas(GraphicsContext* context, const IntRect& horizontalOverhangRect, const IntRect& verticalOverhangRect, const IntRect& dirtyRect)
</span><span class="lines">@@ -1383,7 +1383,7 @@
</span><span class="cx"> return;
</span><span class="cx"> m_drawPanScrollIcon = true;
</span><span class="cx"> m_panScrollIconPoint = IntPoint(iconPosition.x() - panIconSizeLength / 2 , iconPosition.y() - panIconSizeLength / 2) ;
</span><del>- window->invalidateContentsAndRootView(IntRect(m_panScrollIconPoint, IntSize(panIconSizeLength, panIconSizeLength)), true /*immediate*/);
</del><ins>+ window->invalidateContentsAndRootView(IntRect(m_panScrollIconPoint, IntSize(panIconSizeLength, panIconSizeLength)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ScrollView::removePanScrollIcon()
</span><span class="lines">@@ -1392,7 +1392,7 @@
</span><span class="cx"> if (!window)
</span><span class="cx"> return;
</span><span class="cx"> m_drawPanScrollIcon = false;
</span><del>- window->invalidateContentsAndRootView(IntRect(m_panScrollIconPoint, IntSize(panIconSizeLength, panIconSizeLength)), true /*immediate*/);
</del><ins>+ window->invalidateContentsAndRootView(IntRect(m_panScrollIconPoint, IntSize(panIconSizeLength, panIconSizeLength)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ScrollView::setScrollOrigin(const IntPoint& origin, bool updatePositionAtAll, bool updatePositionSynchronously)
</span><span class="lines">@@ -1494,7 +1494,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ScrollView::platformRepaintContentRectangle(const IntRect&, bool /*now*/)
</del><ins>+void ScrollView::platformRepaintContentRectangle(const IntRect&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformScrollViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ScrollView.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ScrollView.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/platform/ScrollView.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -341,7 +341,7 @@
</span><span class="cx"> protected:
</span><span class="cx"> ScrollView();
</span><span class="cx">
</span><del>- virtual void repaintContentRectangle(const IntRect&, bool now = false);
</del><ins>+ virtual void repaintContentRectangle(const IntRect&);
</ins><span class="cx"> virtual void paintContents(GraphicsContext*, const IntRect& damageRect) = 0;
</span><span class="cx">
</span><span class="cx"> virtual void paintOverhangAreas(GraphicsContext*, const IntRect& horizontalOverhangArea, const IntRect& verticalOverhangArea, const IntRect& dirtyRect);
</span><span class="lines">@@ -437,7 +437,7 @@
</span><span class="cx"> void platformSetScrollPosition(const IntPoint&);
</span><span class="cx"> bool platformScroll(ScrollDirection, ScrollGranularity);
</span><span class="cx"> void platformSetScrollbarsSuppressed(bool repaintOnUnsuppress);
</span><del>- void platformRepaintContentRectangle(const IntRect&, bool now);
</del><ins>+ void platformRepaintContentRectangle(const IntRect&);
</ins><span class="cx"> bool platformIsOffscreen() const;
</span><span class="cx"> void platformSetScrollbarOverlayStyle(ScrollbarOverlayStyle);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformiosScrollViewIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ios/ScrollViewIOS.mm (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ios/ScrollViewIOS.mm 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/platform/ios/ScrollViewIOS.mm 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -212,14 +212,13 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ScrollView::platformRepaintContentRectangle(const IntRect& rect, bool /*now*/)
</del><ins>+void ScrollView::platformRepaintContentRectangle(const IntRect& rect)
</ins><span class="cx"> {
</span><span class="cx"> BEGIN_BLOCK_OBJC_EXCEPTIONS;
</span><span class="cx">
</span><span class="cx"> NSView *view = documentView();
</span><span class="cx">
</span><span class="cx"> [view setNeedsDisplayInRect:rect];
</span><del>- // FIXME: Handle "now".
</del><span class="cx">
</span><span class="cx"> END_BLOCK_OBJC_EXCEPTIONS;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmacScrollViewMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mac/ScrollViewMac.mm (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mac/ScrollViewMac.mm 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/platform/mac/ScrollViewMac.mm 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -160,15 +160,12 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ScrollView::platformRepaintContentRectangle(const IntRect& rect, bool now)
</del><ins>+void ScrollView::platformRepaintContentRectangle(const IntRect& rect)
</ins><span class="cx"> {
</span><span class="cx"> BEGIN_BLOCK_OBJC_EXCEPTIONS;
</span><span class="cx"> NSView *view = documentView();
</span><span class="cx"> [view setNeedsDisplayInRect:rect];
</span><del>- if (now) {
- [[view window] displayIfNeeded];
- [[view window] flushWindowIfNeeded];
- }
</del><ins>+
</ins><span class="cx"> END_BLOCK_OBJC_EXCEPTIONS;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -1619,7 +1619,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- layerRenderer->repaintRectangle(rectToRepaint, false, shouldClipToLayer);
</del><ins>+ layerRenderer->repaintRectangle(rectToRepaint, shouldClipToLayer);
</ins><span class="cx"> if (geometry.destRect() == rendererRect)
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderFlowThreadcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderFlowThread.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -406,7 +406,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderFlowThread::repaintRectangleInRegions(const LayoutRect& repaintRect, bool immediate) const
</del><ins>+void RenderFlowThread::repaintRectangleInRegions(const LayoutRect& repaintRect) const
</ins><span class="cx"> {
</span><span class="cx"> if (!shouldRepaint(repaintRect) || !hasValidRegionInfo())
</span><span class="cx"> return;
</span><span class="lines">@@ -418,7 +418,7 @@
</span><span class="cx"> CurrentRenderFlowThreadDisabler disabler(&view());
</span><span class="cx">
</span><span class="cx"> for (auto& region : m_regionList)
</span><del>- region->repaintFlowThreadContent(repaintRect, immediate);
</del><ins>+ region->repaintFlowThreadContent(repaintRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RenderRegion* RenderFlowThread::regionAtBlockOffset(const RenderBox* clampBox, LayoutUnit offset, bool extendLastRegion, RegionAutoGenerationPolicy autoGenerationPolicy)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderFlowThreadh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderFlowThread.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderFlowThread.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx">
</span><span class="cx"> virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
</span><span class="cx">
</span><del>- void repaintRectangleInRegions(const LayoutRect&, bool immediate) const;
</del><ins>+ void repaintRectangleInRegions(const LayoutRect&) const;
</ins><span class="cx">
</span><span class="cx"> LayoutPoint adjustedPositionRelativeToOffsetParent(const RenderBoxModelObject&, const LayoutPoint&);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -1471,7 +1471,7 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderLayer::setFilterBackendNeedsRepaintingInRect(const LayoutRect& rect, bool immediate)
</del><ins>+void RenderLayer::setFilterBackendNeedsRepaintingInRect(const LayoutRect& rect)
</ins><span class="cx"> {
</span><span class="cx"> if (rect.isEmpty())
</span><span class="cx"> return;
</span><span class="lines">@@ -1498,12 +1498,12 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (parentLayer->paintsWithFilters()) {
</span><del>- parentLayer->setFilterBackendNeedsRepaintingInRect(parentLayerRect, immediate);
</del><ins>+ parentLayer->setFilterBackendNeedsRepaintingInRect(parentLayerRect);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (parentLayer->isRootLayer()) {
</span><del>- toRenderView(parentLayer->renderer()).repaintViewRectangle(parentLayerRect, immediate);
</del><ins>+ toRenderView(parentLayer->renderer()).repaintViewRectangle(parentLayerRect);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -609,7 +609,7 @@
</span><span class="cx"> #if ENABLE(CSS_FILTERS)
</span><span class="cx"> RenderLayer* enclosingFilterLayer(IncludeSelfOrNot = IncludeSelf) const;
</span><span class="cx"> RenderLayer* enclosingFilterRepaintLayer() const;
</span><del>- void setFilterBackendNeedsRepaintingInRect(const LayoutRect&, bool immediate);
</del><ins>+ void setFilterBackendNeedsRepaintingInRect(const LayoutRect&);
</ins><span class="cx"> bool hasAncestorWithFilterOutsets() const;
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMultiColumnSetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -479,7 +479,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderMultiColumnSet::repaintFlowThreadContent(const LayoutRect& repaintRect, bool immediate)
</del><ins>+void RenderMultiColumnSet::repaintFlowThreadContent(const LayoutRect& repaintRect)
</ins><span class="cx"> {
</span><span class="cx"> // Figure out the start and end columns and only check within that range so that we don't walk the
</span><span class="cx"> // entire column set. Put the repaint rect into flow thread coordinates by flipping it first.
</span><span class="lines">@@ -513,7 +513,7 @@
</span><span class="cx"> LayoutRect flowThreadOverflowPortion = flowThreadPortionOverflowRect(flowThreadPortion, i, colCount, colGap);
</span><span class="cx">
</span><span class="cx"> // Do a repaint for this specific column.
</span><del>- repaintFlowThreadContentRectangle(repaintRect, immediate, flowThreadPortion, colRect.location(), &flowThreadOverflowPortion);
</del><ins>+ repaintFlowThreadContentRectangle(repaintRect, flowThreadPortion, colRect.location(), &flowThreadOverflowPortion);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMultiColumnSeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMultiColumnSet.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMultiColumnSet.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnSet.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> // FIXME: This will change once we have column sets constrained by enclosing pages, etc.
</span><span class="cx"> virtual LayoutUnit logicalHeightOfAllFlowThreadContent() const override { return m_computedColumnHeight; }
</span><span class="cx">
</span><del>- virtual void repaintFlowThreadContent(const LayoutRect& repaintRect, bool immediate) override;
</del><ins>+ virtual void repaintFlowThreadContent(const LayoutRect& repaintRect) override;
</ins><span class="cx">
</span><span class="cx"> virtual void collectLayerFragments(LayerFragments&, const LayoutRect& layerBoundingBox, const LayoutRect& dirtyRect) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -1225,21 +1225,21 @@
</span><span class="cx"> return repaintContainer;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderObject::repaintUsingContainer(const RenderLayerModelObject* repaintContainer, const LayoutRect& r, bool immediate, bool shouldClipToLayer) const
</del><ins>+void RenderObject::repaintUsingContainer(const RenderLayerModelObject* repaintContainer, const LayoutRect& r, bool shouldClipToLayer) const
</ins><span class="cx"> {
</span><span class="cx"> if (!repaintContainer) {
</span><del>- view().repaintViewRectangle(r, immediate);
</del><ins>+ view().repaintViewRectangle(r);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (repaintContainer->isRenderFlowThread()) {
</span><del>- toRenderFlowThread(repaintContainer)->repaintRectangleInRegions(r, immediate);
</del><ins>+ toRenderFlowThread(repaintContainer)->repaintRectangleInRegions(r);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_FILTERS)
</span><span class="cx"> if (repaintContainer->hasFilter() && repaintContainer->layer() && repaintContainer->layer()->requiresFullLayerImageForFilters()) {
</span><del>- repaintContainer->layer()->setFilterBackendNeedsRepaintingInRect(r, immediate);
</del><ins>+ repaintContainer->layer()->setFilterBackendNeedsRepaintingInRect(r);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="lines">@@ -1249,7 +1249,7 @@
</span><span class="cx"> ASSERT(repaintContainer == &v);
</span><span class="cx"> bool viewHasCompositedLayer = v.hasLayer() && v.layer()->isComposited();
</span><span class="cx"> if (!viewHasCompositedLayer || v.layer()->backing()->paintsIntoWindow()) {
</span><del>- v.repaintViewRectangle(viewHasCompositedLayer && v.layer()->transform() ? v.layer()->transform()->mapRect(r) : r, immediate);
</del><ins>+ v.repaintViewRectangle(viewHasCompositedLayer && v.layer()->transform() ? v.layer()->transform()->mapRect(r) : r);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -1260,7 +1260,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderObject::repaint(bool immediate) const
</del><ins>+void RenderObject::repaint() const
</ins><span class="cx"> {
</span><span class="cx"> // Don't repaint if we're unrooted (note that view() still returns the view when unrooted)
</span><span class="cx"> RenderView* view;
</span><span class="lines">@@ -1271,10 +1271,10 @@
</span><span class="cx"> return; // Don't repaint if we're printing.
</span><span class="cx">
</span><span class="cx"> RenderLayerModelObject* repaintContainer = containerForRepaint();
</span><del>- repaintUsingContainer(repaintContainer ? repaintContainer : view, clippedOverflowRectForRepaint(repaintContainer), immediate);
</del><ins>+ repaintUsingContainer(repaintContainer ? repaintContainer : view, clippedOverflowRectForRepaint(repaintContainer));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderObject::repaintRectangle(const LayoutRect& r, bool immediate, bool shouldClipToLayer) const
</del><ins>+void RenderObject::repaintRectangle(const LayoutRect& r, bool shouldClipToLayer) const
</ins><span class="cx"> {
</span><span class="cx"> // Don't repaint if we're unrooted (note that view() still returns the view when unrooted)
</span><span class="cx"> RenderView* view;
</span><span class="lines">@@ -1292,7 +1292,7 @@
</span><span class="cx">
</span><span class="cx"> RenderLayerModelObject* repaintContainer = containerForRepaint();
</span><span class="cx"> computeRectForRepaint(repaintContainer, dirtyRect);
</span><del>- repaintUsingContainer(repaintContainer ? repaintContainer : view, dirtyRect, immediate, shouldClipToLayer);
</del><ins>+ repaintUsingContainer(repaintContainer ? repaintContainer : view, dirtyRect, shouldClipToLayer);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderObject::repaintSlowRepaintObject() const
</span><span class="lines">@@ -1321,7 +1321,7 @@
</span><span class="cx"> } else
</span><span class="cx"> repaintRect = pixelSnappedIntRect(clippedOverflowRectForRepaint(repaintContainer));
</span><span class="cx">
</span><del>- repaintUsingContainer(repaintContainer, repaintRect, false, shouldClipToLayer);
</del><ins>+ repaintUsingContainer(repaintContainer, repaintRect, shouldClipToLayer);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> IntRect RenderObject::pixelSnappedAbsoluteClippedOverflowRect() const
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -724,14 +724,14 @@
</span><span class="cx"> RenderLayerModelObject* containerForRepaint() const;
</span><span class="cx"> // Actually do the repaint of rect r for this object which has been computed in the coordinate space
</span><span class="cx"> // of repaintContainer. If repaintContainer is 0, repaint via the view.
</span><del>- void repaintUsingContainer(const RenderLayerModelObject* repaintContainer, const LayoutRect&, bool immediate = false, bool shouldClipToLayer = true) const;
</del><ins>+ void repaintUsingContainer(const RenderLayerModelObject* repaintContainer, const LayoutRect&, bool shouldClipToLayer = true) const;
</ins><span class="cx">
</span><span class="cx"> // Repaint the entire object. Called when, e.g., the color of a border changes, or when a border
</span><span class="cx"> // style changes.
</span><del>- void repaint(bool immediate = false) const;
</del><ins>+ void repaint() const;
</ins><span class="cx">
</span><span class="cx"> // Repaint a specific subrectangle within a given object. The rect |r| is in the object's coordinate space.
</span><del>- void repaintRectangle(const LayoutRect&, bool immediate = false, bool shouldClipToLayer = true) const;
</del><ins>+ void repaintRectangle(const LayoutRect&, bool shouldClipToLayer = true) const;
</ins><span class="cx">
</span><span class="cx"> // Repaint a slow repaint object, which, at this time, means we are repainting an object with background-attachment:fixed.
</span><span class="cx"> void repaintSlowRepaintObject() const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderRegioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderRegion.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderRegion.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderRegion.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -261,12 +261,12 @@
</span><span class="cx"> updateScrollInfoAfterLayout();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderRegion::repaintFlowThreadContent(const LayoutRect& repaintRect, bool immediate)
</del><ins>+void RenderRegion::repaintFlowThreadContent(const LayoutRect& repaintRect)
</ins><span class="cx"> {
</span><del>- repaintFlowThreadContentRectangle(repaintRect, immediate, flowThreadPortionRect(), contentBoxRect().location());
</del><ins>+ repaintFlowThreadContentRectangle(repaintRect, flowThreadPortionRect(), contentBoxRect().location());
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderRegion::repaintFlowThreadContentRectangle(const LayoutRect& repaintRect, bool immediate, const LayoutRect& flowThreadPortionRect, const LayoutPoint& regionLocation, const LayoutRect* flowThreadPortionClipRect)
</del><ins>+void RenderRegion::repaintFlowThreadContentRectangle(const LayoutRect& repaintRect, const LayoutRect& flowThreadPortionRect, const LayoutPoint& regionLocation, const LayoutRect* flowThreadPortionClipRect)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(isValid());
</span><span class="cx">
</span><span class="lines">@@ -292,7 +292,7 @@
</span><span class="cx"> flipForWritingMode(clippedRect);
</span><span class="cx">
</span><span class="cx"> // Issue the repaint.
</span><del>- repaintRectangle(clippedRect, immediate);
</del><ins>+ repaintRectangle(clippedRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderRegion::installFlowThread()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderRegionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderRegion.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderRegion.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderRegion.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -108,7 +108,7 @@
</span><span class="cx"> // Whether or not this region is a set.
</span><span class="cx"> virtual bool isRenderRegionSet() const { return false; }
</span><span class="cx">
</span><del>- virtual void repaintFlowThreadContent(const LayoutRect& repaintRect, bool immediate);
</del><ins>+ virtual void repaintFlowThreadContent(const LayoutRect& repaintRect);
</ins><span class="cx">
</span><span class="cx"> virtual void collectLayerFragments(LayerFragments&, const LayoutRect&, const LayoutRect&) { }
</span><span class="cx">
</span><span class="lines">@@ -147,7 +147,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> LayoutRect overflowRectForFlowThreadPortion(const LayoutRect& flowThreadPortionRect, bool isFirstPortion, bool isLastPortion, OverflowType);
</span><del>- void repaintFlowThreadContentRectangle(const LayoutRect& repaintRect, bool immediate, const LayoutRect& flowThreadPortionRect, const LayoutPoint& regionLocation, const LayoutRect* flowThreadPortionClipRect = 0);
</del><ins>+ void repaintFlowThreadContentRectangle(const LayoutRect& repaintRect, const LayoutRect& flowThreadPortionRect, const LayoutPoint& regionLocation, const LayoutRect* flowThreadPortionClipRect = 0);
</ins><span class="cx">
</span><span class="cx"> void computeOverflowFromFlowThread();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderView.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderView.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -539,9 +539,8 @@
</span><span class="cx"> repaint();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderView::repaintViewRectangle(const LayoutRect& repaintRect, bool immediate) const
</del><ins>+void RenderView::repaintViewRectangle(const LayoutRect& repaintRect) const
</ins><span class="cx"> {
</span><del>- // FIXME: Get rid of the 'immediate' argument. It only works on Mac WK1 and should never be used.
</del><span class="cx"> if (!shouldRepaint(repaintRect))
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -558,15 +557,15 @@
</span><span class="cx"> #endif
</span><span class="cx"> adjustedRect.moveBy(-viewRect.location());
</span><span class="cx"> adjustedRect.moveBy(ownerBox.contentBoxRect().location());
</span><del>- ownerBox.repaintRectangle(adjustedRect, immediate);
</del><ins>+ ownerBox.repaintRectangle(adjustedRect);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> IntRect pixelSnappedRect = pixelSnappedIntRect(repaintRect);
</span><span class="cx">
</span><span class="cx"> frameView().addTrackedRepaintRect(pixelSnappedRect);
</span><span class="cx">
</span><del>- if (!m_accumulatedRepaintRegion || immediate) {
- frameView().repaintContentRectangle(pixelSnappedRect, immediate);
</del><ins>+ if (!m_accumulatedRepaintRegion) {
+ frameView().repaintContentRectangle(pixelSnappedRect);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> m_accumulatedRepaintRegion->unite(pixelSnappedRect);
</span><span class="lines">@@ -584,16 +583,16 @@
</span><span class="cx"> ASSERT(m_accumulatedRepaintRegion);
</span><span class="cx"> auto repaintRects = m_accumulatedRepaintRegion->rects();
</span><span class="cx"> for (auto& rect : repaintRects)
</span><del>- frameView().repaintContentRectangle(rect, false);
</del><ins>+ frameView().repaintContentRectangle(rect);
</ins><span class="cx"> m_accumulatedRepaintRegion = nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderView::repaintRectangleInViewAndCompositedLayers(const LayoutRect& ur, bool immediate)
</del><ins>+void RenderView::repaintRectangleInViewAndCompositedLayers(const LayoutRect& ur)
</ins><span class="cx"> {
</span><span class="cx"> if (!shouldRepaint(ur))
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- repaintViewRectangle(ur, immediate);
</del><ins>+ repaintViewRectangle(ur);
</ins><span class="cx">
</span><span class="cx"> RenderLayerCompositor& compositor = this->compositor();
</span><span class="cx"> if (compositor.inCompositingMode()) {
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderView.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderView.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/rendering/RenderView.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -73,10 +73,10 @@
</span><span class="cx"> virtual LayoutRect visualOverflowRect() const override;
</span><span class="cx"> virtual void computeRectForRepaint(const RenderLayerModelObject* repaintContainer, LayoutRect&, bool fixed = false) const override;
</span><span class="cx"> void repaintRootContents();
</span><del>- void repaintViewRectangle(const LayoutRect&, bool immediate = false) const;
</del><ins>+ void repaintViewRectangle(const LayoutRect&) const;
</ins><span class="cx"> // Repaint the view, and all composited layers that intersect the given absolute rectangle.
</span><span class="cx"> // FIXME: ideally we'd never have to do this, if all repaints are container-relative.
</span><del>- void repaintRectangleInViewAndCompositedLayers(const LayoutRect&, bool immediate = false);
</del><ins>+ void repaintRectangleInViewAndCompositedLayers(const LayoutRect&);
</ins><span class="cx"> void repaintViewAndCompositedLayers();
</span><span class="cx">
</span><span class="cx"> virtual void paint(PaintInfo&, const LayoutPoint&) override;
</span></span></pre></div>
<a id="trunkSourceWebCoresvggraphicsSVGImageChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/graphics/SVGImageChromeClient.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/graphics/SVGImageChromeClient.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebCore/svg/graphics/SVGImageChromeClient.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> m_image = 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual void invalidateContentsAndRootView(const IntRect& r, bool) override
</del><ins>+ virtual void invalidateContentsAndRootView(const IntRect& r) override
</ins><span class="cx"> {
</span><span class="cx"> // If m_image->m_page is null, we're being destructed, don't fire changedInRect() in that case.
</span><span class="cx"> if (m_image && m_image->imageObserver() && m_image->m_page)
</span></span></pre></div>
<a id="trunkSourceWebKiteflChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/ChangeLog (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/ChangeLog 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/efl/ChangeLog 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-02-24 Renata Hodovan <rhodovan.u-szeged@partner.samsung.com>
+
+ Get rid of the unused 'immediate' parameters from repaint related functions
+ https://bugs.webkit.org/show_bug.cgi?id=129111
+
+ Reviewed by Simon Fraser.
+
+ Removing the 'immediate' parameters from repaint related functions - accoring
+ to the FIXME in RenderView::repaintViewRectangle() - since they have no effect.
+
+ * WebCoreSupport/ChromeClientEfl.cpp:
+ (WebCore::ChromeClientEfl::invalidateContents):
+ (WebCore::ChromeClientEfl::invalidateRootView):
+ (WebCore::ChromeClientEfl::invalidateContentsAndRootView):
+ (WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):
+ * WebCoreSupport/ChromeClientEfl.h:
+
</ins><span class="cx"> 2014-02-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
</span><span class="cx">
</span><span class="cx"> Change a url parameter type with URL in NavigatorContentUtils
</span></span></pre></div>
<a id="trunkSourceWebKiteflWebCoreSupportChromeClientEflcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -524,12 +524,12 @@
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClientEfl::invalidateContents(const IntRect& /*updateRect*/, bool /*immediate*/)
</del><ins>+void ChromeClientEfl::invalidateContents(const IntRect& /*updateRect*/)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClientEfl::invalidateRootView(const IntRect& updateRect, bool /*immediate*/)
</del><ins>+void ChromeClientEfl::invalidateRootView(const IntRect& updateRect)
</ins><span class="cx"> {
</span><span class="cx"> #if USE(TILED_BACKING_STORE)
</span><span class="cx"> ewk_view_tiled_backing_store_invalidate(m_view, updateRect);
</span><span class="lines">@@ -539,7 +539,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClientEfl::invalidateContentsAndRootView(const IntRect& updateRect, bool /*immediate*/)
</del><ins>+void ChromeClientEfl::invalidateContentsAndRootView(const IntRect& updateRect)
</ins><span class="cx"> {
</span><span class="cx"> if (updateRect.isEmpty())
</span><span class="cx"> return;
</span><span class="lines">@@ -553,9 +553,9 @@
</span><span class="cx"> ewk_view_repaint(m_view, x, y, w, h);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClientEfl::invalidateContentsForSlowScroll(const IntRect& updateRect, bool immediate)
</del><ins>+void ChromeClientEfl::invalidateContentsForSlowScroll(const IntRect& updateRect)
</ins><span class="cx"> {
</span><del>- invalidateContentsAndRootView(updateRect, immediate);
</del><ins>+ invalidateContentsAndRootView(updateRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ChromeClientEfl::scroll(const IntSize& scrollDelta, const IntRect& rectToScroll, const IntRect& clipRect)
</span></span></pre></div>
<a id="trunkSourceWebKiteflWebCoreSupportChromeClientEflh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -160,10 +160,10 @@
</span><span class="cx">
</span><span class="cx"> virtual void cancelGeolocationPermissionForFrame(Frame*, Geolocation*);
</span><span class="cx">
</span><del>- virtual void invalidateContents(const IntRect&, bool);
- virtual void invalidateRootView(const IntRect&, bool);
- virtual void invalidateContentsAndRootView(const IntRect&, bool);
- virtual void invalidateContentsForSlowScroll(const IntRect&, bool);
</del><ins>+ virtual void invalidateContents(const IntRect&);
+ virtual void invalidateRootView(const IntRect&);
+ virtual void invalidateContentsAndRootView(const IntRect&);
+ virtual void invalidateContentsForSlowScroll(const IntRect&);
</ins><span class="cx"> virtual void scroll(const IntSize&, const IntRect&, const IntRect&);
</span><span class="cx"> virtual void cancelGeolocationPermissionRequestForFrame(Frame*);
</span><span class="cx"> virtual void iconForFiles(const Vector<String, 0u>&, PassRefPtr<FileChooser>);
</span></span></pre></div>
<a id="trunkSourceWebKitgtkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/ChangeLog (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/ChangeLog 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/gtk/ChangeLog 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-02-24 Renata Hodovan <rhodovan.u-szeged@partner.samsung.com>
+
+ Get rid of the unused 'immediate' parameters from repaint related functions
+ https://bugs.webkit.org/show_bug.cgi?id=129111
+
+ Reviewed by Simon Fraser.
+
+ Removing the 'immediate' parameters from repaint related functions - accoring
+ to the FIXME in RenderView::repaintViewRectangle() - since they have no effect.
+
+ * WebCoreSupport/ChromeClientGtk.cpp:
+ (WebKit::ChromeClient::invalidateRootView):
+ (WebKit::ChromeClient::invalidateContentsAndRootView):
+ (WebKit::ChromeClient::invalidateContentsForSlowScroll):
+ * WebCoreSupport/ChromeClientGtk.h:
+
</ins><span class="cx"> 2014-02-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
</span><span class="cx">
</span><span class="cx"> Change a url parameter type with URL in NavigatorContentUtils
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportChromeClientGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -638,11 +638,11 @@
</span><span class="cx"> m_forcePaint = false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClient::invalidateRootView(const IntRect&, bool immediate)
</del><ins>+void ChromeClient::invalidateRootView(const IntRect&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClient::invalidateContentsAndRootView(const IntRect& updateRect, bool immediate)
</del><ins>+void ChromeClient::invalidateContentsAndRootView(const IntRect& updateRect)
</ins><span class="cx"> {
</span><span class="cx"> AcceleratedCompositingContext* acContext = m_webView->priv->acceleratedCompositingContext.get();
</span><span class="cx"> if (acContext->enabled()) {
</span><span class="lines">@@ -656,7 +656,7 @@
</span><span class="cx"> m_displayTimer.startOneShot(0);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClient::invalidateContentsForSlowScroll(const IntRect& updateRect, bool immediate)
</del><ins>+void ChromeClient::invalidateContentsForSlowScroll(const IntRect& updateRect)
</ins><span class="cx"> {
</span><span class="cx"> m_adjustmentWatcher.updateAdjustmentsFromScrollbarsLater();
</span><span class="cx">
</span><span class="lines">@@ -666,7 +666,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- invalidateContentsAndRootView(updateRect, immediate);
</del><ins>+ invalidateContentsAndRootView(updateRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ChromeClient::scroll(const IntSize& delta, const IntRect& rectToScroll, const IntRect& clipRect)
</span></span></pre></div>
<a id="trunkSourceWebKitgtkWebCoreSupportChromeClientGtkh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -96,9 +96,9 @@
</span><span class="cx"> virtual KeyboardUIMode keyboardUIMode();
</span><span class="cx">
</span><span class="cx"> virtual IntRect windowResizerRect() const;
</span><del>- virtual void invalidateRootView(const IntRect&, bool);
- virtual void invalidateContentsAndRootView(const IntRect&, bool);
- virtual void invalidateContentsForSlowScroll(const IntRect&, bool);
</del><ins>+ virtual void invalidateRootView(const IntRect&);
+ virtual void invalidateContentsAndRootView(const IntRect&);
+ virtual void invalidateContentsForSlowScroll(const IntRect&);
</ins><span class="cx"> virtual void scroll(const IntSize& scrollDelta, const IntRect& rectToScroll, const IntRect& clipRect);
</span><span class="cx">
</span><span class="cx"> virtual IntPoint screenToRootView(const IntPoint&) const;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -94,9 +94,9 @@
</span><span class="cx"> virtual WebCore::IntRect windowResizerRect() const override;
</span><span class="cx">
</span><span class="cx"> virtual bool supportsImmediateInvalidation() override;
</span><del>- virtual void invalidateRootView(const WebCore::IntRect&, bool) override;
- virtual void invalidateContentsAndRootView(const WebCore::IntRect&, bool) override;
- virtual void invalidateContentsForSlowScroll(const WebCore::IntRect&, bool) override;
</del><ins>+ virtual void invalidateRootView(const WebCore::IntRect&) override;
+ virtual void invalidateContentsAndRootView(const WebCore::IntRect&) override;
+ virtual void invalidateContentsForSlowScroll(const WebCore::IntRect&) override;
</ins><span class="cx"> virtual void scroll(const WebCore::IntSize& scrollDelta, const WebCore::IntRect& rectToScroll, const WebCore::IntRect& clipRect) override;
</span><span class="cx">
</span><span class="cx"> virtual WebCore::IntPoint screenToRootView(const WebCore::IntPoint&) const override;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebChromeClientmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -573,25 +573,17 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebChromeClient::invalidateRootView(const IntRect&, bool immediate)
</del><ins>+void WebChromeClient::invalidateRootView(const IntRect&)
</ins><span class="cx"> {
</span><del>-#if !PLATFORM(IOS)
- if (immediate) {
- [[m_webView window] displayIfNeeded];
- [[m_webView window] flushWindowIfNeeded];
- }
-#else
- UNUSED_PARAM(immediate);
-#endif
</del><span class="cx"> }
</span><span class="cx">
</span><del>-void WebChromeClient::invalidateContentsAndRootView(const IntRect& rect, bool immediate)
</del><ins>+void WebChromeClient::invalidateContentsAndRootView(const IntRect& rect)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebChromeClient::invalidateContentsForSlowScroll(const IntRect& rect, bool immediate)
</del><ins>+void WebChromeClient::invalidateContentsForSlowScroll(const IntRect& rect)
</ins><span class="cx"> {
</span><del>- invalidateContentsAndRootView(rect, immediate);
</del><ins>+ invalidateContentsAndRootView(rect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebChromeClient::scroll(const IntSize&, const IntRect&, const IntRect&)
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/win/ChangeLog 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-02-24 Renata Hodovan <rhodovan.u-szeged@partner.samsung.com>
+
+ Get rid of the unused 'immediate' parameters from repaint related functions
+ https://bugs.webkit.org/show_bug.cgi?id=129111
+
+ Reviewed by Simon Fraser.
+
+ Removing the 'immediate' parameters from repaint related functions - accoring
+ to the FIXME in RenderView::repaintViewRectangle() - since they have no effect.
+
+ * WebCoreSupport/WebChromeClient.cpp:
+ (WebChromeClient::invalidateRootView):
+ (WebChromeClient::invalidateContentsAndRootView):
+ (WebChromeClient::invalidateContentsForSlowScroll):
+ * WebCoreSupport/WebChromeClient.h:
+
</ins><span class="cx"> 2014-02-20 Csaba Osztrogonác <ossy@webkit.org>
</span><span class="cx">
</span><span class="cx"> Get rid of redundant Platform.h includes
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebCoreSupportWebChromeClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -462,22 +462,22 @@
</span><span class="cx"> return IntRect();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebChromeClient::invalidateRootView(const IntRect& windowRect, bool immediate)
</del><ins>+void WebChromeClient::invalidateRootView(const IntRect& windowRect)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(core(m_webView->topLevelFrame()));
</span><del>- m_webView->repaint(windowRect, false /*contentChanged*/, immediate, false /*repaintContentOnly*/);
</del><ins>+ m_webView->repaint(windowRect, false /*contentChanged*/, false /*repaintContentOnly*/);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void WebChromeClient::invalidateContentsAndRootView(const IntRect& windowRect, bool immediate)
</del><ins>+void WebChromeClient::invalidateContentsAndRootView(const IntRect& windowRect)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(core(m_webView->topLevelFrame()));
</span><del>- m_webView->repaint(windowRect, true /*contentChanged*/, immediate /*immediate*/, false /*repaintContentOnly*/);
</del><ins>+ m_webView->repaint(windowRect, true /*contentChanged*/, false /*repaintContentOnly*/);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void WebChromeClient::invalidateContentsForSlowScroll(const IntRect& windowRect, bool immediate)
</del><ins>+void WebChromeClient::invalidateContentsForSlowScroll(const IntRect& windowRect)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(core(m_webView->topLevelFrame()));
</span><del>- m_webView->repaint(windowRect, true /*contentChanged*/, immediate, true /*repaintContentOnly*/);
</del><ins>+ m_webView->repaint(windowRect, true /*contentChanged*/, true /*repaintContentOnly*/);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebChromeClient::scroll(const IntSize& delta, const IntRect& scrollViewRect, const IntRect& clipRect)
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebCoreSupportWebChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -93,9 +93,9 @@
</span><span class="cx"> virtual WebCore::KeyboardUIMode keyboardUIMode();
</span><span class="cx"> virtual WebCore::IntRect windowResizerRect() const;
</span><span class="cx">
</span><del>- virtual void invalidateRootView(const WebCore::IntRect&, bool);
- virtual void invalidateContentsAndRootView(const WebCore::IntRect&, bool);
- virtual void invalidateContentsForSlowScroll(const WebCore::IntRect&, bool);
</del><ins>+ virtual void invalidateRootView(const WebCore::IntRect&);
+ virtual void invalidateContentsAndRootView(const WebCore::IntRect&);
+ virtual void invalidateContentsForSlowScroll(const WebCore::IntRect&);
</ins><span class="cx"> virtual void scroll(const WebCore::IntSize& scrollDelta, const WebCore::IntRect& rectToScroll, const WebCore::IntRect& clipRect);
</span><span class="cx">
</span><span class="cx"> virtual WebCore::IntPoint screenToRootView(const WebCore::IntPoint&) const;
</span></span></pre></div>
<a id="trunkSourceWebKitwinceChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/wince/ChangeLog (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/wince/ChangeLog 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/wince/ChangeLog 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-02-24 Renata Hodovan <rhodovan.u-szeged@partner.samsung.com>
+
+ Get rid of the unused 'immediate' parameters from repaint related functions
+ https://bugs.webkit.org/show_bug.cgi?id=129111
+
+ Reviewed by Simon Fraser.
+
+ Removing the 'immediate' parameters from repaint related functions - accoring
+ to the FIXME in RenderView::repaintViewRectangle() - since they have no effect.
+
+ * WebCoreSupport/ChromeClientWinCE.cpp:
+ (WebKit::ChromeClientWinCE::invalidateRootView):
+ (WebKit::ChromeClientWinCE::invalidateContentsAndRootView):
+ (WebKit::ChromeClientWinCE::invalidateContentsForSlowScroll):
+ (WebKit::ChromeClientWinCE::scroll):
+ * WebCoreSupport/ChromeClientWinCE.h:
+
</ins><span class="cx"> 2014-02-08 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Change TextIterator to use StringView, preparing to wean it from deprecatedCharacters
</span></span></pre></div>
<a id="trunkSourceWebKitwinceWebCoreSupportChromeClientWinCEcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -226,28 +226,25 @@
</span><span class="cx"> return IntRect();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClientWinCE::invalidateRootView(const IntRect&, bool)
</del><ins>+void ChromeClientWinCE::invalidateRootView(const IntRect&)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClientWinCE::invalidateContentsAndRootView(const IntRect& updateRect, bool immediate)
</del><ins>+void ChromeClientWinCE::invalidateContentsAndRootView(const IntRect& updateRect)
</ins><span class="cx"> {
</span><span class="cx"> RECT rect = updateRect;
</span><span class="cx"> InvalidateRect(m_webView->windowHandle(), &rect, FALSE);
</span><del>-
- if (immediate)
- UpdateWindow(m_webView->windowHandle());
</del><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClientWinCE::invalidateContentsForSlowScroll(const IntRect& updateRect, bool immediate)
</del><ins>+void ChromeClientWinCE::invalidateContentsForSlowScroll(const IntRect& updateRect)
</ins><span class="cx"> {
</span><del>- invalidateContentsAndRootView(updateRect, immediate);
</del><ins>+ invalidateContentsAndRootView(updateRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ChromeClientWinCE::scroll(const IntSize&, const IntRect& rectToScroll, const IntRect&)
</span><span class="cx"> {
</span><del>- invalidateContentsAndRootView(rectToScroll, false);
</del><ins>+ invalidateContentsAndRootView(rectToScroll);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> IntRect ChromeClientWinCE::rootViewToScreen(const IntRect& rect) const
</span></span></pre></div>
<a id="trunkSourceWebKitwinceWebCoreSupportChromeClientWinCEh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -92,9 +92,9 @@
</span><span class="cx"> virtual WebCore::IntRect windowResizerRect() const override;
</span><span class="cx">
</span><span class="cx"> // Methods used by HostWindow.
</span><del>- virtual void invalidateRootView(const WebCore::IntRect&, bool) override;
- virtual void invalidateContentsAndRootView(const WebCore::IntRect&, bool) override;
- virtual void invalidateContentsForSlowScroll(const WebCore::IntRect&, bool) override;
</del><ins>+ virtual void invalidateRootView(const WebCore::IntRect&) override;
+ virtual void invalidateContentsAndRootView(const WebCore::IntRect&) override;
+ virtual void invalidateContentsForSlowScroll(const WebCore::IntRect&) override;
</ins><span class="cx"> virtual void scroll(const WebCore::IntSize&, const WebCore::IntRect&, const WebCore::IntRect&) override;
</span><span class="cx"> virtual WebCore::IntPoint screenToRootView(const WebCore::IntPoint&) const override;
</span><span class="cx"> virtual WebCore::IntRect rootViewToScreen(const WebCore::IntRect&) const override;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -427,12 +427,12 @@
</span><span class="cx"> return m_page->windowResizerRect();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebChromeClient::invalidateRootView(const IntRect&, bool)
</del><ins>+void WebChromeClient::invalidateRootView(const IntRect&)
</ins><span class="cx"> {
</span><span class="cx"> // Do nothing here, there's no concept of invalidating the window in the web process.
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebChromeClient::invalidateContentsAndRootView(const IntRect& rect, bool)
</del><ins>+void WebChromeClient::invalidateContentsAndRootView(const IntRect& rect)
</ins><span class="cx"> {
</span><span class="cx"> if (Document* document = m_page->corePage()->mainFrame().document()) {
</span><span class="cx"> if (document->printing())
</span><span class="lines">@@ -442,7 +442,7 @@
</span><span class="cx"> m_page->drawingArea()->setNeedsDisplayInRect(rect);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebChromeClient::invalidateContentsForSlowScroll(const IntRect& rect, bool)
</del><ins>+void WebChromeClient::invalidateContentsForSlowScroll(const IntRect& rect)
</ins><span class="cx"> {
</span><span class="cx"> if (Document* document = m_page->corePage()->mainFrame().document()) {
</span><span class="cx"> if (document->printing())
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h (164593 => 164594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2014-02-24 18:49:01 UTC (rev 164593)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2014-02-24 19:05:21 UTC (rev 164594)
</span><span class="lines">@@ -108,9 +108,9 @@
</span><span class="cx"> virtual WebCore::IntRect windowResizerRect() const override;
</span><span class="cx">
</span><span class="cx"> // HostWindow member function overrides.
</span><del>- virtual void invalidateRootView(const WebCore::IntRect&, bool) override;
- virtual void invalidateContentsAndRootView(const WebCore::IntRect&, bool) override;
- virtual void invalidateContentsForSlowScroll(const WebCore::IntRect&, bool) override;
</del><ins>+ virtual void invalidateRootView(const WebCore::IntRect&) override;
+ virtual void invalidateContentsAndRootView(const WebCore::IntRect&) override;
+ virtual void invalidateContentsForSlowScroll(const WebCore::IntRect&) override;
</ins><span class="cx"> virtual void scroll(const WebCore::IntSize& scrollDelta, const WebCore::IntRect& scrollRect, const WebCore::IntRect& clipRect) override;
</span><span class="cx"> #if USE(TILED_BACKING_STORE)
</span><span class="cx"> virtual void delegatedScrollRequested(const WebCore::IntPoint& scrollOffset) override;
</span></span></pre>
</div>
</div>
</body>
</html>