<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164602] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164602">164602</a></dd>
<dt>Author</dt> <dd>thiago.lacerda@openbossa.org</dd>
<dt>Date</dt> <dd>2014-02-24 13:00:36 -0800 (Mon, 24 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[WebRTC] Validating RTCConfiguration according to the spec
https://bugs.webkit.org/show_bug.cgi?id=129182
Reviewed by Eric Carlson.
Spec states that:
- iceServers should not be an empty list
- the entry in the configuration dictionary is "urls", instead of "url"
- urls can be either a list or a string
Fixing all that in RTCConfiguration validation when creating a RTCPeerConnection
Source/WebCore:
Existing tests were updated.
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::appendIceServer): Added.
(WebCore::processIceServer): Added.
(WebCore::RTCPeerConnection::parseConfiguration):
LayoutTests:
* fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
* fast/mediastream/RTCPeerConnection-createAnswer.html:
* fast/mediastream/RTCPeerConnection-createOffer.html:
* fast/mediastream/RTCPeerConnection-datachannel.html:
* fast/mediastream/RTCPeerConnection-dtmf.html:
* fast/mediastream/RTCPeerConnection-events.html:
* fast/mediastream/RTCPeerConnection-expected.txt:
* fast/mediastream/RTCPeerConnection-have-local-answer.html:
* fast/mediastream/RTCPeerConnection-have-local-offer.html:
* fast/mediastream/RTCPeerConnection-have-local-pranswer.html:
* fast/mediastream/RTCPeerConnection-have-remote-offer.html:
* fast/mediastream/RTCPeerConnection-have-remote-pranswer.html:
* fast/mediastream/RTCPeerConnection-ice-expected.txt:
* fast/mediastream/RTCPeerConnection-ice.html:
* fast/mediastream/RTCPeerConnection-localDescription.html:
* fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
* fast/mediastream/RTCPeerConnection-remoteDescription.html:
* fast/mediastream/RTCPeerConnection-stable.html:
* fast/mediastream/RTCPeerConnection-state-expected.txt:
* fast/mediastream/RTCPeerConnection-state.html:
* fast/mediastream/RTCPeerConnection-stats-expected.txt:
* fast/mediastream/RTCPeerConnection-stats.html:
* fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
* fast/mediastream/RTCPeerConnection-statsSelector.html:
* fast/mediastream/RTCPeerConnection.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionAddRemoveStreamhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectioncreateAnswerhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createAnswer.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectioncreateOfferhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectiondatachannelhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-datachannel.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectiondtmfhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectioneventshtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-events.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionexpectedtxt">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionhavelocalanswerhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-local-answer.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionhavelocalofferhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-local-offer.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionhavelocalpranswerhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-local-pranswer.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionhaveremoteofferhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-remote-offer.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionhaveremotepranswerhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-remote-pranswer.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectioniceexpectedtxt">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionicehtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionlocalDescriptionhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectiononnegotiationneededhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionremoteDescriptionhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionstablehtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-stable.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionstateexpectedtxt">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-state-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionstatehtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-state.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionstatsexpectedtxt">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-stats-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionstatshtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-stats.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionstatsSelectorexpectedtxt">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionstatsSelectorhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCPeerConnectioncpp">trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/ChangeLog 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -1,3 +1,42 @@
</span><ins>+2014-02-24 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
+
+ [WebRTC] Validating RTCConfiguration according to the spec
+ https://bugs.webkit.org/show_bug.cgi?id=129182
+
+ Reviewed by Eric Carlson.
+
+ Spec states that:
+ - iceServers should not be an empty list
+ - the entry in the configuration dictionary is "urls", instead of "url"
+ - urls can be either a list or a string
+ Fixing all that in RTCConfiguration validation when creating a RTCPeerConnection
+
+ * fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
+ * fast/mediastream/RTCPeerConnection-createAnswer.html:
+ * fast/mediastream/RTCPeerConnection-createOffer.html:
+ * fast/mediastream/RTCPeerConnection-datachannel.html:
+ * fast/mediastream/RTCPeerConnection-dtmf.html:
+ * fast/mediastream/RTCPeerConnection-events.html:
+ * fast/mediastream/RTCPeerConnection-expected.txt:
+ * fast/mediastream/RTCPeerConnection-have-local-answer.html:
+ * fast/mediastream/RTCPeerConnection-have-local-offer.html:
+ * fast/mediastream/RTCPeerConnection-have-local-pranswer.html:
+ * fast/mediastream/RTCPeerConnection-have-remote-offer.html:
+ * fast/mediastream/RTCPeerConnection-have-remote-pranswer.html:
+ * fast/mediastream/RTCPeerConnection-ice-expected.txt:
+ * fast/mediastream/RTCPeerConnection-ice.html:
+ * fast/mediastream/RTCPeerConnection-localDescription.html:
+ * fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
+ * fast/mediastream/RTCPeerConnection-remoteDescription.html:
+ * fast/mediastream/RTCPeerConnection-stable.html:
+ * fast/mediastream/RTCPeerConnection-state-expected.txt:
+ * fast/mediastream/RTCPeerConnection-state.html:
+ * fast/mediastream/RTCPeerConnection-stats-expected.txt:
+ * fast/mediastream/RTCPeerConnection-stats.html:
+ * fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
+ * fast/mediastream/RTCPeerConnection-statsSelector.html:
+ * fast/mediastream/RTCPeerConnection.html:
+
</ins><span class="cx"> 2014-02-24 Radu Stavila <stavila@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSS Regions] Relative positioned elements overflowing the region do not get painted into the next tile
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionAddRemoveStreamhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -75,7 +75,7 @@
</span><span class="cx"> testPassed('Got a stream.');
</span><span class="cx"> stream = s;
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> pc.onnegotiationneeded = onErroneousNegotiationNeeded;
</span><span class="cx"> shouldThrow("pc.addStream(stream, {mandatory:{invalid:1}})");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectioncreateAnswerhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createAnswer.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createAnswer.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createAnswer.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -81,7 +81,7 @@
</span><span class="cx"> shouldNotThrow('pc.createAnswer(requestSucceeded2, requestFailed2, {mandatory:{"succeed":false}});');
</span><span class="cx"> }
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> shouldNotThrow('pc.createAnswer(requestSucceeded1, requestFailed1);');
</span><span class="cx">
</span><span class="cx"> window.jsTestIsAsync = true;
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectioncreateOfferhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> shouldNotThrow('pc.createOffer(requestSucceeded2, requestFailed2, {mandatory:{"succeed":false}});');
</span><span class="cx"> }
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> shouldNotThrow('pc.createOffer(requestSucceeded1, requestFailed1, {mandatory:{"succeed":true}});');
</span><span class="cx">
</span><span class="cx"> window.jsTestIsAsync = true;
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectiondatachannelhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-datachannel.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-datachannel.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-datachannel.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -81,7 +81,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> shouldNotThrow('dc = pc.createDataChannel("label1");');
</span><span class="cx"> shouldNotThrow('dc = pc.createDataChannel("label2", {});');
</span><span class="cx"> shouldNotThrow('dc = pc.createDataChannel("label3", {ordered:true});');
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx"> shouldNotThrow('dc = pc.createDataChannel("label3", {maxRetransmits:0});');
</span><span class="cx"> shouldNotThrow('dc = pc.createDataChannel("label3", {maxRetransmitTime:0});');
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> pc.oniceconnectionstatechange = pc_onicechange;
</span><span class="cx"> pc.ondatachannel = pc_ondatachannel;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectiondtmfhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> shouldBe('stream.getAudioTracks().length', '1');
</span><span class="cx"> shouldBe('stream.getVideoTracks().length', '0');
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> pc.oniceconnectionstatechange = pc_onicechange;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectioneventshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-events.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-events.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-events.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> testPassed('gotStream was called.');
</span><span class="cx"> stream = s;
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> pc.onnegotiationneeded = onNegotiationNeeded;
</span><span class="cx">
</span><span class="cx"> pc.addStream(stream);
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -18,66 +18,77 @@
</span><span class="cx"> PASS new webkitRTCPeerConnection(null, {}); threw exception TypeError: First argument of RTCPeerConnection must be a valid Dictionary.
</span><span class="cx"> PASS new webkitRTCPeerConnection(undefined, {}); threw exception TypeError: First argument of RTCPeerConnection must be a valid Dictionary.
</span><span class="cx"> PASS new webkitRTCPeerConnection({iceServers:[]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
</span><del>-PASS new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'}]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com', username:'user'}]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'user', credential:'x'}]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'user', credential:'x'},{url:'stun:bar.com', username:'user2', credential:'x'}]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
-PASS new webkitRTCPeerConnection({iceServers:[]}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'none'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'relay'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'all'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], requestIdentity:'yes'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], requestIdentity:'no'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], requestIdentity:'ifconfigured'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'foo', requestIdentity:'bar'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'none', requestIdentity:'bar'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'foo', requestIdentity:'no'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'none', requestIdentity:'yes'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'none', requestIdentity:'no'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'none', requestIdentity:'ifconfigured'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'relay', requestIdentity:'yes'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'relay', requestIdentity:'no'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'relay', requestIdentity:'ifconfigured'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'all', requestIdentity:'yes'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'all', requestIdentity:'no'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[], iceTransports:'all', requestIdentity:'ifconfigured'}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[]}, {}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]}, {}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'}]}, {}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}]}, {}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com', username:'user'}]}, {}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'user', credential:'x'}]}, {}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'user', credential:'x'},{url:'stun:bar.com', username:'user2', credential:'x'}]}, {}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com', username:'user'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'user', credential:'x'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'user', credential:'x'},{url:'stun:bar.com', username:'user2', credential:'x'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {}); did not throw exception.
</del><ins>+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', credential:'x'}]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com', username:'user'}]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'}]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'},{urls:'stun:bar.com', username:'user2', credential:'x'}]}, null); threw exception TypeError: Optional constraints argument of RTCPeerConnection must be a valid Dictionary.
+PASS new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]}); threw exception TypeError: Error creating RTCPeerConnection.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'http:foo.com'}]}); threw exception TypeError: Error creating RTCPeerConnection.
+PASS new webkitRTCPeerConnection({iceServers:[]}); threw exception TypeError: Error creating RTCPeerConnection.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:foo.com']}]}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'none'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'relay'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'all'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], requestIdentity:'yes'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], requestIdentity:'no'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], requestIdentity:'ifconfigured'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'foo', requestIdentity:'bar'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'none', requestIdentity:'bar'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'foo', requestIdentity:'no'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'none', requestIdentity:'yes'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'none', requestIdentity:'no'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'none', requestIdentity:'ifconfigured'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'relay', requestIdentity:'yes'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'relay', requestIdentity:'no'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'relay', requestIdentity:'ifconfigured'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'all', requestIdentity:'yes'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'all', requestIdentity:'no'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'all', requestIdentity:'ifconfigured'}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:bar.com']}]}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}, {urls:['stun:foo.com', 'turn:bar.com']}]}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', credential:'x'}]}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', credential:'x'},{urls:'stun:bar.com'}]}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com', username:'user'}]}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'}]}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'},{urls:'stun:bar.com', username:'user2', credential:'x'}]}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'},{urls:['stun:bar.com', 'turn:foo.com', 'turn:foo2.com'], username:'user2', credential:'x'}]}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', credential:'x'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', credential:'x'},{urls:'stun:bar.com'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com', username:'user'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'},{urls:'stun:bar.com', username:'user2', credential:'x'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {}); did not throw exception.
</ins><span class="cx"> PASS new webkitRTCPeerConnection({fooServers:[]}, {}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
</span><span class="cx"> PASS new webkitRTCPeerConnection({iceServers:true}, {}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
</span><span class="cx"> PASS new webkitRTCPeerConnection({iceServers:[1, 2, 3]}, {}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
</span><del>-PASS new webkitRTCPeerConnection({iceServers:[{}]}, {}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
-PASS new webkitRTCPeerConnection({iceServers:[{url:'foo'}]}, {}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
-PASS new webkitRTCPeerConnection({iceServers:[]}, {mandatory:true}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
-PASS new webkitRTCPeerConnection({iceServers:[]}, {optional:false}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
-PASS new webkitRTCPeerConnection({iceServers:[]}, {optional:{}}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
-PASS new webkitRTCPeerConnection({iceServers:[]}, {mandatory:{valid_and_supported_1:1}}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[]}, {mandatory:{valid_and_supported_1:1, valid_and_supported_2:1}}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[]}, {optional:[{valid_and_supported_1:0}]}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[]}, {optional:[{valid_and_supported_1:0},{valid_and_supported_2:0}]}); did not throw exception.
-PASS new webkitRTCPeerConnection({iceServers:[]}, {optional:[{valid_but_unsupported_1:0},{valid_but_unsupported_2:0}]}); did not throw exception.
</del><ins>+PASS new webkitRTCPeerConnection({iceServers:[{}]}, {}); threw exception TypeError: Error creating RTCPeerConnection.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'foo'}]}, {}); threw exception TypeError: Error creating RTCPeerConnection.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {mandatory:true}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {optional:false}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {optional:{}}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {mandatory:{valid_and_supported_1:1}}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {mandatory:{valid_and_supported_1:1, valid_and_supported_2:1}}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {optional:[{valid_and_supported_1:0}]}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {optional:[{valid_and_supported_1:0},{valid_and_supported_2:0}]}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {optional:[{valid_but_unsupported_1:0},{valid_but_unsupported_2:0}]}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}, {urls:['stun:bar.com', 'turn:foo.com']}]}, {mandatory:{valid_and_supported_1:1}}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}, {urls:['stun:bar.com', 'turn:foo.com']}]}, {mandatory:{valid_and_supported_1:1, valid_and_supported_2:1}}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}, {urls:['stun:bar.com', 'turn:foo.com']}]}, {optional:[{valid_and_supported_1:0}]}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}, {urls:['stun:bar.com', 'turn:foo.com']}]}, {optional:[{valid_and_supported_1:0},{valid_and_supported_2:0}]}); did not throw exception.
+PASS new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}, {urls:['stun:bar.com', 'turn:foo.com']}]}, {optional:[{valid_but_unsupported_1:0},{valid_but_unsupported_2:0}]}); did not throw exception.
</ins><span class="cx"> PASS new webkitRTCPeerConnection({iceServers:[]}, {mandatory:{valid_and_supported_1:66}}); threw exception TypeError: Error creating RTCPeerConnection.
</span><span class="cx"> PASS new webkitRTCPeerConnection({iceServers:[]}, {mandatory:{invalid:1}}); threw exception TypeError: Error creating RTCPeerConnection.
</span><span class="cx"> PASS new webkitRTCPeerConnection({iceServers:[]}, {mandatory:{valid_but_unsupported_1:1}}); threw exception TypeError: Error creating RTCPeerConnection.
</span><span class="cx"> PASS new webkitRTCPeerConnection({iceServers:[]}, {mandatory:{valid_but_unsupported_1:1, valid_and_supported_1:1}}); threw exception TypeError: Error creating RTCPeerConnection.
</span><del>-PASS new webkitRTCPeerConnection({iceServers:[]}, {optional:{valid_and_supported_1:0}}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
-PASS new webkitRTCPeerConnection({iceServers:[]}, {optional:[{valid_and_supported_1:0,valid_and_supported_2:0}]}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
</del><ins>+PASS new webkitRTCPeerConnection({iceServers:[]}, {optional:{valid_and_supported_1:0}}); threw exception TypeError: Error creating RTCPeerConnection.
+PASS new webkitRTCPeerConnection({iceServers:[]}, {optional:[{valid_and_supported_1:0,valid_and_supported_2:0}]}); threw exception TypeError: Error creating RTCPeerConnection.
</ins><span class="cx"> PASS new webkitRTCPeerConnection({iceServers:[]}, {optional:[{invalid:0}]}); threw exception TypeError: Error creating RTCPeerConnection.
</span><del>-PASS new webkitRTCPeerConnection({iceServers:[]}, {valid_and_supported_1:1}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
-PASS new webkitRTCPeerConnection({iceServers:[]}, {valid_but_unsupported_1:1}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
-PASS new webkitRTCPeerConnection({iceServers:[]}, {valid_and_supported_2:1, mandatory:{valid_and_supported_1:1}}); threw exception TypeError: Invalid RTCPeerConnection constructor arguments.
</del><ins>+PASS new webkitRTCPeerConnection({iceServers:[]}, {valid_and_supported_1:1}); threw exception TypeError: Error creating RTCPeerConnection.
+PASS new webkitRTCPeerConnection({iceServers:[]}, {valid_but_unsupported_1:1}); threw exception TypeError: Error creating RTCPeerConnection.
+PASS new webkitRTCPeerConnection({iceServers:[]}, {valid_and_supported_2:1, mandatory:{valid_and_supported_1:1}}); threw exception TypeError: Error creating RTCPeerConnection.
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionhavelocalanswerhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-local-answer.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-local-answer.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-local-answer.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx"> shouldBe('pc.signalingState', signalingState);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> shouldBe('pc.signalingState', '"stable"');
</span><span class="cx"> var sessionDescription = new RTCSessionDescription({type:"offer", sdp:"remote"});
</span><span class="cx"> shouldNotThrow('pc.setRemoteDescription(sessionDescription, requestSucceeded1, finishIfFailed);');
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionhavelocalofferhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-local-offer.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-local-offer.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-local-offer.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -28,7 +28,7 @@
</span><span class="cx"> {
</span><span class="cx"> testPassed('setRemoteDescription succeeded.');
</span><span class="cx"> check("offer", "local", "pranswer", "remote", '"have-remote-pranswer"');
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> check("", "", "", "", '"stable"');
</span><span class="cx"> sessionDescription = new RTCSessionDescription({type:"offer", sdp:"local"});
</span><span class="cx"> shouldNotThrow('pc.setLocalDescription(sessionDescription, requestSucceeded4, finishIfFailed);');
</span><span class="lines">@@ -109,7 +109,7 @@
</span><span class="cx"> shouldBe('pc.signalingState', signalingState);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> shouldBe('pc.signalingState', '"stable"');
</span><span class="cx"> var sessionDescription = new RTCSessionDescription({type:"offer", sdp:"local"});
</span><span class="cx"> shouldNotThrow('pc.setLocalDescription(sessionDescription, requestSucceeded1, finishIfFailed);');
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionhavelocalpranswerhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-local-pranswer.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-local-pranswer.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-local-pranswer.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -105,7 +105,7 @@
</span><span class="cx"> shouldBe('pc.signalingState', signalingState);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> shouldBe('pc.signalingState', '"stable"');
</span><span class="cx"> var sessionDescription = new RTCSessionDescription({type:"offer", sdp:"remote"});
</span><span class="cx"> shouldNotThrow('pc.setRemoteDescription(sessionDescription, requestSucceeded1, finishIfFailed);');
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionhaveremoteofferhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-remote-offer.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-remote-offer.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-remote-offer.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -28,7 +28,7 @@
</span><span class="cx"> {
</span><span class="cx"> testPassed('setLocalDescription succeeded.');
</span><span class="cx"> check("answer", "local", "offer", "remote", '"stable"');
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> check("", "", "", "", '"stable"');
</span><span class="cx"> sessionDescription = new RTCSessionDescription({type:"offer", sdp:"remote"});
</span><span class="cx"> shouldNotThrow('pc.setRemoteDescription(sessionDescription, requestSucceeded4, finishIfFailed);');
</span><span class="lines">@@ -109,7 +109,7 @@
</span><span class="cx"> shouldBe('pc.signalingState', signalingState);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> shouldBe('pc.signalingState', '"stable"');
</span><span class="cx"> var sessionDescription = new RTCSessionDescription({type:"offer", sdp:"remote"});
</span><span class="cx"> shouldNotThrow('pc.setRemoteDescription(sessionDescription, requestSucceeded1, finishIfFailed);');
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionhaveremotepranswerhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-remote-pranswer.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-remote-pranswer.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-have-remote-pranswer.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -105,7 +105,7 @@
</span><span class="cx"> shouldBe('pc.signalingState', signalingState);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> shouldBe('pc.signalingState', '"stable"');
</span><span class="cx"> var sessionDescription = new RTCSessionDescription({type:"offer", sdp:"local"});
</span><span class="cx"> shouldNotThrow('pc.setLocalDescription(sessionDescription, requestSucceeded1, finishIfFailed);');
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectioniceexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS pc = new webkitRTCPeerConnection({iceServers:[]}); did not throw exception.
</del><ins>+PASS pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}); did not throw exception.
</ins><span class="cx"> PASS iceConnectionState is completed
</span><span class="cx"> PASS pc.addIceCandidate(null, null, null); threw exception TypeError: Type error.
</span><span class="cx"> PASS pc.addIceCandidate(iceCandidate, null, null); threw exception TypeError: Type error.
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionicehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- shouldNotThrow('pc = new webkitRTCPeerConnection({iceServers:[]});');
</del><ins>+ shouldNotThrow("pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});");
</ins><span class="cx"> pc.oniceconnectionstatechange = onIceChange1;
</span><span class="cx">
</span><span class="cx"> window.jsTestIsAsync = true;
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionlocalDescriptionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> shouldNotThrow('pc.setLocalDescription(sessionDescription, requestSucceeded2, requestFailed2);');
</span><span class="cx"> }
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> var sessionDescription = new RTCSessionDescription({type:"offer", sdp:"local"});
</span><span class="cx"> shouldNotThrow('pc.setLocalDescription(sessionDescription, requestSucceeded1, requestFailed1);');
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectiononnegotiationneededhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> testPassed('Got a stream.');
</span><span class="cx"> stream = s;
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> pc.onnegotiationneeded = onNegotiationNeeded;
</span><span class="cx">
</span><span class="cx"> pc.addStream(stream);
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionremoteDescriptionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> shouldNotThrow('pc.setRemoteDescription(sessionDescription, requestSucceeded2, requestFailed2);');
</span><span class="cx"> }
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> var sessionDescription = new RTCSessionDescription({type:"offer", sdp:"remote"});
</span><span class="cx"> shouldNotThrow('pc.setRemoteDescription(sessionDescription, requestSucceeded1, requestFailed1);');
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionstablehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-stable.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-stable.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-stable.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -20,7 +20,7 @@
</span><span class="cx"> {
</span><span class="cx"> testPassed('setLocalDescription succeeded.');
</span><span class="cx"> check("offer", "local", "", "", '"have-local-offer"')
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> check("", "", "", "", '"stable"');
</span><span class="cx"> sessionDescription = new RTCSessionDescription({type:"offer", sdp:"remote"});
</span><span class="cx"> shouldNotThrow('pc.setRemoteDescription(sessionDescription, requestSucceeded2, finishIfFailed);');
</span><span class="lines">@@ -95,7 +95,7 @@
</span><span class="cx"> shouldBe('pc.signalingState', signalingState);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- pc = new webkitRTCPeerConnection({iceServers:[]});
</del><ins>+ pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});
</ins><span class="cx"> shouldBe('pc.signalingState', '"stable"');
</span><span class="cx"> var sessionDescription = new RTCSessionDescription({type:"answer", sdp:"local"});
</span><span class="cx"> shouldNotThrow('pc.setLocalDescription(sessionDescription, finishIfSucceeded, requestFailed1);');
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionstateexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-state-expected.txt (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-state-expected.txt 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-state-expected.txt 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS pc = new webkitRTCPeerConnection({iceServers:[]}); did not throw exception.
</del><ins>+PASS pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}); did not throw exception.
</ins><span class="cx"> PASS pc.signalingState is "stable"
</span><span class="cx"> PASS stateChanged was called
</span><span class="cx"> PASS pc.signalingState is "closed"
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionstatehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-state.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-state.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-state.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -16,7 +16,7 @@
</span><span class="cx"> finishJSTest();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- shouldNotThrow('pc = new webkitRTCPeerConnection({iceServers:[]});');
</del><ins>+ shouldNotThrow("pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});");
</ins><span class="cx"> shouldBeEqualToString('pc.signalingState', 'stable');
</span><span class="cx"> pc.onsignalingstatechange = stateChanged;
</span><span class="cx"> pc.close();
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionstatsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-stats-expected.txt (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-stats-expected.txt 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-stats-expected.txt 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS pc = new webkitRTCPeerConnection({iceServers:[]}) did not throw exception.
</del><ins>+PASS pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}) did not throw exception.
</ins><span class="cx"> PASS pc.getStats(statsHandler1) did not throw exception.
</span><span class="cx"> PASS statsHandler1 was called
</span><span class="cx"> PASS status is non-null.
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionstatshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-stats.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-stats.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-stats.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var startTime = new Date().getTime();
</span><del>- shouldNotThrow('pc = new webkitRTCPeerConnection({iceServers:[]})');
</del><ins>+ shouldNotThrow("pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]})");
</ins><span class="cx"> shouldNotThrow('pc.getStats(statsHandler1)');
</span><span class="cx">
</span><span class="cx"> window.jsTestIsAsync = true;
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionstatsSelectorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector-expected.txt (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector-expected.txt 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector-expected.txt 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS pc = new webkitRTCPeerConnection({iceServers:[]}) did not throw exception.
</del><ins>+PASS pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}) did not throw exception.
</ins><span class="cx"> PASS getUserMedia({audio:true, video:true}, gotStream) did not throw exception.
</span><span class="cx"> PASS Got a stream.
</span><span class="cx"> PASS pc.getStats(statsHandler2, pc.getLocalStreams()[0].getVideoTracks()[0]) did not throw exception.
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionstatsSelectorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var startTime = new Date().getTime();
</span><del>- shouldNotThrow('pc = new webkitRTCPeerConnection({iceServers:[]})');
</del><ins>+ shouldNotThrow("pc = new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]})");
</ins><span class="cx"> shouldNotThrow('getUserMedia({audio:true, video:true}, gotStream)');
</span><span class="cx">
</span><span class="cx"> window.jsTestIsAsync = true;
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -22,63 +22,75 @@
</span><span class="cx"> shouldThrow("new webkitRTCPeerConnection(null, {});");
</span><span class="cx"> shouldThrow("new webkitRTCPeerConnection(undefined, {});");
</span><span class="cx"> shouldThrow("new webkitRTCPeerConnection({iceServers:[]}, null);");
</span><del>- shouldThrow("new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]}, null);");
- shouldThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'}]}, null);");
- shouldThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}]}, null);");
- shouldThrow("new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com', username:'user'}]}, null);");
- shouldThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'user', credential:'x'}]}, null);");
- shouldThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'user', credential:'x'},{url:'stun:bar.com', username:'user2', credential:'x'}]}, null);")
</del><ins>+ shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, null);");
+ shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', credential:'x'}]}, null);");
+ shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}]}, null);");
+ shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com', username:'user'}]}, null);");
+ shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'}]}, null);");
+ shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'},{urls:'stun:bar.com', username:'user2', credential:'x'}]}, null);")
+ shouldThrow("new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]});");
+ shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:'http:foo.com'}]});");
+ shouldThrow("new webkitRTCPeerConnection({iceServers:[]});");
</ins><span class="cx">
</span><del>- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[]});");
</del><ins>+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:foo.com']}]});");
</ins><span class="cx">
</span><del>- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'none'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'relay'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'all'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], requestIdentity:'yes'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], requestIdentity:'no'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], requestIdentity:'ifconfigured'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'foo', requestIdentity:'bar'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'none', requestIdentity:'bar'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'foo', requestIdentity:'no'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'none', requestIdentity:'yes'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'none', requestIdentity:'no'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'none', requestIdentity:'ifconfigured'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'relay', requestIdentity:'yes'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'relay', requestIdentity:'no'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'relay', requestIdentity:'ifconfigured'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'all', requestIdentity:'yes'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'all', requestIdentity:'no'});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], iceTransports:'all', requestIdentity:'ifconfigured'});");
</del><ins>+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'none'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'relay'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'all'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], requestIdentity:'yes'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], requestIdentity:'no'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], requestIdentity:'ifconfigured'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'foo', requestIdentity:'bar'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'none', requestIdentity:'bar'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'foo', requestIdentity:'no'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'none', requestIdentity:'yes'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'none', requestIdentity:'no'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'none', requestIdentity:'ifconfigured'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'relay', requestIdentity:'yes'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'relay', requestIdentity:'no'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'relay', requestIdentity:'ifconfigured'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'all', requestIdentity:'yes'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'all', requestIdentity:'no'});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}], iceTransports:'all', requestIdentity:'ifconfigured'});");
</ins><span class="cx">
</span><del>- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[]}, {});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]}, {});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'}]}, {});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}]}, {});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com', username:'user'}]}, {});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'user', credential:'x'}]}, {});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'user', credential:'x'},{url:'stun:bar.com', username:'user2', credential:'x'}]}, {});");
</del><ins>+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:bar.com']}]}, {});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}, {urls:['stun:foo.com', 'turn:bar.com']}]}, {});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', credential:'x'}]}, {});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', credential:'x'},{urls:'stun:bar.com'}]}, {});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com', username:'user'}]}, {});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'}]}, {});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'},{urls:'stun:bar.com', username:'user2', credential:'x'}]}, {});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'},{urls:['stun:bar.com', 'turn:foo.com', 'turn:foo2.com'], username:'user2', credential:'x'}]}, {});");
</ins><span class="cx">
</span><del>- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com', username:'user'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'user', credential:'x'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'user', credential:'x'},{url:'stun:bar.com', username:'user2', credential:'x'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {});");
</del><ins>+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', credential:'x'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', credential:'x'},{urls:'stun:bar.com'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com', username:'user'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'turn:foo.com', username:'user', credential:'x'},{urls:'stun:bar.com', username:'user2', credential:'x'}], iceTransports:'all', requestIdentity:'ifconfigured'}, {});");
</ins><span class="cx">
</span><span class="cx"> shouldThrow("new webkitRTCPeerConnection({fooServers:[]}, {});");
</span><span class="cx"> shouldThrow("new webkitRTCPeerConnection({iceServers:true}, {});");
</span><span class="cx"> shouldThrow("new webkitRTCPeerConnection({iceServers:[1, 2, 3]}, {});");
</span><span class="cx"> shouldThrow("new webkitRTCPeerConnection({iceServers:[{}]}, {});");
</span><del>- shouldThrow("new webkitRTCPeerConnection({iceServers:[{url:'foo'}]}, {});");
- shouldThrow("new webkitRTCPeerConnection({iceServers:[]}, {mandatory:true});");
- shouldThrow("new webkitRTCPeerConnection({iceServers:[]}, {optional:false});");
- shouldThrow("new webkitRTCPeerConnection({iceServers:[]}, {optional:{}});");
</del><ins>+ shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:'foo'}]}, {});");
+ shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {mandatory:true});");
+ shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {optional:false});");
+ shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {optional:{}});");
</ins><span class="cx">
</span><del>- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[]}, {mandatory:{valid_and_supported_1:1}});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[]}, {mandatory:{valid_and_supported_1:1, valid_and_supported_2:1}});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[]}, {optional:[{valid_and_supported_1:0}]});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[]}, {optional:[{valid_and_supported_1:0},{valid_and_supported_2:0}]});");
- shouldNotThrow("new webkitRTCPeerConnection({iceServers:[]}, {optional:[{valid_but_unsupported_1:0},{valid_but_unsupported_2:0}]});");
</del><ins>+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {mandatory:{valid_and_supported_1:1}});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {mandatory:{valid_and_supported_1:1, valid_and_supported_2:1}});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {optional:[{valid_and_supported_1:0}]});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {optional:[{valid_and_supported_1:0},{valid_and_supported_2:0}]});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, {optional:[{valid_but_unsupported_1:0},{valid_but_unsupported_2:0}]});");
</ins><span class="cx">
</span><ins>+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}, {urls:['stun:bar.com', 'turn:foo.com']}]}, {mandatory:{valid_and_supported_1:1}});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}, {urls:['stun:bar.com', 'turn:foo.com']}]}, {mandatory:{valid_and_supported_1:1, valid_and_supported_2:1}});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}, {urls:['stun:bar.com', 'turn:foo.com']}]}, {optional:[{valid_and_supported_1:0}]});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}, {urls:['stun:bar.com', 'turn:foo.com']}]}, {optional:[{valid_and_supported_1:0},{valid_and_supported_2:0}]});");
+ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}, {urls:['stun:bar.com', 'turn:foo.com']}]}, {optional:[{valid_but_unsupported_1:0},{valid_but_unsupported_2:0}]});");
+
</ins><span class="cx"> shouldThrow("new webkitRTCPeerConnection({iceServers:[]}, {mandatory:{valid_and_supported_1:66}});");
</span><span class="cx"> shouldThrow("new webkitRTCPeerConnection({iceServers:[]}, {mandatory:{invalid:1}});");
</span><span class="cx"> shouldThrow("new webkitRTCPeerConnection({iceServers:[]}, {mandatory:{valid_but_unsupported_1:1}});");
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/Source/WebCore/ChangeLog 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2014-02-24 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
+
+ [WebRTC] Validating RTCConfiguration according to the spec
+ https://bugs.webkit.org/show_bug.cgi?id=129182
+
+ Reviewed by Eric Carlson.
+
+ Spec states that:
+ - iceServers should not be an empty list
+ - the entry in the configuration dictionary is "urls", instead of "url"
+ - urls can be either a list or a string
+ Fixing all that in RTCConfiguration validation when creating a RTCPeerConnection
+
+ Existing tests were updated.
+
+ * Modules/mediastream/RTCPeerConnection.cpp:
+ (WebCore::appendIceServer): Added.
+ (WebCore::processIceServer): Added.
+ (WebCore::RTCPeerConnection::parseConfiguration):
+
</ins><span class="cx"> 2014-02-24 Radu Stavila <stavila@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSS Regions] Relative positioned elements overflowing the region do not get painted into the next tile
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCPeerConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (164601 => 164602)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2014-02-24 20:53:02 UTC (rev 164601)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2014-02-24 21:00:36 UTC (rev 164602)
</span><span class="lines">@@ -66,6 +66,47 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><ins>+static bool appendIceServer(const String& iceURL, const String& credential, const String& username, RTCConfiguration* rtcConfiguration)
+{
+ URL url(URL(), iceURL);
+ if (url.isEmpty() || !url.isValid() || !(url.protocolIs("turn") || url.protocolIs("stun")))
+ return false;
+
+ rtcConfiguration->appendServer(RTCIceServer::create(url, credential, username));
+ return true;
+}
+
+static ExceptionCode processIceServer(const Dictionary& iceServer, RTCConfiguration* rtcConfiguration)
+{
+ String credential, username;
+ iceServer.get("credential", credential);
+ iceServer.get("username", username);
+
+ // Spec says that "urls" can be either a string or a sequence, so we must check for both.
+ Vector<String> urlsList;
+ String urlString;
+ iceServer.get("urls", urlString);
+ // This is the only way to check if "urls" is a sequence or a string. If we try to convert
+ // to a sequence and it fails (in case it is a string), an exception will be set and the
+ // RTCPeerConnection will fail.
+ // So we convert to a string always, which converts a sequence to a string in the format: "foo, bar, ..",
+ // then checking for a comma in the string assures that a string was a sequence and then we convert
+ // it to a sequence safely.
+ if (urlString.find(',') != notFound && iceServer.get("urls", urlsList) && urlsList.size()) {
+ for (auto iter = urlsList.begin(); iter != urlsList.end(); ++iter) {
+ if (!appendIceServer((*iter), credential, username, rtcConfiguration))
+ return INVALID_ACCESS_ERR;
+ }
+
+ return 0;
+ }
+
+ if (!urlString.isEmpty() && appendIceServer(urlString, credential, username, rtcConfiguration))
+ return 0;
+
+ return INVALID_ACCESS_ERR;
+}
+
</ins><span class="cx"> PassRefPtr<RTCConfiguration> RTCPeerConnection::parseConfiguration(const Dictionary& configuration, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> if (configuration.isUndefinedOrNull())
</span><span class="lines">@@ -80,8 +121,8 @@
</span><span class="cx">
</span><span class="cx"> size_t numberOfServers;
</span><span class="cx"> ok = iceServers.length(numberOfServers);
</span><del>- if (!ok) {
- ec = TYPE_MISMATCH_ERR;
</del><ins>+ if (!ok || !numberOfServers) {
+ ec = !ok ? TYPE_MISMATCH_ERR : INVALID_ACCESS_ERR;
</ins><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -103,22 +144,9 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- String urlString, credential, username;
- ok = iceServer.get("url", urlString);
- if (!ok) {
- ec = TYPE_MISMATCH_ERR;
</del><ins>+ ec = processIceServer(iceServer, rtcConfiguration.get());
+ if (ec)
</ins><span class="cx"> return nullptr;
</span><del>- }
- URL url(URL(), urlString);
- if (!url.isValid() || !(url.protocolIs("turn") || url.protocolIs("stun"))) {
- ec = TYPE_MISMATCH_ERR;
- return nullptr;
- }
-
- iceServer.get("credential", credential);
- iceServer.get("username", username);
-
- rtcConfiguration->appendServer(RTCIceServer::create(url, credential, username));
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return rtcConfiguration.release();
</span></span></pre>
</div>
</div>
</body>
</html>