<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164492] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164492">164492</a></dd>
<dt>Author</dt> <dd>jhoneycutt@apple.com</dd>
<dt>Date</dt> <dd>2014-02-21 12:37:01 -0800 (Fri, 21 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Crash reloading page with position: fixed content
https://bugs.webkit.org/show_bug.cgi?id=129119
<rdar://problem/16127090>
Reviewed by Brent Fulgham.
Source/WebCore:
Test: platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::removeDestroyedNodes):
Check the node's ID against the latched node's ID before the node is
removed from the tree.
LayoutTests:
* platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepagescrollingScrollingTreecpp">trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformmacwk2tileddrawingcrashreloadingwithpositionfixedcontentexpectedtxt">trunk/LayoutTests/platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2tileddrawingcrashreloadingwithpositionfixedcontenthtml">trunk/LayoutTests/platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164491 => 164492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2014-02-21 20:18:59 UTC (rev 164491)
+++ trunk/LayoutTests/ChangeLog        2014-02-21 20:37:01 UTC (rev 164492)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-02-21 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Crash reloading page with position: fixed content
+ https://bugs.webkit.org/show_bug.cgi?id=129119
+ <rdar://problem/16127090>
+
+ Reviewed by Brent Fulgham.
+
+ * platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content-expected.txt: Added.
+ * platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html: Added.
+
</ins><span class="cx"> 2014-02-21 Andrei Bucur <abucur@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSS Regions] Regions don't paint correctly in new-multicol elements
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2tileddrawingcrashreloadingwithpositionfixedcontentexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content-expected.txt (0 => 164492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content-expected.txt         (rev 0)
+++ trunk/LayoutTests/platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content-expected.txt        2014-02-21 20:37:01 UTC (rev 164492)
</span><span class="lines">@@ -0,0 +1,2 @@
</span><ins>+WebKit bug #129119
+This test passes if it does not crash after reloading. To run manually, reload the page.
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2tileddrawingcrashreloadingwithpositionfixedcontenthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html (0 => 164492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html         (rev 0)
+++ trunk/LayoutTests/platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html        2014-02-21 20:37:01 UTC (rev 164492)
</span><span class="lines">@@ -0,0 +1,42 @@
</span><ins>+<head>
+ <style>
+ :first-of-type {
+ position: fixed;
+ }
+ </style>
+</head>
+
+<body>
+ <p>
+ WebKit bug #<a href="https://bugs.webkit.org/show_bug.cgi?id=129119">129119</a>
+ </p>
+ <p>
+ This test passes if it does not crash after reloading. To run manually, reload the page.
+ </p>
+</body>
+
+<script>
+function runTest()
+{
+ document.body.offetTop;
+
+ if (!window.sessionStorage)
+ return;
+
+ if (sessionStorage.testCompleted) {
+ delete sessionStorage.testCompleted;
+ if (window.testRunner)
+ testRunner.notifyDone();
+ } else {
+ sessionStorage.testCompleted = true;
+ window.location.reload(true);
+ }
+}
+
+if (window.testRunner) {
+ testRunner.waitUntilDone();
+ testRunner.dumpAsText();
+}
+
+window.addEventListener('DOMContentLoaded', function() { window.setTimeout(runTest, 100) }, false);
+</script>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164491 => 164492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-02-21 20:18:59 UTC (rev 164491)
+++ trunk/Source/WebCore/ChangeLog        2014-02-21 20:37:01 UTC (rev 164492)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-02-21 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Crash reloading page with position: fixed content
+ https://bugs.webkit.org/show_bug.cgi?id=129119
+ <rdar://problem/16127090>
+
+ Reviewed by Brent Fulgham.
+
+ Test: platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html
+
+ * page/scrolling/ScrollingTree.cpp:
+ (WebCore::ScrollingTree::removeDestroyedNodes):
+ Check the node's ID against the latched node's ID before the node is
+ removed from the tree.
+
</ins><span class="cx"> 2014-02-21 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Revert r164486, causing a number of test failures.
</span></span></pre></div>
<a id="trunkSourceWebCorepagescrollingScrollingTreecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp (164491 => 164492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp        2014-02-21 20:18:59 UTC (rev 164491)
+++ trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp        2014-02-21 20:37:01 UTC (rev 164492)
</span><span class="lines">@@ -197,13 +197,13 @@
</span><span class="cx"> if (!node)
</span><span class="cx"> continue;
</span><span class="cx">
</span><ins>+ if (node->scrollingNodeID() == m_latchedNode)
+ clearLatchedNode();
+
</ins><span class="cx"> // Never destroy the root node. There will be a new root node in the state tree, and we will
</span><span class="cx"> // associate it with our existing root node in updateTreeFromStateNode().
</span><span class="cx"> if (node->parent())
</span><span class="cx"> m_rootNode->removeChild(node);
</span><del>-
- if (node->scrollingNodeID() == m_latchedNode)
- clearLatchedNode();
</del><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>