<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164376] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164376">164376</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-02-19 11:22:43 -0800 (Wed, 19 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: AX: clarify reason for ignored state where possible (hidden, default for tag, etc)
https://bugs.webkit.org/show_bug.cgi?id=129037
Patch by James Craig <jcraig@apple.com> on 2014-02-19
Reviewed by Timothy Hatcher.
Source/WebCore:
Passing back hidden and ignoredByDefault attrs to clarify some reasons for "ignored" status.
Test Updated: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
* inspector/protocol/DOM.json:
Source/WebInspectorUI:
Passing back hidden and ignoredByDefault attrs to clarify some reasons for "ignored" status.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/DOMNode.js:
* UserInterface/DOMNodeDetailsSidebarPanel.js:
LayoutTests:
Test updates to support hidden and ignoredByDefault in accessibility properties.
* inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
* inspector-protocol/dom/getAccessibilityPropertiesForNode.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectorprotocoldomgetAccessibilityPropertiesForNodeexpectedtxt">trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectorprotocoldomgetAccessibilityPropertiesForNodehtml">trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMAgentcpp">trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorprotocolDOMjson">trunk/Source/WebCore/inspector/protocol/DOM.json</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceDOMNodejs">trunk/Source/WebInspectorUI/UserInterface/DOMNode.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceDOMNodeDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/DOMNodeDetailsSidebarPanel.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164375 => 164376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-19 19:07:44 UTC (rev 164375)
+++ trunk/LayoutTests/ChangeLog 2014-02-19 19:22:43 UTC (rev 164376)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-02-19 James Craig <jcraig@apple.com>
+
+ Web Inspector: AX: clarify reason for ignored state where possible (hidden, default for tag, etc)
+ https://bugs.webkit.org/show_bug.cgi?id=129037
+
+ Reviewed by Timothy Hatcher.
+
+ Test updates to support hidden and ignoredByDefault in accessibility properties.
+
+ * inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
+ * inspector-protocol/dom/getAccessibilityPropertiesForNode.html:
+
</ins><span class="cx"> 2014-02-19 Jon Honeycutt <jhoneycutt@apple.com>
</span><span class="cx">
</span><span class="cx"> Add missing layout test results for
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldomgetAccessibilityPropertiesForNodeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt (164375 => 164376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt 2014-02-19 19:07:44 UTC (rev 164375)
+++ trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt 2014-02-19 19:22:43 UTC (rev 164376)
</span><span class="lines">@@ -1,8 +1,21 @@
</span><span class="cx"> Checking Web Inspector protocol for the Accessibility Node Inspector.
</span><span class="cx">
</span><del>-
-Total elements to be tested: 15.
</del><ins>+
+Total elements to be tested: 23.
</ins><span class="cx">
</span><ins>+<img src="./404.gif" alt="x" style="display:none;">
+ exists: false
+ label:
+ role:
+
+<img src="./404.gif" alt="x" aria-hidden="true">
+ exists: true
+ label:
+ role: img
+ ignored: true
+ ignoredByDefault: true
+ hidden: true
+
</ins><span class="cx"> <img src="./404.gif" alt="x">
</span><span class="cx"> exists: true
</span><span class="cx"> label:
</span><span class="lines">@@ -20,6 +33,20 @@
</span><span class="cx"> role: img
</span><span class="cx"> ignored: true
</span><span class="cx">
</span><ins>+<input style="display:none;">
+ exists: false
+ label:
+ role:
+
+<input aria-hidden="true">
+ exists: true
+ label:
+ role:
+ ignored: true
+ ignoredByDefault: true
+ hidden: true
+ required: false
+
</ins><span class="cx"> <input aria-invalid="fake-value-will-eval-to-true">
</span><span class="cx"> exists: true
</span><span class="cx"> label:
</span><span class="lines">@@ -46,6 +73,12 @@
</span><span class="cx"> role:
</span><span class="cx"> required: true
</span><span class="cx">
</span><ins>+<input>
+ exists: true
+ label:
+ role:
+ required: false
+
</ins><span class="cx"> <input type="button">
</span><span class="cx"> exists: true
</span><span class="cx"> label:
</span><span class="lines">@@ -61,12 +94,29 @@
</span><span class="cx"> label:
</span><span class="cx"> role: button
</span><span class="cx">
</span><ins>+<span aria-hidden="true"></span>
+ exists: true
+ label:
+ role:
+ ignored: true
+ ignoredByDefault: true
+ hidden: true
+
</ins><span class="cx"> <span></span>
</span><span class="cx"> exists: true
</span><span class="cx"> label:
</span><span class="cx"> role:
</span><span class="cx"> ignored: true
</span><ins>+ ignoredByDefault: true
</ins><span class="cx">
</span><ins>+<div aria-hidden="true"></div>
+ exists: true
+ label:
+ role:
+ ignored: true
+ ignoredByDefault: true
+ hidden: true
+
</ins><span class="cx"> <div></div>
</span><span class="cx"> exists: true
</span><span class="cx"> label:
</span><span class="lines">@@ -85,6 +135,12 @@
</span><span class="cx"> role:
</span><span class="cx"> ignored: true
</span><span class="cx">
</span><ins>+<script style="display:block;"></script>
+ exists: true
+ label:
+ role: group
+ ignored: true
+
</ins><span class="cx"> <script></script>
</span><span class="cx"> exists: false
</span><span class="cx"> label:
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldomgetAccessibilityPropertiesForNodehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html (164375 => 164376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html 2014-02-19 19:07:44 UTC (rev 164375)
+++ trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html 2014-02-19 19:22:43 UTC (rev 164376)
</span><span class="lines">@@ -6,27 +6,33 @@
</span><span class="cx">
</span><span class="cx"> <p>Checking Web Inspector protocol for the Accessibility Node Inspector.</p>
</span><span class="cx">
</span><del>-<!-- This one is never rendered, so "exists" should return false. -->
</del><span class="cx"> <script class="ex"></script>
</span><ins>+<script class="ex" style="display:block;"></script>
</ins><span class="cx">
</span><del>-<!-- The rest are rendered with various property differences. -->
</del><span class="cx"> <div class="ex"><div></div></div>
</span><span class="cx"> <div class="ex" role="presentation"><div></div></div>
</span><span class="cx"> <div class="ex"></div>
</span><ins>+<div class="ex" aria-hidden="true"></div>
</ins><span class="cx"> <span class="ex"></span>
</span><ins>+<span class="ex" aria-hidden="true"></span>
</ins><span class="cx">
</span><span class="cx"> <div class="ex" role="button" tabindex="0"></div>
</span><span class="cx"> <button class="ex"></button>
</span><span class="cx"> <input class="ex" type="button">
</span><span class="cx">
</span><ins>+<input class="ex">
</ins><span class="cx"> <input class="ex" required>
</span><span class="cx"> <input class="ex" aria-required="true">
</span><span class="cx"> <input class="ex" aria-invalid="spelling">
</span><span class="cx"> <input class="ex" aria-invalid="fake-value-will-eval-to-true">
</span><ins>+<input class="ex" aria-hidden="true">
+<input class="ex" style="display:none;">
</ins><span class="cx">
</span><span class="cx"> <img class="ex" src="./404.gif">
</span><span class="cx"> <img class="ex" src="./404.gif" alt="">
</span><span class="cx"> <img class="ex" src="./404.gif" alt="x">
</span><ins>+<img class="ex" src="./404.gif" alt="x" aria-hidden="true">
+<img class="ex" src="./404.gif" alt="x" style="display:none;">
</ins><span class="cx">
</span><span class="cx"> <script type="text/javascript">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164375 => 164376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-19 19:07:44 UTC (rev 164375)
+++ trunk/Source/WebCore/ChangeLog 2014-02-19 19:22:43 UTC (rev 164376)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-02-19 James Craig <jcraig@apple.com>
+
+ Web Inspector: AX: clarify reason for ignored state where possible (hidden, default for tag, etc)
+ https://bugs.webkit.org/show_bug.cgi?id=129037
+
+ Reviewed by Timothy Hatcher.
+
+ Passing back hidden and ignoredByDefault attrs to clarify some reasons for "ignored" status.
+
+ Test Updated: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
+
+ * inspector/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
+ * inspector/protocol/DOM.json:
+
</ins><span class="cx"> 2014-02-19 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
</span><span class="cx">
</span><span class="cx"> [WebRTC] Updating RTCConfiguration to match WebRTC editor's draft of 01/27/2014
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (164375 => 164376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2014-02-19 19:07:44 UTC (rev 164375)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2014-02-19 19:22:43 UTC (rev 164376)
</span><span class="lines">@@ -1416,7 +1416,9 @@
</span><span class="cx">
</span><span class="cx"> bool exists = false;
</span><span class="cx"> bool ignored = true;
</span><ins>+ bool ignoredByDefault = false;
</ins><span class="cx"> String invalid = "false"; // String values: true, false, spelling, grammar, etc.
</span><ins>+ bool hidden = false;
</ins><span class="cx"> String label; // FIXME: Waiting on http://webkit.org/b/121134
</span><span class="cx"> bool required = false;
</span><span class="cx"> String role;
</span><span class="lines">@@ -1426,11 +1428,14 @@
</span><span class="cx"> if (AccessibilityObject* axObject = axObjectCache->getOrCreate(node)) {
</span><span class="cx"> exists = true;
</span><span class="cx"> ignored = axObject->accessibilityIsIgnored();
</span><ins>+ ignoredByDefault = axObject->accessibilityIsIgnoredByDefault();
</ins><span class="cx"> invalid = axObject->invalidStatus();
</span><del>- role = axObject->computedRoleString();
</del><ins>+ if (axObject->isARIAHidden() || axObject->isDOMHidden())
+ hidden = true;
</ins><span class="cx"> supportsRequired = axObject->supportsRequiredAttribute();
</span><span class="cx"> if (supportsRequired)
</span><span class="cx"> required = axObject->isRequired();
</span><ins>+ role = axObject->computedRoleString();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1443,8 +1448,12 @@
</span><span class="cx"> if (exists) {
</span><span class="cx"> if (ignored)
</span><span class="cx"> value->setIgnored(ignored);
</span><ins>+ if (ignoredByDefault)
+ value->setIgnoredByDefault(ignoredByDefault);
</ins><span class="cx"> if (invalid != "false")
</span><span class="cx"> value->setInvalid(invalid);
</span><ins>+ if (hidden)
+ value->setHidden(hidden);
</ins><span class="cx"> if (supportsRequired)
</span><span class="cx"> value->setRequired(required);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorprotocolDOMjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/protocol/DOM.json (164375 => 164376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/protocol/DOM.json 2014-02-19 19:07:44 UTC (rev 164375)
+++ trunk/Source/WebCore/inspector/protocol/DOM.json 2014-02-19 19:22:43 UTC (rev 164376)
</span><span class="lines">@@ -61,7 +61,9 @@
</span><span class="cx"> "properties": [
</span><span class="cx"> { "name": "exists", "type": "boolean", "description": "Returns whether there is an existing AX object for the DOM node. If this is false, all the other properties will be default values." },
</span><span class="cx"> { "name": "ignored", "type": "boolean", "optional": true, "description": "Returns whether the accessibility of the associated AX object node is ignored, whether heuristically or explicitly." },
</span><ins>+ { "name": "ignoredByDefault", "type": "boolean", "optional": true, "description": "Returns whether the accessibility of the associated AX object node is ignored by default for node type." },
</ins><span class="cx"> { "name": "invalid", "type": "string", "optional": true, "description": "Returns the invalid status for form fields: true, false, grammar, spelling." },
</span><ins>+ { "name": "hidden", "type": "boolean", "optional": true, "description": "Returns true if node or an ancestor is hidden via CSS or explicit @aria-hidden, to clarify why the element is ignored." },
</ins><span class="cx"> { "name": "label", "type": "string", "description": "Computed label value for the node, sometimes calculated by referencing other nodes." },
</span><span class="cx"> { "name": "required", "type": "boolean", "optional": true, "description": "Returns whether the element is required or not required." },
</span><span class="cx"> { "name": "role", "type": "string", "description": "Computed value for first recognized role token, default role per element, or overridden role." },
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (164375 => 164376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-02-19 19:07:44 UTC (rev 164375)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-02-19 19:22:43 UTC (rev 164376)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-02-19 James Craig <jcraig@apple.com>
+
+ Web Inspector: AX: clarify reason for ignored state where possible (hidden, default for tag, etc)
+ https://bugs.webkit.org/show_bug.cgi?id=129037
+
+ Reviewed by Timothy Hatcher.
+
+ Passing back hidden and ignoredByDefault attrs to clarify some reasons for "ignored" status.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/DOMNode.js:
+ * UserInterface/DOMNodeDetailsSidebarPanel.js:
+
</ins><span class="cx"> 2014-02-18 James Craig <jcraig@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: AX: more properties: exists, required, and invalid (exists was previously combined with ignored)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (164375 => 164376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2014-02-19 19:07:44 UTC (rev 164375)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2014-02-19 19:22:43 UTC (rev 164376)
</span><span class="lines">@@ -25,6 +25,7 @@
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " % s E v e n t D i s p a t c h e d " ] = " % s E v e n t D i s p a t c h e d " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " % s ( c o m p u t e d ) " ] = " % s ( c o m p u t e d ) " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " % s ( d e f a u l t ) " ] = " % s ( d e f a u l t ) " ;
</span><ins>+ l o c a l i z e d S t r i n g s [ " % s ( h i d d e n ) " ] = " % s ( h i d d e n ) " ;
</ins><span class="cx"> l o c a l i z e d S t r i n g s [ " ( a n o n y m o u s f u n c t i o n ) " ] = " ( a n o n y m o u s f u n c t i o n ) " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " ( p r o g r a m ) " ] = " ( p r o g r a m ) " ;
</span><span class="cx"> l o c a l i z e d S t r i n g s [ " 1 m a t c h " ] = " 1 m a t c h " ;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceDOMNodejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/DOMNode.js (164375 => 164376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/DOMNode.js 2014-02-19 19:07:44 UTC (rev 164375)
+++ trunk/Source/WebInspectorUI/UserInterface/DOMNode.js 2014-02-19 19:22:43 UTC (rev 164376)
</span><span class="lines">@@ -449,7 +449,9 @@
</span><span class="cx"> callback({
</span><span class="cx"> exists: accessibilityProperties.exists,
</span><span class="cx"> ignored: accessibilityProperties.ignored,
</span><ins>+ ignoredByDefault: accessibilityProperties.ignoredByDefault,
</ins><span class="cx"> invalid: accessibilityProperties.invalid,
</span><ins>+ hidden: accessibilityProperties.hidden,
</ins><span class="cx"> label: accessibilityProperties.label,
</span><span class="cx"> required: accessibilityProperties.required,
</span><span class="cx"> role: accessibilityProperties.role
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceDOMNodeDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/DOMNodeDetailsSidebarPanel.js (164375 => 164376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/DOMNodeDetailsSidebarPanel.js 2014-02-19 19:07:44 UTC (rev 164375)
+++ trunk/Source/WebInspectorUI/UserInterface/DOMNodeDetailsSidebarPanel.js 2014-02-19 19:22:43 UTC (rev 164376)
</span><span class="lines">@@ -248,7 +248,15 @@
</span><span class="cx">
</span><span class="cx"> if (accessibilityProperties && accessibilityProperties.exists) {
</span><span class="cx">
</span><del>- var ignored = accessibilityProperties.ignored ? WebInspector.UIString("Yes") : "";
</del><ins>+ var ignored = "";
+ if (accessibilityProperties.ignored) {
+ ignored = WebInspector.UIString("Yes");
+ if (accessibilityProperties.hidden)
+ ignored = WebInspector.UIString("%s (hidden)").format(ignored);
+ else if (accessibilityProperties.ignoredByDefault)
+ ignored = WebInspector.UIString("%s (default)").format(ignored);
+ }
+
</ins><span class="cx"> var invalid = accessibilityProperties.invalid ? accessibilityProperties.invalid : "";
</span><span class="cx">
</span><span class="cx"> // FIXME: label will always come back as empty. Blocked by http://webkit.org/b/121134
</span></span></pre>
</div>
</div>
</body>
</html>