<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164299] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164299">164299</a></dd>
<dt>Author</dt> <dd>mmaxfield@apple.com</dd>
<dt>Date</dt> <dd>2014-02-18 11:32:54 -0800 (Tue, 18 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Convert position:sticky to position:static upon copy and paste
https://bugs.webkit.org/show_bug.cgi?id=128982
Reviewed by NOBODY (OOPS!).
Source/WebCore:
This patch has two parts:
1. Make sure that position:absolute elements trigger the position:relative wrapping (as
well as position:fixed)
2. Now that we copy position:sticky, convert that to position:fixed
Tests: editing/pasteboard/copy-paste-converts-fixed.html
editing/pasteboard/copy-paste-converts-sticky.html
editing/pasteboard/copy-paste-wraps-position-absolute.html
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::convertFixedAndStickyPosition):
LayoutTests:
* editing/pasteboard/copy-paste-converts-fixed-expected.txt: Copied from LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt.
* editing/pasteboard/copy-paste-converts-fixed.html: Copied from LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html.
* editing/pasteboard/copy-paste-converts-sticky-expected.txt: Copied from LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt.
* editing/pasteboard/copy-paste-converts-sticky.html: Copied from LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html.
* editing/pasteboard/copy-paste-wraps-position-absolute-expected.txt: Renamed from LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt.
* editing/pasteboard/copy-paste-wraps-position-absolute.html: Renamed from LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreeditingEditingStylecpp">trunk/Source/WebCore/editing/EditingStyle.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestseditingpasteboardcopypasteconvertsfixedexpectedtxt">trunk/LayoutTests/editing/pasteboard/copy-paste-converts-fixed-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingpasteboardcopypasteconvertsfixedhtml">trunk/LayoutTests/editing/pasteboard/copy-paste-converts-fixed.html</a></li>
<li><a href="#trunkLayoutTestseditingpasteboardcopypasteconvertsstickyexpectedtxt">trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingpasteboardcopypasteconvertsstickyhtml">trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky.html</a></li>
<li><a href="#trunkLayoutTestseditingpasteboardcopypastewrapspositionabsoluteexpectedtxt">trunk/LayoutTests/editing/pasteboard/copy-paste-wraps-position-absolute-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingpasteboardcopypastewrapspositionabsolutehtml">trunk/LayoutTests/editing/pasteboard/copy-paste-wraps-position-absolute.html</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestseditingpasteboardcopypasteconvertsstickyandfixedexpectedtxt">trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingpasteboardcopypasteconvertsstickyandfixedhtml">trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164298 => 164299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-18 19:10:38 UTC (rev 164298)
+++ trunk/LayoutTests/ChangeLog 2014-02-18 19:32:54 UTC (rev 164299)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-02-18 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Convert position:sticky to position:static upon copy and paste
+ https://bugs.webkit.org/show_bug.cgi?id=128982
+
+ Reviewed by Simon Fraser.
+
+ * editing/pasteboard/copy-paste-converts-fixed-expected.txt: Copied from LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt.
+ * editing/pasteboard/copy-paste-converts-fixed.html: Copied from LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html.
+ * editing/pasteboard/copy-paste-converts-sticky-expected.txt: Copied from LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt.
+ * editing/pasteboard/copy-paste-converts-sticky.html: Copied from LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html.
+ * editing/pasteboard/copy-paste-wraps-position-absolute-expected.txt: Renamed from LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt.
+ * editing/pasteboard/copy-paste-wraps-position-absolute.html: Renamed from LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html.
+
</ins><span class="cx"> 2014-02-18 Mihai Tica <mitica@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSS Blending] Add -webkit-blend-mode support for SVG.
</span></span></pre></div>
<a id="trunkLayoutTestseditingpasteboardcopypasteconvertsfixedexpectedtxtfromrev164298trunkLayoutTestseditingpasteboardcopypasteconvertsstickyandfixedexpectedtxt"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/editing/pasteboard/copy-paste-converts-fixed-expected.txt (from rev 164298, trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt) (0 => 164299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/pasteboard/copy-paste-converts-fixed-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-converts-fixed-expected.txt 2014-02-18 19:32:54 UTC (rev 164299)
</span><span class="lines">@@ -0,0 +1,98 @@
</span><ins>+This tests to see if position:fixed gets converted to position:absolute upon copy/paste
+
+first test - before:
+| <html>
+| <head>
+| "
+"
+| <meta>
+| content="text/html; charset=utf-8"
+| http-equiv="Content-type"
+| "
+"
+| <script>
+| src="../../resources/dump-as-markup.js"
+| type="text/javascript"
+| "
+"
+| "
+"
+| <body>
+| "
+abc"
+| <div>
+| style="position: fixed; left: 0px; top: 0px;"
+| "def"
+| "ghi
+"
+| <br>
+| "
+
+"
+| <script>
+| "
+
+Markup.description('This tests to see if position:fixed gets converted to position:absolute upon copy/paste');
+
+document.designMode = 'on';
+
+if (window.internals)
+ window.internals.settings.setShouldConvertPositionStyleOnCopy(true);
+
+var s = window.getSelection();
+
+Markup.dump('test1', 'first test - before');
+document.execCommand("SelectAll");
+document.execCommand("Cut");
+document.execCommand("Paste");
+Markup.dump('test1', 'first test - after');
+
+"
+
+first test - after:
+| <html>
+| <head>
+| "
+"
+| <meta>
+| content="text/html; charset=utf-8"
+| http-equiv="Content-type"
+| "
+"
+| <script>
+| src="../../resources/dump-as-markup.js"
+| type="text/javascript"
+| "
+"
+| "
+"
+| <body>
+| <div>
+| style="position: relative;"
+| "abc"
+| <div>
+| style="position: absolute; left: 0px; top: 0px;"
+| "def"
+| "ghi <#selection-caret>"
+| "
+
+"
+| <script>
+| "
+
+Markup.description('This tests to see if position:fixed gets converted to position:absolute upon copy/paste');
+
+document.designMode = 'on';
+
+if (window.internals)
+ window.internals.settings.setShouldConvertPositionStyleOnCopy(true);
+
+var s = window.getSelection();
+
+Markup.dump('test1', 'first test - before');
+document.execCommand("SelectAll");
+document.execCommand("Cut");
+document.execCommand("Paste");
+Markup.dump('test1', 'first test - after');
+
+"
</ins></span></pre></div>
<a id="trunkLayoutTestseditingpasteboardcopypasteconvertsfixedhtmlfromrev164298trunkLayoutTestseditingpasteboardcopypasteconvertsstickyandfixedhtml"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/editing/pasteboard/copy-paste-converts-fixed.html (from rev 164298, trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html) (0 => 164299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/pasteboard/copy-paste-converts-fixed.html (rev 0)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-converts-fixed.html 2014-02-18 19:32:54 UTC (rev 164299)
</span><span class="lines">@@ -0,0 +1,29 @@
</span><ins>+<html>
+<head>
+<meta http-equiv="Content-type" content="text/html; charset=utf-8" />
+<script type="text/javascript" src="../../resources/dump-as-markup.js"></script>
+</head>
+<body>
+abc<div style="position: fixed; left: 0px; top: 0px;">def</div>ghi
+<br/>
+
+<script>
+
+Markup.description('This tests to see if position:fixed gets converted to position:absolute upon copy/paste');
+
+document.designMode = 'on';
+
+if (window.internals)
+ window.internals.settings.setShouldConvertPositionStyleOnCopy(true);
+
+var s = window.getSelection();
+
+Markup.dump('test1', 'first test - before');
+document.execCommand("SelectAll");
+document.execCommand("Cut");
+document.execCommand("Paste");
+Markup.dump('test1', 'first test - after');
+
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestseditingpasteboardcopypasteconvertsstickyandfixedexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt (164298 => 164299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt 2014-02-18 19:10:38 UTC (rev 164298)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt 2014-02-18 19:32:54 UTC (rev 164299)
</span><span class="lines">@@ -1,98 +0,0 @@
</span><del>-These tests to see if position:sticky and position:fixed get converted to position:static and position:absolute upon copy/paste
-
-first test - before:
-| <html>
-| <head>
-| "
-"
-| <meta>
-| content="text/html; charset=utf-8"
-| http-equiv="Content-type"
-| "
-"
-| <script>
-| src="../../resources/dump-as-markup.js"
-| type="text/javascript"
-| "
-"
-| "
-"
-| <body>
-| "
-abc"
-| <div>
-| style="position: fixed; left: 0px; top: 0px;"
-| "def"
-| "ghi
-"
-| <br>
-| "
-
-"
-| <script>
-| "
-
-Markup.description('These tests to see if position:sticky and position:fixed get converted to position:static and position:absolute upon copy/paste');
-
-document.designMode = 'on';
-
-if (window.internals)
- window.internals.settings.setShouldConvertPositionStyleOnCopy(true);
-
-var s = window.getSelection();
-
-Markup.dump('test1', 'first test - before');
-document.execCommand("SelectAll");
-document.execCommand("Cut");
-document.execCommand("Paste");
-Markup.dump('test1', 'first test - after');
-
-"
-
-first test - after:
-| <html>
-| <head>
-| "
-"
-| <meta>
-| content="text/html; charset=utf-8"
-| http-equiv="Content-type"
-| "
-"
-| <script>
-| src="../../resources/dump-as-markup.js"
-| type="text/javascript"
-| "
-"
-| "
-"
-| <body>
-| <div>
-| style="position: relative;"
-| "abc"
-| <div>
-| style="position: absolute; left: 0px; top: 0px;"
-| "def"
-| "ghi <#selection-caret>"
-| "
-
-"
-| <script>
-| "
-
-Markup.description('These tests to see if position:sticky and position:fixed get converted to position:static and position:absolute upon copy/paste');
-
-document.designMode = 'on';
-
-if (window.internals)
- window.internals.settings.setShouldConvertPositionStyleOnCopy(true);
-
-var s = window.getSelection();
-
-Markup.dump('test1', 'first test - before');
-document.execCommand("SelectAll");
-document.execCommand("Cut");
-document.execCommand("Paste");
-Markup.dump('test1', 'first test - after');
-
-"
</del></span></pre></div>
<a id="trunkLayoutTestseditingpasteboardcopypasteconvertsstickyandfixedhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html (164298 => 164299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html 2014-02-18 19:10:38 UTC (rev 164298)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html 2014-02-18 19:32:54 UTC (rev 164299)
</span><span class="lines">@@ -1,29 +0,0 @@
</span><del>-<html>
-<head>
-<meta http-equiv="Content-type" content="text/html; charset=utf-8" />
-<script type="text/javascript" src="../../resources/dump-as-markup.js"></script>
-</head>
-<body>
-abc<div style="position: fixed; left: 0px; top: 0px;">def</div>ghi
-<br/>
-
-<script>
-
-Markup.description('These tests to see if position:sticky and position:fixed get converted to position:static and position:absolute upon copy/paste');
-
-document.designMode = 'on';
-
-if (window.internals)
- window.internals.settings.setShouldConvertPositionStyleOnCopy(true);
-
-var s = window.getSelection();
-
-Markup.dump('test1', 'first test - before');
-document.execCommand("SelectAll");
-document.execCommand("Cut");
-document.execCommand("Paste");
-Markup.dump('test1', 'first test - after');
-
-</script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestseditingpasteboardcopypasteconvertsstickyexpectedtxtfromrev164298trunkLayoutTestseditingpasteboardcopypasteconvertsstickyandfixedexpectedtxt"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-expected.txt (from rev 164298, trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt) (0 => 164299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-expected.txt 2014-02-18 19:32:54 UTC (rev 164299)
</span><span class="lines">@@ -0,0 +1,95 @@
</span><ins>+This tests to see if position:sticky gets converted to position:static upon copy/paste
+
+first test - before:
+| <html>
+| <head>
+| "
+"
+| <meta>
+| content="text/html; charset=utf-8"
+| http-equiv="Content-type"
+| "
+"
+| <script>
+| src="../../resources/dump-as-markup.js"
+| type="text/javascript"
+| "
+"
+| "
+"
+| <body>
+| "
+abc"
+| <div>
+| style="position: -webkit-sticky; left: 0px; top: 0px;"
+| "def"
+| "ghi
+"
+| <br>
+| "
+
+"
+| <script>
+| "
+
+Markup.description('This tests to see if position:sticky gets converted to position:static upon copy/paste');
+
+document.designMode = 'on';
+
+if (window.internals)
+ window.internals.settings.setShouldConvertPositionStyleOnCopy(true);
+
+var s = window.getSelection();
+
+Markup.dump('test1', 'first test - before');
+document.execCommand("SelectAll");
+document.execCommand("Cut");
+document.execCommand("Paste");
+Markup.dump('test1', 'first test - after');
+
+"
+
+first test - after:
+| <html>
+| <head>
+| "
+"
+| <meta>
+| content="text/html; charset=utf-8"
+| http-equiv="Content-type"
+| "
+"
+| <script>
+| src="../../resources/dump-as-markup.js"
+| type="text/javascript"
+| "
+"
+| "
+"
+| <body>
+| "abc"
+| <div>
+| style="position: static; left: 0px; top: 0px;"
+| "def"
+| "ghi <#selection-caret>
+
+"
+| <script>
+| "
+
+Markup.description('This tests to see if position:sticky gets converted to position:static upon copy/paste');
+
+document.designMode = 'on';
+
+if (window.internals)
+ window.internals.settings.setShouldConvertPositionStyleOnCopy(true);
+
+var s = window.getSelection();
+
+Markup.dump('test1', 'first test - before');
+document.execCommand("SelectAll");
+document.execCommand("Cut");
+document.execCommand("Paste");
+Markup.dump('test1', 'first test - after');
+
+"
</ins></span></pre></div>
<a id="trunkLayoutTestseditingpasteboardcopypasteconvertsstickyhtmlfromrev164298trunkLayoutTestseditingpasteboardcopypasteconvertsstickyandfixedhtml"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky.html (from rev 164298, trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html) (0 => 164299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky.html (rev 0)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky.html 2014-02-18 19:32:54 UTC (rev 164299)
</span><span class="lines">@@ -0,0 +1,29 @@
</span><ins>+<html>
+<head>
+<meta http-equiv="Content-type" content="text/html; charset=utf-8" />
+<script type="text/javascript" src="../../resources/dump-as-markup.js"></script>
+</head>
+<body>
+abc<div style="position: -webkit-sticky; left: 0px; top: 0px;">def</div>ghi
+<br/>
+
+<script>
+
+Markup.description('This tests to see if position:sticky gets converted to position:static upon copy/paste');
+
+document.designMode = 'on';
+
+if (window.internals)
+ window.internals.settings.setShouldConvertPositionStyleOnCopy(true);
+
+var s = window.getSelection();
+
+Markup.dump('test1', 'first test - before');
+document.execCommand("SelectAll");
+document.execCommand("Cut");
+document.execCommand("Paste");
+Markup.dump('test1', 'first test - after');
+
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestseditingpasteboardcopypastewrapspositionabsoluteexpectedtxtfromrev164298trunkLayoutTestseditingpasteboardcopypasteconvertsstickyandfixedexpectedtxt"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/editing/pasteboard/copy-paste-wraps-position-absolute-expected.txt (from rev 164298, trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt) (0 => 164299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/pasteboard/copy-paste-wraps-position-absolute-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-wraps-position-absolute-expected.txt 2014-02-18 19:32:54 UTC (rev 164299)
</span><span class="lines">@@ -0,0 +1,98 @@
</span><ins>+This tests to see if position:absolute gets wrapped with a position:relative upon copy/paste
+
+first test - before:
+| <html>
+| <head>
+| "
+"
+| <meta>
+| content="text/html; charset=utf-8"
+| http-equiv="Content-type"
+| "
+"
+| <script>
+| src="../../resources/dump-as-markup.js"
+| type="text/javascript"
+| "
+"
+| "
+"
+| <body>
+| "
+abc"
+| <div>
+| style="position: absolute; left: 0px; top: 0px;"
+| "def"
+| "ghi
+"
+| <br>
+| "
+
+"
+| <script>
+| "
+
+Markup.description('This tests to see if position:absolute gets wrapped with a position:relative upon copy/paste');
+
+document.designMode = 'on';
+
+if (window.internals)
+ window.internals.settings.setShouldConvertPositionStyleOnCopy(true);
+
+var s = window.getSelection();
+
+Markup.dump('test1', 'first test - before');
+document.execCommand("SelectAll");
+document.execCommand("Cut");
+document.execCommand("Paste");
+Markup.dump('test1', 'first test - after');
+
+"
+
+first test - after:
+| <html>
+| <head>
+| "
+"
+| <meta>
+| content="text/html; charset=utf-8"
+| http-equiv="Content-type"
+| "
+"
+| <script>
+| src="../../resources/dump-as-markup.js"
+| type="text/javascript"
+| "
+"
+| "
+"
+| <body>
+| <div>
+| style="position: relative;"
+| "abc"
+| <div>
+| style="position: absolute; left: 0px; top: 0px;"
+| "def"
+| "ghi <#selection-caret>"
+| "
+
+"
+| <script>
+| "
+
+Markup.description('This tests to see if position:absolute gets wrapped with a position:relative upon copy/paste');
+
+document.designMode = 'on';
+
+if (window.internals)
+ window.internals.settings.setShouldConvertPositionStyleOnCopy(true);
+
+var s = window.getSelection();
+
+Markup.dump('test1', 'first test - before');
+document.execCommand("SelectAll");
+document.execCommand("Cut");
+document.execCommand("Paste");
+Markup.dump('test1', 'first test - after');
+
+"
</ins></span></pre></div>
<a id="trunkLayoutTestseditingpasteboardcopypastewrapspositionabsolutehtmlfromrev164298trunkLayoutTestseditingpasteboardcopypasteconvertsstickyandfixedhtml"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/editing/pasteboard/copy-paste-wraps-position-absolute.html (from rev 164298, trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html) (0 => 164299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/pasteboard/copy-paste-wraps-position-absolute.html (rev 0)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-wraps-position-absolute.html 2014-02-18 19:32:54 UTC (rev 164299)
</span><span class="lines">@@ -0,0 +1,29 @@
</span><ins>+<html>
+<head>
+<meta http-equiv="Content-type" content="text/html; charset=utf-8" />
+<script type="text/javascript" src="../../resources/dump-as-markup.js"></script>
+</head>
+<body>
+abc<div style="position: absolute; left: 0px; top: 0px;">def</div>ghi
+<br/>
+
+<script>
+
+Markup.description('This tests to see if position:absolute gets wrapped with a position:relative upon copy/paste');
+
+document.designMode = 'on';
+
+if (window.internals)
+ window.internals.settings.setShouldConvertPositionStyleOnCopy(true);
+
+var s = window.getSelection();
+
+Markup.dump('test1', 'first test - before');
+document.execCommand("SelectAll");
+document.execCommand("Cut");
+document.execCommand("Paste");
+Markup.dump('test1', 'first test - after');
+
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164298 => 164299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-18 19:10:38 UTC (rev 164298)
+++ trunk/Source/WebCore/ChangeLog 2014-02-18 19:32:54 UTC (rev 164299)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2014-02-18 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Convert position:sticky to position:static upon copy and paste
+ https://bugs.webkit.org/show_bug.cgi?id=128982
+
+ Reviewed by Simon Fraser.
+
+ This patch has two parts:
+
+ 1. Make sure that position:absolute elements trigger the position:relative wrapping (as
+ well as position:fixed)
+ 2. Now that we copy position:sticky, convert that to position:fixed
+
+ Tests: editing/pasteboard/copy-paste-converts-fixed.html
+ editing/pasteboard/copy-paste-converts-sticky.html
+ editing/pasteboard/copy-paste-wraps-position-absolute.html
+
+ * editing/EditingStyle.cpp:
+ (WebCore::EditingStyle::convertFixedAndStickyPosition):
+
</ins><span class="cx"> 2014-02-18 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> Add type-checked casts for StyleImage and subclasses
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingEditingStylecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/EditingStyle.cpp (164298 => 164299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/EditingStyle.cpp 2014-02-18 19:10:38 UTC (rev 164298)
+++ trunk/Source/WebCore/editing/EditingStyle.cpp 2014-02-18 19:32:54 UTC (rev 164299)
</span><span class="lines">@@ -1227,11 +1227,18 @@
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> RefPtr<CSSPrimitiveValue> sticky = cssValuePool().createIdentifierValue(CSSValueWebkitSticky);
</span><ins>+ if (m_mutableStyle->propertyMatches(CSSPropertyPosition, sticky.get())) {
+ m_mutableStyle->setProperty(CSSPropertyPosition, cssValuePool().createIdentifierValue(CSSValueStatic), m_mutableStyle->propertyIsImportant(CSSPropertyPosition));
+ return false;
+ }
</ins><span class="cx"> RefPtr<CSSPrimitiveValue> fixed = cssValuePool().createIdentifierValue(CSSValueFixed);
</span><span class="cx"> if (m_mutableStyle->propertyMatches(CSSPropertyPosition, fixed.get())) {
</span><span class="cx"> m_mutableStyle->setProperty(CSSPropertyPosition, cssValuePool().createIdentifierValue(CSSValueAbsolute), m_mutableStyle->propertyIsImportant(CSSPropertyPosition));
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><ins>+ RefPtr<CSSPrimitiveValue> absolute = cssValuePool().createIdentifierValue(CSSValueAbsolute);
+ if (m_mutableStyle->propertyMatches(CSSPropertyPosition, absolute.get()))
+ return true;
</ins><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>