<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164234] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164234">164234</a></dd>
<dt>Author</dt> <dd>stavila@adobe.com</dd>
<dt>Date</dt> <dd>2014-02-17 11:22:14 -0800 (Mon, 17 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Regions] Make regions unsplittable
https://bugs.webkit.org/show_bug.cgi?id=128811
Reviewed by David Hyatt.
Source/WebCore:
At the moment, nested regions are not properly fragmented across regions. For the moment,
the regions will become unsplittable elements to avoid slicing. At a later time a proper
fragmentation algorithm should be written, also taking into consideration pagination strut.
Test: fast/regions/unsplittable-nested-region.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::isUnsplittableForPagination):
LayoutTests:
Added test for checking that nested regions are unsplittable.
* fast/regions/unsplittable-nested-region-expected.html: Added.
* fast/regions/unsplittable-nested-region.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastregionsunsplittablenestedregionexpectedhtml">trunk/LayoutTests/fast/regions/unsplittable-nested-region-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastregionsunsplittablenestedregionhtml">trunk/LayoutTests/fast/regions/unsplittable-nested-region.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164233 => 164234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-17 19:15:26 UTC (rev 164233)
+++ trunk/LayoutTests/ChangeLog 2014-02-17 19:22:14 UTC (rev 164234)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-02-17 Radu Stavila <stavila@adobe.com>
+
+ [CSS Regions] Make regions unsplittable
+ https://bugs.webkit.org/show_bug.cgi?id=128811
+
+ Reviewed by David Hyatt.
+
+ Added test for checking that nested regions are unsplittable.
+
+ * fast/regions/unsplittable-nested-region-expected.html: Added.
+ * fast/regions/unsplittable-nested-region.html: Added.
+
</ins><span class="cx"> 2014-02-17 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Graphics buffer issue with clip-path and fixed positioned element
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsunsplittablenestedregionexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/unsplittable-nested-region-expected.html (0 => 164234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/unsplittable-nested-region-expected.html (rev 0)
+++ trunk/LayoutTests/fast/regions/unsplittable-nested-region-expected.html 2014-02-17 19:22:14 UTC (rev 164234)
</span><span class="lines">@@ -0,0 +1,55 @@
</span><ins>+<!doctype html>
+<html>
+ <head>
+ <style>
+ #outerContent {
+ -webkit-flow-into: outerFlow;
+ color: blue;
+ }
+ .outerRegion {
+ -webkit-flow-from: outerFlow;
+ width: 300px;
+ height: 180px;
+ border: solid 2px Gray;
+ margin: 5px;
+ border: 2px solid blue;
+ padding: 30px;
+ }
+ #innerContent {
+ -webkit-flow-into: innerFlow;
+ color: red;
+ }
+
+ #innerRegion {
+ -webkit-flow-from: innerFlow;
+ border: solid 2px red;
+ overflow: hidden;
+ color: blue;
+ }
+ #outerRegion1
+ {
+ float: left;
+ }
+ #outerRegion2
+ {
+ float: right;
+ }
+ </style>
+ </head>
+ <body>
+ <a href="https://bugs.webkit.org/show_bug.cgi?id=128811">Bug 128811</a><br/>
+ <p>The <span style="color:red">nested region</span> should <b>not</b> be split between the <span style="color:blue">2 outer regions</span> and should overflow the first region</p>
+
+ <div class="outerRegion" id="outerRegion1">
+ <div id="outerContent">
+ <div id="innerRegion">
+ <div id="innerContent">
+ Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.
+ </div>
+ </div>
+ </div>
+ </div>
+
+ <div class="outerRegion" id="outerRegion2"></div>
+ </body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsunsplittablenestedregionhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/unsplittable-nested-region.html (0 => 164234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/unsplittable-nested-region.html (rev 0)
+++ trunk/LayoutTests/fast/regions/unsplittable-nested-region.html 2014-02-17 19:22:14 UTC (rev 164234)
</span><span class="lines">@@ -0,0 +1,54 @@
</span><ins>+<!doctype html>
+<html>
+ <head>
+ <style>
+ #outerContent {
+ -webkit-flow-into: outerFlow;
+ color: blue;
+ }
+ .outerRegion {
+ -webkit-flow-from: outerFlow;
+ width: 300px;
+ height: 180px;
+ border: solid 2px Gray;
+ margin: 5px;
+ border: 2px solid blue;
+ padding: 30px;
+ }
+ #innerContent {
+ -webkit-flow-into: innerFlow;
+ color: red;
+ }
+
+ #innerRegion {
+ -webkit-flow-from: innerFlow;
+ border: solid 2px red;
+ overflow: hidden;
+ color: blue;
+ }
+ #outerRegion1
+ {
+ float: left;
+ }
+ #outerRegion2
+ {
+ float: right;
+ }
+ </style>
+ </head>
+ <body>
+ <a href="https://bugs.webkit.org/show_bug.cgi?id=128811">Bug 128811</a><br/>
+ <p>The <span style="color:red">nested region</span> should <b>not</b> be split between the <span style="color:blue">2 outer regions</span> and should overflow the first region</p>
+
+ <div id="outerContent">
+ <div id="innerRegion"></div>
+ </div>
+
+ <div id="innerContent">
+ Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.
+ </div>
+
+ <div class="outerRegion" id="outerRegion1"></div>
+ <div class="outerRegion" id="outerRegion2"></div>
+ </body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164233 => 164234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-17 19:15:26 UTC (rev 164233)
+++ trunk/Source/WebCore/ChangeLog 2014-02-17 19:22:14 UTC (rev 164234)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-02-17 Radu Stavila <stavila@adobe.com>
+
+ [CSS Regions] Make regions unsplittable
+ https://bugs.webkit.org/show_bug.cgi?id=128811
+
+ Reviewed by David Hyatt.
+
+ At the moment, nested regions are not properly fragmented across regions. For the moment,
+ the regions will become unsplittable elements to avoid slicing. At a later time a proper
+ fragmentation algorithm should be written, also taking into consideration pagination strut.
+
+ Test: fast/regions/unsplittable-nested-region.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::isUnsplittableForPagination):
+
</ins><span class="cx"> 2014-02-17 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Graphics buffer issue with clip-path and fixed positioned element
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (164233 => 164234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp 2014-02-17 19:15:26 UTC (rev 164233)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2014-02-17 19:22:14 UTC (rev 164234)
</span><span class="lines">@@ -4412,7 +4412,7 @@
</span><span class="cx">
</span><span class="cx"> bool RenderBox::isUnsplittableForPagination() const
</span><span class="cx"> {
</span><del>- return isReplaced() || hasUnsplittableScrollingOverflow() || (parent() && isWritingModeRoot());
</del><ins>+ return isReplaced() || hasUnsplittableScrollingOverflow() || (parent() && isWritingModeRoot()) || isRenderNamedFlowFragmentContainer();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> LayoutUnit RenderBox::lineHeight(bool /*firstLine*/, LineDirectionMode direction, LinePositionMode /*linePositionMode*/) const
</span></span></pre>
</div>
</div>
</body>
</html>