<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164203] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164203">164203</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2014-02-16 19:19:49 -0800 (Sun, 16 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>When applying style, attribute value matching should be case sensitive for SVG
https://bugs.webkit.org/show_bug.cgi?id=128882
Reviewed by Andreas Kling.
Source/WebCore:
SelectorChecker was incorrectly matching attribute values with a case insensitve comparison
in some cases.
The choice to use case sensitive matching was taking into account the document type but not
the element type. As a result, SVG (and likely MHTML) elements were incorrectly being tested
as if they were HTML element.
With the patch, WebKit also matches the behavior of Firefox, which is great.
Tests: fast/css/case-insensitive-attribute-with-svg.html
fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
LayoutTests:
* fast/css/case-insensitive-attribute-with-svg-expected.html: Added.
* fast/css/case-insensitive-attribute-with-svg.html: Added.
* fast/selectors/querySelector-case-insensitive-attribute-match-with-svg-expected.txt: Added.
* fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssSelectorCheckercpp">trunk/Source/WebCore/css/SelectorChecker.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcsscaseinsensitiveattributewithsvgexpectedhtml">trunk/LayoutTests/fast/css/case-insensitive-attribute-with-svg-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastcsscaseinsensitiveattributewithsvghtml">trunk/LayoutTests/fast/css/case-insensitive-attribute-with-svg.html</a></li>
<li><a href="#trunkLayoutTestsfastselectorsquerySelectorcaseinsensitiveattributematchwithsvgexpectedtxt">trunk/LayoutTests/fast/selectors/querySelector-case-insensitive-attribute-match-with-svg-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastselectorsquerySelectorcaseinsensitiveattributematchwithsvghtml">trunk/LayoutTests/fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164202 => 164203)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-17 03:14:48 UTC (rev 164202)
+++ trunk/LayoutTests/ChangeLog 2014-02-17 03:19:49 UTC (rev 164203)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-02-16 Benjamin Poulain <benjamin@webkit.org>
+
+ When applying style, attribute value matching should be case sensitive for SVG
+ https://bugs.webkit.org/show_bug.cgi?id=128882
+
+ Reviewed by Andreas Kling.
+
+ * fast/css/case-insensitive-attribute-with-svg-expected.html: Added.
+ * fast/css/case-insensitive-attribute-with-svg.html: Added.
+ * fast/selectors/querySelector-case-insensitive-attribute-match-with-svg-expected.txt: Added.
+ * fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html: Added.
+
</ins><span class="cx"> 2014-02-15 Piotr Grad <p.grad@samsung.com>
</span><span class="cx">
</span><span class="cx"> Setting currentTime on HTMLMediaElement with media controller should throw exception.
</span></span></pre></div>
<a id="trunkLayoutTestsfastcsscaseinsensitiveattributewithsvgexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/case-insensitive-attribute-with-svg-expected.html (0 => 164203)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/case-insensitive-attribute-with-svg-expected.html (rev 0)
+++ trunk/LayoutTests/fast/css/case-insensitive-attribute-with-svg-expected.html 2014-02-17 03:19:49 UTC (rev 164203)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>Case Insensitive and Case Sensitive Attribute matching</title>
+</head>
+<body>
+ <p>On success, there should be a large green surface visible and no red anywhere.</p>
+
+ <svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewBox="0 0 100 100" style="margin-top:50px">
+ <rect x="50" y="0" width="50" height="50" style="fill:green" />
+ <rect x="0" y="0" width="50" height="50" style="fill:green" />
+ </svg>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcsscaseinsensitiveattributewithsvghtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/case-insensitive-attribute-with-svg.html (0 => 164203)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/case-insensitive-attribute-with-svg.html (rev 0)
+++ trunk/LayoutTests/fast/css/case-insensitive-attribute-with-svg.html 2014-02-17 03:19:49 UTC (rev 164203)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>Case Insensitive and Case Sensitive Attribute matching</title>
+<style>
+[link=foobar], [lang=foobar] {
+ display: none;
+}
+</style>
+</head>
+<body>
+ <p>On success, there should be a large green surface visible and no red anywhere.</p>
+ <!-- None of these rects should appear, lang and link attribute matching is case insensitive for HTML documents. -->
+ <div style="background-color: red; position: absolute; left:0; width:50px; height:50px" lang="FooBar"></div>
+ <div style="background-color: red; position: absolute; left:50px; width:50px; height:50px" link="FooBar"></div>
+ <div style="background-color: red; position: absolute; left:100px; width:50px; height:50px" lang="foobar"></div>
+ <div style="background-color: red; position: absolute; left:150px; width:50px; height:50px" link="foobar"></div>
+
+ <svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewBox="0 0 100 100" style="margin-top:50px">
+ <!-- The first green rects should be visible, attribute matching is always case sensitive for XML or SVG documents. -->
+ <rect x="50" y="0" width="50" height="50" lang="FooBar" style="fill:green" />
+ <rect x="0" y="0" width="50" height="50" link="FooBar" style="fill:green" />
+ <!-- These are regular match and should not appear. -->
+ <rect x="0" y="50" width="50" height="50" lang="foobar" style="fill:red" />
+ <rect x="50" y="50" width="50" height="50" link="foobar" style="fill:red" />
+ </svg>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastselectorsquerySelectorcaseinsensitiveattributematchwithsvgexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/selectors/querySelector-case-insensitive-attribute-match-with-svg-expected.txt (0 => 164203)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/selectors/querySelector-case-insensitive-attribute-match-with-svg-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/selectors/querySelector-case-insensitive-attribute-match-with-svg-expected.txt 2014-02-17 03:19:49 UTC (rev 164203)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+Some attribute needs case insensitive value matching with HTML. This test we do not incorrectly match SVG.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS document.querySelectorAll("[lang=foobar]").length is 3
+PASS document.querySelectorAll("[lang=foobar]")[0].id is "div1"
+PASS document.querySelectorAll("[lang=foobar]")[1].id is "div3"
+PASS document.querySelectorAll("[lang=foobar]")[2].id is "rect3"
+PASS document.querySelectorAll("[link=foobar]").length is 3
+PASS document.querySelectorAll("[link=foobar]")[0].id is "div2"
+PASS document.querySelectorAll("[link=foobar]")[1].id is "div4"
+PASS document.querySelectorAll("[link=foobar]")[2].id is "rect4"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastselectorsquerySelectorcaseinsensitiveattributematchwithsvghtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html (0 => 164203)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html (rev 0)
+++ trunk/LayoutTests/fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html 2014-02-17 03:19:49 UTC (rev 164203)
</span><span class="lines">@@ -0,0 +1,35 @@
</span><ins>+<!doctype html>
+<html>
+<head>
+<script src="../../resources/js-test-pre.js"></script>
+</head>
+<body>
+<div style="display:none">
+ <div id=div1 style="background-color: red; position: absolute; left:0; width:50px; height:50px" lang="FooBar"></div>
+ <div id=div2 style="background-color: red; position: absolute; left:50px; width:50px; height:50px" link="FooBar"></div>
+ <div id=div3 style="background-color: red; position: absolute; left:100px; width:50px; height:50px" lang="foobar"></div>
+ <div id=div4 style="background-color: red; position: absolute; left:150px; width:50px; height:50px" link="foobar"></div>
+
+ <svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewBox="0 0 100 100" style="margin-top:50px">
+ <rect id=rect1 x="50" y="0" width="50" height="50" lang="FooBar" style="fill:green" />
+ <rect id=rect2 x="0" y="0" width="50" height="50" link="FooBar" style="fill:green" />
+ <rect id=rect3 x="0" y="50" width="50" height="50" lang="foobar" style="fill:red" />
+ <rect id=rect4 x="50" y="50" width="50" height="50" link="foobar" style="fill:red" />
+ </svg>
+</div>
+</body>
+<script>
+description('Some attribute needs case insensitive value matching with HTML. This test we do not incorrectly match SVG.');
+
+shouldBe('document.querySelectorAll("[lang=foobar]").length', '3');
+shouldBeEqualToString('document.querySelectorAll("[lang=foobar]")[0].id', 'div1');
+shouldBeEqualToString('document.querySelectorAll("[lang=foobar]")[1].id', 'div3');
+shouldBeEqualToString('document.querySelectorAll("[lang=foobar]")[2].id', 'rect3');
+
+shouldBe('document.querySelectorAll("[link=foobar]").length', '3');
+shouldBeEqualToString('document.querySelectorAll("[link=foobar]")[0].id', 'div2');
+shouldBeEqualToString('document.querySelectorAll("[link=foobar]")[1].id', 'div4');
+shouldBeEqualToString('document.querySelectorAll("[link=foobar]")[2].id', 'rect4');
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164202 => 164203)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-17 03:14:48 UTC (rev 164202)
+++ trunk/Source/WebCore/ChangeLog 2014-02-17 03:19:49 UTC (rev 164203)
</span><span class="lines">@@ -1,5 +1,27 @@
</span><span class="cx"> 2014-02-16 Benjamin Poulain <benjamin@webkit.org>
</span><span class="cx">
</span><ins>+ When applying style, attribute value matching should be case sensitive for SVG
+ https://bugs.webkit.org/show_bug.cgi?id=128882
+
+ Reviewed by Andreas Kling.
+
+ SelectorChecker was incorrectly matching attribute values with a case insensitve comparison
+ in some cases.
+
+ The choice to use case sensitive matching was taking into account the document type but not
+ the element type. As a result, SVG (and likely MHTML) elements were incorrectly being tested
+ as if they were HTML element.
+
+ With the patch, WebKit also matches the behavior of Firefox, which is great.
+
+ Tests: fast/css/case-insensitive-attribute-with-svg.html
+ fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html
+
+ * css/SelectorChecker.cpp:
+ (WebCore::SelectorChecker::checkOne):
+
+2014-02-16 Benjamin Poulain <benjamin@webkit.org>
+
</ins><span class="cx"> Split compilation state between querySelector and CSS matching
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=128869
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecssSelectorCheckercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (164202 => 164203)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/SelectorChecker.cpp 2014-02-17 03:14:48 UTC (rev 164202)
+++ trunk/Source/WebCore/css/SelectorChecker.cpp 2014-02-17 03:19:49 UTC (rev 164203)
</span><span class="lines">@@ -372,7 +372,7 @@
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> const QualifiedName& attr = selector->attribute();
</span><del>- bool caseSensitive = !m_documentIsHTML || HTMLDocument::isCaseSensitiveAttribute(attr);
</del><ins>+ bool caseSensitive = !(m_documentIsHTML && element->isHTMLElement()) || HTMLDocument::isCaseSensitiveAttribute(attr);
</ins><span class="cx">
</span><span class="cx"> if (!anyAttributeMatches(element, selector, attr, caseSensitive))
</span><span class="cx"> return false;
</span></span></pre>
</div>
</div>
</body>
</html>