<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164184] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164184">164184</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-02-15 18:01:04 -0800 (Sat, 15 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add checked casts for Event.
<https://webkit.org/b/128875>
Generate casting helpers for casting from Event to various subclasses
and go on static_cast replacement spree.
Reviewed by Sam Weinig.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSErrorHandlercpp">trunk/Source/WebCore/bindings/js/JSErrorHandler.cpp</a></li>
<li><a href="#trunkSourceWebCoredomBeforeTextInsertedEventh">trunk/Source/WebCore/dom/BeforeTextInsertedEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomBeforeUnloadEventh">trunk/Source/WebCore/dom/BeforeUnloadEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomErrorEventcpp">trunk/Source/WebCore/dom/ErrorEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoredomErrorEventh">trunk/Source/WebCore/dom/ErrorEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomEventcpp">trunk/Source/WebCore/dom/Event.cpp</a></li>
<li><a href="#trunkSourceWebCoredomEventh">trunk/Source/WebCore/dom/Event.h</a></li>
<li><a href="#trunkSourceWebCoredomFocusEventh">trunk/Source/WebCore/dom/FocusEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomKeyboardEventcpp">trunk/Source/WebCore/dom/KeyboardEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoredomKeyboardEventh">trunk/Source/WebCore/dom/KeyboardEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomMouseEventcpp">trunk/Source/WebCore/dom/MouseEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoredomMouseEventh">trunk/Source/WebCore/dom/MouseEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomNodecpp">trunk/Source/WebCore/dom/Node.cpp</a></li>
<li><a href="#trunkSourceWebCoredomTextEventcpp">trunk/Source/WebCore/dom/TextEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoredomTextEventh">trunk/Source/WebCore/dom/TextEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomTouchEventh">trunk/Source/WebCore/dom/TouchEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomUIEventh">trunk/Source/WebCore/dom/UIEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomWheelEventcpp">trunk/Source/WebCore/dom/WheelEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoredomWheelEventh">trunk/Source/WebCore/dom/WheelEvent.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAnchorElementcpp">trunk/Source/WebCore/html/HTMLAnchorElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLButtonElementcpp">trunk/Source/WebCore/html/HTMLButtonElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFrameSetElementcpp">trunk/Source/WebCore/html/HTMLFrameSetElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLInputElementcpp">trunk/Source/WebCore/html/HTMLInputElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementcpp">trunk/Source/WebCore/html/HTMLSelectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSummaryElementcpp">trunk/Source/WebCore/html/HTMLSummaryElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTextAreaElementcpp">trunk/Source/WebCore/html/HTMLTextAreaElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlImageDocumentcpp">trunk/Source/WebCore/html/ImageDocument.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlInputTypecpp">trunk/Source/WebCore/html/InputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlMediaDocumentcpp">trunk/Source/WebCore/html/MediaDocument.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlTextFieldInputTypecpp">trunk/Source/WebCore/html/TextFieldInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowMediaControlElementTypescpp">trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowMediaControlElementscpp">trunk/Source/WebCore/html/shadow/MediaControlElements.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowMediaControlscpp">trunk/Source/WebCore/html/shadow/MediaControls.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowMediaControlsApplecpp">trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowSliderThumbElementcpp">trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowSpinButtonElementcpp">trunk/Source/WebCore/html/shadow/SpinButtonElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowTextControlInnerElementscpp">trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp</a></li>
<li><a href="#trunkSourceWebCorepageContextMenuControllercpp">trunk/Source/WebCore/page/ContextMenuController.cpp</a></li>
<li><a href="#trunkSourceWebCorepageEventHandlercpp">trunk/Source/WebCore/page/EventHandler.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderEmbeddedObjectcpp">trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderSnapshottedPlugIncpp">trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/ChangeLog 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-02-15 Andreas Kling <akling@apple.com>
+
+ Add checked casts for Event.
+ <https://webkit.org/b/128875>
+
+ Generate casting helpers for casting from Event to various subclasses
+ and go on static_cast replacement spree.
+
+ Reviewed by Sam Weinig.
+
</ins><span class="cx"> 2014-02-15 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> HTMLTextFormControlElement::subtreeHasChanged should be called before updating selection
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSErrorHandlercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSErrorHandler.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSErrorHandler.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/bindings/js/JSErrorHandler.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -66,7 +66,7 @@
</span><span class="cx"> if (!scriptExecutionContext)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- ErrorEvent* errorEvent = static_cast<ErrorEvent*>(event);
</del><ins>+ ErrorEvent* errorEvent = toErrorEvent(event);
</ins><span class="cx">
</span><span class="cx"> JSLockHolder lock(scriptExecutionContext->vm());
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomBeforeTextInsertedEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/BeforeTextInsertedEvent.h (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/BeforeTextInsertedEvent.h 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/BeforeTextInsertedEvent.h 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -51,6 +51,8 @@
</span><span class="cx"> String m_text;
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+EVENT_TYPE_CASTS(BeforeTextInsertedEvent)
+
</ins><span class="cx"> } // namespace
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoredomBeforeUnloadEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/BeforeUnloadEvent.h (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/BeforeUnloadEvent.h 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/BeforeUnloadEvent.h 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -51,11 +51,7 @@
</span><span class="cx"> String m_returnValue;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-inline BeforeUnloadEvent* toBeforeUnloadEvent(Event* event)
-{
- ASSERT_WITH_SECURITY_IMPLICATION(!event || event->isBeforeUnloadEvent());
- return static_cast<BeforeUnloadEvent*>(event);
-}
</del><ins>+EVENT_TYPE_CASTS(BeforeUnloadEvent)
</ins><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomErrorEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ErrorEvent.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ErrorEvent.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/ErrorEvent.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -74,4 +74,9 @@
</span><span class="cx"> return ErrorEventInterfaceType;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+bool ErrorEvent::isErrorEvent() const
+{
+ return true;
+}
+
</ins><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoredomErrorEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ErrorEvent.h (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ErrorEvent.h 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/ErrorEvent.h 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -73,12 +73,16 @@
</span><span class="cx"> ErrorEvent(const String& message, const String& fileName, unsigned lineNumber, unsigned columnNumber);
</span><span class="cx"> ErrorEvent(const AtomicString&, const ErrorEventInit&);
</span><span class="cx">
</span><ins>+ virtual bool isErrorEvent() const override;
+
</ins><span class="cx"> String m_message;
</span><span class="cx"> String m_fileName;
</span><span class="cx"> unsigned m_lineNumber;
</span><span class="cx"> unsigned m_columnNumber;
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+EVENT_TYPE_CASTS(ErrorEvent)
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // ErrorEvent_h
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Event.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Event.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/Event.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -168,6 +168,21 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+bool Event::isErrorEvent() const
+{
+ return false;
+}
+
+bool Event::isTextEvent() const
+{
+ return false;
+}
+
+bool Event::isWheelEvent() const
+{
+ return false;
+}
+
</ins><span class="cx"> PassRefPtr<Event> Event::cloneFor(HTMLIFrameElement*) const
</span><span class="cx"> {
</span><span class="cx"> return Event::create(type(), bubbles(), cancelable());
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Event.h (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Event.h 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/Event.h 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -145,6 +145,10 @@
</span><span class="cx">
</span><span class="cx"> virtual bool isBeforeUnloadEvent() const;
</span><span class="cx">
</span><ins>+ virtual bool isErrorEvent() const;
+ virtual bool isTextEvent() const;
+ virtual bool isWheelEvent() const;
+
</ins><span class="cx"> bool propagationStopped() const { return m_propagationStopped || m_immediatePropagationStopped; }
</span><span class="cx"> bool immediatePropagationStopped() const { return m_immediatePropagationStopped; }
</span><span class="cx">
</span><span class="lines">@@ -201,6 +205,10 @@
</span><span class="cx"> RefPtr<Event> m_underlyingEvent;
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+#define EVENT_TYPE_CASTS(ToValueTypeName) \
+ TYPE_CASTS_BASE(ToValueTypeName, Event, event, event->is##ToValueTypeName(), event.is##ToValueTypeName())
+
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // Event_h
</span></span></pre></div>
<a id="trunkSourceWebCoredomFocusEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/FocusEvent.h (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/FocusEvent.h 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/FocusEvent.h 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -70,18 +70,8 @@
</span><span class="cx"> RefPtr<EventTarget> m_relatedTarget;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-inline FocusEvent* toFocusEvent(Event* event)
-{
- ASSERT_WITH_SECURITY_IMPLICATION(event && event->isFocusEvent());
- return static_cast<FocusEvent*>(event);
-}
</del><ins>+EVENT_TYPE_CASTS(FocusEvent)
</ins><span class="cx">
</span><del>-inline FocusEvent& toFocusEvent(Event& event)
-{
- ASSERT(event.isFocusEvent());
- return static_cast<FocusEvent&>(event);
-}
-
</del><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // FocusEvent_h
</span></span></pre></div>
<a id="trunkSourceWebCoredomKeyboardEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/KeyboardEvent.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/KeyboardEvent.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/KeyboardEvent.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -207,7 +207,7 @@
</span><span class="cx"> {
</span><span class="cx"> for (Event* e = event; e; e = e->underlyingEvent())
</span><span class="cx"> if (e->isKeyboardEvent())
</span><del>- return static_cast<KeyboardEvent*>(e);
</del><ins>+ return toKeyboardEvent(e);
</ins><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomKeyboardEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/KeyboardEvent.h (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/KeyboardEvent.h 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/KeyboardEvent.h 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -124,6 +124,8 @@
</span><span class="cx"> #endif
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+EVENT_TYPE_CASTS(KeyboardEvent)
+
</ins><span class="cx"> KeyboardEvent* findKeyboardEvent(Event*);
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoredomMouseEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MouseEvent.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MouseEvent.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/MouseEvent.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -277,7 +277,7 @@
</span><span class="cx"> setUnderlyingEvent(underlyingEvent);
</span><span class="cx">
</span><span class="cx"> if (this->underlyingEvent() && this->underlyingEvent()->isMouseEvent()) {
</span><del>- MouseEvent* mouseEvent = static_cast<MouseEvent*>(this->underlyingEvent());
</del><ins>+ MouseEvent* mouseEvent = toMouseEvent(this->underlyingEvent());
</ins><span class="cx"> m_screenLocation = mouseEvent->screenLocation();
</span><span class="cx"> initCoordinates(mouseEvent->clientLocation());
</span><span class="cx"> } else if (target) {
</span></span></pre></div>
<a id="trunkSourceWebCoredomMouseEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MouseEvent.h (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MouseEvent.h 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/MouseEvent.h 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -131,18 +131,8 @@
</span><span class="cx"> SimulatedMouseEvent(const AtomicString& eventType, PassRefPtr<AbstractView>, PassRefPtr<Event> underlyingEvent, Element* target);
</span><span class="cx"> };
</span><span class="cx">
</span><del>-inline MouseEvent* toMouseEvent(Event* event)
-{
- ASSERT_WITH_SECURITY_IMPLICATION(event && event->isMouseEvent());
- return static_cast<MouseEvent*>(event);
-}
</del><ins>+EVENT_TYPE_CASTS(MouseEvent)
</ins><span class="cx">
</span><del>-inline MouseEvent& toMouseEvent(Event& event)
-{
- ASSERT(event.isMouseEvent());
- return static_cast<MouseEvent&>(event);
-}
-
</del><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // MouseEvent_h
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/Node.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -2101,9 +2101,9 @@
</span><span class="cx"> if (eventType == eventNames().keydownEvent || eventType == eventNames().keypressEvent) {
</span><span class="cx"> if (event->isKeyboardEvent())
</span><span class="cx"> if (Frame* frame = document().frame())
</span><del>- frame->eventHandler().defaultKeyboardEventHandler(static_cast<KeyboardEvent*>(event));
</del><ins>+ frame->eventHandler().defaultKeyboardEventHandler(toKeyboardEvent(event));
</ins><span class="cx"> } else if (eventType == eventNames().clickEvent) {
</span><del>- int detail = event->isUIEvent() ? static_cast<UIEvent*>(event)->detail() : 0;
</del><ins>+ int detail = event->isUIEvent() ? toUIEvent(event)->detail() : 0;
</ins><span class="cx"> if (dispatchDOMActivateEvent(detail, event))
</span><span class="cx"> event->setDefaultHandled();
</span><span class="cx"> #if ENABLE(CONTEXT_MENUS)
</span><span class="lines">@@ -2115,11 +2115,10 @@
</span><span class="cx"> } else if (eventType == eventNames().textInputEvent) {
</span><span class="cx"> if (event->eventInterface() == TextEventInterfaceType)
</span><span class="cx"> if (Frame* frame = document().frame())
</span><del>- frame->eventHandler().defaultTextInputEventHandler(static_cast<TextEvent*>(event));
</del><ins>+ frame->eventHandler().defaultTextInputEventHandler(toTextEvent(event));
</ins><span class="cx"> #if ENABLE(PAN_SCROLLING)
</span><span class="cx"> } else if (eventType == eventNames().mousedownEvent && event->isMouseEvent()) {
</span><del>- MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
- if (mouseEvent->button() == MiddleButton) {
</del><ins>+ if (toMouseEvent(event)->button() == MiddleButton) {
</ins><span class="cx"> if (enclosingLinkEventParentOrSelf())
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -2134,8 +2133,7 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx"> } else if ((eventType == eventNames().wheelEvent || eventType == eventNames().mousewheelEvent) && event->eventInterface() == WheelEventInterfaceType) {
</span><del>- WheelEvent* wheelEvent = static_cast<WheelEvent*>(event);
-
</del><ins>+
</ins><span class="cx"> // If we don't have a renderer, send the wheel event to the first node we find with a renderer.
</span><span class="cx"> // This is needed for <option> and <optgroup> elements so that <select>s get a wheel scroll.
</span><span class="cx"> Node* startNode = this;
</span><span class="lines">@@ -2144,18 +2142,16 @@
</span><span class="cx">
</span><span class="cx"> if (startNode && startNode->renderer())
</span><span class="cx"> if (Frame* frame = document().frame())
</span><del>- frame->eventHandler().defaultWheelEventHandler(startNode, wheelEvent);
</del><ins>+ frame->eventHandler().defaultWheelEventHandler(startNode, toWheelEvent(event));
</ins><span class="cx"> #if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS)
</span><span class="cx"> } else if (event->eventInterface() == TouchEventInterfaceType && eventNames().isTouchEventType(eventType)) {
</span><del>- TouchEvent* touchEvent = static_cast<TouchEvent*>(event);
-
</del><span class="cx"> RenderObject* renderer = this->renderer();
</span><span class="cx"> while (renderer && (!renderer->isBox() || !toRenderBox(renderer)->canBeScrolledAndHasScrollableArea()))
</span><span class="cx"> renderer = renderer->parent();
</span><span class="cx">
</span><span class="cx"> if (renderer && renderer->node()) {
</span><span class="cx"> if (Frame* frame = document().frame())
</span><del>- frame->eventHandler().defaultTouchEventHandler(renderer->node(), touchEvent);
</del><ins>+ frame->eventHandler().defaultTouchEventHandler(renderer->node(), toTouchEvent(touchEvent));
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx"> } else if (event->type() == eventNames().webkitEditableContentChangedEvent) {
</span></span></pre></div>
<a id="trunkSourceWebCoredomTextEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/TextEvent.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/TextEvent.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/TextEvent.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -118,4 +118,9 @@
</span><span class="cx"> return TextEventInterfaceType;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+bool TextEvent::isTextEvent() const
+{
+ return true;
+}
+
</ins><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoredomTextEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/TextEvent.h (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/TextEvent.h 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/TextEvent.h 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -73,6 +73,8 @@
</span><span class="cx"> bool shouldSmartReplace, bool shouldMatchStyle);
</span><span class="cx"> TextEvent(PassRefPtr<AbstractView>, const String& data, const Vector<DictationAlternative>& dictationAlternatives);
</span><span class="cx">
</span><ins>+ virtual bool isTextEvent() const override;
+
</ins><span class="cx"> TextEventInputType m_inputType;
</span><span class="cx"> String m_data;
</span><span class="cx">
</span><span class="lines">@@ -82,6 +84,8 @@
</span><span class="cx"> Vector<DictationAlternative> m_dictationAlternatives;
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+EVENT_TYPE_CASTS(TextEvent)
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // TextEvent_h
</span></span></pre></div>
<a id="trunkSourceWebCoredomTouchEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/TouchEvent.h (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/TouchEvent.h 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/TouchEvent.h 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -86,18 +86,8 @@
</span><span class="cx"> RefPtr<TouchList> m_changedTouches;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-inline TouchEvent* toTouchEvent(Event* event)
-{
- ASSERT_WITH_SECURITY_IMPLICATION(event && event->isTouchEvent());
- return static_cast<TouchEvent*>(event);
-}
</del><ins>+EVENT_TYPE_CASTS(TouchEvent)
</ins><span class="cx">
</span><del>-inline TouchEvent& toTouchEvent(Event& event)
-{
- ASSERT(event.isTouchEvent());
- return static_cast<TouchEvent&>(event);
-}
-
</del><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // ENABLE(TOUCH_EVENTS)
</span></span></pre></div>
<a id="trunkSourceWebCoredomUIEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/UIEvent.h (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/UIEvent.h 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/UIEvent.h 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -85,6 +85,8 @@
</span><span class="cx"> int m_detail;
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+EVENT_TYPE_CASTS(UIEvent)
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // UIEvent_h
</span></span></pre></div>
<a id="trunkSourceWebCoredomWheelEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/WheelEvent.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/WheelEvent.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/WheelEvent.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -124,4 +124,9 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+bool WheelEvent::isWheelEvent() const
+{
+ return true;
+}
+
</ins><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoredomWheelEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/WheelEvent.h (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/WheelEvent.h 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/dom/WheelEvent.h 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -102,6 +102,8 @@
</span><span class="cx"> unsigned, PassRefPtr<AbstractView>, const IntPoint& screenLocation, const IntPoint& pageLocation,
</span><span class="cx"> bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, bool directionInvertedFromDevice, double timestamp);
</span><span class="cx">
</span><ins>+ virtual bool isWheelEvent() const override;
+
</ins><span class="cx"> IntPoint m_wheelDelta;
</span><span class="cx"> double m_deltaX;
</span><span class="cx"> double m_deltaY;
</span><span class="lines">@@ -110,6 +112,8 @@
</span><span class="cx"> bool m_directionInvertedFromDevice;
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+EVENT_TYPE_CASTS(WheelEvent)
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // WheelEvent_h
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAnchorElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -168,7 +168,7 @@
</span><span class="cx"> RenderImage* renderer = toRenderImage(imageElement->renderer());
</span><span class="cx">
</span><span class="cx"> // FIXME: This should probably pass true for useTransforms.
</span><del>- FloatPoint absolutePosition = renderer->absoluteToLocal(FloatPoint(static_cast<MouseEvent*>(event)->pageX(), static_cast<MouseEvent*>(event)->pageY()));
</del><ins>+ FloatPoint absolutePosition = renderer->absoluteToLocal(FloatPoint(toMouseEvent(event)->pageX(), toMouseEvent(event)->pageY()));
</ins><span class="cx"> int x = absolutePosition.x();
</span><span class="cx"> int y = absolutePosition.y();
</span><span class="cx"> url.append('?');
</span><span class="lines">@@ -194,9 +194,9 @@
</span><span class="cx"> if (hasEditableStyle()) {
</span><span class="cx"> // This keeps track of the editable block that the selection was in (if it was in one) just before the link was clicked
</span><span class="cx"> // for the LiveWhenNotFocused editable link behavior
</span><del>- if (event->type() == eventNames().mousedownEvent && event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() != RightButton && document().frame()) {
</del><ins>+ if (event->type() == eventNames().mousedownEvent && event->isMouseEvent() && toMouseEvent(event)->button() != RightButton && document().frame()) {
</ins><span class="cx"> setRootEditableElementForSelectionOnMouseDown(document().frame()->selection().selection().rootEditableElement());
</span><del>- m_wasShiftKeyDownOnMouseDown = static_cast<MouseEvent*>(event)->shiftKey();
</del><ins>+ m_wasShiftKeyDownOnMouseDown = toMouseEvent(event)->shiftKey();
</ins><span class="cx"> } else if (event->type() == eventNames().mouseoverEvent) {
</span><span class="cx"> // These are cleared on mouseover and not mouseout because their values are needed for drag events,
</span><span class="cx"> // but drag events happen after mouse out events.
</span><span class="lines">@@ -556,7 +556,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (!event->isMouseEvent())
</span><span class="cx"> return NonMouseEvent;
</span><del>- return static_cast<MouseEvent*>(event)->shiftKey() ? MouseEventWithShiftKey : MouseEventWithoutShiftKey;
</del><ins>+ return toMouseEvent(event)->shiftKey() ? MouseEventWithShiftKey : MouseEventWithoutShiftKey;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool HTMLAnchorElement::treatLinkAsLiveForEventType(EventType eventType) const
</span><span class="lines">@@ -591,12 +591,12 @@
</span><span class="cx">
</span><span class="cx"> bool isEnterKeyKeydownEvent(Event* event)
</span><span class="cx"> {
</span><del>- return event->type() == eventNames().keydownEvent && event->isKeyboardEvent() && static_cast<KeyboardEvent*>(event)->keyIdentifier() == "Enter";
</del><ins>+ return event->type() == eventNames().keydownEvent && event->isKeyboardEvent() && toKeyboardEvent(event)->keyIdentifier() == "Enter";
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool isLinkClick(Event* event)
</span><span class="cx"> {
</span><del>- return event->type() == eventNames().clickEvent && (!event->isMouseEvent() || static_cast<MouseEvent*>(event)->button() != RightButton);
</del><ins>+ return event->type() == eventNames().clickEvent && (!event->isMouseEvent() || toMouseEvent(event)->button() != RightButton);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool shouldProhibitLinks(Element* element)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLButtonElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLButtonElement.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLButtonElement.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/HTMLButtonElement.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -124,13 +124,13 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (event->isKeyboardEvent()) {
</span><del>- if (event->type() == eventNames().keydownEvent && static_cast<KeyboardEvent*>(event)->keyIdentifier() == "U+0020") {
</del><ins>+ if (event->type() == eventNames().keydownEvent && toKeyboardEvent(event)->keyIdentifier() == "U+0020") {
</ins><span class="cx"> setActive(true, true);
</span><span class="cx"> // No setDefaultHandled() - IE dispatches a keypress in this case.
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> if (event->type() == eventNames().keypressEvent) {
</span><del>- switch (static_cast<KeyboardEvent*>(event)->charCode()) {
</del><ins>+ switch (toKeyboardEvent(event)->charCode()) {
</ins><span class="cx"> case '\r':
</span><span class="cx"> dispatchSimulatedClick(event);
</span><span class="cx"> event->setDefaultHandled();
</span><span class="lines">@@ -141,7 +141,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>- if (event->type() == eventNames().keyupEvent && static_cast<KeyboardEvent*>(event)->keyIdentifier() == "U+0020") {
</del><ins>+ if (event->type() == eventNames().keyupEvent && toKeyboardEvent(event)->keyIdentifier() == "U+0020") {
</ins><span class="cx"> if (active())
</span><span class="cx"> dispatchSimulatedClick(event);
</span><span class="cx"> event->setDefaultHandled();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFrameSetElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFrameSetElement.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFrameSetElement.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/HTMLFrameSetElement.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -190,7 +190,7 @@
</span><span class="cx"> void HTMLFrameSetElement::defaultEventHandler(Event* evt)
</span><span class="cx"> {
</span><span class="cx"> if (evt->isMouseEvent() && !m_noresize && renderer() && renderer()->isFrameSet()) {
</span><del>- if (toRenderFrameSet(renderer())->userResize(static_cast<MouseEvent*>(evt))) {
</del><ins>+ if (toRenderFrameSet(renderer())->userResize(toMouseEvent(evt))) {
</ins><span class="cx"> evt->setDefaultHandled();
</span><span class="cx"> return;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLInputElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -1101,22 +1101,22 @@
</span><span class="cx">
</span><span class="cx"> void HTMLInputElement::defaultEventHandler(Event* evt)
</span><span class="cx"> {
</span><del>- if (evt->isMouseEvent() && evt->type() == eventNames().clickEvent && static_cast<MouseEvent*>(evt)->button() == LeftButton) {
- m_inputType->handleClickEvent(static_cast<MouseEvent*>(evt));
</del><ins>+ if (evt->isMouseEvent() && evt->type() == eventNames().clickEvent && toMouseEvent(evt)->button() == LeftButton) {
+ m_inputType->handleClickEvent(toMouseEvent(evt));
</ins><span class="cx"> if (evt->defaultHandled())
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(TOUCH_EVENTS)
</span><span class="cx"> if (evt->isTouchEvent()) {
</span><del>- m_inputType->handleTouchEvent(static_cast<TouchEvent*>(evt));
</del><ins>+ m_inputType->handleTouchEvent(toTouchEvent(evt));
</ins><span class="cx"> if (evt->defaultHandled())
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> if (evt->isKeyboardEvent() && evt->type() == eventNames().keydownEvent) {
</span><del>- m_inputType->handleKeydownEvent(static_cast<KeyboardEvent*>(evt));
</del><ins>+ m_inputType->handleKeydownEvent(toKeyboardEvent(evt));
</ins><span class="cx"> if (evt->defaultHandled())
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -1143,13 +1143,13 @@
</span><span class="cx"> // Use key press event here since sending simulated mouse events
</span><span class="cx"> // on key down blocks the proper sending of the key press event.
</span><span class="cx"> if (evt->isKeyboardEvent() && evt->type() == eventNames().keypressEvent) {
</span><del>- m_inputType->handleKeypressEvent(static_cast<KeyboardEvent*>(evt));
</del><ins>+ m_inputType->handleKeypressEvent(toKeyboardEvent(evt));
</ins><span class="cx"> if (evt->defaultHandled())
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (evt->isKeyboardEvent() && evt->type() == eventNames().keyupEvent) {
</span><del>- m_inputType->handleKeyupEvent(static_cast<KeyboardEvent*>(evt));
</del><ins>+ m_inputType->handleKeyupEvent(toKeyboardEvent(evt));
</ins><span class="cx"> if (evt->defaultHandled())
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -1174,10 +1174,10 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (evt->isBeforeTextInsertedEvent())
</span><del>- m_inputType->handleBeforeTextInsertedEvent(static_cast<BeforeTextInsertedEvent*>(evt));
</del><ins>+ m_inputType->handleBeforeTextInsertedEvent(toBeforeTextInsertedEvent(evt));
</ins><span class="cx">
</span><span class="cx"> if (evt->isMouseEvent() && evt->type() == eventNames().mousedownEvent) {
</span><del>- m_inputType->handleMouseDownEvent(static_cast<MouseEvent*>(evt));
</del><ins>+ m_inputType->handleMouseDownEvent(toMouseEvent(evt));
</ins><span class="cx"> if (evt->defaultHandled())
</span><span class="cx"> return;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -1149,7 +1149,7 @@
</span><span class="cx"> if (!event->isKeyboardEvent())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (platformHandleKeydownEvent(static_cast<KeyboardEvent*>(event)))
</del><ins>+ if (platformHandleKeydownEvent(toKeyboardEvent(event)))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> // When using spatial navigation, we want to be able to navigate away
</span><span class="lines">@@ -1160,7 +1160,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const String& keyIdentifier = static_cast<KeyboardEvent*>(event)->keyIdentifier();
</del><ins>+ const String& keyIdentifier = toKeyboardEvent(event)->keyIdentifier();
</ins><span class="cx"> bool handled = true;
</span><span class="cx"> const Vector<HTMLElement*>& listItems = this->listItems();
</span><span class="cx"> int listIndex = optionToListIndex(selectedIndex());
</span><span class="lines">@@ -1201,7 +1201,7 @@
</span><span class="cx"> if (!event->isKeyboardEvent())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- int keyCode = static_cast<KeyboardEvent*>(event)->keyCode();
</del><ins>+ int keyCode = toKeyboardEvent(event)->keyCode();
</ins><span class="cx"> bool handled = false;
</span><span class="cx">
</span><span class="cx"> if (keyCode == ' ' && isSpatialNavigationEnabled(document().frame())) {
</span><span class="lines">@@ -1256,7 +1256,7 @@
</span><span class="cx"> event->setDefaultHandled();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mousedownEvent && event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == LeftButton) {
</del><ins>+ if (event->type() == eventNames().mousedownEvent && event->isMouseEvent() && toMouseEvent(event)->button() == LeftButton) {
</ins><span class="cx"> focus();
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> if (renderer() && renderer()->isMenuList()) {
</span><span class="lines">@@ -1339,14 +1339,14 @@
</span><span class="cx"> {
</span><span class="cx"> const Vector<HTMLElement*>& listItems = this->listItems();
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mousedownEvent && event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == LeftButton) {
</del><ins>+ if (event->type() == eventNames().mousedownEvent && event->isMouseEvent() && toMouseEvent(event)->button() == LeftButton) {
</ins><span class="cx"> focus();
</span><span class="cx"> // Calling focus() may cause us to lose our renderer, in which case do not want to handle the event.
</span><span class="cx"> if (!renderer())
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> // Convert to coords relative to the list box if needed.
</span><del>- MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
</del><ins>+ MouseEvent* mouseEvent = toMouseEvent(event);
</ins><span class="cx"> IntPoint localOffset = roundedIntPoint(renderer()->absoluteToLocal(mouseEvent->absoluteLocation(), UseTransforms));
</span><span class="cx"> int listIndex = toRenderListBox(renderer())->listIndexAtOffset(toIntSize(localOffset));
</span><span class="cx"> if (listIndex >= 0) {
</span><span class="lines">@@ -1363,7 +1363,7 @@
</span><span class="cx"> event->setDefaultHandled();
</span><span class="cx"> }
</span><span class="cx"> } else if (event->type() == eventNames().mousemoveEvent && event->isMouseEvent() && !toRenderBox(renderer())->canBeScrolledAndHasScrollableArea()) {
</span><del>- MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
</del><ins>+ MouseEvent* mouseEvent = toMouseEvent(event);
</ins><span class="cx"> if (mouseEvent->button() != LeftButton || !mouseEvent->buttonDown())
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -1386,7 +1386,7 @@
</span><span class="cx"> }
</span><span class="cx"> event->setDefaultHandled();
</span><span class="cx"> }
</span><del>- } else if (event->type() == eventNames().mouseupEvent && event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == LeftButton && document().frame()->eventHandler().autoscrollRenderer() != renderer()) {
</del><ins>+ } else if (event->type() == eventNames().mouseupEvent && event->isMouseEvent() && toMouseEvent(event)->button() == LeftButton && document().frame()->eventHandler().autoscrollRenderer() != renderer()) {
</ins><span class="cx"> // This click or drag event was not over any of the options.
</span><span class="cx"> if (m_lastOnChangeSelection.isEmpty())
</span><span class="cx"> return;
</span><span class="lines">@@ -1397,7 +1397,7 @@
</span><span class="cx"> } else if (event->type() == eventNames().keydownEvent) {
</span><span class="cx"> if (!event->isKeyboardEvent())
</span><span class="cx"> return;
</span><del>- const String& keyIdentifier = static_cast<KeyboardEvent*>(event)->keyIdentifier();
</del><ins>+ const String& keyIdentifier = toKeyboardEvent(event)->keyIdentifier();
</ins><span class="cx">
</span><span class="cx"> bool handled = false;
</span><span class="cx"> int endIndex = 0;
</span><span class="lines">@@ -1459,15 +1459,15 @@
</span><span class="cx"> #if PLATFORM(COCOA)
</span><span class="cx"> m_allowsNonContiguousSelection = m_multiple && isSpatialNavigationEnabled(document().frame());
</span><span class="cx"> #else
</span><del>- m_allowsNonContiguousSelection = m_multiple && (isSpatialNavigationEnabled(document().frame()) || static_cast<KeyboardEvent*>(event)->ctrlKey());
</del><ins>+ m_allowsNonContiguousSelection = m_multiple && (isSpatialNavigationEnabled(document().frame()) || toKeyboardEvent(event)->ctrlKey());
</ins><span class="cx"> #endif
</span><del>- bool selectNewItem = static_cast<KeyboardEvent*>(event)->shiftKey() || !m_allowsNonContiguousSelection;
</del><ins>+ bool selectNewItem = toKeyboardEvent(event)->shiftKey() || !m_allowsNonContiguousSelection;
</ins><span class="cx">
</span><span class="cx"> if (selectNewItem)
</span><span class="cx"> m_activeSelectionState = true;
</span><span class="cx"> // If the anchor is unitialized, or if we're going to deselect all
</span><span class="cx"> // other options, then set the anchor index equal to the end index.
</span><del>- bool deselectOthers = !m_multiple || (!static_cast<KeyboardEvent*>(event)->shiftKey() && selectNewItem);
</del><ins>+ bool deselectOthers = !m_multiple || (!toKeyboardEvent(event)->shiftKey() && selectNewItem);
</ins><span class="cx"> if (m_activeSelectionAnchorIndex < 0 || deselectOthers) {
</span><span class="cx"> if (deselectOthers)
</span><span class="cx"> deselectItemsWithoutValidation();
</span><span class="lines">@@ -1486,7 +1486,7 @@
</span><span class="cx"> } else if (event->type() == eventNames().keypressEvent) {
</span><span class="cx"> if (!event->isKeyboardEvent())
</span><span class="cx"> return;
</span><del>- int keyCode = static_cast<KeyboardEvent*>(event)->keyCode();
</del><ins>+ int keyCode = toKeyboardEvent(event)->keyCode();
</ins><span class="cx">
</span><span class="cx"> if (keyCode == '\r') {
</span><span class="cx"> if (form())
</span><span class="lines">@@ -1527,7 +1527,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (event->type() == eventNames().keypressEvent && event->isKeyboardEvent()) {
</span><del>- KeyboardEvent* keyboardEvent = static_cast<KeyboardEvent*>(event);
</del><ins>+ KeyboardEvent* keyboardEvent = toKeyboardEvent(event);
</ins><span class="cx"> if (!keyboardEvent->ctrlKey() && !keyboardEvent->altKey() && !keyboardEvent->metaKey() && u_isprint(keyboardEvent->charCode())) {
</span><span class="cx"> typeAheadFind(keyboardEvent);
</span><span class="cx"> event->setDefaultHandled();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSummaryElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSummaryElement.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSummaryElement.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/HTMLSummaryElement.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -126,13 +126,13 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (event->isKeyboardEvent()) {
</span><del>- if (event->type() == eventNames().keydownEvent && static_cast<KeyboardEvent*>(event)->keyIdentifier() == "U+0020") {
</del><ins>+ if (event->type() == eventNames().keydownEvent && toKeyboardEvent(event)->keyIdentifier() == "U+0020") {
</ins><span class="cx"> setActive(true, true);
</span><span class="cx"> // No setDefaultHandled() - IE dispatches a keypress in this case.
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> if (event->type() == eventNames().keypressEvent) {
</span><del>- switch (static_cast<KeyboardEvent*>(event)->charCode()) {
</del><ins>+ switch (toKeyboardEvent(event)->charCode()) {
</ins><span class="cx"> case '\r':
</span><span class="cx"> dispatchSimulatedClick(event);
</span><span class="cx"> event->setDefaultHandled();
</span><span class="lines">@@ -143,7 +143,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>- if (event->type() == eventNames().keyupEvent && static_cast<KeyboardEvent*>(event)->keyIdentifier() == "U+0020") {
</del><ins>+ if (event->type() == eventNames().keyupEvent && toKeyboardEvent(event)->keyIdentifier() == "U+0020") {
</ins><span class="cx"> if (active())
</span><span class="cx"> dispatchSimulatedClick(event);
</span><span class="cx"> event->setDefaultHandled();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTextAreaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -269,7 +269,7 @@
</span><span class="cx"> if (renderer() && (event->isMouseEvent() || event->isDragEvent() || event->eventInterface() == WheelEventInterfaceType || event->type() == eventNames().blurEvent))
</span><span class="cx"> forwardEvent(event);
</span><span class="cx"> else if (renderer() && event->isBeforeTextInsertedEvent())
</span><del>- handleBeforeTextInsertedEvent(static_cast<BeforeTextInsertedEvent*>(event));
</del><ins>+ handleBeforeTextInsertedEvent(toBeforeTextInsertedEvent(event));
</ins><span class="cx">
</span><span class="cx"> HTMLTextFormControlElement::defaultEventHandler(event);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlImageDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ImageDocument.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ImageDocument.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/ImageDocument.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -417,7 +417,7 @@
</span><span class="cx"> if (event->type() == eventNames().resizeEvent)
</span><span class="cx"> m_doc->windowSizeChanged();
</span><span class="cx"> else if (event->type() == eventNames().clickEvent && event->isMouseEvent()) {
</span><del>- MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
</del><ins>+ MouseEvent* mouseEvent = toMouseEvent(event);
</ins><span class="cx"> m_doc->imageClicked(mouseEvent->x(), mouseEvent->y());
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/InputType.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/InputType.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/InputType.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -470,7 +470,7 @@
</span><span class="cx">
</span><span class="cx"> bool InputType::shouldSubmitImplicitly(Event* event)
</span><span class="cx"> {
</span><del>- return event->isKeyboardEvent() && event->type() == eventNames().keypressEvent && static_cast<KeyboardEvent*>(event)->charCode() == '\r';
</del><ins>+ return event->isKeyboardEvent() && event->type() == eventNames().keypressEvent && toKeyboardEvent(event)->charCode() == '\r';
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<HTMLFormElement> InputType::formForSubmission() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlMediaDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/MediaDocument.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/MediaDocument.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/MediaDocument.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -187,7 +187,7 @@
</span><span class="cx"> if (!video)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- KeyboardEvent* keyboardEvent = static_cast<KeyboardEvent*>(event);
</del><ins>+ KeyboardEvent* keyboardEvent = toKeyboardEvent(event);
</ins><span class="cx"> if (keyboardEvent->keyIdentifier() == "U+0020") { // space
</span><span class="cx"> if (video->paused()) {
</span><span class="cx"> if (video->canPlay())
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlTextFieldInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/TextFieldInputType.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/TextFieldInputType.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/TextFieldInputType.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -202,7 +202,7 @@
</span><span class="cx">
</span><span class="cx"> bool TextFieldInputType::shouldSubmitImplicitly(Event* event)
</span><span class="cx"> {
</span><del>- return (event->type() == eventNames().textInputEvent && event->eventInterface() == TextEventInterfaceType && static_cast<TextEvent*>(event)->data() == "\n") || InputType::shouldSubmitImplicitly(event);
</del><ins>+ return (event->type() == eventNames().textInputEvent && event->eventInterface() == TextEventInterfaceType && toTextEvent(event)->data() == "\n") || InputType::shouldSubmitImplicitly(event);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RenderPtr<RenderElement> TextFieldInputType::createInputRenderer(PassRef<RenderStyle> style)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowMediaControlElementTypescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -255,7 +255,7 @@
</span><span class="cx"> void MediaControlVolumeSliderElement::defaultEventHandler(Event* event)
</span><span class="cx"> {
</span><span class="cx"> // Left button is 0. Rejects mouse events not from left button.
</span><del>- if (event->isMouseEvent() && static_cast<MouseEvent*>(event)->button())
</del><ins>+ if (event->isMouseEvent() && toMouseEvent(event)->button())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (!renderer())
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowMediaControlElementscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/MediaControlElements.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/MediaControlElements.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/shadow/MediaControlElements.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -225,7 +225,7 @@
</span><span class="cx"> MediaControlDivElement::defaultEventHandler(event);
</span><span class="cx">
</span><span class="cx"> if (event->isMouseEvent()) {
</span><del>- LayoutPoint location = static_cast<MouseEvent*>(event)->absoluteLocation();
</del><ins>+ LayoutPoint location = toMouseEvent(event)->absoluteLocation();
</ins><span class="cx"> if (event->type() == eventNames().mousedownEvent && event->target() == this) {
</span><span class="cx"> startDrag(location);
</span><span class="cx"> event->setDefaultHandled();
</span><span class="lines">@@ -362,7 +362,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> // Poor man's mouseleave event detection.
</span><del>- MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
</del><ins>+ MouseEvent* mouseEvent = toMouseEvent(event);
</ins><span class="cx"> EventTarget* relatedTarget = mouseEvent->relatedTarget();
</span><span class="cx"> if (!relatedTarget || !relatedTarget->toNode())
</span><span class="cx"> return;
</span><span class="lines">@@ -939,7 +939,7 @@
</span><span class="cx"> void MediaControlTimelineElement::defaultEventHandler(Event* event)
</span><span class="cx"> {
</span><span class="cx"> // Left button is 0. Rejects mouse events not from left button.
</span><del>- if (event->isMouseEvent() && static_cast<MouseEvent*>(event)->button())
</del><ins>+ if (event->isMouseEvent() && toMouseEvent(event)->button())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (!renderer())
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowMediaControlscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/MediaControls.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/MediaControls.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/shadow/MediaControls.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -373,7 +373,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (!event->isMouseEvent())
</span><span class="cx"> return false;
</span><del>- EventTarget* relatedTarget = static_cast<MouseEvent*>(event)->relatedTarget();
</del><ins>+ EventTarget* relatedTarget = toMouseEvent(event)->relatedTarget();
</ins><span class="cx"> if (!relatedTarget)
</span><span class="cx"> return false;
</span><span class="cx"> return contains(relatedTarget->toNode());
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowMediaControlsApplecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -589,7 +589,7 @@
</span><span class="cx"> if (event->type() == eventNames().clickEvent)
</span><span class="cx"> m_mediaControls->handleClickEvent(event);
</span><span class="cx"> else if ((event->type() == eventNames().wheelEvent || event->type() == eventNames().mousewheelEvent) && event->eventInterface() == WheelEventInterfaceType) {
</span><del>- WheelEvent* wheelEvent = static_cast<WheelEvent*>(event);
</del><ins>+ WheelEvent* wheelEvent = toWheelEvent(event);
</ins><span class="cx"> if (m_mediaControls->shouldClosedCaptionsContainerPreventPageScrolling(wheelEvent->wheelDeltaY()))
</span><span class="cx"> event->preventDefault();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowSliderThumbElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -350,7 +350,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
</del><ins>+ MouseEvent* mouseEvent = toMouseEvent(event);
</ins><span class="cx"> bool isLeftButton = mouseEvent->button() == LeftButton;
</span><span class="cx"> const AtomicString& eventType = event->type();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowSpinButtonElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/SpinButtonElement.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/SpinButtonElement.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/shadow/SpinButtonElement.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -91,7 +91,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
</del><ins>+ MouseEvent* mouseEvent = toMouseEvent(event);
</ins><span class="cx"> IntPoint local = roundedIntPoint(box->absoluteToLocal(mouseEvent->absoluteLocation(), UseTransforms));
</span><span class="cx"> if (mouseEvent->type() == eventNames().mousedownEvent && mouseEvent->button() == LeftButton) {
</span><span class="cx"> if (box->pixelSnappedBorderBoxRect().contains(local)) {
</span><span class="lines">@@ -160,7 +160,7 @@
</span><span class="cx"> if (!m_spinButtonOwner->shouldSpinButtonRespondToWheelEvents())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- doStepAction(static_cast<WheelEvent*>(event)->wheelDeltaY());
</del><ins>+ doStepAction(toWheelEvent(event)->wheelDeltaY());
</ins><span class="cx"> event->setDefaultHandled();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowTextControlInnerElementscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -162,7 +162,7 @@
</span><span class="cx"> {
</span><span class="cx"> // On mousedown, bring up a menu, if needed
</span><span class="cx"> HTMLInputElement* input = toHTMLInputElement(shadowHost());
</span><del>- if (input && event->type() == eventNames().mousedownEvent && event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == LeftButton) {
</del><ins>+ if (input && event->type() == eventNames().mousedownEvent && event->isMouseEvent() && toMouseEvent(event)->button() == LeftButton) {
</ins><span class="cx"> input->focus();
</span><span class="cx"> input->select();
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="lines">@@ -224,7 +224,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mousedownEvent && event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == LeftButton) {
</del><ins>+ if (event->type() == eventNames().mousedownEvent && event->isMouseEvent() && toMouseEvent(event)->button() == LeftButton) {
</ins><span class="cx"> if (renderer() && renderer()->visibleToHitTesting()) {
</span><span class="cx"> if (Frame* frame = document().frame()) {
</span><span class="cx"> frame->eventHandler().setCapturingMouseEventsElement(this);
</span><span class="lines">@@ -235,7 +235,7 @@
</span><span class="cx"> input->select();
</span><span class="cx"> event->setDefaultHandled();
</span><span class="cx"> }
</span><del>- if (event->type() == eventNames().mouseupEvent && event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == LeftButton) {
</del><ins>+ if (event->type() == eventNames().mouseupEvent && event->isMouseEvent() && toMouseEvent(event)->button() == LeftButton) {
</ins><span class="cx"> if (m_capturing) {
</span><span class="cx"> if (Frame* frame = document().frame()) {
</span><span class="cx"> frame->eventHandler().setCapturingMouseEventsElement(nullptr);
</span><span class="lines">@@ -313,7 +313,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // On mouse down, select the text and set focus.
</span><del>- if (event->type() == eventNames().mousedownEvent && event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == LeftButton) {
</del><ins>+ if (event->type() == eventNames().mousedownEvent && event->isMouseEvent() && toMouseEvent(event)->button() == LeftButton) {
</ins><span class="cx"> if (renderer() && renderer()->visibleToHitTesting()) {
</span><span class="cx"> if (Frame* frame = document().frame()) {
</span><span class="cx"> frame->eventHandler().setCapturingMouseEventsElement(this);
</span><span class="lines">@@ -326,7 +326,7 @@
</span><span class="cx"> event->setDefaultHandled();
</span><span class="cx"> }
</span><span class="cx"> // On mouse up, release capture cleanly.
</span><del>- if (event->type() == eventNames().mouseupEvent && event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == LeftButton) {
</del><ins>+ if (event->type() == eventNames().mouseupEvent && event->isMouseEvent() && toMouseEvent(event)->button() == LeftButton) {
</ins><span class="cx"> if (m_capturing && renderer() && renderer()->visibleToHitTesting()) {
</span><span class="cx"> if (Frame* frame = document().frame()) {
</span><span class="cx"> frame->eventHandler().setCapturingMouseEventsElement(nullptr);
</span></span></pre></div>
<a id="trunkSourceWebCorepageContextMenuControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/ContextMenuController.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/ContextMenuController.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/page/ContextMenuController.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -135,11 +135,11 @@
</span><span class="cx"> if (!event->isMouseEvent())
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
- HitTestResult result(mouseEvent->absoluteLocation());
</del><ins>+ MouseEvent& mouseEvent = toMouseEvent(*event);
+ HitTestResult result(mouseEvent.absoluteLocation());
</ins><span class="cx">
</span><span class="cx"> if (Frame* frame = event->target()->toNode()->document().frame())
</span><del>- result = frame->eventHandler().hitTestResultAtPoint(mouseEvent->absoluteLocation());
</del><ins>+ result = frame->eventHandler().hitTestResultAtPoint(mouseEvent.absoluteLocation());
</ins><span class="cx">
</span><span class="cx"> if (!result.innerNonSharedNode())
</span><span class="cx"> return nullptr;
</span></span></pre></div>
<a id="trunkSourceWebCorepageEventHandlercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/EventHandler.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/EventHandler.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -3257,7 +3257,7 @@
</span><span class="cx"> {
</span><span class="cx"> // Platforms should differentiate real commands like selectAll from text input in disguise (like insertNewline),
</span><span class="cx"> // and avoid dispatching text input events from keydown default handlers.
</span><del>- ASSERT(!underlyingEvent || !underlyingEvent->isKeyboardEvent() || static_cast<KeyboardEvent*>(underlyingEvent)->type() == eventNames().keypressEvent);
</del><ins>+ ASSERT(!underlyingEvent || !underlyingEvent->isKeyboardEvent() || toKeyboardEvent(underlyingEvent)->type() == eventNames().keypressEvent);
</ins><span class="cx">
</span><span class="cx"> EventTarget* target;
</span><span class="cx"> if (underlyingEvent)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderEmbeddedObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -608,9 +608,9 @@
</span><span class="cx"> if (!event->isMouseEvent())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
</del><ins>+ MouseEvent* mouseEvent = toMouseEvent(event);
</ins><span class="cx"> HTMLPlugInElement& element = toHTMLPlugInElement(frameOwnerElement());
</span><del>- if (event->type() == eventNames().mousedownEvent && static_cast<MouseEvent*>(event)->button() == LeftButton) {
</del><ins>+ if (event->type() == eventNames().mousedownEvent && toMouseEvent(event)->button() == LeftButton) {
</ins><span class="cx"> m_mouseDownWasInUnavailablePluginIndicator = isInUnavailablePluginIndicator(mouseEvent);
</span><span class="cx"> if (m_mouseDownWasInUnavailablePluginIndicator) {
</span><span class="cx"> frame().eventHandler().setCapturingMouseEventsElement(&element);
</span><span class="lines">@@ -619,7 +619,7 @@
</span><span class="cx"> }
</span><span class="cx"> event->setDefaultHandled();
</span><span class="cx"> }
</span><del>- if (event->type() == eventNames().mouseupEvent && static_cast<MouseEvent*>(event)->button() == LeftButton) {
</del><ins>+ if (event->type() == eventNames().mouseupEvent && toMouseEvent(event)->button() == LeftButton) {
</ins><span class="cx"> if (m_unavailablePluginIndicatorIsPressed) {
</span><span class="cx"> frame().eventHandler().setCapturingMouseEventsElement(nullptr);
</span><span class="cx"> element.setIsCapturingMouseEvents(false);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderSnapshottedPlugIncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp (164183 => 164184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp 2014-02-16 00:36:36 UTC (rev 164183)
+++ trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp 2014-02-16 02:01:04 UTC (rev 164184)
</span><span class="lines">@@ -156,7 +156,7 @@
</span><span class="cx"> if (!event->isMouseEvent())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
</del><ins>+ MouseEvent* mouseEvent = toMouseEvent(event);
</ins><span class="cx">
</span><span class="cx"> // If we're a snapshotted plugin, we want to make sure we activate on
</span><span class="cx"> // clicks even if the page is preventing our default behaviour. Otherwise
</span></span></pre>
</div>
</div>
</body>
</html>