<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164103] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164103">164103</a></dd>
<dt>Author</dt> <dd>abucur@adobe.com</dd>
<dt>Date</dt> <dd>2014-02-14 09:35:22 -0800 (Fri, 14 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Regions] visibility: hidden on a region should hide its content
https://bugs.webkit.org/show_bug.cgi?id=128814
Reviewed by Mihnea Ovidenie.
Source/WebCore:
The patch properly checks that the content of a region layer should be painted before actually
calling the paint function (for example, when visibility: hidden is specified on a region, its
content should be hidden).
Test: fast/regions/visibility-hidden.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
LayoutTests:
Add a test that verifies visibility: hidden on a region hides the content of
the flow thread.
* fast/regions/visibility-hidden-expected.html: Added.
* fast/regions/visibility-hidden.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastregionsvisibilityhiddenexpectedhtml">trunk/LayoutTests/fast/regions/visibility-hidden-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastregionsvisibilityhiddenhtml">trunk/LayoutTests/fast/regions/visibility-hidden.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164102 => 164103)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-14 17:11:23 UTC (rev 164102)
+++ trunk/LayoutTests/ChangeLog 2014-02-14 17:35:22 UTC (rev 164103)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-02-14 Andrei Bucur <abucur@adobe.com>
+
+ [CSS Regions] visibility: hidden on a region should hide its content
+ https://bugs.webkit.org/show_bug.cgi?id=128814
+
+ Reviewed by Mihnea Ovidenie.
+
+ Add a test that verifies visibility: hidden on a region hides the content of
+ the flow thread.
+
+ * fast/regions/visibility-hidden-expected.html: Added.
+ * fast/regions/visibility-hidden.html: Added.
+
</ins><span class="cx"> 2014-02-14 Grzegorz Czajkowski <g.czajkowski@samsung.com>
</span><span class="cx">
</span><span class="cx"> Refactoring design-mode-spellcheck-off.html to use asynchronous spellchecking
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsvisibilityhiddenexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/visibility-hidden-expected.html (0 => 164103)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/visibility-hidden-expected.html (rev 0)
+++ trunk/LayoutTests/fast/regions/visibility-hidden-expected.html 2014-02-14 17:35:22 UTC (rev 164103)
</span><span class="lines">@@ -0,0 +1,9 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <title>Test - Bug 128814: [CSS Regions] visibility: hidden on a region should hide its content</title>
+ </head>
+ <body>
+ <p>There should be no red on the page.</p>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastregionsvisibilityhiddenhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/visibility-hidden.html (0 => 164103)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/visibility-hidden.html (rev 0)
+++ trunk/LayoutTests/fast/regions/visibility-hidden.html 2014-02-14 17:35:22 UTC (rev 164103)
</span><span class="lines">@@ -0,0 +1,31 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <title>Test - Bug 128814: [CSS Regions] visibility: hidden on a region should hide its content</title>
+ <style>
+ #region1 {
+ -webkit-flow-from: article;
+ width: 300px;
+ height: 300px;
+ visibility: hidden;
+ }
+
+ article {
+ color: red;
+ }
+
+ #content {
+ -webkit-flow-into: article;
+ }
+ </style>
+ </head>
+ <body>
+ <p>There should be no red on the page.</p>
+ <div id="region1"></div>
+ <article id="content">
+ <p>
+ Should be hidden.
+ </p>
+ </article>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164102 => 164103)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-14 17:11:23 UTC (rev 164102)
+++ trunk/Source/WebCore/ChangeLog 2014-02-14 17:35:22 UTC (rev 164103)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-02-14 Andrei Bucur <abucur@adobe.com>
+
+ [CSS Regions] visibility: hidden on a region should hide its content
+ https://bugs.webkit.org/show_bug.cgi?id=128814
+
+ Reviewed by Mihnea Ovidenie.
+
+ The patch properly checks that the content of a region layer should be painted before actually
+ calling the paint function (for example, when visibility: hidden is specified on a region, its
+ content should be hidden).
+
+ Test: fast/regions/visibility-hidden.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintLayerContents):
+
</ins><span class="cx"> 2014-02-14 László Langó <llango.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> Follow-up fix after r164036.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (164102 => 164103)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-02-14 17:11:23 UTC (rev 164102)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-02-14 17:35:22 UTC (rev 164103)
</span><span class="lines">@@ -4098,7 +4098,8 @@
</span><span class="cx"> paintFixedLayersInNamedFlows(context, localPaintingInfo, localPaintFlags);
</span><span class="cx">
</span><span class="cx"> // If this is a region, paint its contents via the flow thread's layer.
</span><del>- paintFlowThreadIfRegion(context, localPaintingInfo, localPaintFlags, offsetFromRoot, paintDirtyRect, isPaintingOverflowContents);
</del><ins>+ if (shouldPaintContent)
+ paintFlowThreadIfRegion(context, localPaintingInfo, localPaintFlags, offsetFromRoot, paintDirtyRect, isPaintingOverflowContents);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (isPaintingOverlayScrollbars)
</span></span></pre>
</div>
</div>
</body>
</html>