<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164145] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164145">164145</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2014-02-14 16:59:56 -0800 (Fri, 14 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/157443">r157443</a>): Search fields with a non-white background don’t have a round bezel
https://bugs.webkit.org/show_bug.cgi?id=126295
Reviewed by Ryosuke Niwa.
Source/WebCore:
Reverted <a href="http://trac.webkit.org/projects/webkit/changeset/157443">r157443</a> and improved comment.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isControlStyled):
LayoutTests:
Reverted <a href="http://trac.webkit.org/projects/webkit/changeset/157443">r157443</a>.
* fast/forms/search/search-field-background-color-expected.txt: Removed.
* fast/forms/search/search-field-background-color.html: Removed.
* platform/efl/fast/forms/search: Removed.
* platform/efl/fast/forms/search/search-field-background-color-expected.png: Removed.
* platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Removed.
* platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Removed.
* platform/mac/fast/forms/search-styled-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacfastformssearchstyledexpectedtxt">trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemecpp">trunk/Source/WebCore/rendering/RenderTheme.cpp</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastformssearchsearchfieldbackgroundcolorexpectedtxt">trunk/LayoutTests/fast/forms/search/search-field-background-color-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastformssearchsearchfieldbackgroundcolorhtml">trunk/LayoutTests/fast/forms/search/search-field-background-color.html</a></li>
<li>trunk/LayoutTests/platform/efl/fast/forms/search/</li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164144 => 164145)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-15 00:54:36 UTC (rev 164144)
+++ trunk/LayoutTests/ChangeLog 2014-02-15 00:59:56 UTC (rev 164145)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-02-14 Dan Bernstein <mitz@apple.com>
+
+ REGRESSION (r157443): Search fields with a non-white background don’t have a round bezel
+ https://bugs.webkit.org/show_bug.cgi?id=126295
+
+ Reviewed by Ryosuke Niwa.
+
+ Reverted r157443.
+
+ * fast/forms/search/search-field-background-color-expected.txt: Removed.
+ * fast/forms/search/search-field-background-color.html: Removed.
+ * platform/efl/fast/forms/search: Removed.
+ * platform/efl/fast/forms/search/search-field-background-color-expected.png: Removed.
+ * platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Removed.
+ * platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Removed.
+ * platform/mac/fast/forms/search-styled-expected.txt:
+
</ins><span class="cx"> 2014-02-14 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Activate CSS Region Tests on Windows
</span></span></pre></div>
<a id="trunkLayoutTestsfastformssearchsearchfieldbackgroundcolorexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/forms/search/search-field-background-color-expected.txt (164144 => 164145)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/search/search-field-background-color-expected.txt 2014-02-15 00:54:36 UTC (rev 164144)
+++ trunk/LayoutTests/fast/forms/search/search-field-background-color-expected.txt 2014-02-15 00:59:56 UTC (rev 164145)
</span><span class="lines">@@ -1,4 +0,0 @@
</span><del>-PASS getComputedStyle(test, null).getPropertyValue('background-color') is color
-The following search field should have red background.
-
-
</del></span></pre></div>
<a id="trunkLayoutTestsfastformssearchsearchfieldbackgroundcolorhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/forms/search/search-field-background-color.html (164144 => 164145)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/search/search-field-background-color.html 2014-02-15 00:54:36 UTC (rev 164144)
+++ trunk/LayoutTests/fast/forms/search/search-field-background-color.html 2014-02-15 00:59:56 UTC (rev 164145)
</span><span class="lines">@@ -1,24 +0,0 @@
</span><del>-<!DOCTYPE html>
-<html>
-<head>
-<script src="../../../resources/js-test-pre.js"></script>
-<style>
- input { background: red; }
-</style>
-</head>
-
-<body>
-<p>The following search field should have red background.</p>
-<input type="search" id="test">
-
-<script>
-if (window.testRunner)
- testRunner.dumpAsText(true);
-
- var test = document.getElementById("test");
- var color = 'rgb(255, 0, 0)';
- shouldBe("getComputedStyle(test, null).getPropertyValue('background-color')", "color");
-</script>
-
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsplatformmacfastformssearchstyledexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt (164144 => 164145)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt 2014-02-15 00:54:36 UTC (rev 164144)
+++ trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt 2014-02-15 00:59:56 UTC (rev 164145)
</span><span class="lines">@@ -1,17 +1,17 @@
</span><span class="cx"> layer at (0,0) size 800x600
</span><span class="cx"> RenderView at (0,0) size 800x600
</span><del>-layer at (0,0) size 800x41
- RenderBlock {HTML} at (0,0) size 800x41
- RenderBody {BODY} at (8,8) size 784x25
- RenderTextControl {INPUT} at (2,2) size 220x21 [bgcolor=#FFFFFF] [border: (1px solid #BDC7D8)]
- RenderFlexibleBox {DIV} at (18,4) size 198x13
</del><ins>+layer at (0,0) size 800x39
+ RenderBlock {HTML} at (0,0) size 800x39
+ RenderBody {BODY} at (8,8) size 784x23
+ RenderTextControl {INPUT} at (2,2) size 158x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
+ RenderFlexibleBox {DIV} at (3,3) size 152x13
</ins><span class="cx"> RenderBlock {DIV} at (0,1) size 22x11
</span><del>- RenderBlock {DIV} at (22,0) size 163x13
- RenderBlock {DIV} at (185,1) size 13x11
</del><ins>+ RenderBlock {DIV} at (22,0) size 117x13
+ RenderBlock {DIV} at (139,1) size 13x11
</ins><span class="cx"> RenderText {#text} at (0,0) size 0x0
</span><del>-layer at (50,14) size 163x13
- RenderBlock {DIV} at (40,4) size 163x13 [color=#A9A9A9]
</del><ins>+layer at (35,13) size 117x13
+ RenderBlock {DIV} at (25,3) size 117x13 [color=#A9A9A9]
</ins><span class="cx"> RenderText {#text} at (0,0) size 92x13
</span><span class="cx"> text run at (0,0) width 92: "Search for Events"
</span><del>-layer at (50,14) size 163x13
- RenderBlock {DIV} at (0,0) size 163x13
</del><ins>+layer at (35,13) size 117x13
+ RenderBlock {DIV} at (0,0) size 117x13
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164144 => 164145)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-15 00:54:36 UTC (rev 164144)
+++ trunk/Source/WebCore/ChangeLog 2014-02-15 00:59:56 UTC (rev 164145)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-02-14 Dan Bernstein <mitz@apple.com>
+
+ REGRESSION (r157443): Search fields with a non-white background don’t have a round bezel
+ https://bugs.webkit.org/show_bug.cgi?id=126295
+
+ Reviewed by Ryosuke Niwa.
+
+ Reverted r157443 and improved comment.
+
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::isControlStyled):
+
</ins><span class="cx"> 2014-02-14 Brian Burg <bburg@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Replay: AtomicString replay input names should be stored in a thread-local table
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (164144 => 164145)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2014-02-15 00:54:36 UTC (rev 164144)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2014-02-15 00:59:56 UTC (rev 164145)
</span><span class="lines">@@ -684,7 +684,7 @@
</span><span class="cx"> case ContinuousCapacityLevelIndicatorPart:
</span><span class="cx"> case DiscreteCapacityLevelIndicatorPart:
</span><span class="cx"> case RatingLevelIndicatorPart:
</span><del>- case SearchFieldPart:
</del><ins>+ // FIXME: SearchFieldPart should be included here when making search fields style-able.
</ins><span class="cx"> case TextFieldPart:
</span><span class="cx"> case TextAreaPart:
</span><span class="cx"> // Test the style to see if the UA border and background match.
</span></span></pre>
</div>
</div>
</body>
</html>