<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164142] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164142">164142</a></dd>
<dt>Author</dt> <dd>jer.noble@apple.com</dd>
<dt>Date</dt> <dd>2014-02-14 16:48:09 -0800 (Fri, 14 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add support for specced event handlers to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=128292
Reviewed by Andreas Kling.
Source/WebCore:
Test: media/media-event-listeners.html
Add explicit event listener IDL attributes to HTMLMediaElement.
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
LayoutTests:
* media/media-event-listeners-expected.txt: Added.
* media/media-event-listeners.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementh">trunk/Source/WebCore/html/HTMLMediaElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementidl">trunk/Source/WebCore/html/HTMLMediaElement.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmediamediaeventlistenersexpectedtxt">trunk/LayoutTests/media/media-event-listeners-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamediaeventlistenershtml">trunk/LayoutTests/media/media-event-listeners.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164141 => 164142)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-15 00:04:55 UTC (rev 164141)
+++ trunk/LayoutTests/ChangeLog 2014-02-15 00:48:09 UTC (rev 164142)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-02-14 Jer Noble <jer.noble@apple.com>
+
+ Add support for specced event handlers to HTMLMediaElement
+ https://bugs.webkit.org/show_bug.cgi?id=128292
+
+ Reviewed by Andreas Kling.
+
+ * media/media-event-listeners-expected.txt: Added.
+ * media/media-event-listeners.html: Added.
+
</ins><span class="cx"> 2014-02-14 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Mac rebaseline after r164127.
</span></span></pre></div>
<a id="trunkLayoutTestsmediamediaeventlistenersexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/media-event-listeners-expected.txt (0 => 164142)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/media-event-listeners-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-event-listeners-expected.txt 2014-02-15 00:48:09 UTC (rev 164142)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+
+LISTENER(durationchange)
+LISTENER(loadedmetadata)
+LISTENER(loadeddata)
+LISTENER(canplay)
+LISTENER(canplaythrough)
+LISTENER(play)
+LISTENER(playing)
+LISTENER(ratechange)
+LISTENER(timeupdate)
+LISTENER(pause)
+LISTENER(ended)
+LISTENER(volumechange)
+END OF TEST
+
</ins></span></pre></div>
<a id="trunkLayoutTestsmediamediaeventlistenershtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/media-event-listeners.html (0 => 164142)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/media-event-listeners.html (rev 0)
+++ trunk/LayoutTests/media/media-event-listeners.html 2014-02-15 00:48:09 UTC (rev 164142)
</span><span class="lines">@@ -0,0 +1,57 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <script src=media-file.js></script>
+ <script src=video-test.js></script>
+
+ <script>
+ function start() {
+ findMediaElement();
+
+ video.onloadedmetadata = eventListenerFired;
+ video.onloadeddata = eventListenerFired;
+ video.oncanplay = eventListenerFired;
+ video.oncanplaythrough = eventListenerFired;
+ video.onplaying = eventListenerFired;
+ video.onended = eventListenerFired;
+ video.ondurationchange = eventListenerFired;
+ video.ontimeupdate = eventListenerFired;
+ video.onplay = eventListenerFired;
+ video.onpause = eventListenerFired;
+ video.onratechange = eventListenerFired;
+ video.onvolumechange = eventListenerFired;
+
+ video.addEventListener('playing', playing);
+ video.src = findMediaFile('video', 'content/test');
+ }
+
+ function eventListenerFired(event) {
+ consoleWrite('LISTENER(' + event.type + ')');
+ event.target['on' + event.type] = null;
+ }
+
+ function playing() {
+ video.addEventListener('ratechange', rateChange)
+ video.playbackRate = 2;
+ }
+
+ function rateChange() {
+ video.addEventListener('ended', ended);
+ video.currentTime = video.duration - .1;
+ }
+
+ function ended() {
+ video.addEventListener('volumechange', volumeChange);
+ video.volume = 0;
+ }
+
+ function volumeChange() {
+ endTest();
+ }
+
+ </script>
+ </head>
+ <body onload="start()">
+ <video controls autoplay></video>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164141 => 164142)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-15 00:04:55 UTC (rev 164141)
+++ trunk/Source/WebCore/ChangeLog 2014-02-15 00:48:09 UTC (rev 164142)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-02-14 Jer Noble <jer.noble@apple.com>
+
+ Add support for specced event handlers to HTMLMediaElement
+ https://bugs.webkit.org/show_bug.cgi?id=128292
+
+ Reviewed by Andreas Kling.
+
+ Test: media/media-event-listeners.html
+
+ Add explicit event listener IDL attributes to HTMLMediaElement.
+
+ * html/HTMLMediaElement.h:
+ * html/HTMLMediaElement.idl:
+
</ins><span class="cx"> 2014-02-14 Oliver Hunt <oliver@apple.com>
</span><span class="cx">
</span><span class="cx"> Implement a few more Array prototype functions in JS
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (164141 => 164142)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.h 2014-02-15 00:04:55 UTC (rev 164141)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2014-02-15 00:48:09 UTC (rev 164142)
</span><span class="lines">@@ -252,6 +252,21 @@
</span><span class="cx">
</span><span class="cx"> double percentLoaded() const;
</span><span class="cx">
</span><ins>+ DEFINE_ATTRIBUTE_EVENT_LISTENER(emptied);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(loadedmetadata);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(loadeddata);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(canplay);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(canplaythrough);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(playing);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(ended);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(waiting);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(durationchange);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(timeupdate);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(play);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(pause);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(ratechange);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(volumechange);
+
</ins><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><span class="cx"> PassRefPtr<TextTrack> addTextTrack(const String& kind, const String& label, const String& language, ExceptionCode&);
</span><span class="cx"> PassRefPtr<TextTrack> addTextTrack(const String& kind, const String& label, ExceptionCode& ec) { return addTextTrack(kind, label, emptyString(), ec); }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.idl (164141 => 164142)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.idl 2014-02-15 00:04:55 UTC (rev 164141)
+++ trunk/Source/WebCore/html/HTMLMediaElement.idl 2014-02-15 00:48:09 UTC (rev 164142)
</span><span class="lines">@@ -83,6 +83,21 @@
</span><span class="cx"> attribute boolean muted;
</span><span class="cx"> [Reflect=muted] attribute boolean defaultMuted;
</span><span class="cx">
</span><ins>+ attribute EventListener onemptied;
+ attribute EventListener onloadedmetadata;
+ attribute EventListener onloadeddata;
+ attribute EventListener oncanplay;
+ attribute EventListener oncanplaythrough;
+ attribute EventListener onplaying;
+ attribute EventListener onended;
+ attribute EventListener onwaiting;
+ attribute EventListener ondurationchange;
+ attribute EventListener ontimeupdate;
+ attribute EventListener onplay;
+ attribute EventListener onpause;
+ attribute EventListener onratechange;
+ attribute EventListener onvolumechange;
+
</ins><span class="cx"> // WebKit extensions
</span><span class="cx"> attribute boolean webkitPreservesPitch;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>