<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[164107] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/164107">164107</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2014-02-14 09:52:41 -0800 (Fri, 14 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: WebKit needs heuristics to differentiate lists used for layout from semantic data lists, similar to the heuristics for layout tables versus data tables.
https://bugs.webkit.org/show_bug.cgi?id=122320
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Many authors use lists for layout, rather than presenting data. Exposing these kinds of lists to accessibility users
makes the web harder to process and listen, while degrading the importance of real lists.
This introduces heuristics to filter out layout lists with the following:
1. If it's a named list, like ol or aria=list, then it's a list.
1a. Unless the list has no children, then it's not a list.
2. If it displays visible list markers, it's a list.
3. If it does not display list markers and has only one child, it's not a list.
4. If it does not have any listitem children, it's not a list.
5. Otherwise it's a list (for now).
Test: accessibility/list-detection.html
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::determineAccessibilityRole):
(WebCore::AccessibilityList::roleValue):
* accessibility/AccessibilityList.h:
LayoutTests:
* accessibility/aria-roles.html:
* accessibility/list-detection-expected.txt: Added.
* accessibility/list-detection.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsaccessibilityariaroleshtml">trunk/LayoutTests/accessibility/aria-roles.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityListcpp">trunk/Source/WebCore/accessibility/AccessibilityList.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityListh">trunk/Source/WebCore/accessibility/AccessibilityList.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsaccessibilitylistdetectionexpectedtxt">trunk/LayoutTests/accessibility/list-detection-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilitylistdetectionhtml">trunk/LayoutTests/accessibility/list-detection.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (164106 => 164107)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-02-14 17:51:28 UTC (rev 164106)
+++ trunk/LayoutTests/ChangeLog 2014-02-14 17:52:41 UTC (rev 164107)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-02-14 Chris Fleizach <cfleizach@apple.com>
+
+ AX: WebKit needs heuristics to differentiate lists used for layout from semantic data lists, similar to the heuristics for layout tables versus data tables.
+ https://bugs.webkit.org/show_bug.cgi?id=122320
+
+ Reviewed by Mario Sanchez Prada.
+
+ * accessibility/aria-roles.html:
+ * accessibility/list-detection-expected.txt: Added.
+ * accessibility/list-detection.html: Added.
+
</ins><span class="cx"> 2014-02-13 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Create some latched scrolling tests.
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityariaroleshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/aria-roles.html (164106 => 164107)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/aria-roles.html 2014-02-14 17:51:28 UTC (rev 164106)
+++ trunk/LayoutTests/accessibility/aria-roles.html 2014-02-14 17:52:41 UTC (rev 164107)
</span><span class="lines">@@ -146,7 +146,7 @@
</span><span class="cx"> <!--List-->
</span><span class="cx"> <div class="newRole">
</span><span class="cx"> <p>The following should be a list:</p>
</span><del>- <p><span tabindex="0" role="list" id="ariaList">X</span></p>
</del><ins>+ <p><span tabindex="0" role="list" id="ariaList"><span role="listitem">X</span></span></p>
</ins><span class="cx"> <p>Actual list:</p>
</span><span class="cx"> <ul id="realList">
</span><span class="cx"> <li>Broccoli</li>
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitylistdetectionexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/list-detection-expected.txt (0 => 164107)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/list-detection-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/list-detection-expected.txt 2014-02-14 17:52:41 UTC (rev 164107)
</span><span class="lines">@@ -0,0 +1,61 @@
</span><ins>+This tests the heuristic to determine if a 'list' is really a list, or just being used for layout.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Ordered list is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Empty ordered list is not a list.
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+Empty description list is not a list.
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+Description list is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+ARIA role=list is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Empty ARIA list is not a list.
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+ARIA list with one item is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Default styled Unordered list is a list, because it shows markers.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Unordered list with more than 1 item and no style is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Unordered list with 1 item and no style is not list.
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+List with non list item children is not a list
+PASS axElement.role == 'AXRole: AXList' is false
+
+
+Unordered list with image for markers is a list - even if image fails to load.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+Unordered list with aria role and at least one aria list items is a list.
+PASS axElement.role == 'AXRole: AXList' is true
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsaccessibilitylistdetectionhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/list-detection.html (0 => 164107)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/list-detection.html (rev 0)
+++ trunk/LayoutTests/accessibility/list-detection.html 2014-02-14 17:52:41 UTC (rev 164107)
</span><span class="lines">@@ -0,0 +1,98 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+<div id="content">
+
+<ol id="list1" test-description="Ordered list is a list." is-list="true">
+<li>item</li>
+<li>item</li>
+</ol>
+
+<ol id="list2" test-description="Empty ordered list is not a list." is-list="false">
+</ol>
+
+<dl id="list3" test-description="Empty description list is not a list." is-list="false">
+</dl>
+
+<dl id="list4" test-description="Description list is a list." is-list="true">
+<li>item</li>
+<li>item</li>
+</dl>
+
+<div id="list5" role="list" test-description="ARIA role=list is a list." is-list="true">
+<div role="listitem">item</div>
+<div role="listitem">item</div>
+</div>
+
+<div id="list6" role="list" test-description="Empty ARIA list is not a list." is-list="false">
+</div>
+
+<div id="list7" role="list" test-description="ARIA list with one item is a list." is-list="true">
+<div role="listitem">item</div>
+</div>
+
+<ul id="list8" test-description="Default styled Unordered list is a list, because it shows markers." is-list="true">
+<li>item</li>
+<li>item</li>
+</ul>
+
+<ul id="list9" style="list-style-type: none;" test-description="Unordered list with more than 1 item and no style is a list." is-list="true">
+<li>item</li>
+<li>item</li>
+</ul>
+
+<ul id="list10" style="list-style-type: none;" test-description="Unordered list with 1 item and no style is not list." is-list="false">
+<li>item</li>
+</ul>
+
+<ul id="list11" test-description="List with non list item children is not a list" is-list="false">
+<div>item</div>
+</ul>
+
+<ul id="list12" style="list-style-image: url('test.gif');" test-description="Unordered list with image for markers is a list - even if image fails to load." is-list="true">
+<li>item</li>
+<li>item</li>
+</ul>
+
+<ul id="list13" role="list" test-description="Unordered list with aria role and at least one aria list items is a list." is-list="true">
+<div role="listitem">item</div>
+<div>item</div>
+</ul>
+
+</div>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests the heuristic to determine if a 'list' is really a list, or just being used for layout.");
+
+ if (window.accessibilityController) {
+
+ var k = 1;
+ while (document.getElementById("list" + k)) {
+ var element = document.getElementById("list" + k);
+ var axElement = accessibilityController.accessibleElementById("list" + k);
+ debug(element.getAttribute("test-description"));
+ if (element.getAttribute("is-list") === "true") {
+ shouldBeTrue("axElement.role == 'AXRole: AXList'");
+ } else {
+ shouldBeFalse("axElement.role == 'AXRole: AXList'");
+ }
+ debug("\n");
+ k++;
+ }
+
+ document.getElementById("content").style.visibility = "hidden";
+ }
+
+</script>
+
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (164106 => 164107)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-02-14 17:51:28 UTC (rev 164106)
+++ trunk/Source/WebCore/ChangeLog 2014-02-14 17:52:41 UTC (rev 164107)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2014-02-14 Chris Fleizach <cfleizach@apple.com>
+
+ AX: WebKit needs heuristics to differentiate lists used for layout from semantic data lists, similar to the heuristics for layout tables versus data tables.
+ https://bugs.webkit.org/show_bug.cgi?id=122320
+
+ Reviewed by Mario Sanchez Prada.
+
+ Many authors use lists for layout, rather than presenting data. Exposing these kinds of lists to accessibility users
+ makes the web harder to process and listen, while degrading the importance of real lists.
+
+ This introduces heuristics to filter out layout lists with the following:
+ 1. If it's a named list, like ol or aria=list, then it's a list.
+ 1a. Unless the list has no children, then it's not a list.
+ 2. If it displays visible list markers, it's a list.
+ 3. If it does not display list markers and has only one child, it's not a list.
+ 4. If it does not have any listitem children, it's not a list.
+ 5. Otherwise it's a list (for now).
+
+ Test: accessibility/list-detection.html
+
+ * accessibility/AccessibilityList.cpp:
+ (WebCore::AccessibilityList::determineAccessibilityRole):
+ (WebCore::AccessibilityList::roleValue):
+ * accessibility/AccessibilityList.h:
+
</ins><span class="cx"> 2014-02-14 Brendan Long <b.long@cablelabs.com>
</span><span class="cx">
</span><span class="cx"> Use AtomicString arguments in TrackPrivateBaseClient callbacks
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityList.cpp (164106 => 164107)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityList.cpp 2014-02-14 17:51:28 UTC (rev 164106)
+++ trunk/Source/WebCore/accessibility/AccessibilityList.cpp 2014-02-14 17:52:41 UTC (rev 164107)
</span><span class="lines">@@ -31,7 +31,9 @@
</span><span class="cx">
</span><span class="cx"> #include "AXObjectCache.h"
</span><span class="cx"> #include "HTMLNames.h"
</span><ins>+#include "RenderListItem.h"
</ins><span class="cx"> #include "RenderObject.h"
</span><ins>+#include "RenderStyle.h"
</ins><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="lines">@@ -91,15 +93,67 @@
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> Node* node = m_renderer->node();
</span><del>- return node && node->hasTagName(dlTag);
</del><ins>+ return node && node->hasTagName(dlTag);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-AccessibilityRole AccessibilityList::roleValue() const
</del><ins>+AccessibilityRole AccessibilityList::determineAccessibilityRole()
</ins><span class="cx"> {
</span><del>- if (isDescriptionList())
</del><ins>+ m_ariaRole = determineAriaRoleAttribute();
+
+ // Directory is mapped to list for now, but does not adhere to the same heuristics.
+ if (ariaRoleAttribute() == DirectoryRole)
+ return ListRole;
+
+ // Heuristic to determine if this list is being used for layout or for content.
+ // 1. If it's a named list, like ol or aria=list, then it's a list.
+ // 1a. Unless the list has no children, then it's not a list.
+ // 2. If it displays visible list markers, it's a list.
+ // 3. If it does not display list markers and has only one child, it's not a list.
+ // 4. If it does not have any listitem children, it's not a list.
+ // 5. Otherwise it's a list (for now).
+
+ AccessibilityRole role = ListRole;
+
+ // Temporarily set role so that we can query children (otherwise canHaveChildren returns false).
+ m_role = role;
+
+ unsigned listItemCount = 0;
+ bool hasVisibleMarkers = false;
+
+ const auto& children = this->children();
+ // DescriptionLists are always semantically a description list, so do not apply heuristics.
+ if (isDescriptionList() && children.size())
</ins><span class="cx"> return DescriptionListRole;
</span><ins>+
+ for (const auto& child : children) {
+ if (child->ariaRoleAttribute() == ListItemRole)
+ listItemCount++;
+ else if (child->roleValue() == ListItemRole) {
+ RenderObject* listItem = child->renderer();
+ if (listItem && listItem->isListItem()) {
+ if (listItem->style().listStyleType() != NoneListStyle || listItem->style().listStyleImage())
+ hasVisibleMarkers = true;
+ listItemCount++;
+ }
+ }
+ }
</ins><span class="cx">
</span><del>- return ListRole;
</del><ins>+ bool unorderedList = isUnorderedList();
+ // Non <ul> lists and ARIA lists only need to have one child.
+ // <ul> lists need to have 1 child, or visible markers.
+ if (!unorderedList || ariaRoleAttribute() != UnknownRole) {
+ if (!listItemCount)
+ role = GroupRole;
+ } else if (unorderedList && listItemCount <= 1 && !hasVisibleMarkers)
+ role = GroupRole;
+
+ return role;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+AccessibilityRole AccessibilityList::roleValue() const
+{
+ ASSERT(m_role != UnknownRole);
+ return m_role;
+}
+
</ins><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityList.h (164106 => 164107)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityList.h 2014-02-14 17:51:28 UTC (rev 164106)
+++ trunk/Source/WebCore/accessibility/AccessibilityList.h 2014-02-14 17:52:41 UTC (rev 164107)
</span><span class="lines">@@ -49,6 +49,7 @@
</span><span class="cx"> virtual AccessibilityRole roleValue() const override final;
</span><span class="cx"> private:
</span><span class="cx"> virtual bool computeAccessibilityIsIgnored() const override;
</span><ins>+ virtual AccessibilityRole determineAccessibilityRole() override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> ACCESSIBILITY_OBJECT_TYPE_CASTS(AccessibilityList, isList())
</span></span></pre>
</div>
</div>
</body>
</html>